[jira] [Commented] (OPENMEETINGS-2433) Settings->SearchUsers show some users more than once
[
https://issues.apache.org/jira/browse/OPENMEETINGS-2433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17194920#comment-17194920
]
Maxim Solodovnik commented on OPENMEETINGS-2433:
Hello [~uwesimon],
i was unable to reproduce this issue
my steps:
# clean OM just installed with H2 DB
# create additional group {{test}}
# create new user with login {{e}} add this user to 2 groups
# search for {{eee}}
Result: only one user in the list
maybe you have users with same first/last names as
# internal OM users
# users authenticated via FB/Google etc.
# user as "contact"
can you check this in Admin area? and/or DB
> Settings->SearchUsers show some users more than once
>
>
> Key: OPENMEETINGS-2433
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2433
> Project: Openmeetings
> Issue Type: Bug
> Components: UI
>Affects Versions: 5.0.0
>Reporter: Uwe Simon
>Assignee: Maxim Solodovnik
>Priority: Minor
>
> When searching in "settings->searhc users" for users the result contains some
> users more then once.
> Looks like this happens for users who are members of more than one group.
> Could be repproduced by
> # create a new group
> # add a user to this new group (user should be no member of 2 groups)
> # Search for users. in "settings->search users" the changed user now is
> shown twice in the result
> Seams that a DISTINCT is missing in the database query.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (OPENMEETINGS-2431) Recordings are not available
[
https://issues.apache.org/jira/browse/OPENMEETINGS-2431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17194836#comment-17194836
]
Ali Alhaidary edited comment on OPENMEETINGS-2431 at 9/12/20, 8:02 PM:
---
solved
1. change owner of /opt/open500/webapps/openmeetings/data and subs to
nobody:nogroup
2. change mod to 755
{{sudo find . -type d -exec chmod 755 {} +}}
On 9/12/20 3:14 PM, Maxim Solodovnik (Jira) wrote:
was (Author: ali.alhaidary):
solved
1. change owner of /opt/open500/webapps/openmeetings/data and subs to
nobody:nogroup
2. change mod to 755
On 9/12/20 3:14 PM, Maxim Solodovnik (Jira) wrote:
> Recordings are not available
>
>
> Key: OPENMEETINGS-2431
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2431
> Project: Openmeetings
> Issue Type: Bug
> Components: Audio/Video, Converters, Recordings
>Affects Versions: 5.0.0
> Environment: ubuntu 18.04
>Reporter: Ali Alhaidary
>Assignee: Maxim Solodovnik
>Priority: Major
> Attachments: Screenshot_2020-09-11 مَوْقِعُ النُّجُومِ الخمسه
> (أَصْحَابُ الكساء صَلَوَات اللّه وَسَلَامِه عَلَيْهُمْ).png
>
>
> when finishing screen recording, the output can not be played. It reports
> that it does not exist.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2431) Recordings are not available
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17194836#comment-17194836 ] Ali Alhaidary commented on OPENMEETINGS-2431: - solved 1. change owner of /opt/open500/webapps/openmeetings/data and subs to nobody:nogroup 2. change mod to 755 On 9/12/20 3:14 PM, Maxim Solodovnik (Jira) wrote: > Recordings are not available > > > Key: OPENMEETINGS-2431 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2431 > Project: Openmeetings > Issue Type: Bug > Components: Audio/Video, Converters, Recordings >Affects Versions: 5.0.0 > Environment: ubuntu 18.04 >Reporter: Ali Alhaidary >Assignee: Maxim Solodovnik >Priority: Major > Attachments: Screenshot_2020-09-11 مَوْقِعُ النُّجُومِ الخمسه > (أَصْحَابُ الكساء صَلَوَات اللّه وَسَلَامِه عَلَيْهُمْ).png > > > when finishing screen recording, the output can not be played. It reports > that it does not exist. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OPENMEETINGS-2433) Settings->SearchUsers show some users more than once
Uwe Simon created OPENMEETINGS-2433: --- Summary: Settings->SearchUsers show some users more than once Key: OPENMEETINGS-2433 URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2433 Project: Openmeetings Issue Type: Bug Components: UI Affects Versions: 5.0.0 Reporter: Uwe Simon Assignee: Maxim Solodovnik When searching in "settings->searhc users" for users the result contains some users more then once. Looks like this happens for users who are members of more than one group. Could be repproduced by # create a new group # add a user to this new group (user should be no member of 2 groups) # Search for users. in "settings->search users" the changed user now is shown twice in the result Seams that a DISTINCT is missing in the database query. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2427) Sonar issues need to be addressed (5.0.1)
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17194778#comment-17194778 ] ASF subversion and git services commented on OPENMEETINGS-2427: --- Commit 88ad533983ae8acbc2de1117185b51e20dad628e in openmeetings's branch refs/heads/master from Maxim Solodovnik [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=88ad533 ] [OPENMEETINGS-2427] sonar should be more happy > Sonar issues need to be addressed (5.0.1) > - > > Key: OPENMEETINGS-2427 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2427 > Project: Openmeetings > Issue Type: Task > Components: Builds >Affects Versions: 5.0.1 >Reporter: Maxim Solodovnik >Assignee: Maxim Solodovnik >Priority: Major > Fix For: 5.0.1 > > > Sonar issues need to be addressed (M4) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[openmeetings] branch master updated: [OPENMEETINGS-2427] sonar should be more happy
This is an automated email from the ASF dual-hosted git repository.
solomax pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/openmeetings.git
The following commit(s) were added to refs/heads/master by this push:
new 88ad533 [OPENMEETINGS-2427] sonar should be more happy
88ad533 is described below
commit 88ad533983ae8acbc2de1117185b51e20dad628e
Author: Maxim Solodovnik
AuthorDate: Sat Sep 12 23:39:30 2020 +0700
[OPENMEETINGS-2427] sonar should be more happy
---
.../java/org/apache/openmeetings/core/remote/KurentoHandler.java | 9 +++--
.../main/java/org/apache/openmeetings/db/util/AuthLevelUtil.java | 8
.../main/java/org/apache/openmeetings/backup/BackupImport.java | 4 +---
.../main/java/org/apache/openmeetings/web/app/Application.java | 4 +---
.../main/java/org/apache/openmeetings/web/app/WebSession.java| 4 +---
.../org/apache/openmeetings/web/common/UploadableImagePanel.java | 4 +---
.../org/apache/openmeetings/web/pages/install/InstallWizard.java | 4 +---
.../main/java/org/apache/openmeetings/web/room/RoomPanel.java| 4 +---
.../src/main/java/org/apache/openmeetings/web/room/raw-room.js | 2 +-
.../src/main/java/org/apache/openmeetings/web/room/raw-video.js | 2 +-
.../main/java/org/apache/openmeetings/web/room/wb/WbPanel.java | 5 ++---
.../org/apache/openmeetings/web/room/wb/WbWebSocketHelper.java | 3 ---
.../main/java/org/apache/openmeetings/web/room/wb/raw-wb-area.js | 8
.../main/java/org/apache/openmeetings/web/user/chat/raw-chat.js | 4 ++--
14 files changed, 23 insertions(+), 42 deletions(-)
diff --git
a/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/KurentoHandler.java
b/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/KurentoHandler.java
index 37e5730..42d6874 100644
---
a/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/KurentoHandler.java
+++
b/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/KurentoHandler.java
@@ -282,9 +282,7 @@ public class KurentoHandler {
KRoom getRoom(Long roomId) {
log.debug("Searching for room {}", roomId);
- KRoom room = rooms.get(roomId);
-
- if (room == null) {
+ KRoom room = rooms.computeIfAbsent(roomId, k -> {
log.debug("Room {} does not exist. Will create now!",
roomId);
Room r = roomDao.get(roomId);
Transaction t = beginTransaction();
@@ -292,9 +290,8 @@ public class KurentoHandler {
pipe.addTag(t, TAG_KUID, kuid);
pipe.addTag(t, TAG_ROOM, String.valueOf(roomId));
t.commit();
- room = new KRoom(streamProcessor, r, pipe, chunkDao);
- rooms.put(roomId, room);
- }
+ return new KRoom(streamProcessor, r, pipe, chunkDao);
+ });
log.debug("Room {} found!", roomId);
return room;
}
diff --git
a/openmeetings-db/src/main/java/org/apache/openmeetings/db/util/AuthLevelUtil.java
b/openmeetings-db/src/main/java/org/apache/openmeetings/db/util/AuthLevelUtil.java
index 076da63..bd20559 100644
---
a/openmeetings-db/src/main/java/org/apache/openmeetings/db/util/AuthLevelUtil.java
+++
b/openmeetings-db/src/main/java/org/apache/openmeetings/db/util/AuthLevelUtil.java
@@ -50,11 +50,11 @@ public class AuthLevelUtil {
if (u == null) {
return result;
}
- if (hasAdminLevel(u.getRights())) {
- //admin user get superModerator level, no-one can kick
him/her
- result.add(Room.Right.SUPER_MODERATOR);
- } else if (r.isAppointment() && a != null &&
u.getId().equals(a.getOwner().getId())) {
+ if (//admin user get superModerator level, no-one can kick
him/her
+ hasAdminLevel(u.getRights())
// appointment owner is super moderator
+ || (r.isAppointment() && a != null &&
u.getId().equals(a.getOwner().getId(
+ {
result.add(Room.Right.SUPER_MODERATOR);
}
if (result.isEmpty()) {
diff --git
a/openmeetings-install/src/main/java/org/apache/openmeetings/backup/BackupImport.java
b/openmeetings-install/src/main/java/org/apache/openmeetings/backup/BackupImport.java
index b8678e2..0a9c11a 100644
---
a/openmeetings-install/src/main/java/org/apache/openmeetings/backup/BackupImport.java
+++
b/openmeetings-install/src/main/java/org/apache/openmeetings/backup/BackupImport.java
@@ -917,9 +917,7 @@ public class BackupImport {
)
{
TreeMap items = new TreeMap<>();
- readList(baseDir, fileName, listNodeName, nodeName, clazz, f ->
{
-
[openmeetings] branch master updated: [OPENMEETINGS-2432] pings count is 10
This is an automated email from the ASF dual-hosted git repository.
solomax pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/openmeetings.git
The following commit(s) were added to refs/heads/master by this push:
new 4397ae7 [OPENMEETINGS-2432] pings count is 10
4397ae7 is described below
commit 4397ae7f3f526ea871327bc9b65debdf10ab1e27
Author: Maxim Solodovnik
AuthorDate: Sat Sep 12 22:49:59 2020 +0700
[OPENMEETINGS-2432] pings count is 10
---
.../src/main/java/org/apache/openmeetings/web/room/raw-nettest.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/raw-nettest.js
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/raw-nettest.js
index 23c3757..871bdb8 100644
---
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/raw-nettest.js
+++
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/raw-nettest.js
@@ -1,6 +1,6 @@
/* Licensed under the Apache License, Version 2.0 (the "License")
http://www.apache.org/licenses/LICENSE-2.0 */
var NetTest = (function() {
- const self = {}, PINGS = 5, LIMIT = 2000, URL =
'./services/networktest/'
+ const self = {}, PINGS = 10, LIMIT = 2000, URL =
'./services/networktest/'
, DELAY = 3000, KB = 1024, MB = KB * KB;
let output, lbls, net, tests, testName, testLabel, testNext, bulk =
true;
[jira] [Commented] (OPENMEETINGS-2432) Rate limit should be checked for network test web service
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17194760#comment-17194760 ] ASF subversion and git services commented on OPENMEETINGS-2432: --- Commit 4397ae7f3f526ea871327bc9b65debdf10ab1e27 in openmeetings's branch refs/heads/master from Maxim Solodovnik [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=4397ae7 ] [OPENMEETINGS-2432] pings count is 10 > Rate limit should be checked for network test web service > - > > Key: OPENMEETINGS-2432 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2432 > Project: Openmeetings > Issue Type: Improvement > Components: SOAP/REST API, Testing-Tool >Affects Versions: 5.0.0 >Reporter: Maxim Solodovnik >Assignee: Maxim Solodovnik >Priority: Critical > Fix For: 5.0.1 > > > Rate limit is not checked for network test web service ATM > this need to be fixed -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (OPENMEETINGS-2431) Recordings are not available
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Solodovnik resolved OPENMEETINGS-2431. Fix Version/s: (was: 5.0.1) Resolution: Information Provided [~ali.alhaidary] most probably the issue is caused by the fact OM and KMS were started with different users and/or folder permissions are wrong please check mailing list archives https://openmeetings.markmail.org/ the topic was raised multiple times > Recordings are not available > > > Key: OPENMEETINGS-2431 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2431 > Project: Openmeetings > Issue Type: Bug > Components: Audio/Video, Converters, Recordings >Affects Versions: 5.0.0 > Environment: ubuntu 18.04 >Reporter: Ali Alhaidary >Assignee: Maxim Solodovnik >Priority: Major > Attachments: Screenshot_2020-09-11 مَوْقِعُ النُّجُومِ الخمسه > (أَصْحَابُ الكساء صَلَوَات اللّه وَسَلَامِه عَلَيْهُمْ).png > > > when finishing screen recording, the output can not be played. It reports > that it does not exist. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OPENMEETINGS-2429) (My rooms) label in the dashboard
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Solodovnik updated OPENMEETINGS-2429: --- Flags: (was: Patch) Labels: (was: patch) > (My rooms) label in the dashboard > - > > Key: OPENMEETINGS-2429 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2429 > Project: Openmeetings > Issue Type: Bug > Components: Dashboard >Affects Versions: 5.0.0 > Environment: ubuntu 18.04 >Reporter: Ali Alhaidary >Assignee: Maxim Solodovnik >Priority: Minor > Fix For: 5.0.1 > > Attachments: My rooms.png > > > (My rooms) label in the dashboard does not apply translation only after the > file (dashboard.xml) is deleted, otherwise, it does not translate to what > ever language you change. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2432) Rate limit should be checked for network test web service
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17194650#comment-17194650 ] ASF subversion and git services commented on OPENMEETINGS-2432: --- Commit 69929466818fe291e450f9854a8a3627a83b6325 in openmeetings's branch refs/heads/master from Maxim Solodovnik [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=6992946 ] [OPENMEETINGS-2432] rate limit is being checked > Rate limit should be checked for network test web service > - > > Key: OPENMEETINGS-2432 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2432 > Project: Openmeetings > Issue Type: Improvement > Components: SOAP/REST API, Testing-Tool >Affects Versions: 5.0.0 >Reporter: Maxim Solodovnik >Assignee: Maxim Solodovnik >Priority: Critical > Fix For: 5.0.1 > > > Rate limit is not checked for network test web service ATM > this need to be fixed -- This message was sent by Atlassian Jira (v8.3.4#803005)
[openmeetings] branch master updated: [OPENMEETINGS-2432] rate limit is being checked
This is an automated email from the ASF dual-hosted git repository.
solomax pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/openmeetings.git
The following commit(s) were added to refs/heads/master by this push:
new 6992946 [OPENMEETINGS-2432] rate limit is being checked
6992946 is described below
commit 69929466818fe291e450f9854a8a3627a83b6325
Author: Maxim Solodovnik
AuthorDate: Sat Sep 12 14:59:44 2020 +0700
[OPENMEETINGS-2432] rate limit is being checked
---
openmeetings-web/pom.xml |1 -
.../org/apache/openmeetings/web/room/network.js| 2171
.../apache/openmeetings/web/room/raw-nettest.js| 213 +-
.../main/webapp/WEB-INF/classes/cxf-servlet.xml|9 +-
.../src/main/webapp/css/raw-nettest.css|3 +
.../openmeetings/webservice/NetTestWebService.java |8 +-
.../webservice/util/RateLimitRequestFilter.java| 63 +
.../openmeetings/webservice/util/RateLimited.java | 34 +
8 files changed, 250 insertions(+), 2252 deletions(-)
diff --git a/openmeetings-web/pom.xml b/openmeetings-web/pom.xml
index 47e665d..4f297e1 100644
--- a/openmeetings-web/pom.xml
+++ b/openmeetings-web/pom.xml
@@ -242,7 +242,6 @@
../java/org/apache/openmeetings/web/room
raw-nettest.js
-
network.js
nettest.js
CLOSURE
diff --git
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/network.js
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/network.js
deleted file mode 100644
index 5f34968..000
--- a/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/network.js
+++ /dev/null
@@ -1,2171 +0,0 @@
-/* Licensed MIT https://github.com/nesk/network.js/blob/master/LICENSE */
-(function(f){if(typeof exports==="object"&
module!=="undefined"){module.exports=f()}else if(typeof
define==="function"&){define([],f)}else{var g;if(typeof
window!=="undefined"){g=window}else if(typeof
global!=="undefined"){g=global}else if(typeof
self!=="undefined"){g=self}else{g=this}g.Network = f()}})(function(){var
define,module,exports;return (function e(t,n,r){function
s(o,u){if(!n[o]){if(!t[o]){var a=typeof
require=="function"&if(!u&)return a(o,!0);if(i [...]
-'use strict';
-
-Object.defineProperty(exports, '__esModule', {
-value: true
-});
-
-var _createDecoratedClass = (function () { function defineProperties(target,
descriptors, initializers) { for (var i = 0; i < descriptors.length; i++) { var
descriptor = descriptors[i]; var decorators = descriptor.decorators; var key =
descriptor.key; delete descriptor.key; delete descriptor.decorators;
descriptor.enumerable = descriptor.enumerable || false; descriptor.configurable
= true; if ('value' in descriptor || descriptor.initializer)
descriptor.writable = true; if (decorators) { [...]
-
-function _classCallCheck(instance, Constructor) { if (!(instance instanceof
Constructor)) { throw new TypeError('Cannot call a class as a function'); } }
-
-function _defineDecoratedPropertyDescriptor(target, key, descriptors) { var
_descriptor = descriptors[key]; if (!_descriptor) return; var descriptor = {};
for (var _key in _descriptor) descriptor[_key] = _descriptor[_key];
descriptor.value = descriptor.initializer.call(target);
Object.defineProperty(target, key, descriptor); }
-
-var _utilsDecorators = require('../utils/decorators');
-
-/**
- * A callback used as an event handler.
- * @public
- * @callback EventDispatcher~eventHandler
- * @param {...*} args The extra parameters provided to the `trigger` method.
- * @returns {?boolean} If `false` is explicitly returned, the `trigger` method
will return `false`.
- */
-
-/**
- * @class EventDispatcher
- */
-
-var EventDispatcher = (function () {
-var _instanceInitializers = {};
-
-function EventDispatcher() {
-_classCallCheck(this, EventDispatcher);
-
-_defineDecoratedPropertyDescriptor(this, '_eventCallbacks',
_instanceInitializers);
-}
-
-_createDecoratedClass(EventDispatcher, [{
-key: 'on',
-
-/**
- * Attach a callback to one or more events.
- * @public
- * @method EventDispatcher#on
- * @param {string|string[]} events One or multiple event names.
- * @param {EventDispatcher~eventHandler} callback An event handler.
- * @returns {EventDispatcher}
- */
-value: function on(events, callback) {
-var _this = this;
-
-events = Array.isArray(events) ? events : [events];
-
-events.forEach(function (event) {
-var
[jira] [Created] (OPENMEETINGS-2432) Rate limit should be checked for network test web service
Maxim Solodovnik created OPENMEETINGS-2432: -- Summary: Rate limit should be checked for network test web service Key: OPENMEETINGS-2432 URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2432 Project: Openmeetings Issue Type: Improvement Components: SOAP/REST API, Testing-Tool Affects Versions: 5.0.0 Reporter: Maxim Solodovnik Assignee: Maxim Solodovnik Fix For: 5.0.1 Rate limit is not checked for network test web service ATM this need to be fixed -- This message was sent by Atlassian Jira (v8.3.4#803005)
