[jira] [Commented] (OPENMEETINGS-2468) Moving keys 282, 283, 286 and 287 from translation table to configuration
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17205217#comment-17205217 ] Maxim Solodovnik commented on OPENMEETINGS-2468: Well, I'm not sure this need to be moved to configuration this way you can't have localized URLs (right now this is possible) this is true the changes will be lost on upgrade ... not sure what can be done here :((( > Moving keys 282, 283, 286 and 287 from translation table to configuration > - > > Key: OPENMEETINGS-2468 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2468 > Project: Openmeetings > Issue Type: Improvement > Components: Dashboard >Affects Versions: 5.1.0 >Reporter: Ali Alhaidary >Assignee: Maxim Solodovnik >Priority: Minor > > Keys 282, 283, 286 and 287 in language table have the same site specific > characteristics as some other configuration keys like site name, google > analytics and mail parameters > When upgrading to a new build or version, these keys need to be configured > each and every time, so moving them to the database makes it more practical. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OPENMEETINGS-2468) Moving keys 282, 283, 286 and 287 from translation table to configuration
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Solodovnik updated OPENMEETINGS-2468: --- Fix Version/s: (was: 5.1.0) > Moving keys 282, 283, 286 and 287 from translation table to configuration > - > > Key: OPENMEETINGS-2468 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2468 > Project: Openmeetings > Issue Type: Improvement > Components: Dashboard >Affects Versions: 5.1.0 >Reporter: Ali Alhaidary >Assignee: Maxim Solodovnik >Priority: Minor > > Keys 282, 283, 286 and 287 in language table have the same site specific > characteristics as some other configuration keys like site name, google > analytics and mail parameters > When upgrading to a new build or version, these keys need to be configured > each and every time, so moving them to the database makes it more practical. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OPENMEETINGS-2468) Moving keys 282, 283, 286 and 287 from translation table to configuration
Ali Alhaidary created OPENMEETINGS-2468: --- Summary: Moving keys 282, 283, 286 and 287 from translation table to configuration Key: OPENMEETINGS-2468 URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2468 Project: Openmeetings Issue Type: Improvement Components: Dashboard Affects Versions: 5.1.0 Reporter: Ali Alhaidary Assignee: Maxim Solodovnik Fix For: 5.1.0 Keys 282, 283, 286 and 287 in language table have the same site specific characteristics as some other configuration keys like site name, google analytics and mail parameters When upgrading to a new build or version, these keys need to be configured each and every time, so moving them to the database makes it more practical. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2466) Camera is occupied (on) even after leaving the room
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17205209#comment-17205209 ] Ali Alhaidary commented on OPENMEETINGS-2466: - lubuntu 18.04, FireFox > Camera is occupied (on) even after leaving the room > --- > > Key: OPENMEETINGS-2466 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2466 > Project: Openmeetings > Issue Type: Bug > Components: Audio/Video >Affects Versions: 5.1.0 >Reporter: Ali Alhaidary >Assignee: Maxim Solodovnik >Priority: Minor > Fix For: 5.1.0 > > > Camera keeps occupied (on) even after leaving the room, no other application > can use it. It will turn off after logging out of OM. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (OPENMEETINGS-2467) Appearence of "My rooms" differ form "Recent rooms"
[
https://issues.apache.org/jira/browse/OPENMEETINGS-2467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maxim Solodovnik resolved OPENMEETINGS-2467.
Resolution: Fixed
Thanks for analysis :)
> Appearence of "My rooms" differ form "Recent rooms"
> ---
>
> Key: OPENMEETINGS-2467
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2467
> Project: Openmeetings
> Issue Type: Improvement
> Components: UI
>Affects Versions: 5.0.1, 5.1.0
>Reporter: Uwe Simon
>Assignee: Maxim Solodovnik
>Priority: Minor
> Fix For: 5.1.0
>
> Attachments: Bildschirmfoto vom 2020-09-30 20-03-56.png
>
>
> In "My rooms" the room details of the marked room are right to the room list,
> in "Recent rooms" below the list.
>
> Expectation: "Recent rooms" with rommdetail right of list.
> Solution:
> Change in the HTML for "Recent rooms"
>
> {code:java}
>
> {code}
>
> to
>
> {code:java}
>
>
> {code}
>
> !Bildschirmfoto vom 2020-09-30 20-03-56.png!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2466) Camera is occupied (on) even after leaving the room
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17205191#comment-17205191 ] Maxim Solodovnik commented on OPENMEETINGS-2466: OS and browser, please > Camera is occupied (on) even after leaving the room > --- > > Key: OPENMEETINGS-2466 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2466 > Project: Openmeetings > Issue Type: Bug > Components: Audio/Video >Affects Versions: 5.1.0 >Reporter: Ali Alhaidary >Assignee: Maxim Solodovnik >Priority: Minor > Fix For: 5.1.0 > > > Camera keeps occupied (on) even after leaving the room, no other application > can use it. It will turn off after logging out of OM. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[openmeetings] branch master updated: [OPENMEETINGS-2467] recent rooms widget is fixed
This is an automated email from the ASF dual-hosted git repository. solomax pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/openmeetings.git The following commit(s) were added to refs/heads/master by this push: new 91edf2e [OPENMEETINGS-2467] recent rooms widget is fixed 91edf2e is described below commit 91edf2e0b0903db2ef1f85da7dc010a78bda1aad Author: Maxim Solodovnik AuthorDate: Thu Oct 1 08:43:32 2020 +0700 [OPENMEETINGS-2467] recent rooms widget is fixed --- .../apache/openmeetings/web/user/dashboard/RecentRoomsWidgetView.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/dashboard/RecentRoomsWidgetView.html b/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/dashboard/RecentRoomsWidgetView.html index 20ef822..6f5b002 100644 --- a/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/dashboard/RecentRoomsWidgetView.html +++ b/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/dashboard/RecentRoomsWidgetView.html @@ -20,6 +20,6 @@ http://wicket.apache.org;> - +
[jira] [Commented] (OPENMEETINGS-2467) Appearence of "My rooms" differ form "Recent rooms"
[
https://issues.apache.org/jira/browse/OPENMEETINGS-2467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17205189#comment-17205189
]
ASF subversion and git services commented on OPENMEETINGS-2467:
---
Commit 91edf2e0b0903db2ef1f85da7dc010a78bda1aad in openmeetings's branch
refs/heads/master from Maxim Solodovnik
[ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=91edf2e ]
[OPENMEETINGS-2467] recent rooms widget is fixed
> Appearence of "My rooms" differ form "Recent rooms"
> ---
>
> Key: OPENMEETINGS-2467
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2467
> Project: Openmeetings
> Issue Type: Improvement
> Components: UI
>Affects Versions: 5.0.1, 5.1.0
>Reporter: Uwe Simon
>Assignee: Maxim Solodovnik
>Priority: Minor
> Fix For: 5.1.0
>
> Attachments: Bildschirmfoto vom 2020-09-30 20-03-56.png
>
>
> In "My rooms" the room details of the marked room are right to the room list,
> in "Recent rooms" below the list.
>
> Expectation: "Recent rooms" with rommdetail right of list.
> Solution:
> Change in the HTML for "Recent rooms"
>
> {code:java}
>
> {code}
>
> to
>
> {code:java}
>
>
> {code}
>
> !Bildschirmfoto vom 2020-09-30 20-03-56.png!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2464) Invitation to Metting from user: null null
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17205180#comment-17205180 ] Maxim Solodovnik commented on OPENMEETINGS-2464: Thanks for verification! > Invitation to Metting from user: null null > -- > > Key: OPENMEETINGS-2464 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2464 > Project: Openmeetings > Issue Type: Bug > Components: Email >Affects Versions: 5.1.0 >Reporter: Uwe Simon >Assignee: Maxim Solodovnik >Priority: Minor > Fix For: 5.1.0 > > > Invitation to a meeting contains null when lastname or firstname of user is > empty > Better: > Meeting invitation should contain "display name" of sender similar to other > places where the username is shown. > > Example Email: > *OpenMeetings - Invitation* > Message from user: null null > Message: > OpenMeetings conference reminder: New Event > Start: 29 Sep 2020, 20:00:00 > End: 29 Sep 2020, 20:30:00 > Click this link to participate in the conference [The link may only work for > a certain period.]: > [Click here to enter room|http://localhost:8080/openmeetings/#room/35] > > If you have problems with the link, please copy and paste this to your > browser: > http://localhost:8080/openmeetings/#room/35 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2456) Poll Results: chart is closed when a participant vote
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17205179#comment-17205179 ] Maxim Solodovnik commented on OPENMEETINGS-2456: Thanks for verification! > Poll Results: chart is closed when a participant vote > - > > Key: OPENMEETINGS-2456 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2456 > Project: Openmeetings > Issue Type: Bug > Components: UI >Affects Versions: 5.1.0 >Reporter: Uwe Simon >Assignee: Maxim Solodovnik >Priority: Minor > Fix For: 5.1.0 > > Attachments: Bildschirmfoto vom 2020-09-26 16-26-18.png, > Bildschirmfoto vom 2020-09-26 16-37-47.png, Bildschirmfoto vom 2020-09-29 > 18-55-26.png > > > When the dialog "Poll Results" is open while participants are still voting > the chart is closed when a new vote is done. > Expected behaviour: Chart is redrawn with new values > > Workarround: select another chart type or close dialog and reopen it > > When reopening the "Poll Results" it looks like there are 2 chart on top of > each other. > !Bildschirmfoto vom 2020-09-26 16-26-18.png! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OPENMEETINGS-2467) Appearence of "My rooms" differ form "Recent rooms"
[
https://issues.apache.org/jira/browse/OPENMEETINGS-2467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maxim Solodovnik updated OPENMEETINGS-2467:
---
Fix Version/s: 5.1.0
> Appearence of "My rooms" differ form "Recent rooms"
> ---
>
> Key: OPENMEETINGS-2467
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2467
> Project: Openmeetings
> Issue Type: Improvement
> Components: UI
>Affects Versions: 5.0.1, 5.1.0
>Reporter: Uwe Simon
>Assignee: Maxim Solodovnik
>Priority: Minor
> Fix For: 5.1.0
>
> Attachments: Bildschirmfoto vom 2020-09-30 20-03-56.png
>
>
> In "My rooms" the room details of the marked room are right to the room list,
> in "Recent rooms" below the list.
>
> Expectation: "Recent rooms" with rommdetail right of list.
> Solution:
> Change in the HTML for "Recent rooms"
>
> {code:java}
>
> {code}
>
> to
>
> {code:java}
>
>
> {code}
>
> !Bildschirmfoto vom 2020-09-30 20-03-56.png!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OPENMEETINGS-2467) Appearence of "My rooms" differ form "Recent rooms"
[
https://issues.apache.org/jira/browse/OPENMEETINGS-2467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Simon updated OPENMEETINGS-2467:
Affects Version/s: 5.1.0
5.0.1
> Appearence of "My rooms" differ form "Recent rooms"
> ---
>
> Key: OPENMEETINGS-2467
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2467
> Project: Openmeetings
> Issue Type: Improvement
> Components: UI
>Affects Versions: 5.0.1, 5.1.0
>Reporter: Uwe Simon
>Assignee: Maxim Solodovnik
>Priority: Minor
> Attachments: Bildschirmfoto vom 2020-09-30 20-03-56.png
>
>
> In "My rooms" the room details of the marked room are right to the room list,
> in "Recent rooms" below the list.
>
> Expectation: "Recent rooms" with rommdetail right of list.
> Solution:
> Change in the HTML for "Recent rooms"
>
> {code:java}
>
> {code}
>
> to
>
> {code:java}
>
>
> {code}
>
> !Bildschirmfoto vom 2020-09-30 20-03-56.png!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (OPENMEETINGS-2467) Appearence of "My rooms" differ form "Recent rooms"
Uwe Simon created OPENMEETINGS-2467:
---
Summary: Appearence of "My rooms" differ form "Recent rooms"
Key: OPENMEETINGS-2467
URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2467
Project: Openmeetings
Issue Type: Improvement
Components: UI
Reporter: Uwe Simon
Assignee: Maxim Solodovnik
Attachments: Bildschirmfoto vom 2020-09-30 20-03-56.png
In "My rooms" the room details of the marked room are right to the room list,
in "Recent rooms" below the list.
Expectation: "Recent rooms" with rommdetail right of list.
Solution:
Change in the HTML for "Recent rooms"
{code:java}
{code}
to
{code:java}
{code}
!Bildschirmfoto vom 2020-09-30 20-03-56.png!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (OPENMEETINGS-2466) Camera is occupied (on) even after leaving the room
Ali Alhaidary created OPENMEETINGS-2466: --- Summary: Camera is occupied (on) even after leaving the room Key: OPENMEETINGS-2466 URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2466 Project: Openmeetings Issue Type: Bug Components: Audio/Video Affects Versions: 5.1.0 Reporter: Ali Alhaidary Assignee: Maxim Solodovnik Fix For: 5.1.0 Camera keeps occupied (on) even after leaving the room, no other application can use it. It will turn off after logging out of OM. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2464) Invitation to Metting from user: null null
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17204927#comment-17204927 ] Uwe Simon commented on OPENMEETINGS-2464: - Email looks fine now > Invitation to Metting from user: null null > -- > > Key: OPENMEETINGS-2464 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2464 > Project: Openmeetings > Issue Type: Bug > Components: Email >Affects Versions: 5.1.0 >Reporter: Uwe Simon >Assignee: Maxim Solodovnik >Priority: Minor > Fix For: 5.1.0 > > > Invitation to a meeting contains null when lastname or firstname of user is > empty > Better: > Meeting invitation should contain "display name" of sender similar to other > places where the username is shown. > > Example Email: > *OpenMeetings - Invitation* > Message from user: null null > Message: > OpenMeetings conference reminder: New Event > Start: 29 Sep 2020, 20:00:00 > End: 29 Sep 2020, 20:30:00 > Click this link to participate in the conference [The link may only work for > a certain period.]: > [Click here to enter room|http://localhost:8080/openmeetings/#room/35] > > If you have problems with the link, please copy and paste this to your > browser: > http://localhost:8080/openmeetings/#room/35 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2456) Poll Results: chart is closed when a participant vote
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17204916#comment-17204916 ] Uwe Simon commented on OPENMEETINGS-2456: - Works now, "chart type" matches chart shown. > Poll Results: chart is closed when a participant vote > - > > Key: OPENMEETINGS-2456 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2456 > Project: Openmeetings > Issue Type: Bug > Components: UI >Affects Versions: 5.1.0 >Reporter: Uwe Simon >Assignee: Maxim Solodovnik >Priority: Minor > Fix For: 5.1.0 > > Attachments: Bildschirmfoto vom 2020-09-26 16-26-18.png, > Bildschirmfoto vom 2020-09-26 16-37-47.png, Bildschirmfoto vom 2020-09-29 > 18-55-26.png > > > When the dialog "Poll Results" is open while participants are still voting > the chart is closed when a new vote is done. > Expected behaviour: Chart is redrawn with new values > > Workarround: select another chart type or close dialog and reopen it > > When reopening the "Poll Results" it looks like there are 2 chart on top of > each other. > !Bildschirmfoto vom 2020-09-26 16-26-18.png! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2456) Poll Results: chart is closed when a participant vote
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17204767#comment-17204767 ] ASF subversion and git services commented on OPENMEETINGS-2456: --- Commit b4fb8fcae379fc6b054cf224f14b33662e984d7a in openmeetings's branch refs/heads/master from Maxim Solodovnik [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=b4fb8fc ] [OPENMEETINGS-2456] close button works as expected > Poll Results: chart is closed when a participant vote > - > > Key: OPENMEETINGS-2456 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2456 > Project: Openmeetings > Issue Type: Bug > Components: UI >Affects Versions: 5.1.0 >Reporter: Uwe Simon >Assignee: Maxim Solodovnik >Priority: Minor > Fix For: 5.1.0 > > Attachments: Bildschirmfoto vom 2020-09-26 16-26-18.png, > Bildschirmfoto vom 2020-09-26 16-37-47.png, Bildschirmfoto vom 2020-09-29 > 18-55-26.png > > > When the dialog "Poll Results" is open while participants are still voting > the chart is closed when a new vote is done. > Expected behaviour: Chart is redrawn with new values > > Workarround: select another chart type or close dialog and reopen it > > When reopening the "Poll Results" it looks like there are 2 chart on top of > each other. > !Bildschirmfoto vom 2020-09-26 16-26-18.png! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[openmeetings] branch master updated: [OPENMEETINGS-2456] close button works as expected
This is an automated email from the ASF dual-hosted git repository.
solomax pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/openmeetings.git
The following commit(s) were added to refs/heads/master by this push:
new b4fb8fc [OPENMEETINGS-2456] close button works as expected
b4fb8fc is described below
commit b4fb8fcae379fc6b054cf224f14b33662e984d7a
Author: Maxim Solodovnik
AuthorDate: Wed Sep 30 21:19:45 2020 +0700
[OPENMEETINGS-2456] close button works as expected
---
.../java/org/apache/openmeetings/web/room/poll/PollResultsDialog.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/poll/PollResultsDialog.java
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/poll/PollResultsDialog.java
index a51714b..8b9fe69 100644
---
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/poll/PollResultsDialog.java
+++
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/poll/PollResultsDialog.java
@@ -173,7 +173,7 @@ public class PollResultsDialog extends Modal {
StringBuilder sb = new StringBuilder()
.append("$('#").append(chartDiv.getMarkupId()).append("').html(''); ");
if (onShow) {
-
sb.append("$('#").append(getMarkupId()).append("').off().on('shown.bs.modal',
function (e) {\n");
+
sb.append("$('#").append(getMarkupId()).append("').off('shown.bs.modal').on('shown.bs.modal',
function (e) {\n");
}
sb.append("$.jqplot('").append(chartDiv.getMarkupId()).append("', ")
.append(chart.getChartData().toJsonString())
[jira] [Resolved] (OPENMEETINGS-2456) Poll Results: chart is closed when a participant vote
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Solodovnik resolved OPENMEETINGS-2456. Resolution: Fixed > Poll Results: chart is closed when a participant vote > - > > Key: OPENMEETINGS-2456 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2456 > Project: Openmeetings > Issue Type: Bug > Components: UI >Affects Versions: 5.1.0 >Reporter: Uwe Simon >Assignee: Maxim Solodovnik >Priority: Minor > Fix For: 5.1.0 > > Attachments: Bildschirmfoto vom 2020-09-26 16-26-18.png, > Bildschirmfoto vom 2020-09-26 16-37-47.png, Bildschirmfoto vom 2020-09-29 > 18-55-26.png > > > When the dialog "Poll Results" is open while participants are still voting > the chart is closed when a new vote is done. > Expected behaviour: Chart is redrawn with new values > > Workarround: select another chart type or close dialog and reopen it > > When reopening the "Poll Results" it looks like there are 2 chart on top of > each other. > !Bildschirmfoto vom 2020-09-26 16-26-18.png! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (OPENMEETINGS-2451) Mute others is broken
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Solodovnik resolved OPENMEETINGS-2451. Resolution: Fixed > Mute others is broken > - > > Key: OPENMEETINGS-2451 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2451 > Project: Openmeetings > Issue Type: Bug > Components: Audio/Video >Affects Versions: 5.0.1 >Reporter: Maxim Solodovnik >Assignee: Maxim Solodovnik >Priority: Major > Fix For: 5.1.0 > > > Apologies for the previous long email. I had previously tried your > suggestions - the results being the same on the OM demo site below: > I tested the following mute functionality on the > https://om.alteametasoft.com/openmeetings demo site also and noticed the > following (with 3 users): > *SHIFT + F7* (works as expected as a quick on / off toggle for individual > users) > *SHIFT + F12* mutes all users (including moderator)... however, moderator and > all participants will have to click individually on the "speaker /audio" of > all participants if they want to hear each other again. > Perhaps it would be more useful to mute everybody... except the moderator... > whereby everyone can at least hear the moderator. > Finally (the function I am really eager to use), clicking on a users video > pod (or avatar when they have their camera deactivated) in order "mute > microphones of others"... will result in the popup message "Do you really > want to mute all users except this one?" ... but does not do anything. As I > can't test this any further, I can only assume that would this mute the > moderator also and if so would it best to "mute all others except this one > and the moderator". > I tested this using the latest versions of Chrome and Firefox. When using > Firefox the current hotkeys open the Firefox web debugging tools also.The > room type I was using was "conference" > (https://om.alteametasoft.com/openmeetings/#room/98659). > ML thread: https://markmail.org/message/dl3rqxhwca3nrtlg -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2451) Mute others is broken
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17204750#comment-17204750 ] ASF subversion and git services commented on OPENMEETINGS-2451: --- Commit 0f2e5d36f8baf51b2498927eeabf59f5ba13c0e4 in openmeetings's branch refs/heads/master from Maxim Solodovnik [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=0f2e5d3 ] [OPENMEETINGS-2451] don't ask again should be fixed > Mute others is broken > - > > Key: OPENMEETINGS-2451 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2451 > Project: Openmeetings > Issue Type: Bug > Components: Audio/Video >Affects Versions: 5.0.1 >Reporter: Maxim Solodovnik >Assignee: Maxim Solodovnik >Priority: Major > Fix For: 5.1.0 > > > Apologies for the previous long email. I had previously tried your > suggestions - the results being the same on the OM demo site below: > I tested the following mute functionality on the > https://om.alteametasoft.com/openmeetings demo site also and noticed the > following (with 3 users): > *SHIFT + F7* (works as expected as a quick on / off toggle for individual > users) > *SHIFT + F12* mutes all users (including moderator)... however, moderator and > all participants will have to click individually on the "speaker /audio" of > all participants if they want to hear each other again. > Perhaps it would be more useful to mute everybody... except the moderator... > whereby everyone can at least hear the moderator. > Finally (the function I am really eager to use), clicking on a users video > pod (or avatar when they have their camera deactivated) in order "mute > microphones of others"... will result in the popup message "Do you really > want to mute all users except this one?" ... but does not do anything. As I > can't test this any further, I can only assume that would this mute the > moderator also and if so would it best to "mute all others except this one > and the moderator". > I tested this using the latest versions of Chrome and Firefox. When using > Firefox the current hotkeys open the Firefox web debugging tools also.The > room type I was using was "conference" > (https://om.alteametasoft.com/openmeetings/#room/98659). > ML thread: https://markmail.org/message/dl3rqxhwca3nrtlg -- This message was sent by Atlassian Jira (v8.3.4#803005)
[openmeetings] branch master updated: [OPENMEETINGS-2451] don't ask again should be fixed
This is an automated email from the ASF dual-hosted git repository.
solomax pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/openmeetings.git
The following commit(s) were added to refs/heads/master by this push:
new 0f2e5d3 [OPENMEETINGS-2451] don't ask again should be fixed
0f2e5d3 is described below
commit 0f2e5d36f8baf51b2498927eeabf59f5ba13c0e4
Author: Maxim Solodovnik
AuthorDate: Wed Sep 30 21:07:04 2020 +0700
[OPENMEETINGS-2451] don't ask again should be fixed
---
.../src/main/java/org/apache/openmeetings/web/room/RoomPanel.html | 6 +++---
.../main/java/org/apache/openmeetings/web/room/raw-video-manager.js | 5 -
2 files changed, 7 insertions(+), 4 deletions(-)
diff --git
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/RoomPanel.html
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/RoomPanel.html
index ef61649..17920c5 100644
---
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/RoomPanel.html
+++
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/RoomPanel.html
@@ -81,11 +81,11 @@
-
-
+
+
-
+
diff --git
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/raw-video-manager.js
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/raw-video-manager.js
index 426a888..ad4e40f 100644
---
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/raw-video-manager.js
+++
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/raw-video-manager.js
@@ -226,7 +226,8 @@ var VideoManager = (function() {
if (false !== s.video.confirmMuteOthers) {
const dlg = $('#muteothers-confirm');
dlg.dialog({
- buttons: [
+ appendTo: ".room-container"
+ , buttons: [
{
text: dlg.data('btn-ok')
, click: function() {
@@ -244,6 +245,8 @@ var VideoManager = (function() {
}
]
})
+ } else {
+ OmUtil.roomAction({action: 'muteOthers', uid: uid});
}
}
function _muteOthers(uid) {
[jira] [Reopened] (OPENMEETINGS-2451) Mute others is broken
[
https://issues.apache.org/jira/browse/OPENMEETINGS-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maxim Solodovnik reopened OPENMEETINGS-2451:
{{Don't ask again}} is broken
> Mute others is broken
> -
>
> Key: OPENMEETINGS-2451
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2451
> Project: Openmeetings
> Issue Type: Bug
> Components: Audio/Video
>Affects Versions: 5.0.1
>Reporter: Maxim Solodovnik
>Assignee: Maxim Solodovnik
>Priority: Major
> Fix For: 5.1.0
>
>
> Apologies for the previous long email. I had previously tried your
> suggestions - the results being the same on the OM demo site below:
> I tested the following mute functionality on the
> https://om.alteametasoft.com/openmeetings demo site also and noticed the
> following (with 3 users):
> *SHIFT + F7* (works as expected as a quick on / off toggle for individual
> users)
> *SHIFT + F12* mutes all users (including moderator)... however, moderator and
> all participants will have to click individually on the "speaker /audio" of
> all participants if they want to hear each other again.
> Perhaps it would be more useful to mute everybody... except the moderator...
> whereby everyone can at least hear the moderator.
> Finally (the function I am really eager to use), clicking on a users video
> pod (or avatar when they have their camera deactivated) in order "mute
> microphones of others"... will result in the popup message "Do you really
> want to mute all users except this one?" ... but does not do anything. As I
> can't test this any further, I can only assume that would this mute the
> moderator also and if so would it best to "mute all others except this one
> and the moderator".
> I tested this using the latest versions of Chrome and Firefox. When using
> Firefox the current hotkeys open the Firefox web debugging tools also.The
> room type I was using was "conference"
> (https://om.alteametasoft.com/openmeetings/#room/98659).
> ML thread: https://markmail.org/message/dl3rqxhwca3nrtlg
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2455) (5.1.0) Library versions need to be updated
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17204725#comment-17204725 ] ASF subversion and git services commented on OPENMEETINGS-2455: --- Commit 05a2eb4a22ac1e9a027851ec75eb81a3a5c1274f in openmeetings's branch refs/heads/master from Maxim Solodovnik [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=05a2eb4 ] [OPENMEETINGS-2455] commons-pool > (5.1.0) Library versions need to be updated > --- > > Key: OPENMEETINGS-2455 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2455 > Project: Openmeetings > Issue Type: Task > Components: Builds >Affects Versions: 5.1.0 >Reporter: Maxim Solodovnik >Assignee: Maxim Solodovnik >Priority: Major > Fix For: 5.1.0 > > > Library versions need to be updated -- This message was sent by Atlassian Jira (v8.3.4#803005)
[openmeetings] branch master updated: [OPENMEETINGS-2455] commons-pool
This is an automated email from the ASF dual-hosted git repository. solomax pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/openmeetings.git The following commit(s) were added to refs/heads/master by this push: new 05a2eb4 [OPENMEETINGS-2455] commons-pool 05a2eb4 is described below commit 05a2eb4a22ac1e9a027851ec75eb81a3a5c1274f Author: Maxim Solodovnik AuthorDate: Wed Sep 30 20:19:05 2020 +0700 [OPENMEETINGS-2455] commons-pool --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 2364b10..f390471 100644 --- a/pom.xml +++ b/pom.xml @@ -94,7 +94,7 @@ 3.1.2 3.8.0 2.8.0 - 2.8.1 + 2.9.0 42.2.16 1.4 2.1.3
[jira] [Commented] (OPENMEETINGS-2363) Rework Conference Room UI-Dialogs to use Bootstrap style
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17204705#comment-17204705 ] ASF subversion and git services commented on OPENMEETINGS-2363: --- Commit 16f9280072856da62c1ab5ecd3bd63eaa15077e9 in openmeetings's branch refs/heads/master from Maxim Solodovnik [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=16f9280 ] [OPENMEETINGS-2363] default jquery-ui theme is tweaked > Rework Conference Room UI-Dialogs to use Bootstrap style > > > Key: OPENMEETINGS-2363 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2363 > Project: Openmeetings > Issue Type: Improvement > Components: UI >Reporter: Sebastian Wagner >Assignee: Maxim Solodovnik >Priority: Major > Fix For: 5.1.0 > > > As discussed, those UI-Dialogs should be moved to Bootstrap style. For Dialog > maybe and for the buttons inside of it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2456) Poll Results: chart is closed when a participant vote
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17204706#comment-17204706 ] ASF subversion and git services commented on OPENMEETINGS-2456: --- Commit 7888e503148894b03dc3e743564e2c54d3eaae33 in openmeetings's branch refs/heads/master from Maxim Solodovnik [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=7888e50 ] [OPENMEETINGS-2456] partially fixed > Poll Results: chart is closed when a participant vote > - > > Key: OPENMEETINGS-2456 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2456 > Project: Openmeetings > Issue Type: Bug > Components: UI >Affects Versions: 5.1.0 >Reporter: Uwe Simon >Assignee: Maxim Solodovnik >Priority: Minor > Fix For: 5.1.0 > > Attachments: Bildschirmfoto vom 2020-09-26 16-26-18.png, > Bildschirmfoto vom 2020-09-26 16-37-47.png, Bildschirmfoto vom 2020-09-29 > 18-55-26.png > > > When the dialog "Poll Results" is open while participants are still voting > the chart is closed when a new vote is done. > Expected behaviour: Chart is redrawn with new values > > Workarround: select another chart type or close dialog and reopen it > > When reopening the "Poll Results" it looks like there are 2 chart on top of > each other. > !Bildschirmfoto vom 2020-09-26 16-26-18.png! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[openmeetings] branch master updated: [OPENMEETINGS-2456] partially fixed
This is an automated email from the ASF dual-hosted git repository.
solomax pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/openmeetings.git
The following commit(s) were added to refs/heads/master by this push:
new 7888e50 [OPENMEETINGS-2456] partially fixed
7888e50 is described below
commit 7888e503148894b03dc3e743564e2c54d3eaae33
Author: Maxim Solodovnik
AuthorDate: Wed Sep 30 19:51:31 2020 +0700
[OPENMEETINGS-2456] partially fixed
---
.../web/room/poll/PollResultsDialog.java | 73 +++---
1 file changed, 35 insertions(+), 38 deletions(-)
diff --git
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/poll/PollResultsDialog.java
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/poll/PollResultsDialog.java
index c6ef92c..a51714b 100644
---
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/poll/PollResultsDialog.java
+++
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/poll/PollResultsDialog.java
@@ -81,7 +81,10 @@ public class PollResultsDialog extends Modal {
private BootstrapAjaxLink clone;
private boolean moderator = false;
private boolean opened = false;
+ private String chartSimple;
+ private String chartPie;
private final CreatePollDialog createPoll;
+ private DropDownChoice chartType;
@SpringBean
private PollDao pollDao;
@SpringBean
@@ -96,10 +99,10 @@ public class PollResultsDialog extends Modal {
@Override
protected void onInitialize() {
header(new ResourceModel("37"));
- setCloseOnEscapeKey(false);
- setBackdrop(Backdrop.STATIC);
setUseCloseHandler(true);
+ chartSimple = getString("1414");
+ chartPie = getString("1415");
add(selForm = new PollSelectForm("selForm"));
add(dispForm = new PollResultsForm("dispForm"));
addButton(close = new BootstrapAjaxLink<>("button", null,
Buttons.Type.Outline_Danger, new ResourceModel("1418")) {
@@ -214,14 +217,13 @@ public class PollResultsDialog extends Modal {
public Modal show(IPartialPageRequestHandler handler) {
opened = true;
super.show(handler);
-
handler.appendJavaScript(getScript(barChart(selForm.select.getModelObject()),
true));
+ redraw(handler, true);
return this;
}
@Override
public void onClose(IPartialPageRequestHandler handler) {
opened = false;
- super.onClose(handler);
}
public boolean isOpened() {
@@ -279,6 +281,35 @@ public class PollResultsDialog extends Modal {
return barChart;
}
+ private PieChart pieChart(RoomPoll p) {
+ PieChart pieChart = new PieChart<>(null);
+ String[] ticks = getTicks(p);
+ Integer[] values = getValues(p);
+ for (int i = 0; i < values.length; ++i) {
+ pieChart.addValue(ticks[i], values[i]);
+ }
+
+ pieChart.getSeriesDefaults().setRendererOptions(new
RendererOptions().setHighlightMouseDown(true)
+
.setShowDataLabels(true).setFill(false).setSliceMargin(4).setLineWidth(5));
+
+ Highlighter h = new Highlighter();
+ h.setShow(true);
+ h.setFormatString("%s, %P");
+ h.setTooltipLocation(Location.ne);
+ h.setShowTooltip(true);
+ h.setUseAxesFormatters(false);
+
+ pieChart.getChartConfiguration()
+ .setLegend(null).setHighlighter(h);
+ return pieChart;
+ }
+
+ private void redraw(IPartialPageRequestHandler handler, boolean onShow)
{
+ RoomPoll p = dispForm.getModelObject();
+ Chart chart = chartSimple.equals(chartType.getModelObject())
? barChart(p) : pieChart(p);
+ handler.appendJavaScript(getScript(chart, onShow));
+ }
+
private class PollSelectForm extends Form {
private static final long serialVersionUID = 1L;
private DropDownChoice select;
@@ -331,12 +362,9 @@ public class PollResultsDialog extends Modal {
private class PollResultsForm extends Form {
private static final long serialVersionUID = 1L;
- private String chartSimple;
- private String chartPie;
private final Label name = new Label("name",
Model.of((String)null));
private final Label question = new Label("question",
Model.of((String)null));
private final Label count = new Label("count", Model.of(0));
- private DropDownChoice chartType;
PollResultsForm(String id) {
super(id,
[openmeetings] branch master updated: [OPENMEETINGS-2363] default jquery-ui theme is tweaked
This is an automated email from the ASF dual-hosted git repository. solomax pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/openmeetings.git The following commit(s) were added to refs/heads/master by this push: new 16f9280 [OPENMEETINGS-2363] default jquery-ui theme is tweaked 16f9280 is described below commit 16f9280072856da62c1ab5ecd3bd63eaa15077e9 Author: Maxim Solodovnik AuthorDate: Wed Sep 30 19:49:22 2020 +0700 [OPENMEETINGS-2363] default jquery-ui theme is tweaked --- .../theme_om/images/ui-icons_2694e8_256x240.png| Bin 4549 -> 0 bytes .../theme_om/images/ui-icons_2e83ff_256x240.png| Bin 4549 -> 4618 bytes .../theme_om/images/ui-icons_3d80b3_256x240.png| Bin 4549 -> 0 bytes .../theme_om/images/ui-icons_495057_256x240.png| Bin 0 -> 4618 bytes .../theme_om/images/ui-icons_72a7cf_256x240.png| Bin 4549 -> 0 bytes .../theme_om/images/ui-icons_8E8C84_256x240.png| Bin 0 -> 4618 bytes .../theme_om/images/ui-icons_cc_256x240.png| Bin 4549 -> 4618 bytes .../theme_om/images/ui-icons_ff_256x240.png| Bin 6299 -> 6487 bytes .../src/main/webapp/css/theme_om/jquery-ui.css | 79 ++--- .../src/main/webapp/css/theme_om/jquery-ui.min.css | 6 +- 10 files changed, 42 insertions(+), 43 deletions(-) diff --git a/openmeetings-web/src/main/webapp/css/theme_om/images/ui-icons_2694e8_256x240.png b/openmeetings-web/src/main/webapp/css/theme_om/images/ui-icons_2694e8_256x240.png deleted file mode 100644 index a3f4509..000 Binary files a/openmeetings-web/src/main/webapp/css/theme_om/images/ui-icons_2694e8_256x240.png and /dev/null differ diff --git a/openmeetings-web/src/main/webapp/css/theme_om/images/ui-icons_2e83ff_256x240.png b/openmeetings-web/src/main/webapp/css/theme_om/images/ui-icons_2e83ff_256x240.png index 1f5f497..5d479f8 100644 Binary files a/openmeetings-web/src/main/webapp/css/theme_om/images/ui-icons_2e83ff_256x240.png and b/openmeetings-web/src/main/webapp/css/theme_om/images/ui-icons_2e83ff_256x240.png differ diff --git a/openmeetings-web/src/main/webapp/css/theme_om/images/ui-icons_3d80b3_256x240.png b/openmeetings-web/src/main/webapp/css/theme_om/images/ui-icons_3d80b3_256x240.png deleted file mode 100644 index 6ed9d63..000 Binary files a/openmeetings-web/src/main/webapp/css/theme_om/images/ui-icons_3d80b3_256x240.png and /dev/null differ diff --git a/openmeetings-web/src/main/webapp/css/theme_om/images/ui-icons_495057_256x240.png b/openmeetings-web/src/main/webapp/css/theme_om/images/ui-icons_495057_256x240.png new file mode 100644 index 000..c39573d Binary files /dev/null and b/openmeetings-web/src/main/webapp/css/theme_om/images/ui-icons_495057_256x240.png differ diff --git a/openmeetings-web/src/main/webapp/css/theme_om/images/ui-icons_72a7cf_256x240.png b/openmeetings-web/src/main/webapp/css/theme_om/images/ui-icons_72a7cf_256x240.png deleted file mode 100644 index b7c5812..000 Binary files a/openmeetings-web/src/main/webapp/css/theme_om/images/ui-icons_72a7cf_256x240.png and /dev/null differ diff --git a/openmeetings-web/src/main/webapp/css/theme_om/images/ui-icons_8E8C84_256x240.png b/openmeetings-web/src/main/webapp/css/theme_om/images/ui-icons_8E8C84_256x240.png new file mode 100644 index 000..6a545cf Binary files /dev/null and b/openmeetings-web/src/main/webapp/css/theme_om/images/ui-icons_8E8C84_256x240.png differ diff --git a/openmeetings-web/src/main/webapp/css/theme_om/images/ui-icons_cc_256x240.png b/openmeetings-web/src/main/webapp/css/theme_om/images/ui-icons_cc_256x240.png index 45ac778..9f2709b 100644 Binary files a/openmeetings-web/src/main/webapp/css/theme_om/images/ui-icons_cc_256x240.png and b/openmeetings-web/src/main/webapp/css/theme_om/images/ui-icons_cc_256x240.png differ diff --git a/openmeetings-web/src/main/webapp/css/theme_om/images/ui-icons_ff_256x240.png b/openmeetings-web/src/main/webapp/css/theme_om/images/ui-icons_ff_256x240.png index fe41d2d..9de497e 100644 Binary files a/openmeetings-web/src/main/webapp/css/theme_om/images/ui-icons_ff_256x240.png and b/openmeetings-web/src/main/webapp/css/theme_om/images/ui-icons_ff_256x240.png differ diff --git a/openmeetings-web/src/main/webapp/css/theme_om/jquery-ui.css b/openmeetings-web/src/main/webapp/css/theme_om/jquery-ui.css index e6bcbbb..4ceae2a 100644 --- a/openmeetings-web/src/main/webapp/css/theme_om/jquery-ui.css +++ b/openmeetings-web/src/main/webapp/css/theme_om/jquery-ui.css @@ -1,7 +1,7 @@ -/*! jQuery UI - v1.12.0 - 2016-09-10 +/*! jQuery UI - v1.12.1 - 2020-09-30 * http://jqueryui.com * Includes: draggable.css, core.css, resizable.css, selectable.css, sortable.css, accordion.css, autocomplete.css, menu.css, button.css, controlgroup.css, checkboxradio.css, datepicker.css, dialog.css, progressbar.css, selectmenu.css, slider.css, spinner.css, tabs.css, tooltip.css, theme.css -* To view and modify
[jira] [Resolved] (OPENMEETINGS-2363) Rework Conference Room UI-Dialogs to use Bootstrap style
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Solodovnik resolved OPENMEETINGS-2363. Assignee: Maxim Solodovnik (was: Sebastian Wagner) Resolution: Fixed looks better now > Rework Conference Room UI-Dialogs to use Bootstrap style > > > Key: OPENMEETINGS-2363 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2363 > Project: Openmeetings > Issue Type: Improvement > Components: UI >Reporter: Sebastian Wagner >Assignee: Maxim Solodovnik >Priority: Major > Fix For: 5.1.0 > > > As discussed, those UI-Dialogs should be moved to Bootstrap style. For Dialog > maybe and for the buttons inside of it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
