[jira] [Created] (OPENMEETINGS-2564) Video does not play on WB
Ali Alhaidary created OPENMEETINGS-2564: --- Summary: Video does not play on WB Key: OPENMEETINGS-2564 URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2564 Project: Openmeetings Issue Type: Bug Components: Recordings, UI, WhiteBoard Affects Versions: 6.0.0 Reporter: Ali Alhaidary Assignee: Maxim Solodovnik My steps are: 1) enter the room as moderator in FF or MS, 2) enter the same room as regular user in FF or MS, on another PC over the internet. 3) As moderator drop video to WB from 'My recordings'. Result: regular user not can see the video on WB 4) As moderator, I click play. Result: regular user not can see the video on WB, however, if he hovers over the WB, he can see only a frame (boarder) of the video, as if there is 'something' there. (I could not capture it :() BUT, if the moderator drops a video into the WB from 'Public recordings', all works as expected, regardless of browser type or OS. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2561) Captcha should be configurable
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17273308#comment-17273308 ] Ali Alhaidary commented on OPENMEETINGS-2561: - done ;) > Captcha should be configurable > -- > > Key: OPENMEETINGS-2561 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2561 > Project: Openmeetings > Issue Type: New Feature > Components: Security, UI >Affects Versions: 5.1.0 >Reporter: Maxim Solodovnik >Assignee: Maxim Solodovnik >Priority: Major > Fix For: 6.0.0 > > Attachments: captchi.png, github_edit.png > > > Currently captcha is {{'a'-'z'}} and non-configurable > This should be improved: > following attributes should be added to language.xml: > # 'tip' - short text describing this captcha for ex. "Enter uppercase English > letters" > # 'rangeStart' - initial letter/code of possible captcha characters > # 'rangeEnd' - final letter/code of possible captcha characters > {{'tip'}} above should be displayed as placeholder -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OPENMEETINGS-2561) Captcha should be configurable
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Solodovnik updated OPENMEETINGS-2561: --- Attachment: github_edit.png > Captcha should be configurable > -- > > Key: OPENMEETINGS-2561 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2561 > Project: Openmeetings > Issue Type: New Feature > Components: Security, UI >Affects Versions: 5.1.0 >Reporter: Maxim Solodovnik >Assignee: Maxim Solodovnik >Priority: Major > Fix For: 6.0.0 > > Attachments: captchi.png, github_edit.png > > > Currently captcha is {{'a'-'z'}} and non-configurable > This should be improved: > following attributes should be added to language.xml: > # 'tip' - short text describing this captcha for ex. "Enter uppercase English > letters" > # 'rangeStart' - initial letter/code of possible captcha characters > # 'rangeEnd' - final letter/code of possible captcha characters > {{'tip'}} above should be displayed as placeholder -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2561) Captcha should be configurable
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17273215#comment-17273215 ] Maxim Solodovnik commented on OPENMEETINGS-2561: You have multiple options :))) # post proposed changes to old "Captcha related" mail thread # create new mail thread # (*the best way*) ## register at https://github.com/ ## open https://github.com/apache/openmeetings/blob/master/openmeetings-web/src/main/webapp/languages/languages.xml ## click edit button !github_edit.png! ## and create your first PR ;) > Captcha should be configurable > -- > > Key: OPENMEETINGS-2561 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2561 > Project: Openmeetings > Issue Type: New Feature > Components: Security, UI >Affects Versions: 5.1.0 >Reporter: Maxim Solodovnik >Assignee: Maxim Solodovnik >Priority: Major > Fix For: 6.0.0 > > Attachments: captchi.png, github_edit.png > > > Currently captcha is {{'a'-'z'}} and non-configurable > This should be improved: > following attributes should be added to language.xml: > # 'tip' - short text describing this captcha for ex. "Enter uppercase English > letters" > # 'rangeStart' - initial letter/code of possible captcha characters > # 'rangeEnd' - final letter/code of possible captcha characters > {{'tip'}} above should be displayed as placeholder -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2000) High resolution webcam videos should not fill the entire screen by default. Just because you set a higher resolution doesn't mean the slides should be overlaid
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17273213#comment-17273213 ] Maxim Solodovnik commented on OPENMEETINGS-2000: [~ali.alhaidary] in testing I'm using video stored in "My files" Please share detailed steps which doesn't work for you (better in mailing list or separate JIRA) > High resolution webcam videos should not fill the entire screen by default. > Just because you set a higher resolution doesn't mean the slides should be > overlaid > --- > > Key: OPENMEETINGS-2000 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2000 > Project: Openmeetings > Issue Type: Improvement > Components: UI >Affects Versions: 4.0.7 >Reporter: Peter Dähn >Assignee: Maxim Solodovnik >Priority: Minor > Fix For: 6.0.0 > > Attachments: Auswahl_018.png, Auswahl_019.png > > > Define an initial maximum size for videos -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2561) Captcha should be configurable
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17273198#comment-17273198 ] Ali Alhaidary commented on OPENMEETINGS-2561: - how about '>arabic' can it be '>عربي' ? > Captcha should be configurable > -- > > Key: OPENMEETINGS-2561 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2561 > Project: Openmeetings > Issue Type: New Feature > Components: Security, UI >Affects Versions: 5.1.0 >Reporter: Maxim Solodovnik >Assignee: Maxim Solodovnik >Priority: Major > Fix For: 6.0.0 > > Attachments: captchi.png > > > Currently captcha is {{'a'-'z'}} and non-configurable > This should be improved: > following attributes should be added to language.xml: > # 'tip' - short text describing this captcha for ex. "Enter uppercase English > letters" > # 'rangeStart' - initial letter/code of possible captcha characters > # 'rangeEnd' - final letter/code of possible captcha characters > {{'tip'}} above should be displayed as placeholder -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2000) High resolution webcam videos should not fill the entire screen by default. Just because you set a higher resolution doesn't mean the slides should be overlaid
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17273077#comment-17273077 ] Ali Alhaidary commented on OPENMEETINGS-2000: - very much correct, however, that is only if the video is in the 'Public Recordings' and not as other files being anywhere in the tree. > High resolution webcam videos should not fill the entire screen by default. > Just because you set a higher resolution doesn't mean the slides should be > overlaid > --- > > Key: OPENMEETINGS-2000 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2000 > Project: Openmeetings > Issue Type: Improvement > Components: UI >Affects Versions: 4.0.7 >Reporter: Peter Dähn >Assignee: Maxim Solodovnik >Priority: Minor > Fix For: 6.0.0 > > Attachments: Auswahl_018.png, Auswahl_019.png > > > Define an initial maximum size for videos -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2561) Captcha should be configurable
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17273001#comment-17273001 ] Ali Alhaidary commented on OPENMEETINGS-2561: - Then I should copy this file after modification for each new snapshot I install ? > Captcha should be configurable > -- > > Key: OPENMEETINGS-2561 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2561 > Project: Openmeetings > Issue Type: New Feature > Components: Security, UI >Affects Versions: 5.1.0 >Reporter: Maxim Solodovnik >Assignee: Maxim Solodovnik >Priority: Major > Fix For: 6.0.0 > > Attachments: captchi.png > > > Currently captcha is {{'a'-'z'}} and non-configurable > This should be improved: > following attributes should be added to language.xml: > # 'tip' - short text describing this captcha for ex. "Enter uppercase English > letters" > # 'rangeStart' - initial letter/code of possible captcha characters > # 'rangeEnd' - final letter/code of possible captcha characters > {{'tip'}} above should be displayed as placeholder -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2000) High resolution webcam videos should not fill the entire screen by default. Just because you set a higher resolution doesn't mean the slides should be overlaid
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272984#comment-17272984 ] Maxim Solodovnik commented on OPENMEETINGS-2000: [~ali.alhaidary] As I wrote in previous comment: {quote}video on WB works for me (both locally and at demo-next){quote} My steps are: 1) enter the room as moderator in Chrome 2) enter the same room as regular user in FF 3) As moderator drop video to WB Result: regular user can see the video on WB 4) As moderator click play Result: the video plays for both users synchronously > High resolution webcam videos should not fill the entire screen by default. > Just because you set a higher resolution doesn't mean the slides should be > overlaid > --- > > Key: OPENMEETINGS-2000 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2000 > Project: Openmeetings > Issue Type: Improvement > Components: UI >Affects Versions: 4.0.7 >Reporter: Peter Dähn >Assignee: Maxim Solodovnik >Priority: Minor > Fix For: 6.0.0 > > Attachments: Auswahl_018.png, Auswahl_019.png > > > Define an initial maximum size for videos -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2561) Captcha should be configurable
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272981#comment-17272981 ] Maxim Solodovnik commented on OPENMEETINGS-2561: [~ali.alhaidary] {quote}ok, I found it in languages.xml{quote} great :)) this is why I posted the link in comments ;) https://issues.apache.org/jira/browse/OPENMEETINGS-2561?focusedCommentId=17272953&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17272953 {quote}should I change it for the languages that we use?{quote} sure :) > Captcha should be configurable > -- > > Key: OPENMEETINGS-2561 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2561 > Project: Openmeetings > Issue Type: New Feature > Components: Security, UI >Affects Versions: 5.1.0 >Reporter: Maxim Solodovnik >Assignee: Maxim Solodovnik >Priority: Major > Fix For: 6.0.0 > > Attachments: captchi.png > > > Currently captcha is {{'a'-'z'}} and non-configurable > This should be improved: > following attributes should be added to language.xml: > # 'tip' - short text describing this captcha for ex. "Enter uppercase English > letters" > # 'rangeStart' - initial letter/code of possible captcha characters > # 'rangeEnd' - final letter/code of possible captcha characters > {{'tip'}} above should be displayed as placeholder -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2000) High resolution webcam videos should not fill the entire screen by default. Just because you set a higher resolution doesn't mean the slides should be overlaid
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272980#comment-17272980 ] Ali Alhaidary commented on OPENMEETINGS-2000: - if you drop a picture, pdf, doc or even draw on the whiteboard, it shows directly to all participants whiteboards in the room, however, if you drop a video, it show only on the moderator whiteboard and not on participants whiteboard. > High resolution webcam videos should not fill the entire screen by default. > Just because you set a higher resolution doesn't mean the slides should be > overlaid > --- > > Key: OPENMEETINGS-2000 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2000 > Project: Openmeetings > Issue Type: Improvement > Components: UI >Affects Versions: 4.0.7 >Reporter: Peter Dähn >Assignee: Maxim Solodovnik >Priority: Minor > Fix For: 6.0.0 > > Attachments: Auswahl_018.png, Auswahl_019.png > > > Define an initial maximum size for videos -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OPENMEETINGS-2561) Captcha should be configurable
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272951#comment-17272951 ] Ali Alhaidary edited comment on OPENMEETINGS-2561 at 1/27/21, 4:24 PM: --- The gray text inside the text box is not localized, wrong and can not find it in POEditor, where is it? was (Author: ali.alhaidary): The gray text inside the text box is not localized and can not find it in POEditor, where is it? > Captcha should be configurable > -- > > Key: OPENMEETINGS-2561 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2561 > Project: Openmeetings > Issue Type: New Feature > Components: Security, UI >Affects Versions: 5.1.0 >Reporter: Maxim Solodovnik >Assignee: Maxim Solodovnik >Priority: Major > Fix For: 6.0.0 > > Attachments: captchi.png > > > Currently captcha is {{'a'-'z'}} and non-configurable > This should be improved: > following attributes should be added to language.xml: > # 'tip' - short text describing this captcha for ex. "Enter uppercase English > letters" > # 'rangeStart' - initial letter/code of possible captcha characters > # 'rangeEnd' - final letter/code of possible captcha characters > {{'tip'}} above should be displayed as placeholder -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2561) Captcha should be configurable
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272973#comment-17272973 ] Ali Alhaidary commented on OPENMEETINGS-2561: - ok, I found it in languages.xml, should I change it for the languages that we use? > Captcha should be configurable > -- > > Key: OPENMEETINGS-2561 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2561 > Project: Openmeetings > Issue Type: New Feature > Components: Security, UI >Affects Versions: 5.1.0 >Reporter: Maxim Solodovnik >Assignee: Maxim Solodovnik >Priority: Major > Fix For: 6.0.0 > > Attachments: captchi.png > > > Currently captcha is {{'a'-'z'}} and non-configurable > This should be improved: > following attributes should be added to language.xml: > # 'tip' - short text describing this captcha for ex. "Enter uppercase English > letters" > # 'rangeStart' - initial letter/code of possible captcha characters > # 'rangeEnd' - final letter/code of possible captcha characters > {{'tip'}} above should be displayed as placeholder -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2561) Captcha should be configurable
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272965#comment-17272965 ] Ali Alhaidary commented on OPENMEETINGS-2561: - !captchi.png! > Captcha should be configurable > -- > > Key: OPENMEETINGS-2561 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2561 > Project: Openmeetings > Issue Type: New Feature > Components: Security, UI >Affects Versions: 5.1.0 >Reporter: Maxim Solodovnik >Assignee: Maxim Solodovnik >Priority: Major > Fix For: 6.0.0 > > Attachments: captchi.png > > > Currently captcha is {{'a'-'z'}} and non-configurable > This should be improved: > following attributes should be added to language.xml: > # 'tip' - short text describing this captcha for ex. "Enter uppercase English > letters" > # 'rangeStart' - initial letter/code of possible captcha characters > # 'rangeEnd' - final letter/code of possible captcha characters > {{'tip'}} above should be displayed as placeholder -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OPENMEETINGS-2561) Captcha should be configurable
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ali Alhaidary updated OPENMEETINGS-2561: Attachment: captchi.png > Captcha should be configurable > -- > > Key: OPENMEETINGS-2561 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2561 > Project: Openmeetings > Issue Type: New Feature > Components: Security, UI >Affects Versions: 5.1.0 >Reporter: Maxim Solodovnik >Assignee: Maxim Solodovnik >Priority: Major > Fix For: 6.0.0 > > Attachments: captchi.png > > > Currently captcha is {{'a'-'z'}} and non-configurable > This should be improved: > following attributes should be added to language.xml: > # 'tip' - short text describing this captcha for ex. "Enter uppercase English > letters" > # 'rangeStart' - initial letter/code of possible captcha characters > # 'rangeEnd' - final letter/code of possible captcha characters > {{'tip'}} above should be displayed as placeholder -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2561) Captcha should be configurable
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272953#comment-17272953 ] Maxim Solodovnik commented on OPENMEETINGS-2561: https://github.com/apache/openmeetings/blob/master/openmeetings-web/src/main/webapp/languages/languages.xml#L35 > Captcha should be configurable > -- > > Key: OPENMEETINGS-2561 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2561 > Project: Openmeetings > Issue Type: New Feature > Components: Security, UI >Affects Versions: 5.1.0 >Reporter: Maxim Solodovnik >Assignee: Maxim Solodovnik >Priority: Major > Fix For: 6.0.0 > > > Currently captcha is {{'a'-'z'}} and non-configurable > This should be improved: > following attributes should be added to language.xml: > # 'tip' - short text describing this captcha for ex. "Enter uppercase English > letters" > # 'rangeStart' - initial letter/code of possible captcha characters > # 'rangeEnd' - final letter/code of possible captcha characters > {{'tip'}} above should be displayed as placeholder -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2561) Captcha should be configurable
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272951#comment-17272951 ] Ali Alhaidary commented on OPENMEETINGS-2561: - The gray text inside the text box is not localized and can not find it in POEditor, where is it? > Captcha should be configurable > -- > > Key: OPENMEETINGS-2561 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2561 > Project: Openmeetings > Issue Type: New Feature > Components: Security, UI >Affects Versions: 5.1.0 >Reporter: Maxim Solodovnik >Assignee: Maxim Solodovnik >Priority: Major > Fix For: 6.0.0 > > > Currently captcha is {{'a'-'z'}} and non-configurable > This should be improved: > following attributes should be added to language.xml: > # 'tip' - short text describing this captcha for ex. "Enter uppercase English > letters" > # 'rangeStart' - initial letter/code of possible captcha characters > # 'rangeEnd' - final letter/code of possible captcha characters > {{'tip'}} above should be displayed as placeholder -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2000) High resolution webcam videos should not fill the entire screen by default. Just because you set a higher resolution doesn't mean the slides should be overlaid
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272946#comment-17272946 ] Maxim Solodovnik commented on OPENMEETINGS-2000: [~ali.alhaidary] video on WB works for me (both locally and at demo-next) > High resolution webcam videos should not fill the entire screen by default. > Just because you set a higher resolution doesn't mean the slides should be > overlaid > --- > > Key: OPENMEETINGS-2000 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2000 > Project: Openmeetings > Issue Type: Improvement > Components: UI >Affects Versions: 4.0.7 >Reporter: Peter Dähn >Assignee: Maxim Solodovnik >Priority: Minor > Fix For: 6.0.0 > > Attachments: Auswahl_018.png, Auswahl_019.png > > > Define an initial maximum size for videos -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2563) Empty tabs should be hidden from private rooms panel
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272715#comment-17272715 ] ASF subversion and git services commented on OPENMEETINGS-2563: --- Commit 5b0921a992ac696824214922bcb0816061d7dae7 in openmeetings's branch refs/heads/master from Maxim Solodovnik [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=5b0921a ] [OPENMEETINGS-2563] empty tabs are hidden from private rooms panel > Empty tabs should be hidden from private rooms panel > > > Key: OPENMEETINGS-2563 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2563 > Project: Openmeetings > Issue Type: Improvement > Components: Dashboard, Room >Affects Versions: 5.1.0 >Reporter: Maxim Solodovnik >Assignee: Maxim Solodovnik >Priority: Major > Fix For: 6.0.0 > > > Empty tabs should be hidden from private rooms panel > Currently multiple user groups without rooms can create mess at private rooms > panel -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (OPENMEETINGS-2563) Empty tabs should be hidden from private rooms panel
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Solodovnik resolved OPENMEETINGS-2563. Resolution: Fixed > Empty tabs should be hidden from private rooms panel > > > Key: OPENMEETINGS-2563 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2563 > Project: Openmeetings > Issue Type: Improvement > Components: Dashboard, Room >Affects Versions: 5.1.0 >Reporter: Maxim Solodovnik >Assignee: Maxim Solodovnik >Priority: Major > Fix For: 6.0.0 > > > Empty tabs should be hidden from private rooms panel > Currently multiple user groups without rooms can create mess at private rooms > panel -- This message was sent by Atlassian Jira (v8.3.4#803005)
[openmeetings] branch master updated: [OPENMEETINGS-2563] empty tabs are hidden from private rooms panel
This is an automated email from the ASF dual-hosted git repository. solomax pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/openmeetings.git The following commit(s) were added to refs/heads/master by this push: new 5b0921a [OPENMEETINGS-2563] empty tabs are hidden from private rooms panel 5b0921a is described below commit 5b0921a992ac696824214922bcb0816061d7dae7 Author: Maxim Solodovnik AuthorDate: Wed Jan 27 16:42:59 2021 +0700 [OPENMEETINGS-2563] empty tabs are hidden from private rooms panel --- .../org/apache/openmeetings/db/dao/basic/ConfigurationDao.java | 3 +-- .../apache/openmeetings/web/user/rooms/RoomsTabbedPanel.java | 10 -- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/openmeetings-db/src/main/java/org/apache/openmeetings/db/dao/basic/ConfigurationDao.java b/openmeetings-db/src/main/java/org/apache/openmeetings/db/dao/basic/ConfigurationDao.java index 257ce13..3bcc3a8 100644 --- a/openmeetings-db/src/main/java/org/apache/openmeetings/db/dao/basic/ConfigurationDao.java +++ b/openmeetings-db/src/main/java/org/apache/openmeetings/db/dao/basic/ConfigurationDao.java @@ -47,7 +47,6 @@ import org.apache.openmeetings.db.dao.server.OAuth2Dao; import org.apache.openmeetings.db.dao.user.UserDao; import org.apache.openmeetings.db.entity.basic.Configuration; import org.apache.openmeetings.db.util.DaoHelper; -import org.apache.openmeetings.util.OpenmeetingsVariables; import org.apache.openmeetings.util.crypt.CryptProvider; import org.apache.wicket.Application; import org.apache.wicket.csp.CSPDirective; @@ -491,7 +490,7 @@ public class ConfigurationDao implements IDataProviderDao { } private void reloadRecordingEnabled() { - OpenmeetingsVariables.setRecordingsEnabled(getBool(CONFIG_RECORDING_ENABLED, true)); + setRecordingsEnabled(getBool(CONFIG_RECORDING_ENABLED, true)); } public void reinit() { diff --git a/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/rooms/RoomsTabbedPanel.java b/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/rooms/RoomsTabbedPanel.java index bf84df6..e14abd8 100644 --- a/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/rooms/RoomsTabbedPanel.java +++ b/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/rooms/RoomsTabbedPanel.java @@ -21,9 +21,12 @@ package org.apache.openmeetings.web.user.rooms; import static org.apache.openmeetings.web.app.WebSession.getUserId; import java.util.stream.Collectors; +import java.util.stream.Stream; import org.apache.openmeetings.db.dao.room.RoomDao; import org.apache.openmeetings.db.dao.user.UserDao; +import org.apache.openmeetings.db.entity.user.Group; +import org.apache.openmeetings.db.entity.user.GroupUser; import org.apache.openmeetings.db.entity.user.User; import org.apache.openmeetings.web.common.UserPanel; import org.apache.wicket.extensions.markup.html.tabs.AbstractTab; @@ -49,12 +52,15 @@ public class RoomsTabbedPanel extends UserPanel { protected void onInitialize() { super.onInitialize(); User u = userDao.get(getUserId()); - add(new AjaxBootstrapTabbedPanel<>("orgTabs", u.getGroupUsers().stream().map(gu -> new AbstractTab(Model.of(gu.getGroup().getName())) { + Stream groups = u.getGroupUsers().stream() + .map(GroupUser::getGroup) + .filter(g -> !roomDao.getGroupRooms(g.getId()).isEmpty()); + add(new AjaxBootstrapTabbedPanel<>("orgTabs", groups.map(g -> new AbstractTab(Model.of(g.getName())) { private static final long serialVersionUID = 1L; @Override public WebMarkupContainer getPanel(String panelId) { - return new RoomsPanel(panelId, roomDao.getGroupRooms(gu.getGroup().getId())); + return new RoomsPanel(panelId, roomDao.getGroupRooms(g.getId())); } }).collect(Collectors.toList(; }
[jira] [Created] (OPENMEETINGS-2563) Empty tabs should be hidden from private rooms panel
Maxim Solodovnik created OPENMEETINGS-2563: -- Summary: Empty tabs should be hidden from private rooms panel Key: OPENMEETINGS-2563 URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2563 Project: Openmeetings Issue Type: Improvement Components: Dashboard, Room Affects Versions: 5.1.0 Reporter: Maxim Solodovnik Assignee: Maxim Solodovnik Fix For: 6.0.0 Empty tabs should be hidden from private rooms panel Currently multiple user groups without rooms can create mess at private rooms panel -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (OPENMEETINGS-2562) It should be possible to globally disable recording functionality
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Solodovnik resolved OPENMEETINGS-2562. Resolution: Fixed > It should be possible to globally disable recording functionality > - > > Key: OPENMEETINGS-2562 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2562 > Project: Openmeetings > Issue Type: New Feature > Components: Recordings >Affects Versions: 5.1.0 >Reporter: Maxim Solodovnik >Assignee: Maxim Solodovnik >Priority: Major > Fix For: 6.0.0 > > > Currently recordings can be disabled per room > It should be possible to globally disable recording functionality -- This message was sent by Atlassian Jira (v8.3.4#803005)
[openmeetings] branch master updated: [OPENMEETINGS-2562] fixes issue #119: config to globally disable recordings
This is an automated email from the ASF dual-hosted git repository. solomax pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/openmeetings.git The following commit(s) were added to refs/heads/master by this push: new 4f519b9 [OPENMEETINGS-2562] fixes issue #119: config to globally disable recordings 4f519b9 is described below commit 4f519b9a6f13a1121f2c64d18c2fb68dd5dc813d Author: Maxim Solodovnik AuthorDate: Wed Jan 27 15:27:40 2021 +0700 [OPENMEETINGS-2562] fixes issue #119: config to globally disable recordings --- .../org/apache/openmeetings/core/remote/StreamProcessor.java | 5 +++-- .../org/apache/openmeetings/db/dao/basic/ConfigurationDao.java | 9 + .../main/java/org/apache/openmeetings/backup/BackupImport.java | 2 ++ .../org/apache/openmeetings/installation/ImportInitvalues.java | 2 ++ .../org/apache/openmeetings/util/OpenmeetingsVariables.java| 10 ++ .../java/org/apache/openmeetings/web/admin/rooms/RoomForm.java | 3 ++- .../java/org/apache/openmeetings/web/common/MainPanel.java | 7 +-- .../apache/openmeetings/web/common/tree/OmTreeProvider.java| 5 +++-- 8 files changed, 36 insertions(+), 7 deletions(-) diff --git a/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/StreamProcessor.java b/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/StreamProcessor.java index be483e0..58eab69 100644 --- a/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/StreamProcessor.java +++ b/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/StreamProcessor.java @@ -24,6 +24,7 @@ import static org.apache.openmeetings.core.remote.KurentoHandler.PARAM_ICE; import static org.apache.openmeetings.core.remote.KurentoHandler.activityAllowed; import static org.apache.openmeetings.core.remote.KurentoHandler.newKurentoMsg; import static org.apache.openmeetings.core.remote.KurentoHandler.sendError; +import static org.apache.openmeetings.util.OpenmeetingsVariables.isRecordingsEnabled; import java.util.Collection; import java.util.HashSet; @@ -456,11 +457,11 @@ public class StreamProcessor implements IStreamProcessor { public boolean hasRightsToRecord(Client c) { Room r = c.getRoom(); - return r != null && r.isAllowRecording() && c.hasRight(Right.MODERATOR); + return isRecordingsEnabled() && r != null && r.isAllowRecording() && c.hasRight(Right.MODERATOR); } public boolean recordingAllowed(Client c) { - if (!kHandler.isConnected()) { + if (!kHandler.isConnected() || !isRecordingsEnabled()) { return false; } Room r = c.getRoom(); diff --git a/openmeetings-db/src/main/java/org/apache/openmeetings/db/dao/basic/ConfigurationDao.java b/openmeetings-db/src/main/java/org/apache/openmeetings/db/dao/basic/ConfigurationDao.java index 35d68c7..257ce13 100644 --- a/openmeetings-db/src/main/java/org/apache/openmeetings/db/dao/basic/ConfigurationDao.java +++ b/openmeetings-db/src/main/java/org/apache/openmeetings/db/dao/basic/ConfigurationDao.java @@ -47,6 +47,7 @@ import org.apache.openmeetings.db.dao.server.OAuth2Dao; import org.apache.openmeetings.db.dao.user.UserDao; import org.apache.openmeetings.db.entity.basic.Configuration; import org.apache.openmeetings.db.util.DaoHelper; +import org.apache.openmeetings.util.OpenmeetingsVariables; import org.apache.openmeetings.util.crypt.CryptProvider; import org.apache.wicket.Application; import org.apache.wicket.csp.CSPDirective; @@ -348,6 +349,9 @@ public class ConfigurationDao implements IDataProviderDao { case CONFIG_APPOINTMENT_PRE_START_MINUTES: reloadAppointmentSettings(); break; + case CONFIG_RECORDING_ENABLED: + reloadRecordingEnabled(); + break; } return entity; } @@ -486,6 +490,10 @@ public class ConfigurationDao implements IDataProviderDao { setAppointmentReminderMinutes(getInt(CONFIG_APPOINTMENT_REMINDER_MINUTES, 15)); } + private void reloadRecordingEnabled() { + OpenmeetingsVariables.setRecordingsEnabled(getBool(CONFIG_RECORDING_ENABLED, true)); + } + public void reinit() { reloadMaxUpload(); reloadCrypt(); @@ -512,6 +520,7 @@ public class ConfigurationDao implements IDataProviderDao { reloadMyRoomsEnabled(); reloadMailSettings(); reloadAppointmentSettings(); + reloadRecordingEnabled(); updateCsp(); } diff --git a/openmeetings-install/src/main/java/org/apache/openmeetings/backup/BackupImport.java b/openmeetings-install/src/main/java/org/apache/openme
[jira] [Commented] (OPENMEETINGS-2562) It should be possible to globally disable recording functionality
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272662#comment-17272662 ] ASF subversion and git services commented on OPENMEETINGS-2562: --- Commit 4f519b9a6f13a1121f2c64d18c2fb68dd5dc813d in openmeetings's branch refs/heads/master from Maxim Solodovnik [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=4f519b9 ] [OPENMEETINGS-2562] fixes issue #119: config to globally disable recordings > It should be possible to globally disable recording functionality > - > > Key: OPENMEETINGS-2562 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2562 > Project: Openmeetings > Issue Type: New Feature > Components: Recordings >Affects Versions: 5.1.0 >Reporter: Maxim Solodovnik >Assignee: Maxim Solodovnik >Priority: Major > Fix For: 6.0.0 > > > Currently recordings can be disabled per room > It should be possible to globally disable recording functionality -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OPENMEETINGS-2562) It should be possible to globally disable recording functionality
Maxim Solodovnik created OPENMEETINGS-2562: -- Summary: It should be possible to globally disable recording functionality Key: OPENMEETINGS-2562 URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2562 Project: Openmeetings Issue Type: New Feature Components: Recordings Affects Versions: 5.1.0 Reporter: Maxim Solodovnik Assignee: Maxim Solodovnik Fix For: 6.0.0 Currently recordings can be disabled per room It should be possible to globally disable recording functionality -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (OPENMEETINGS-2561) Captcha should be configurable
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Solodovnik resolved OPENMEETINGS-2561. Resolution: Fixed > Captcha should be configurable > -- > > Key: OPENMEETINGS-2561 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2561 > Project: Openmeetings > Issue Type: New Feature > Components: Security, UI >Affects Versions: 5.1.0 >Reporter: Maxim Solodovnik >Assignee: Maxim Solodovnik >Priority: Major > Fix For: 6.0.0 > > > Currently captcha is {{'a'-'z'}} and non-configurable > This should be improved: > following attributes should be added to language.xml: > # 'tip' - short text describing this captcha for ex. "Enter uppercase English > letters" > # 'rangeStart' - initial letter/code of possible captcha characters > # 'rangeEnd' - final letter/code of possible captcha characters > {{'tip'}} above should be displayed as placeholder -- This message was sent by Atlassian Jira (v8.3.4#803005)