[jira] [Commented] (OPENMEETINGS-2577) Add performance and monitoring metrics - in disabled state
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17288891#comment-17288891 ] Ali Alhaidary commented on OPENMEETINGS-2577: - # is it always exposed or it uses the 'login' of OM? # How to enable/disable it? > Add performance and monitoring metrics - in disabled state > -- > > Key: OPENMEETINGS-2577 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2577 > Project: Openmeetings > Issue Type: New Feature >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > Fix For: 6.0.0 > > > As discussed: > [https://markmail.org/thread/new2mdd6jbyp2o6i] > Add performance metrics as par PoC using Prometheus metrics. > Shall be disabled by default. > This also requires to update the confluence page with some description on how > to enable it: > [https://cwiki.apache.org/confluence/display/OPENMEETINGS/Prometheus+Logging+and+Metrics|https://cwiki.apache.org/confluence/display/OPENMEETINGS/Prometheus+Logging+and+Metrics] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2577) Add performance and monitoring metrics - in disabled state
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1729#comment-1729 ] Ali Alhaidary commented on OPENMEETINGS-2577: - who is 'sonar'? > Add performance and monitoring metrics - in disabled state > -- > > Key: OPENMEETINGS-2577 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2577 > Project: Openmeetings > Issue Type: New Feature >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > Fix For: 6.0.0 > > > As discussed: > [https://markmail.org/thread/new2mdd6jbyp2o6i] > Add performance metrics as par PoC using Prometheus metrics. > Shall be disabled by default. > This also requires to update the confluence page with some description on how > to enable it: > [https://cwiki.apache.org/confluence/display/OPENMEETINGS/Prometheus+Logging+and+Metrics|https://cwiki.apache.org/confluence/display/OPENMEETINGS/Prometheus+Logging+and+Metrics] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2520) (6.0.0) Sonar issues need to be addressed
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17288832#comment-17288832 ] ASF subversion and git services commented on OPENMEETINGS-2520: --- Commit 976a75fd8c3def17f4600d71e467a966930f9915 in openmeetings's branch refs/heads/master from Maxim Solodovnik [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=976a75f ] [OPENMEETINGS-2520] sonar sould be more happy > (6.0.0) Sonar issues need to be addressed > - > > Key: OPENMEETINGS-2520 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2520 > Project: Openmeetings > Issue Type: Task > Components: Builds >Affects Versions: 6.0.0 >Reporter: Maxim Solodovnik >Assignee: Maxim Solodovnik >Priority: Major > Fix For: 6.0.0 > > > Sonar issues need to be addressed -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2567) Investigate Performance logging options
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17288833#comment-17288833 ] ASF subversion and git services commented on OPENMEETINGS-2567: --- Commit cce6d10b50e4db2f60ce308da45cef48a630f52a in openmeetings's branch refs/heads/master from Maxim Solodovnik [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=cce6d10 ] [OPENMEETINGS-2567] some indicies are added > Investigate Performance logging options > --- > > Key: OPENMEETINGS-2567 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2567 > Project: Openmeetings > Issue Type: Task > Components: Performance >Affects Versions: 5.1.0 >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > > A placeholder Jira to log changes around investigating performance logging > options. > Investigation happen in branch, but still good to have Jira to log commits in > it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[openmeetings] 02/02: [OPENMEETINGS-2567] some indicies are added
This is an automated email from the ASF dual-hosted git repository.
solomax pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/openmeetings.git
commit cce6d10b50e4db2f60ce308da45cef48a630f52a
Author: Maxim Solodovnik
AuthorDate: Tue Feb 23 11:33:14 2021 +0700
[OPENMEETINGS-2567] some indicies are added
---
.../main/java/org/apache/openmeetings/db/entity/user/Address.java| 5 -
.../src/main/java/org/apache/openmeetings/db/entity/user/User.java | 1 +
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git
a/openmeetings-db/src/main/java/org/apache/openmeetings/db/entity/user/Address.java
b/openmeetings-db/src/main/java/org/apache/openmeetings/db/entity/user/Address.java
index bf01604..b60cec8 100644
---
a/openmeetings-db/src/main/java/org/apache/openmeetings/db/entity/user/Address.java
+++
b/openmeetings-db/src/main/java/org/apache/openmeetings/db/entity/user/Address.java
@@ -23,6 +23,7 @@ import javax.persistence.Entity;
import javax.persistence.GeneratedValue;
import javax.persistence.GenerationType;
import javax.persistence.Id;
+import javax.persistence.Index;
import javax.persistence.Lob;
import javax.persistence.Table;
import javax.xml.bind.annotation.XmlElement;
@@ -32,7 +33,9 @@ import javax.xml.bind.annotation.XmlTransient;
import org.apache.openmeetings.db.entity.HistoricalEntity;
@Entity
-@Table(name = "address")
+@Table(name = "address", indexes = {
+ @Index(name = "email_idx", columnList = "email")
+})
@XmlRootElement(name = "address")
public class Address extends HistoricalEntity {
private static final long serialVersionUID = 1L;
diff --git
a/openmeetings-db/src/main/java/org/apache/openmeetings/db/entity/user/User.java
b/openmeetings-db/src/main/java/org/apache/openmeetings/db/entity/user/User.java
index a39b8c4..d93f90f 100644
---
a/openmeetings-db/src/main/java/org/apache/openmeetings/db/entity/user/User.java
+++
b/openmeetings-db/src/main/java/org/apache/openmeetings/db/entity/user/User.java
@@ -121,6 +121,7 @@ import org.apache.wicket.util.string.Strings;
@Index(name = "login_idx", columnList = "login")
, @Index(name = "lastname_idx", columnList = "lastname")
, @Index(name = "firstname_idx", columnList = "firstname")
+ , @Index(name = "type_idx", columnList = "type")
})
@XmlRootElement(name = USER_NODE)
public class User extends HistoricalEntity {
[openmeetings] branch master updated (c8e5520 -> cce6d10)
This is an automated email from the ASF dual-hosted git repository. solomax pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/openmeetings.git. from c8e5520 [OPENMEETINGS-2577] sonar should be more happy new 976a75f [OPENMEETINGS-2520] sonar sould be more happy new cce6d10 [OPENMEETINGS-2567] some indicies are added The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../main/java/org/apache/openmeetings/db/entity/user/Address.java | 5 - .../main/java/org/apache/openmeetings/db/entity/user/User.java| 1 + .../org/apache/openmeetings/util/crypt/SCryptImplementation.java | 8 3 files changed, 9 insertions(+), 5 deletions(-)
[openmeetings] 01/02: [OPENMEETINGS-2520] sonar sould be more happy
This is an automated email from the ASF dual-hosted git repository.
solomax pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/openmeetings.git
commit 976a75fd8c3def17f4600d71e467a966930f9915
Author: Maxim Solodovnik
AuthorDate: Tue Feb 23 11:32:20 2021 +0700
[OPENMEETINGS-2520] sonar sould be more happy
---
.../org/apache/openmeetings/util/crypt/SCryptImplementation.java | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
a/openmeetings-util/src/main/java/org/apache/openmeetings/util/crypt/SCryptImplementation.java
b/openmeetings-util/src/main/java/org/apache/openmeetings/util/crypt/SCryptImplementation.java
index 34ba241..560d824 100644
---
a/openmeetings-util/src/main/java/org/apache/openmeetings/util/crypt/SCryptImplementation.java
+++
b/openmeetings-util/src/main/java/org/apache/openmeetings/util/crypt/SCryptImplementation.java
@@ -44,7 +44,7 @@ public class SCryptImplementation implements ICrypt {
}
return sr;
});
- private static int COST = 1024 * 16;
+ private static int cost = 1024 * 16;
private static final int KEY_LENGTH = 512;
private static final int SALT_LENGTH = 200;
@@ -58,14 +58,14 @@ public class SCryptImplementation implements ICrypt {
try (final InputStream is =
getClass().getResourceAsStream("/openmeetings.properties")) {
Properties props = new Properties();
props.load(is);
- COST = Integer.valueOf(props.getProperty("scrypt.cost",
"" + COST));
+ cost = Integer.valueOf(props.getProperty("scrypt.cost",
"" + cost));
} catch (Exception e) {
- log.error("Failed to initialize the COST", e);
+ log.error("Failed to initialize the cost", e);
}
}
private static String hash(String str, byte[] salt) {
- byte[] dk = SCrypt.generate(str.getBytes(UTF_8), salt, COST, 8,
8, KEY_LENGTH);
+ byte[] dk = SCrypt.generate(str.getBytes(UTF_8), salt, cost, 8,
8, KEY_LENGTH);
return Base64.encodeBase64String(dk);
}
[jira] [Commented] (OPENMEETINGS-2577) Add performance and monitoring metrics - in disabled state
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17288830#comment-17288830 ] ASF subversion and git services commented on OPENMEETINGS-2577: --- Commit c8e552069d82188c2eea1167579af8822ea422d1 in openmeetings's branch refs/heads/master from Maxim Solodovnik [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=c8e5520 ] [OPENMEETINGS-2577] sonar should be more happy > Add performance and monitoring metrics - in disabled state > -- > > Key: OPENMEETINGS-2577 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2577 > Project: Openmeetings > Issue Type: New Feature >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > Fix For: 6.0.0 > > > As discussed: > [https://markmail.org/thread/new2mdd6jbyp2o6i] > Add performance metrics as par PoC using Prometheus metrics. > Shall be disabled by default. > This also requires to update the confluence page with some description on how > to enable it: > [https://cwiki.apache.org/confluence/display/OPENMEETINGS/Prometheus+Logging+and+Metrics|https://cwiki.apache.org/confluence/display/OPENMEETINGS/Prometheus+Logging+and+Metrics] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[openmeetings] branch master updated: [OPENMEETINGS-2577] sonar should be more happy
This is an automated email from the ASF dual-hosted git repository.
solomax pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/openmeetings.git
The following commit(s) were added to refs/heads/master by this push:
new c8e5520 [OPENMEETINGS-2577] sonar should be more happy
c8e5520 is described below
commit c8e552069d82188c2eea1167579af8822ea422d1
Author: Maxim Solodovnik
AuthorDate: Tue Feb 23 11:29:07 2021 +0700
[OPENMEETINGS-2577] sonar should be more happy
---
.../core/remote/StreamProcessorActions.java| 3 +-
.../openmeetings/util/logging/PrometheusUtil.java | 12 ++--
.../web/util/logging/TomcatGenericExports.java | 82 +++---
3 files changed, 50 insertions(+), 47 deletions(-)
diff --git
a/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/StreamProcessorActions.java
b/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/StreamProcessorActions.java
index d6de328..6580918 100644
---
a/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/StreamProcessorActions.java
+++
b/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/StreamProcessorActions.java
@@ -41,8 +41,7 @@ import com.github.openjson.JSONObject;
@Component
public class StreamProcessorActions {
-
- private static final Logger log =
LoggerFactory.getLogger(StreamProcessor.class);
+ private static final Logger log =
LoggerFactory.getLogger(StreamProcessorActions.class);
@Autowired
private IClientManager cm;
diff --git
a/openmeetings-util/src/main/java/org/apache/openmeetings/util/logging/PrometheusUtil.java
b/openmeetings-util/src/main/java/org/apache/openmeetings/util/logging/PrometheusUtil.java
index a663b99..0f1cfd3 100644
---
a/openmeetings-util/src/main/java/org/apache/openmeetings/util/logging/PrometheusUtil.java
+++
b/openmeetings-util/src/main/java/org/apache/openmeetings/util/logging/PrometheusUtil.java
@@ -22,13 +22,15 @@ package org.apache.openmeetings.util.logging;
import io.prometheus.client.Histogram;
public class PrometheusUtil {
-
- private static Histogram histogram = Histogram.build() //
- .help("OpenMeetings Application Metrics") //
- .name("org_openmeetings_metrics") //
- .labelNames("class", "method", "type", "message") //
+ private static final Histogram histogram = Histogram.build()
+ .help("OpenMeetings Application Metrics")
+ .name("org_openmeetings_metrics")
+ .labelNames("class", "method", "type", "message")
.register();
+ private PrometheusUtil() {
+ }
+
public static Histogram getHistogram() {
return histogram;
}
diff --git
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/util/logging/TomcatGenericExports.java
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/util/logging/TomcatGenericExports.java
index 382fff9..20a049e 100644
---
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/util/logging/TomcatGenericExports.java
+++
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/util/logging/TomcatGenericExports.java
@@ -18,16 +18,8 @@
*/
package org.apache.openmeetings.web.util.logging;
-import io.prometheus.client.Collector;
-import io.prometheus.client.CounterMetricFamily;
-import io.prometheus.client.GaugeMetricFamily;
-import org.apache.catalina.util.ServerInfo;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
import java.lang.management.ManagementFactory;
import java.util.ArrayList;
-import java.util.Arrays;
import java.util.Collections;
import java.util.List;
import java.util.Set;
@@ -38,12 +30,19 @@ import javax.management.MBeanServer;
import javax.management.ObjectInstance;
import javax.management.ObjectName;
+import org.apache.catalina.util.ServerInfo;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import io.prometheus.client.Collector;
+import io.prometheus.client.CounterMetricFamily;
+import io.prometheus.client.GaugeMetricFamily;
+
/**
* Exports Tomcat metrics applicable to most most applications:
*
* - http session metrics - request processor metrics - thread pool metrics
*
- *
* Example usage:
*
*
@@ -73,10 +72,9 @@ import javax.management.ObjectName;
*
*/
public class TomcatGenericExports extends Collector {
-
private static final Logger log =
LoggerFactory.getLogger(TomcatGenericExports.class);
+ private static final String labelName = "name";
private String jmxDomain = "Catalina";
- private final String labelName = "name";
public TomcatGenericExports(boolean embedded) {
if (embedded) {
@@ -90,7 +88,7 @@ public class TomcatGenericExports extends Collector {
ObjectName filterName = new ObjectName(jmxDomain +
[jira] [Resolved] (OPENMEETINGS-2551) There should be way to limit NetTest client count
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Solodovnik resolved OPENMEETINGS-2551. Resolution: Fixed > There should be way to limit NetTest client count > - > > Key: OPENMEETINGS-2551 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2551 > Project: Openmeetings > Issue Type: Improvement > Components: Testing-Tool >Affects Versions: 5.1.0 >Reporter: Maxim Solodovnik >Assignee: Maxim Solodovnik >Priority: Major > Fix For: 6.0.0 > > > Currently there can be unlimited clients of Network testing tool > It should be possible to limit -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2577) Add performance and monitoring metrics - in disabled state
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17288775#comment-17288775 ] ASF subversion and git services commented on OPENMEETINGS-2577: --- Commit cc281deb8b8796ab5993ef457669f858bcdc690d in openmeetings's branch refs/heads/master from Sebastian Wagner [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=cc281de ] Merge pull request #130 from apache/feature/OPENMEETINGS-2577-performance--metrics-disabled-state OPENMEETINGS-2577 performance metrics disabled state > Add performance and monitoring metrics - in disabled state > -- > > Key: OPENMEETINGS-2577 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2577 > Project: Openmeetings > Issue Type: New Feature >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > Fix For: 6.0.0 > > > As discussed: > [https://markmail.org/thread/new2mdd6jbyp2o6i] > Add performance metrics as par PoC using Prometheus metrics. > Shall be disabled by default. > This also requires to update the confluence page with some description on how > to enable it: > [https://cwiki.apache.org/confluence/display/OPENMEETINGS/Prometheus+Logging+and+Metrics|https://cwiki.apache.org/confluence/display/OPENMEETINGS/Prometheus+Logging+and+Metrics] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2577) Add performance and monitoring metrics - in disabled state
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17288774#comment-17288774 ] ASF subversion and git services commented on OPENMEETINGS-2577: --- Commit 02dd02e5f80e77a598858065ffc5114c1b204b36 in openmeetings's branch refs/heads/master from Sebastian Wagner [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=02dd02e ] OPENMEETINGS-2577 Fix externalise constant name and no wildcard imports. > Add performance and monitoring metrics - in disabled state > -- > > Key: OPENMEETINGS-2577 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2577 > Project: Openmeetings > Issue Type: New Feature >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > Fix For: 6.0.0 > > > As discussed: > [https://markmail.org/thread/new2mdd6jbyp2o6i] > Add performance metrics as par PoC using Prometheus metrics. > Shall be disabled by default. > This also requires to update the confluence page with some description on how > to enable it: > [https://cwiki.apache.org/confluence/display/OPENMEETINGS/Prometheus+Logging+and+Metrics|https://cwiki.apache.org/confluence/display/OPENMEETINGS/Prometheus+Logging+and+Metrics] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2577) Add performance and monitoring metrics - in disabled state
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17288769#comment-17288769 ] ASF subversion and git services commented on OPENMEETINGS-2577: --- Commit a812074c3ef29768dc58eb86f5076222440ea592 in openmeetings's branch refs/heads/master from Sebastian Wagner [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=a812074 ] OPENMEETINGS-2577 Fix header of Util. > Add performance and monitoring metrics - in disabled state > -- > > Key: OPENMEETINGS-2577 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2577 > Project: Openmeetings > Issue Type: New Feature >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > Fix For: 6.0.0 > > > As discussed: > [https://markmail.org/thread/new2mdd6jbyp2o6i] > Add performance metrics as par PoC using Prometheus metrics. > Shall be disabled by default. > This also requires to update the confluence page with some description on how > to enable it: > [https://cwiki.apache.org/confluence/display/OPENMEETINGS/Prometheus+Logging+and+Metrics|https://cwiki.apache.org/confluence/display/OPENMEETINGS/Prometheus+Logging+and+Metrics] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2577) Add performance and monitoring metrics - in disabled state
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17288772#comment-17288772 ] ASF subversion and git services commented on OPENMEETINGS-2577: --- Commit 17db6e8c0cecebde8ccf82fe27f4231718b39ec3 in openmeetings's branch refs/heads/master from Sebastian Wagner [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=17db6e8 ] OPENMEETINGS-2577 avoid wildcard imports. > Add performance and monitoring metrics - in disabled state > -- > > Key: OPENMEETINGS-2577 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2577 > Project: Openmeetings > Issue Type: New Feature >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > Fix For: 6.0.0 > > > As discussed: > [https://markmail.org/thread/new2mdd6jbyp2o6i] > Add performance metrics as par PoC using Prometheus metrics. > Shall be disabled by default. > This also requires to update the confluence page with some description on how > to enable it: > [https://cwiki.apache.org/confluence/display/OPENMEETINGS/Prometheus+Logging+and+Metrics|https://cwiki.apache.org/confluence/display/OPENMEETINGS/Prometheus+Logging+and+Metrics] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2577) Add performance and monitoring metrics - in disabled state
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17288770#comment-17288770 ] ASF subversion and git services commented on OPENMEETINGS-2577: --- Commit 8862d2f8ad83055440ae9478910f5eabd31ae797 in openmeetings's branch refs/heads/master from Sebastian Wagner [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=8862d2f ] OPENMEETINGS-2577 Fix adding additional class to mock. > Add performance and monitoring metrics - in disabled state > -- > > Key: OPENMEETINGS-2577 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2577 > Project: Openmeetings > Issue Type: New Feature >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > Fix For: 6.0.0 > > > As discussed: > [https://markmail.org/thread/new2mdd6jbyp2o6i] > Add performance metrics as par PoC using Prometheus metrics. > Shall be disabled by default. > This also requires to update the confluence page with some description on how > to enable it: > [https://cwiki.apache.org/confluence/display/OPENMEETINGS/Prometheus+Logging+and+Metrics|https://cwiki.apache.org/confluence/display/OPENMEETINGS/Prometheus+Logging+and+Metrics] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2577) Add performance and monitoring metrics - in disabled state
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17288773#comment-17288773 ] ASF subversion and git services commented on OPENMEETINGS-2577: --- Commit f8e9fac6213d57919dbaa0d6627ddb4fce358baf in openmeetings's branch refs/heads/master from Sebastian Wagner [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=f8e9fac ] OPENMEETINGS-2577 Fix aspectjtools version into dependency-manager section. > Add performance and monitoring metrics - in disabled state > -- > > Key: OPENMEETINGS-2577 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2577 > Project: Openmeetings > Issue Type: New Feature >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > Fix For: 6.0.0 > > > As discussed: > [https://markmail.org/thread/new2mdd6jbyp2o6i] > Add performance metrics as par PoC using Prometheus metrics. > Shall be disabled by default. > This also requires to update the confluence page with some description on how > to enable it: > [https://cwiki.apache.org/confluence/display/OPENMEETINGS/Prometheus+Logging+and+Metrics|https://cwiki.apache.org/confluence/display/OPENMEETINGS/Prometheus+Logging+and+Metrics] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2577) Add performance and monitoring metrics - in disabled state
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17288771#comment-17288771 ] ASF subversion and git services commented on OPENMEETINGS-2577: --- Commit 0b5bc21915ed9517c82dec358934324c951d69be in openmeetings's branch refs/heads/master from Sebastian Wagner [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=0b5bc21 ] OPENMEETINGS-2577 Generalise common log method. > Add performance and monitoring metrics - in disabled state > -- > > Key: OPENMEETINGS-2577 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2577 > Project: Openmeetings > Issue Type: New Feature >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > Fix For: 6.0.0 > > > As discussed: > [https://markmail.org/thread/new2mdd6jbyp2o6i] > Add performance metrics as par PoC using Prometheus metrics. > Shall be disabled by default. > This also requires to update the confluence page with some description on how > to enable it: > [https://cwiki.apache.org/confluence/display/OPENMEETINGS/Prometheus+Logging+and+Metrics|https://cwiki.apache.org/confluence/display/OPENMEETINGS/Prometheus+Logging+and+Metrics] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2577) Add performance and monitoring metrics - in disabled state
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17288776#comment-17288776 ] ASF subversion and git services commented on OPENMEETINGS-2577: --- Commit cc281deb8b8796ab5993ef457669f858bcdc690d in openmeetings's branch refs/heads/master from Sebastian Wagner [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=cc281de ] Merge pull request #130 from apache/feature/OPENMEETINGS-2577-performance--metrics-disabled-state OPENMEETINGS-2577 performance metrics disabled state > Add performance and monitoring metrics - in disabled state > -- > > Key: OPENMEETINGS-2577 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2577 > Project: Openmeetings > Issue Type: New Feature >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > Fix For: 6.0.0 > > > As discussed: > [https://markmail.org/thread/new2mdd6jbyp2o6i] > Add performance metrics as par PoC using Prometheus metrics. > Shall be disabled by default. > This also requires to update the confluence page with some description on how > to enable it: > [https://cwiki.apache.org/confluence/display/OPENMEETINGS/Prometheus+Logging+and+Metrics|https://cwiki.apache.org/confluence/display/OPENMEETINGS/Prometheus+Logging+and+Metrics] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2577) Add performance and monitoring metrics - in disabled state
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17288768#comment-17288768 ] ASF subversion and git services commented on OPENMEETINGS-2577: --- Commit 92cba66dd6522e9a661721b01cb4472aafa81c06 in openmeetings's branch refs/heads/master from Sebastian Wagner [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=92cba66 ] OPENMEETINGS-2577 Fix disable by default for metrics. > Add performance and monitoring metrics - in disabled state > -- > > Key: OPENMEETINGS-2577 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2577 > Project: Openmeetings > Issue Type: New Feature >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > Fix For: 6.0.0 > > > As discussed: > [https://markmail.org/thread/new2mdd6jbyp2o6i] > Add performance metrics as par PoC using Prometheus metrics. > Shall be disabled by default. > This also requires to update the confluence page with some description on how > to enable it: > [https://cwiki.apache.org/confluence/display/OPENMEETINGS/Prometheus+Logging+and+Metrics|https://cwiki.apache.org/confluence/display/OPENMEETINGS/Prometheus+Logging+and+Metrics] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2577) Add performance and monitoring metrics - in disabled state
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17288767#comment-17288767 ] ASF subversion and git services commented on OPENMEETINGS-2577: --- Commit 4d5fb810615ed01ed91152bb7954d9bd2e34afc6 in openmeetings's branch refs/heads/master from Sebastian Wagner [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=4d5fb81 ] OPENMEETINGS-2577 Update and externalise Method calls for being able to have Spring style annotations on method calls. > Add performance and monitoring metrics - in disabled state > -- > > Key: OPENMEETINGS-2577 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2577 > Project: Openmeetings > Issue Type: New Feature >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > Fix For: 6.0.0 > > > As discussed: > [https://markmail.org/thread/new2mdd6jbyp2o6i] > Add performance metrics as par PoC using Prometheus metrics. > Shall be disabled by default. > This also requires to update the confluence page with some description on how > to enable it: > [https://cwiki.apache.org/confluence/display/OPENMEETINGS/Prometheus+Logging+and+Metrics|https://cwiki.apache.org/confluence/display/OPENMEETINGS/Prometheus+Logging+and+Metrics] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2577) Add performance and monitoring metrics - in disabled state
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17288766#comment-17288766 ] ASF subversion and git services commented on OPENMEETINGS-2577: --- Commit 3e8b3b8436cbd7cd50f40f07e59ab0369fd3b869 in openmeetings's branch refs/heads/master from Sebastian Wagner [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=3e8b3b8 ] OPENMEETINGS-2577 Fix adding Tomcat metrics as part of Metrics Servlet. > Add performance and monitoring metrics - in disabled state > -- > > Key: OPENMEETINGS-2577 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2577 > Project: Openmeetings > Issue Type: New Feature >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > Fix For: 6.0.0 > > > As discussed: > [https://markmail.org/thread/new2mdd6jbyp2o6i] > Add performance metrics as par PoC using Prometheus metrics. > Shall be disabled by default. > This also requires to update the confluence page with some description on how > to enable it: > [https://cwiki.apache.org/confluence/display/OPENMEETINGS/Prometheus+Logging+and+Metrics|https://cwiki.apache.org/confluence/display/OPENMEETINGS/Prometheus+Logging+and+Metrics] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[openmeetings] branch master updated (55b5f08 -> cc281de)
This is an automated email from the ASF dual-hosted git repository.
sebawagner pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/openmeetings.git.
from 55b5f08 [OPENMEETINGS-2519] spring, jetty
add 0a12b0f OPENMEETINGS-2577 Add aop-style Annotations and Aspect to
register in Prometheus.
add ceea0dd OPENMEETINGS-2577 Add and annotate core streaming classes.
Add metrics servlet. Add TomcatMetrics.
add 3e8b3b8 OPENMEETINGS-2577 Fix adding Tomcat metrics as part of
Metrics Servlet.
add 4d5fb81 OPENMEETINGS-2577 Update and externalise Method calls for
being able to have Spring style annotations on method calls.
add 92cba66 OPENMEETINGS-2577 Fix disable by default for metrics.
add a812074 OPENMEETINGS-2577 Fix header of Util.
add 8862d2f OPENMEETINGS-2577 Fix adding additional class to mock.
add 0b5bc21 OPENMEETINGS-2577 Generalise common log method.
add 17db6e8 OPENMEETINGS-2577 avoid wildcard imports.
add f8e9fac OPENMEETINGS-2577 Fix aspectjtools version into
dependency-manager section.
add 02dd02e OPENMEETINGS-2577 Fix externalise constant name and no
wildcard imports.
new cc281de Merge pull request #130 from
apache/feature/OPENMEETINGS-2577-performance--metrics-disabled-state
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../openmeetings/core/remote/StreamProcessor.java | 81 +-
.../core/remote/StreamProcessorActions.java| 127 +
.../openmeetings/core/remote/BaseMockedTest.java | 3 +
openmeetings-util/pom.xml | 16 ++
.../util/logging/PrometheusAspect.java | 54
.../openmeetings/util/logging/PrometheusUtil.java | 22 +-
.../util/logging/TimedApplication.java | 17 +-
.../openmeetings/util/logging/TimedDatabase.java | 17 +-
openmeetings-web/pom.xml | 8 +
.../logging/OpenMeetingsMetricsServlet.java} | 14 +-
.../web/util/logging/TomcatGenericExports.java | 314 +
.../webapp/WEB-INF/classes/applicationContext.xml | 5 +
openmeetings-web/src/main/webapp/WEB-INF/web.xml | 40 +++
pom.xml| 44 +++
14 files changed, 658 insertions(+), 104 deletions(-)
create mode 100644
openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/StreamProcessorActions.java
create mode 100644
openmeetings-util/src/main/java/org/apache/openmeetings/util/logging/PrometheusAspect.java
copy
openmeetings-install/src/main/java/org/apache/openmeetings/backup/ProgressHolder.java
=>
openmeetings-util/src/main/java/org/apache/openmeetings/util/logging/PrometheusUtil.java
(67%)
copy openmeetings-core/src/test/java/org/apache/openmeetings/gui/TestGui.java
=>
openmeetings-util/src/main/java/org/apache/openmeetings/util/logging/TimedApplication.java
(72%)
copy openmeetings-core/src/test/java/org/apache/openmeetings/gui/TestGui.java
=>
openmeetings-util/src/main/java/org/apache/openmeetings/util/logging/TimedDatabase.java
(72%)
copy
openmeetings-web/src/main/java/org/apache/openmeetings/web/{pages/PrivacyPage.java
=> util/logging/OpenMeetingsMetricsServlet.java} (71%)
create mode 100644
openmeetings-web/src/main/java/org/apache/openmeetings/web/util/logging/TomcatGenericExports.java
[openmeetings] 01/01: Merge pull request #130 from apache/feature/OPENMEETINGS-2577-performance--metrics-disabled-state
This is an automated email from the ASF dual-hosted git repository. sebawagner pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/openmeetings.git commit cc281deb8b8796ab5993ef457669f858bcdc690d Merge: 55b5f08 02dd02e Author: Sebastian Wagner AuthorDate: Tue Feb 23 14:35:24 2021 +1300 Merge pull request #130 from apache/feature/OPENMEETINGS-2577-performance--metrics-disabled-state OPENMEETINGS-2577 performance metrics disabled state .../openmeetings/core/remote/StreamProcessor.java | 81 +- .../core/remote/StreamProcessorActions.java| 127 + .../openmeetings/core/remote/BaseMockedTest.java | 3 + openmeetings-util/pom.xml | 16 ++ .../util/logging/PrometheusAspect.java | 54 .../openmeetings/util/logging/PrometheusUtil.java | 35 +++ .../util/logging/TimedApplication.java | 31 ++ .../openmeetings/util/logging/TimedDatabase.java | 31 ++ openmeetings-web/pom.xml | 8 + .../util/logging/OpenMeetingsMetricsServlet.java | 32 +++ .../web/util/logging/TomcatGenericExports.java | 314 + .../webapp/WEB-INF/classes/applicationContext.xml | 5 + openmeetings-web/src/main/webapp/WEB-INF/web.xml | 40 +++ pom.xml| 44 +++ 14 files changed, 750 insertions(+), 71 deletions(-)
[jira] [Commented] (OPENMEETINGS-2577) Add performance and monitoring metrics - in disabled state
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17288709#comment-17288709 ] ASF subversion and git services commented on OPENMEETINGS-2577: --- Commit 02dd02e5f80e77a598858065ffc5114c1b204b36 in openmeetings's branch refs/heads/feature/OPENMEETINGS-2577-performance--metrics-disabled-state from Sebastian Wagner [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=02dd02e ] OPENMEETINGS-2577 Fix externalise constant name and no wildcard imports. > Add performance and monitoring metrics - in disabled state > -- > > Key: OPENMEETINGS-2577 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2577 > Project: Openmeetings > Issue Type: New Feature >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > Fix For: 6.0.0 > > > As discussed: > [https://markmail.org/thread/new2mdd6jbyp2o6i] > Add performance metrics as par PoC using Prometheus metrics. > Shall be disabled by default. > This also requires to update the confluence page with some description on how > to enable it: > [https://cwiki.apache.org/confluence/display/OPENMEETINGS/Prometheus+Logging+and+Metrics|https://cwiki.apache.org/confluence/display/OPENMEETINGS/Prometheus+Logging+and+Metrics] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2577) Add performance and monitoring metrics - in disabled state
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17288707#comment-17288707 ] ASF subversion and git services commented on OPENMEETINGS-2577: --- Commit 17db6e8c0cecebde8ccf82fe27f4231718b39ec3 in openmeetings's branch refs/heads/feature/OPENMEETINGS-2577-performance--metrics-disabled-state from Sebastian Wagner [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=17db6e8 ] OPENMEETINGS-2577 avoid wildcard imports. > Add performance and monitoring metrics - in disabled state > -- > > Key: OPENMEETINGS-2577 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2577 > Project: Openmeetings > Issue Type: New Feature >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > Fix For: 6.0.0 > > > As discussed: > [https://markmail.org/thread/new2mdd6jbyp2o6i] > Add performance metrics as par PoC using Prometheus metrics. > Shall be disabled by default. > This also requires to update the confluence page with some description on how > to enable it: > [https://cwiki.apache.org/confluence/display/OPENMEETINGS/Prometheus+Logging+and+Metrics|https://cwiki.apache.org/confluence/display/OPENMEETINGS/Prometheus+Logging+and+Metrics] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2577) Add performance and monitoring metrics - in disabled state
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17288706#comment-17288706 ] ASF subversion and git services commented on OPENMEETINGS-2577: --- Commit 0b5bc21915ed9517c82dec358934324c951d69be in openmeetings's branch refs/heads/feature/OPENMEETINGS-2577-performance--metrics-disabled-state from Sebastian Wagner [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=0b5bc21 ] OPENMEETINGS-2577 Generalise common log method. > Add performance and monitoring metrics - in disabled state > -- > > Key: OPENMEETINGS-2577 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2577 > Project: Openmeetings > Issue Type: New Feature >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > Fix For: 6.0.0 > > > As discussed: > [https://markmail.org/thread/new2mdd6jbyp2o6i] > Add performance metrics as par PoC using Prometheus metrics. > Shall be disabled by default. > This also requires to update the confluence page with some description on how > to enable it: > [https://cwiki.apache.org/confluence/display/OPENMEETINGS/Prometheus+Logging+and+Metrics|https://cwiki.apache.org/confluence/display/OPENMEETINGS/Prometheus+Logging+and+Metrics] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2577) Add performance and monitoring metrics - in disabled state
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17288708#comment-17288708 ] ASF subversion and git services commented on OPENMEETINGS-2577: --- Commit f8e9fac6213d57919dbaa0d6627ddb4fce358baf in openmeetings's branch refs/heads/feature/OPENMEETINGS-2577-performance--metrics-disabled-state from Sebastian Wagner [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=f8e9fac ] OPENMEETINGS-2577 Fix aspectjtools version into dependency-manager section. > Add performance and monitoring metrics - in disabled state > -- > > Key: OPENMEETINGS-2577 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2577 > Project: Openmeetings > Issue Type: New Feature >Reporter: Sebastian Wagner >Assignee: Sebastian Wagner >Priority: Major > Fix For: 6.0.0 > > > As discussed: > [https://markmail.org/thread/new2mdd6jbyp2o6i] > Add performance metrics as par PoC using Prometheus metrics. > Shall be disabled by default. > This also requires to update the confluence page with some description on how > to enable it: > [https://cwiki.apache.org/confluence/display/OPENMEETINGS/Prometheus+Logging+and+Metrics|https://cwiki.apache.org/confluence/display/OPENMEETINGS/Prometheus+Logging+and+Metrics] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[openmeetings] branch feature/OPENMEETINGS-2577-performance--metrics-disabled-state updated (8862d2f -> 02dd02e)
This is an automated email from the ASF dual-hosted git repository. sebawagner pushed a change to branch feature/OPENMEETINGS-2577-performance--metrics-disabled-state in repository https://gitbox.apache.org/repos/asf/openmeetings.git. from 8862d2f OPENMEETINGS-2577 Fix adding additional class to mock. add 0b5bc21 OPENMEETINGS-2577 Generalise common log method. add 17db6e8 OPENMEETINGS-2577 avoid wildcard imports. add f8e9fac OPENMEETINGS-2577 Fix aspectjtools version into dependency-manager section. add 02dd02e OPENMEETINGS-2577 Fix externalise constant name and no wildcard imports. No new revisions were added by this update. Summary of changes: openmeetings-util/pom.xml | 1 - .../util/logging/PrometheusAspect.java | 22 -- .../web/util/logging/TomcatGenericExports.java | 21 +++-- pom.xml| 6 ++ 4 files changed, 29 insertions(+), 21 deletions(-)
