[jira] [Commented] (OPENMEETINGS-2332) Room exit always redirects to public room list
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100032#comment-17100032 ] ASF subversion and git services commented on OPENMEETINGS-2332: --- Commit 4b7405cab44b35bae54186c1fb44ceea5e41e2a1 in openmeetings's branch refs/heads/master from Maxim Solodovnik [ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=4b7405c ] [OPENMEETINGS-2332] room scope is taken into account on exit > Room exit always redirects to public room list > -- > > Key: OPENMEETINGS-2332 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2332 > Project: Openmeetings > Issue Type: Bug > Components: Room >Affects Versions: 5.0.0-M4 >Reporter: Konstantin Kuzov >Assignee: Maxim Solodovnik >Priority: Minor > > When exiting the room user is always redirected to public room list. Even > when user was in private or personal room. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2332) Room exit always redirects to public room list
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100019#comment-17100019 ] Maxim Solodovnik commented on OPENMEETINGS-2332: Make sense Thanks for the code :) > Room exit always redirects to public room list > -- > > Key: OPENMEETINGS-2332 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2332 > Project: Openmeetings > Issue Type: Bug > Components: Room >Affects Versions: 5.0.0-M4 >Reporter: Konstantin Kuzov >Assignee: Maxim Solodovnik >Priority: Minor > > When exiting the room user is always redirected to public room list. Even > when user was in private or personal room. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2332) Room exit always redirects to public room list
[
https://issues.apache.org/jira/browse/OPENMEETINGS-2332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099610#comment-17099610
]
Konstantin Kuzov commented on OPENMEETINGS-2332:
As I previously wrote default.landing.zone is not working for exit from the
room because the public room list is hardcoded for exit. And even if it worked
I can see a case when user want different pages in case of room exit and in
case of default landing page after sign-in. So I proposed introduction of new
setting so they can be set separately.
But I still cannot understand the reasoning against original proposal of
redirecting user to related room list on room exit. It's IMHO still be more
logical than the current behaviour.
Like this:
{code:java}
---
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/menu/RoomMenuPanel.java
+++
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/menu/RoomMenuPanel.java
@@ -22,8 +22,11 @@ import static
org.apache.openmeetings.util.OpenmeetingsVariables.ATTR_CLASS;
import static org.apache.openmeetings.util.OpenmeetingsVariables.ATTR_TITLE;
import static
org.apache.openmeetings.util.OpenmeetingsVariables.CONFIG_REDIRECT_URL_FOR_EXTERNAL;
import static org.apache.openmeetings.util.OpenmeetingsVariables.getBaseUrl;
+import static
org.apache.openmeetings.util.OpenmeetingsVariables.isMyRoomsEnabled;
import static org.apache.openmeetings.web.app.WebSession.getUserId;
import static
org.apache.openmeetings.web.util.GroupLogoResourceReference.getUrl;
+import static org.apache.openmeetings.web.util.OmUrlFragment.ROOMS_GROUP;
+import static org.apache.openmeetings.web.util.OmUrlFragment.ROOMS_MY;
import static org.apache.openmeetings.web.util.OmUrlFragment.ROOMS_PUBLIC;
import java.util.ArrayList;
@@ -247,8 +250,14 @@ public class RoomMenuPanel extends Panel {
public void exit(IPartialPageRequestHandler handler) {
cm.exitRoom(room.getClient());
+ final Room r = room.getRoom();
if (WebSession.getRights().contains(User.Right.DASHBOARD)) {
- room.getMainPanel().updateContents(ROOMS_PUBLIC,
handler);
+ if (isMyRoomsEnabled() && r != null && r.getOwnerId()
!= null && r.getOwnerId().equals(getUserId()))
+ room.getMainPanel().updateContents(ROOMS_MY,
handler);
+ else if (r != null && !r.getIspublic())
+ room.getMainPanel().updateContents(ROOMS_GROUP,
handler);
+ else
+
room.getMainPanel().updateContents(ROOMS_PUBLIC, handler);
} else {
String url =
cfgDao.getString(CONFIG_REDIRECT_URL_FOR_EXTERNAL, "");
throw new RedirectToUrlException(Strings.isEmpty(url) ?
getBaseUrl() : url);
---
a/openmeetings-web/src/main/java/org/apache/openmeetings/web/util/OmUrlFragment.java
+++
b/openmeetings-web/src/main/java/org/apache/openmeetings/web/util/OmUrlFragment.java
@@ -80,7 +80,9 @@ public class OmUrlFragment implements Serializable {
public static final OmUrlFragment PROFILE_EDIT = new
OmUrlFragment(AreaKeys.profile, TYPE_EDIT);
public static final OmUrlFragment PROFILE_MESSAGES = new
OmUrlFragment(AreaKeys.profile, TYPE_MESSAGES);
public static final OmUrlFragment CALENDAR = new
OmUrlFragment(AreaKeys.user, TYPE_CALENDAR);
+ public static final OmUrlFragment ROOMS_GROUP = new
OmUrlFragment(AreaKeys.rooms, TYPE_GROUP);
public static final OmUrlFragment ROOMS_PUBLIC = new
OmUrlFragment(AreaKeys.rooms, TYPE_PUBLIC);
+ public static final OmUrlFragment ROOMS_MY = new
OmUrlFragment(AreaKeys.rooms, TYPE_MY);
public enum AreaKeys {
user
{code}
It can be enchanced with some new override setting if we want to provide user
with ability to override page to which user will be redirected on exit. But for
my case it is sufficient.
> Room exit always redirects to public room list
> --
>
> Key: OPENMEETINGS-2332
> URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2332
> Project: Openmeetings
> Issue Type: Bug
> Components: Room
>Affects Versions: 5.0.0-M4
>Reporter: Konstantin Kuzov
>Assignee: Maxim Solodovnik
>Priority: Minor
>
> When exiting the room user is always redirected to public room list. Even
> when user was in private or personal room.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2332) Room exit always redirects to public room list
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098968#comment-17098968 ] Maxim Solodovnik commented on OPENMEETINGS-2332: [~NoSFeRaTU] we are not tracking where the user was, so we have no idea where he/she should be redirecting on room exit `default.landing.zone` might provide some flexibility here i.e. we have no idea where user would like to exit but you as OM admin might hard-code it user can enter the hash manually instead of pushing "Exit" . I don't see why additional setting is required here :9 Can you elaborate? > Room exit always redirects to public room list > -- > > Key: OPENMEETINGS-2332 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2332 > Project: Openmeetings > Issue Type: Bug > Components: Room >Affects Versions: 5.0.0-M4 >Reporter: Konstantin Kuzov >Assignee: Maxim Solodovnik >Priority: Minor > > When exiting the room user is always redirected to public room list. Even > when user was in private or personal room. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2332) Room exit always redirects to public room list
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098540#comment-17098540 ] Konstantin Kuzov commented on OPENMEETINGS-2332: Yes, you can enter the room from multiple locations but that doesn't answer the question why user need to be always redirected to public room list on room exit. IMHO Intuitive way will be to redirect user back to the page from which he entered the room or to related room list. Regarding landing.zone setting isn't it only works for requests without specified fragment and so it does typically trigger only on user sign-in or if user manually delete fragment part from url? And will room exit button still redirect user to the public list no matter landing.zone? If so it's useless for our case. Acceptable solution to our case would be to have some other global setting which override exit room redirect from default rooms/public to anything else. But in general it still be a little weird. > Room exit always redirects to public room list > -- > > Key: OPENMEETINGS-2332 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2332 > Project: Openmeetings > Issue Type: Bug > Components: Room >Affects Versions: 5.0.0-M4 >Reporter: Konstantin Kuzov >Assignee: Maxim Solodovnik >Priority: Minor > > When exiting the room user is always redirected to public room list. Even > when user was in private or personal room. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OPENMEETINGS-2332) Room exit always redirects to public room list
[ https://issues.apache.org/jira/browse/OPENMEETINGS-2332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17097527#comment-17097527 ] Konstantin Kuzov commented on OPENMEETINGS-2332: In our case we are rarely using any public rooms at all. And it's just a bit inconvenient to jump through hoops of changing to different room list every time you need to move to another private room and that room is not already in dropdown menu. Is there any reasoning behind this design decision and against moving user to room list associated with the room from which user exit? > Room exit always redirects to public room list > -- > > Key: OPENMEETINGS-2332 > URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2332 > Project: Openmeetings > Issue Type: Bug > Components: Room >Affects Versions: 5.0.0-M4 >Reporter: Konstantin Kuzov >Assignee: Maxim Solodovnik >Priority: Minor > > When exiting the room user is always redirected to public room list. Even > when user was in private or personal room. -- This message was sent by Atlassian Jira (v8.3.4#803005)
