svn commit: r1883053 - in /pdfbox/trunk/pdfbox/src: main/java/org/apache/pdfbox/pdmodel/fixup/processor/AcroFormOrphanWidgetsProcessor.java test/java/org/apache/pdfbox/pdmodel/interactive/form/PDAcroFormFromAnnotsTest.java

[msahyoun]

Author: msahyoun
Date: Sun Nov  1 16:26:31 2020
New Revision: 1883053

URL: http://svn.apache.org/viewvc?rev=1883053&view=rev
Log:
PDFBOX-3891: ensure resources are only added if annotation is a widget

Modified:
    
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fixup/processor/AcroFormOrphanWidgetsProcessor.java
    
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDAcroFormFromAnnotsTest.java

Modified: 
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fixup/processor/AcroFormOrphanWidgetsProcessor.java
URL: 
http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fixup/processor/AcroFormOrphanWidgetsProcessor.java?rev=1883053&r1=1883052&r2=1883053&view=diff
==============================================================================
--- 
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fixup/processor/AcroFormOrphanWidgetsProcessor.java
 (original)
+++ 
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fixup/processor/AcroFormOrphanWidgetsProcessor.java
 Sun Nov  1 16:26:31 2020
@@ -111,10 +111,10 @@ public class AcroFormOrphanWidgetsProces
 
         for (PDAnnotation annot : annotations)
         {
-            addFontFromWidget(acroFormResources, annot);
-
             if (annot instanceof PDAnnotationWidget)
             {
+                addFontFromWidget(acroFormResources, annot);
+
                 if (annot.getCOSObject().containsKey(COSName.PARENT))
                 {
                     PDField resolvedField = resolveNonRootField(acroForm, 
(PDAnnotationWidget) annot, nonTerminalFieldsMap);

Modified: 
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDAcroFormFromAnnotsTest.java
URL: 
http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDAcroFormFromAnnotsTest.java?rev=1883053&r1=1883052&r2=1883053&view=diff
==============================================================================
--- 
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDAcroFormFromAnnotsTest.java
 (original)
+++ 
pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDAcroFormFromAnnotsTest.java
 Sun Nov  1 16:26:31 2020
@@ -283,8 +283,6 @@ public class PDAcroFormFromAnnotsTest
         }
     }
 
-
-
     /*
      * Create fields from widget annotations
      */