PHOENIX-4358 Case Sensitive String match on SqlType in PDataType (Dave Angulo)
Project: http://git-wip-us.apache.org/repos/asf/phoenix/repo Commit: http://git-wip-us.apache.org/repos/asf/phoenix/commit/9556b8e1 Tree: http://git-wip-us.apache.org/repos/asf/phoenix/tree/9556b8e1 Diff: http://git-wip-us.apache.org/repos/asf/phoenix/diff/9556b8e1 Branch: refs/heads/omid2 Commit: 9556b8e10361286b3a7ef9402620be29d2422355 Parents: 7580b7e Author: Thomas D'Silva <tdsi...@apache.org> Authored: Fri Oct 12 13:46:15 2018 -0700 Committer: Thomas D'Silva <tdsi...@apache.org> Committed: Fri Oct 12 13:47:42 2018 -0700 ---------------------------------------------------------------------- .../main/java/org/apache/phoenix/schema/types/PDataType.java | 2 +- .../java/org/apache/phoenix/schema/types/PDataTypeTest.java | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/phoenix/blob/9556b8e1/phoenix-core/src/main/java/org/apache/phoenix/schema/types/PDataType.java ---------------------------------------------------------------------- diff --git a/phoenix-core/src/main/java/org/apache/phoenix/schema/types/PDataType.java b/phoenix-core/src/main/java/org/apache/phoenix/schema/types/PDataType.java index 1e29d6f..eba6079 100644 --- a/phoenix-core/src/main/java/org/apache/phoenix/schema/types/PDataType.java +++ b/phoenix-core/src/main/java/org/apache/phoenix/schema/types/PDataType.java @@ -1041,7 +1041,7 @@ public abstract class PDataType<T> implements DataType<T>, Comparable<PDataType< public static PDataType fromSqlTypeName(String sqlTypeName) { for (PDataType t : PDataTypeFactory.getInstance().getTypes()) { - if (t.getSqlTypeName().equals(sqlTypeName)) return t; + if (t.getSqlTypeName().equalsIgnoreCase(sqlTypeName)) return t; } throw newIllegalDataException("Unsupported sql type: " + sqlTypeName); } http://git-wip-us.apache.org/repos/asf/phoenix/blob/9556b8e1/phoenix-core/src/test/java/org/apache/phoenix/schema/types/PDataTypeTest.java ---------------------------------------------------------------------- diff --git a/phoenix-core/src/test/java/org/apache/phoenix/schema/types/PDataTypeTest.java b/phoenix-core/src/test/java/org/apache/phoenix/schema/types/PDataTypeTest.java index 4b02cea..e868f4e 100644 --- a/phoenix-core/src/test/java/org/apache/phoenix/schema/types/PDataTypeTest.java +++ b/phoenix-core/src/test/java/org/apache/phoenix/schema/types/PDataTypeTest.java @@ -1949,4 +1949,10 @@ public class PDataTypeTest { } } } + + @Test + public void testFromSqlTypeName() { + assertEquals(PVarchar.INSTANCE, PDataType.fromSqlTypeName("varchar")); + } + }
