[GitHub] [incubator-pinot] nadcharin opened a new pull request #4548: [TE] correct time format before send query to Vertica

nadcharin opened a new pull request #4548: [TE] correct time format before send query to Vertica URL: https://github.com/apache/incubator-pinot/pull/4548 found incorrect result return from Vertica because time format in query that send to Vertica is incorrect

[incubator-pinot] branch master updated (d62f467 -> c0dbbfc)

This is an automated email from the ASF dual-hosted git repository. mcvsubbu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from d62f467 [TE] Make HTTPS redirection configurable (#4539) add c0dbbfc Set the consumption end time

[GitHub] [incubator-pinot] mcvsubbu merged pull request #4546: [Issue #4511] Set the consumption end time of a segment based on its creation time

mcvsubbu merged pull request #4546: [Issue #4511] Set the consumption end time of a segment based on its creation time URL: https://github.com/apache/incubator-pinot/pull/4546 This is an automated message from the Apache

[GitHub] [incubator-pinot] npawar commented on a change in pull request #4547: Indexed table

npawar commented on a change in pull request #4547: Indexed table URL: https://github.com/apache/incubator-pinot/pull/4547#discussion_r315978483 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/IndexedTableImpl.java ## @@ -0,0 +1,169 @@ +/** + * Licensed

[GitHub] [incubator-pinot] npawar commented on a change in pull request #4547: Indexed table

npawar commented on a change in pull request #4547: Indexed table URL: https://github.com/apache/incubator-pinot/pull/4547#discussion_r315969950 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/IndexedTableImpl.java ## @@ -0,0 +1,169 @@ +/** + * Licensed

[GitHub] [incubator-pinot] npawar commented on a change in pull request #4547: Indexed table

npawar commented on a change in pull request #4547: Indexed table URL: https://github.com/apache/incubator-pinot/pull/4547#discussion_r315969744 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/IndexedTableImpl.java ## @@ -0,0 +1,169 @@ +/** + * Licensed

[GitHub] [incubator-pinot] npawar commented on a change in pull request #4547: Indexed table

npawar commented on a change in pull request #4547: Indexed table URL: https://github.com/apache/incubator-pinot/pull/4547#discussion_r315969504 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/IndexedTable.java ## @@ -0,0 +1,85 @@ +/** + * Licensed to

[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #4540: Fixing the issue of selection order by won't give correct ordering

Jackie-Jiang commented on issue #4540: Fixing the issue of selection order by won't give correct ordering URL: https://github.com/apache/incubator-pinot/pull/4540#issuecomment-523255715 In that case, can you please make the selection test query comparison check the order? With that we can

[GitHub] [incubator-pinot] codecov-io commented on issue #4529: Upgrade Helix to version 0.9.0.1

codecov-io commented on issue #4529: Upgrade Helix to version 0.9.0.1 URL: https://github.com/apache/incubator-pinot/pull/4529#issuecomment-523254639 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4529?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] fx19880617 commented on issue #4540: Fixing the issue of selection order by won't give correct ordering

fx19880617 commented on issue #4540: Fixing the issue of selection order by won't give correct ordering URL: https://github.com/apache/incubator-pinot/pull/4540#issuecomment-523248892 The selection test query comparison logic only check the record existence, so it won't recognize the

[GitHub] [incubator-pinot] siddharthteotia commented on issue #4547: Indexed table

siddharthteotia commented on issue #4547: Indexed table URL: https://github.com/apache/incubator-pinot/pull/4547#issuecomment-523246556 I think we should implement this in a generic manner -- something like a container of columns to pass a columnar data batch between operators. The batch

[GitHub] [incubator-pinot] siddharthteotia edited a comment on issue #4547: Indexed table

siddharthteotia edited a comment on issue #4547: Indexed table URL: https://github.com/apache/incubator-pinot/pull/4547#issuecomment-523246556 I think we should implement this in a generic manner -- something like a container of columns to pass a columnar data batch between operators. The

[GitHub] [incubator-pinot] fx19880617 commented on issue #4540: Fixing the issue of selection order by won't give correct ordering

fx19880617 commented on issue #4540: Fixing the issue of selection order by won't give correct ordering URL: https://github.com/apache/incubator-pinot/pull/4540#issuecomment-523244884 Current behavior keeps the column ordering from selection list and not put ordered columns in front.

[incubator-pinot] branch try_helix_hotfix updated (a1c0502 -> 0515660)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch try_helix_hotfix in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard a1c0502 Upgrade Helix to version 0.9.0.1 add 6e209e4 Handle NPE from getting live instance

[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #4540: Fixing the issue of selection order by won't give correct ordering

Jackie-Jiang commented on issue #4540: Fixing the issue of selection order by won't give correct ordering URL: https://github.com/apache/incubator-pinot/pull/4540#issuecomment-523240598 If server side guarantees that the sorted columns are always put in front of other columns, then broker

[GitHub] [incubator-pinot] codecov-io commented on issue #4546: [Issue #4511] Set the consumption end time of a segment based on its creation time

codecov-io commented on issue #4546: [Issue #4511] Set the consumption end time of a segment based on its creation time URL: https://github.com/apache/incubator-pinot/pull/4546#issuecomment-523239996 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4546?src=pr=h1) Report

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4547: Indexed table

kishoreg commented on a change in pull request #4547: Indexed table URL: https://github.com/apache/incubator-pinot/pull/4547#discussion_r315949156 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/IndexedTableImpl.java ## @@ -0,0 +1,169 @@ +/** + *

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4547: Indexed table

kishoreg commented on a change in pull request #4547: Indexed table URL: https://github.com/apache/incubator-pinot/pull/4547#discussion_r315945793 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/IndexedTableImpl.java ## @@ -0,0 +1,169 @@ +/** + *

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4547: Indexed table

kishoreg commented on a change in pull request #4547: Indexed table URL: https://github.com/apache/incubator-pinot/pull/4547#discussion_r315946396 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/IndexedTableImpl.java ## @@ -0,0 +1,169 @@ +/** + *

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4547: Indexed table

kishoreg commented on a change in pull request #4547: Indexed table URL: https://github.com/apache/incubator-pinot/pull/4547#discussion_r315944957 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/IndexedTable.java ## @@ -0,0 +1,85 @@ +/** + * Licensed to

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4547: Indexed table

kishoreg commented on a change in pull request #4547: Indexed table URL: https://github.com/apache/incubator-pinot/pull/4547#discussion_r315946148 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/IndexedTableImpl.java ## @@ -0,0 +1,169 @@ +/** + *

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4547: Indexed table

kishoreg commented on a change in pull request #4547: Indexed table URL: https://github.com/apache/incubator-pinot/pull/4547#discussion_r315942448 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/IndexedTable.java ## @@ -0,0 +1,85 @@ +/** + * Licensed to

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4547: Indexed table

kishoreg commented on a change in pull request #4547: Indexed table URL: https://github.com/apache/incubator-pinot/pull/4547#discussion_r315944667 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/IndexedTable.java ## @@ -0,0 +1,85 @@ +/** + * Licensed to

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4547: Indexed table

kishoreg commented on a change in pull request #4547: Indexed table URL: https://github.com/apache/incubator-pinot/pull/4547#discussion_r315945008 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/IndexedTable.java ## @@ -0,0 +1,85 @@ +/** + * Licensed to

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4547: Indexed table

kishoreg commented on a change in pull request #4547: Indexed table URL: https://github.com/apache/incubator-pinot/pull/4547#discussion_r315949299 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/IndexedTableImpl.java ## @@ -0,0 +1,169 @@ +/** + *

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4547: Indexed table

kishoreg commented on a change in pull request #4547: Indexed table URL: https://github.com/apache/incubator-pinot/pull/4547#discussion_r315949450 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/IndexedTableImpl.java ## @@ -0,0 +1,169 @@ +/** + *

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4547: Indexed table

kishoreg commented on a change in pull request #4547: Indexed table URL: https://github.com/apache/incubator-pinot/pull/4547#discussion_r315945567 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/IndexedTableImpl.java ## @@ -0,0 +1,169 @@ +/** + *

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4547: Indexed table

kishoreg commented on a change in pull request #4547: Indexed table URL: https://github.com/apache/incubator-pinot/pull/4547#discussion_r315945268 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/IndexedTable.java ## @@ -0,0 +1,85 @@ +/** + * Licensed to

[GitHub] [incubator-pinot] codecov-io commented on issue #4545: Add APIs to get leader for all tables or a given table

codecov-io commented on issue #4545: Add APIs to get leader for all tables or a given table URL: https://github.com/apache/incubator-pinot/pull/4545#issuecomment-523237858 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4545?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] mcvsubbu commented on issue #4546: Set the consumption end time of a segment based on its creation time

mcvsubbu commented on issue #4546: Set the consumption end time of a segment based on its creation time URL: https://github.com/apache/incubator-pinot/pull/4546#issuecomment-523230556 This PR addresses issue #4511 This is

[GitHub] [incubator-pinot] npawar opened a new pull request #4547: Indexed table

npawar opened a new pull request #4547: Indexed table URL: https://github.com/apache/incubator-pinot/pull/4547 Indexed table will be used as the data structure throughout the query engine to pass data records between the various operators. IndexedTableImpl is for records containing keys

[GitHub] [incubator-pinot] mcvsubbu opened a new pull request #4546: Set the consumption end time of a segment based on its creation time

mcvsubbu opened a new pull request #4546: Set the consumption end time of a segment based on its creation time URL: https://github.com/apache/incubator-pinot/pull/4546 We used to set the end time of a consuming segment as the consumption start time plus the configured time threshold. In

[GitHub] [incubator-pinot] fx19880617 commented on issue #4540: Fixing the issue of selection order by won't give correct ordering

fx19880617 commented on issue #4540: Fixing the issue of selection order by won't give correct ordering URL: https://github.com/apache/incubator-pinot/pull/4540#issuecomment-523186393 Server side will return a data table with schema. broker side reduce logic should be agnostic to the

[incubator-pinot] branch bugfixing_orderby updated (f04014b -> ceee22f)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch bugfixing_orderby in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard f04014b Update selection columns logic add ceee22f Update selection columns logic This

[GitHub] [incubator-pinot] jackjlli opened a new pull request #4545: Add APIs to get leader for all tables or a given table

jackjlli opened a new pull request #4545: Add APIs to get leader for all tables or a given table URL: https://github.com/apache/incubator-pinot/pull/4545 This PR adds APIs to get leader for all tables or a given table. Get leaders for all tables: API GET /leader/tables ```

[incubator-pinot] branch bugfixing_orderby updated (71b10d6 -> f04014b)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch bugfixing_orderby in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 71b10d6 Fixing the issue of selection order by won't give correct ordering add f04014b

[GitHub] [incubator-pinot] xiaohui-sun opened a new pull request #4544: [TE] Skip creating notification task when there is no anomaly to notify

xiaohui-sun opened a new pull request #4544: [TE] Skip creating notification task when there is no anomaly to notify URL: https://github.com/apache/incubator-pinot/pull/4544 This is an automated message from the Apache Git

[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #4540: Fixing the issue of selection order by won't give correct ordering

Jackie-Jiang commented on issue #4540: Fixing the issue of selection order by won't give correct ordering URL: https://github.com/apache/incubator-pinot/pull/4540#issuecomment-523130762 @fx19880617 Check SelectionOperatorUtil.extractDataSchema, sort columns are put in front of the other

[GitHub] [incubator-pinot] jihaozh merged pull request #4539: [TE] Make HTTPS redirection configurable

jihaozh merged pull request #4539: [TE] Make HTTPS redirection configurable URL: https://github.com/apache/incubator-pinot/pull/4539 This is an automated message from the Apache Git Service. To respond to the message, please

[incubator-pinot] branch master updated: [TE] Make HTTPS redirection configurable (#4539)

This is an automated email from the ASF dual-hosted git repository. jihao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new d62f467 [TE] Make HTTPS redirection

[incubator-pinot] branch master updated: Expose table-name via StreamConfig (#4543)

This is an automated email from the ASF dual-hosted git repository. sunithabeeram pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new d261a76 Expose table-name via

[GitHub] [incubator-pinot] sunithabeeram merged pull request #4543: Expose table-name via StreamConfig

sunithabeeram merged pull request #4543: Expose table-name via StreamConfig URL: https://github.com/apache/incubator-pinot/pull/4543 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-pinot] sunithabeeram opened a new pull request #4543: Expose table-name via StreamConfig

sunithabeeram opened a new pull request #4543: Expose table-name via StreamConfig URL: https://github.com/apache/incubator-pinot/pull/4543 TableName is required to emit metrics in higher layers and currently the stream-config only has the topic-name. Since topic-name and table-name don't

[GitHub] [incubator-pinot] keenangebze commented on issue #4542: Multiple aggregate columns not showing on Pinot Data Explorer.

keenangebze commented on issue #4542: Multiple aggregate columns not showing on Pinot Data Explorer. URL: https://github.com/apache/incubator-pinot/issues/4542#issuecomment-523042855 I see. Thanks for the quick reply. This

[GitHub] [incubator-pinot] kishoreg commented on issue #4542: Multiple aggregate columns not showing on Pinot Data Explorer.

kishoreg commented on issue #4542: Multiple aggregate columns not showing on Pinot Data Explorer. URL: https://github.com/apache/incubator-pinot/issues/4542#issuecomment-523038763 Yes. The table in the query console is buggy and needs some work. Feel free to contribute.

[GitHub] [incubator-pinot] keenangebze opened a new issue #4542: Multiple aggregate columns not showing on Pinot Data Explorer.

keenangebze opened a new issue #4542: Multiple aggregate columns not showing on Pinot Data Explorer. URL: https://github.com/apache/incubator-pinot/issues/4542 I just built quickstart from latest commit from origin/HEAD: 83cc88d76298edafbd0ca72a7d2fbde8e13dabf0 Do some queries on

[GitHub] [incubator-pinot] fx19880617 commented on issue #4540: Fixing the issue of selection order by won't give correct ordering

fx19880617 commented on issue #4540: Fixing the issue of selection order by won't give correct ordering URL: https://github.com/apache/incubator-pinot/pull/4540#issuecomment-522923082 I don't think we move column sequence now. Server data table is built based on selection column list