[GitHub] [incubator-pinot] chenboat edited a comment on issue #4484: Pinot query timeout due to the broker waiting for a single non-responsive server

chenboat edited a comment on issue #4484: Pinot query timeout due to the broker waiting for a single non-responsive server URL: https://github.com/apache/incubator-pinot/issues/4484#issuecomment-528715376 > As currently designed, the broker (after pruning segments) comes up with a set of

[GitHub] [incubator-pinot] chenboat commented on issue #4484: Pinot query timeout due to the broker waiting for a single non-responsive server

chenboat commented on issue #4484: Pinot query timeout due to the broker waiting for a single non-responsive server URL: https://github.com/apache/incubator-pinot/issues/4484#issuecomment-528715376 > As currently designed, the broker (after pruning segments) comes up with a set of

[GitHub] [incubator-pinot] snleee commented on a change in pull request #4581: Adding example for kubernetes deployment on GKE

snleee commented on a change in pull request #4581: Adding example for kubernetes deployment on GKE URL: https://github.com/apache/incubator-pinot/pull/4581#discussion_r321573972 ## File path: kubernetes/examples/gke/skaffold/setup.sh ## @@ -0,0 +1,52 @@ +#!/usr/bin/env

[GitHub] [incubator-pinot] snleee commented on a change in pull request #4581: Adding example for kubernetes deployment on GKE

snleee commented on a change in pull request #4581: Adding example for kubernetes deployment on GKE URL: https://github.com/apache/incubator-pinot/pull/4581#discussion_r321573798 ## File path: kubernetes/examples/gke/skaffold/cleanup.sh ## @@ -0,0 +1,39 @@ +#!/usr/bin/env

[GitHub] [incubator-pinot] snleee commented on a change in pull request #4581: Adding example for kubernetes deployment on GKE

snleee commented on a change in pull request #4581: Adding example for kubernetes deployment on GKE URL: https://github.com/apache/incubator-pinot/pull/4581#discussion_r321573767 ## File path: kubernetes/examples/gke/skaffold/cleanup.sh ## @@ -0,0 +1,39 @@ +#!/usr/bin/env

[GitHub] [incubator-pinot] snleee commented on a change in pull request #4585: Presence vector

snleee commented on a change in pull request #4585: Presence vector URL: https://github.com/apache/incubator-pinot/pull/4585#discussion_r321570383 ## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/creator/impl/presence/PresenceVectorCreator.java ## @@

[GitHub] [incubator-pinot] snleee commented on a change in pull request #4585: Presence vector

snleee commented on a change in pull request #4585: Presence vector URL: https://github.com/apache/incubator-pinot/pull/4585#discussion_r321571678 ## File path: pinot-core/src/test/resources/data/test_presence_vector_data.json ## @@ -0,0 +1,12 @@ +{ Review comment:

[GitHub] [incubator-pinot] snleee commented on a change in pull request #4585: Presence vector

snleee commented on a change in pull request #4585: Presence vector URL: https://github.com/apache/incubator-pinot/pull/4585#discussion_r321570277 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/recordtransformer/NullValueTransformer.java ## @@ -33,17

[GitHub] [incubator-pinot] snleee commented on a change in pull request #4585: Presence vector

snleee commented on a change in pull request #4585: Presence vector URL: https://github.com/apache/incubator-pinot/pull/4585#discussion_r321568658 ## File path: pinot-core/src/test/resources/data/test_presence_vector_pinot_schema.json ## @@ -0,0 +1,26 @@ +{ +

[GitHub] [incubator-pinot] snleee commented on a change in pull request #4585: Presence vector

snleee commented on a change in pull request #4585: Presence vector URL: https://github.com/apache/incubator-pinot/pull/4585#discussion_r321568965 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/CommonConstants.java ## @@ -373,6 +373,8 @@ public

[GitHub] [incubator-pinot] snleee commented on a change in pull request #4585: Presence vector

snleee commented on a change in pull request #4585: Presence vector URL: https://github.com/apache/incubator-pinot/pull/4585#discussion_r321568760 ## File path: pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/ClusterIntegrationTestUtils.java ## @@

[GitHub] [incubator-pinot] snleee commented on a change in pull request #4585: Presence vector

snleee commented on a change in pull request #4585: Presence vector URL: https://github.com/apache/incubator-pinot/pull/4585#discussion_r321572493 ## File path: pinot-core/src/main/java/org/apache/pinot/core/indexsegment/mutable/MutableSegmentImpl.java ## @@ -479,6

[GitHub] [incubator-pinot] snleee commented on a change in pull request #4585: Presence vector

snleee commented on a change in pull request #4585: Presence vector URL: https://github.com/apache/incubator-pinot/pull/4585#discussion_r321568590 ## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/index/readers/PresenceVectorReaderImpl.java ## @@ -0,0

[GitHub] [incubator-pinot] snleee commented on a change in pull request #4585: Presence vector

snleee commented on a change in pull request #4585: Presence vector URL: https://github.com/apache/incubator-pinot/pull/4585#discussion_r321570358 ## File path: pinot-core/src/main/java/org/apache/pinot/core/realtime/impl/presence/RealtimePresenceVectorReaderWriter.java ##

[GitHub] [incubator-pinot] snleee commented on a change in pull request #4585: Presence vector

snleee commented on a change in pull request #4585: Presence vector URL: https://github.com/apache/incubator-pinot/pull/4585#discussion_r321568650 ## File path: pinot-core/src/test/resources/data/test_presence_vector_data.json ## @@ -0,0 +1,12 @@ +{ + "description" :

[GitHub] [incubator-pinot] codecov-io commented on issue #4588: Fix comparison to pick the right minimum value for hash-set

codecov-io commented on issue #4588: Fix comparison to pick the right minimum value for hash-set URL: https://github.com/apache/incubator-pinot/pull/4588#issuecomment-528674111 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4588?src=pr=h1) Report > Merging

[incubator-pinot] branch master updated (05609e4 -> 76e0c62)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 05609e4 Use Apache Pinot License (#4584) add 76e0c62 Adding Predicate supports for Bytes Column

[incubator-pinot] branch fixing_raw_bytes_comparison deleted (was 88ff602)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch fixing_raw_bytes_comparison in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. was 88ff602 address comments The revisions that were on this branch are still contained

[GitHub] [incubator-pinot] fx19880617 merged pull request #4586: Adding Predicate supports for Bytes Column without dictionary

fx19880617 merged pull request #4586: Adding Predicate supports for Bytes Column without dictionary URL: https://github.com/apache/incubator-pinot/pull/4586 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-pinot] sunithabeeram opened a new pull request #4588: Fix comparison to pick the right minimum value for hash-set

sunithabeeram opened a new pull request #4588: Fix comparison to pick the right minimum value for hash-set URL: https://github.com/apache/incubator-pinot/pull/4588 https://github.com/apache/incubator-pinot/pull/3009 had a typo/error - the intention was to fix the min size. Thanks

[GitHub] [incubator-pinot] codecov-io commented on issue #4586: Adding Predicate supports for Bytes Column without dictionary

codecov-io commented on issue #4586: Adding Predicate supports for Bytes Column without dictionary URL: https://github.com/apache/incubator-pinot/pull/4586#issuecomment-528647383 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4586?src=pr=h1) Report > Merging

[incubator-pinot] branch fixing_raw_bytes_comparison updated (235a51f -> 88ff602)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch fixing_raw_bytes_comparison in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 235a51f Adding bytes support for ValueMatcher add 88ff602 address comments No

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4586: Adding Predicate supports for Bytes Column without dictionary

Jackie-Jiang commented on a change in pull request #4586: Adding Predicate supports for Bytes Column without dictionary URL: https://github.com/apache/incubator-pinot/pull/4586#discussion_r321437961 ## File path:

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4586: Adding Predicate supports for Bytes Column without dictionary

Jackie-Jiang commented on a change in pull request #4586: Adding Predicate supports for Bytes Column without dictionary URL: https://github.com/apache/incubator-pinot/pull/4586#discussion_r321438611 ## File path:

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4586: Adding Predicate supports for Bytes Column without dictionary

Jackie-Jiang commented on a change in pull request #4586: Adding Predicate supports for Bytes Column without dictionary URL: https://github.com/apache/incubator-pinot/pull/4586#discussion_r321437584 ## File path:

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #3009: [PINOT-6736] Fix min size for hash-set in In/NotIn predicate impl

Jackie-Jiang commented on a change in pull request #3009: [PINOT-6736] Fix min size for hash-set in In/NotIn predicate impl URL: https://github.com/apache/incubator-pinot/pull/3009#discussion_r321436948 ## File path:

[GitHub] [incubator-pinot] kishoreg commented on issue #4586: Adding Predicate supports for Bytes Column without dictionary

kishoreg commented on issue #4586: Adding Predicate supports for Bytes Column without dictionary URL: https://github.com/apache/incubator-pinot/pull/4586#issuecomment-528527009 - There are cases where request id's can be generated as MD5 which can be represented as byte[]. Searching for a

[GitHub] [incubator-pinot] harleyjj opened a new pull request #4587: [TE] frontend - harleyjj/alert-details - handle reported anomaly for …

harleyjj opened a new pull request #4587: [TE] frontend - harleyjj/alert-details - handle reported anomaly for … URL: https://github.com/apache/incubator-pinot/pull/4587 …anomaly table This is an automated message from the

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #4583: Support default value for Byte column

mayankshriv commented on a change in pull request #4583: Support default value for Byte column URL: https://github.com/apache/incubator-pinot/pull/4583#discussion_r321412097 ## File path:

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4583: Support default value for Byte column

jackjlli commented on a change in pull request #4583: Support default value for Byte column URL: https://github.com/apache/incubator-pinot/pull/4583#discussion_r321384433 ## File path: pinot-core/src/test/resources/data/newColumnsSchema3.json ## @@ -16,6 +16,11 @@ {

[GitHub] [incubator-pinot] mcvsubbu commented on issue #4484: Pinot query timeout due to the broker waiting for a single non-responsive server

mcvsubbu commented on issue #4484: Pinot query timeout due to the broker waiting for a single non-responsive server URL: https://github.com/apache/incubator-pinot/issues/4484#issuecomment-528440340 As currently designed, the broker (after pruning segments) comes up with a set of segments

[GitHub] [incubator-pinot] lsabi closed issue #4574: Support simpler streams

lsabi closed issue #4574: Support simpler streams URL: https://github.com/apache/incubator-pinot/issues/4574 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [incubator-pinot] lsabi commented on issue #4574: Support simpler streams

lsabi commented on issue #4574: Support simpler streams URL: https://github.com/apache/incubator-pinot/issues/4574#issuecomment-528297364 1. That's not bad, I thought one per database 2. Too bad, I'm using kafka 2.3. I'll compile it myself when I have time Though, the

[GitHub] [incubator-pinot] sunny19930321 commented on issue #4484: Pinot query timeout due to the broker waiting for a single non-responsive server

sunny19930321 commented on issue #4484: Pinot query timeout due to the broker waiting for a single non-responsive server URL: https://github.com/apache/incubator-pinot/issues/4484#issuecomment-528262739 > Does Pinot broker need to wait the responses of all the servers before it can

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4581: Adding example for kubernetes deployment on GKE

codecov-io edited a comment on issue #4581: Adding example for kubernetes deployment on GKE URL: https://github.com/apache/incubator-pinot/pull/4581#issuecomment-528240127 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4581?src=pr=h1) Report > Merging

[incubator-pinot] branch k8s-quickstart updated (5ed4b4f -> 53c2383)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch k8s-quickstart in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 5ed4b4f Adding license add 53c2383 Adding license This update added new revisions after

[GitHub] [incubator-pinot] codecov-io commented on issue #4581: Adding example for kubernetes deployment on GKE

codecov-io commented on issue #4581: Adding example for kubernetes deployment on GKE URL: https://github.com/apache/incubator-pinot/pull/4581#issuecomment-528240127 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4581?src=pr=h1) Report > Merging

[incubator-pinot] branch k8s-quickstart updated (6919ce5 -> 5ed4b4f)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch k8s-quickstart in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 6919ce5 Adding license add 5ed4b4f Adding license This update added new revisions after