[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6073: Adding more table config validation

2020-10-01 Thread GitBox
Jackie-Jiang commented on a change in pull request #6073: URL: https://github.com/apache/incubator-pinot/pull/6073#discussion_r498475575 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java ## @@ -1195,12 +1182,26

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6073: Adding more table config validation

2020-10-01 Thread GitBox
Jackie-Jiang commented on a change in pull request #6073: URL: https://github.com/apache/incubator-pinot/pull/6073#discussion_r498459982 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java ## @@ -1374,6 +1378,14

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6073: Adding more table config validation

2020-09-29 Thread GitBox
Jackie-Jiang commented on a change in pull request #6073: URL: https://github.com/apache/incubator-pinot/pull/6073#discussion_r497231638 ## File path: pinot-core/src/main/java/org/apache/pinot/core/util/TableConfigUtils.java ## @@ -76,10 +79,41 @@ public static void