[GitHub] [incubator-pinot] Jackie-Jiang commented on pull request #5984: Add row based schema validation code to detect schema mismatch

2020-09-09 Thread GitBox
Jackie-Jiang commented on pull request #5984: URL: https://github.com/apache/incubator-pinot/pull/5984#issuecomment-689836238 > Most of the cases can be covered by validating pinot schema and avro schema. One tricky thing is that when all the fields are required to be fetched, we convert

[GitHub] [incubator-pinot] Jackie-Jiang commented on pull request #5984: Add row based schema validation code to detect schema mismatch

2020-09-08 Thread GitBox
Jackie-Jiang commented on pull request #5984: URL: https://github.com/apache/incubator-pinot/pull/5984#issuecomment-689256109 High level question, do we really need row level validation? What is the overhead of this validation? Seems like the validation only applies to the Avro reader.