[GitHub] [incubator-pinot] KKcorps commented on a change in pull request #6020: Add Caching in Controller Broker API

2020-10-02 Thread GitBox
KKcorps commented on a change in pull request #6020: URL: https://github.com/apache/incubator-pinot/pull/6020#discussion_r498706060 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/listener/ClusterInstanceConfigChangeListener.java ## @@ -0,0

[GitHub] [incubator-pinot] KKcorps commented on a change in pull request #6020: Add Caching in Controller Broker API

2020-10-02 Thread GitBox
KKcorps commented on a change in pull request #6020: URL: https://github.com/apache/incubator-pinot/pull/6020#discussion_r498650655 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/listener/ClusterInstanceConfigChangeListener.java ## @@ -0,0

[GitHub] [incubator-pinot] KKcorps commented on a change in pull request #6020: Add Caching in Controller Broker API

2020-10-02 Thread GitBox
KKcorps commented on a change in pull request #6020: URL: https://github.com/apache/incubator-pinot/pull/6020#discussion_r498641677 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/listener/ClusterInstanceConfigChangeListener.java ## @@ -0,0

[GitHub] [incubator-pinot] KKcorps commented on a change in pull request #6020: Add Caching in Controller Broker API

2020-10-02 Thread GitBox
KKcorps commented on a change in pull request #6020: URL: https://github.com/apache/incubator-pinot/pull/6020#discussion_r498641247 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java ## @@ -2174,13 +2192,42 @@

[GitHub] [incubator-pinot] KKcorps commented on a change in pull request #6020: Add Caching in Controller Broker API

2020-09-29 Thread GitBox
KKcorps commented on a change in pull request #6020: URL: https://github.com/apache/incubator-pinot/pull/6020#discussion_r496623617 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java ## @@ -223,6 +228,16 @@

[GitHub] [incubator-pinot] KKcorps commented on a change in pull request #6020: Add Caching in Controller Broker API

2020-09-29 Thread GitBox
KKcorps commented on a change in pull request #6020: URL: https://github.com/apache/incubator-pinot/pull/6020#discussion_r496623436 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/listener/ClusterInstanceConfigChangeListener.java ## @@ -0,0

[GitHub] [incubator-pinot] KKcorps commented on a change in pull request #6020: Add Caching in Controller Broker API

2020-09-28 Thread GitBox
KKcorps commented on a change in pull request #6020: URL: https://github.com/apache/incubator-pinot/pull/6020#discussion_r495919782 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java ## @@ -2458,6 +2486,7 @@

[GitHub] [incubator-pinot] KKcorps commented on a change in pull request #6020: Add Caching in Controller Broker API

2020-09-28 Thread GitBox
KKcorps commented on a change in pull request #6020: URL: https://github.com/apache/incubator-pinot/pull/6020#discussion_r495917780 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java ## @@ -223,6 +228,16 @@

[GitHub] [incubator-pinot] KKcorps commented on a change in pull request #6020: Add Caching in Controller Broker API

2020-09-21 Thread GitBox
KKcorps commented on a change in pull request #6020: URL: https://github.com/apache/incubator-pinot/pull/6020#discussion_r491796919 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/listener/ClusterLiveInstanceChangeListener.java ## @@ -0,0

[GitHub] [incubator-pinot] KKcorps commented on a change in pull request #6020: Add Caching in Controller Broker API

2020-09-20 Thread GitBox
KKcorps commented on a change in pull request #6020: URL: https://github.com/apache/incubator-pinot/pull/6020#discussion_r491797007 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/listener/ClusterInstanceConfigChangeListener.java ## @@ -0,0

[GitHub] [incubator-pinot] KKcorps commented on a change in pull request #6020: Add Caching in Controller Broker API

2020-09-20 Thread GitBox
KKcorps commented on a change in pull request #6020: URL: https://github.com/apache/incubator-pinot/pull/6020#discussion_r491796919 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/listener/ClusterLiveInstanceChangeListener.java ## @@ -0,0