codecov-io commented on issue #4622: Standardize the Dictionary interface, ensure the BYTES support URL: https://github.com/apache/incubator-pinot/pull/4622#issuecomment-533400408 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4622?src=pr&el=h1) Report > Merging [#4622](https://codecov.io/gh/apache/incubator-pinot/pull/4622?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/44d1ce911441d79782331c3d6ee3f07743706cb9?src=pr&el=desc) will **decrease** coverage by `0.21%`. > The diff coverage is `60.97%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/4622?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #4622 +/- ## ============================================ - Coverage 64.25% 64.03% -0.22% Complexity 32 32 ============================================ Files 1072 1071 -1 Lines 55701 55842 +141 Branches 8130 8216 +86 ============================================ - Hits 35789 35761 -28 - Misses 17271 17408 +137 - Partials 2641 2673 +32 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4622?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...re/segment/index/data/source/ColumnDataSource.java](https://codecov.io/gh/apache/incubator-pinot/pull/4622/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2luZGV4L2RhdGEvc291cmNlL0NvbHVtbkRhdGFTb3VyY2UuamF2YQ==) | `95.45% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...ment/creator/impl/SegmentColumnarIndexCreator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4622/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2NyZWF0b3IvaW1wbC9TZWdtZW50Q29sdW1uYXJJbmRleENyZWF0b3IuamF2YQ==) | `77.17% <ø> (-0.07%)` | `0 <0> (ø)` | | | [...e/pinot/core/segment/creator/impl/V1Constants.java](https://codecov.io/gh/apache/incubator-pinot/pull/4622/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2NyZWF0b3IvaW1wbC9WMUNvbnN0YW50cy5qYXZh) | `11.11% <ø> (-22.23%)` | `0 <0> (ø)` | | | [...t/core/segment/index/readers/OnHeapDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/4622/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2luZGV4L3JlYWRlcnMvT25IZWFwRGljdGlvbmFyeS5qYXZh) | `100% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...impl/stats/StringColumnPreIndexStatsCollector.java](https://codecov.io/gh/apache/incubator-pinot/pull/4622/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2NyZWF0b3IvaW1wbC9zdGF0cy9TdHJpbmdDb2x1bW5QcmVJbmRleFN0YXRzQ29sbGVjdG9yLmphdmE=) | `76.11% <ø> (-0.7%)` | `0 <0> (ø)` | | | [.../impl/stats/AbstractColumnStatisticsCollector.java](https://codecov.io/gh/apache/incubator-pinot/pull/4622/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2NyZWF0b3IvaW1wbC9zdGF0cy9BYnN0cmFjdENvbHVtblN0YXRpc3RpY3NDb2xsZWN0b3IuamF2YQ==) | `94.28% <ø> (+4.08%)` | `0 <0> (ø)` | :arrow_down: | | [...time/impl/dictionary/MutableDictionaryFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/4622/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvTXV0YWJsZURpY3Rpb25hcnlGYWN0b3J5LmphdmE=) | `65% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...ent/index/column/PhysicalColumnIndexContainer.java](https://codecov.io/gh/apache/incubator-pinot/pull/4622/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2luZGV4L2NvbHVtbi9QaHlzaWNhbENvbHVtbkluZGV4Q29udGFpbmVyLmphdmE=) | `92.06% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...pinot/core/query/pruner/AbstractSegmentPruner.java](https://codecov.io/gh/apache/incubator-pinot/pull/4622/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9wcnVuZXIvQWJzdHJhY3RTZWdtZW50UHJ1bmVyLmphdmE=) | `72.72% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...t/index/loader/bloomfilter/BloomFilterHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/4622/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2luZGV4L2xvYWRlci9ibG9vbWZpbHRlci9CbG9vbUZpbHRlckhhbmRsZXIuamF2YQ==) | `71.66% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: | | ... and [68 more](https://codecov.io/gh/apache/incubator-pinot/pull/4622/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4622?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4622?src=pr&el=footer). Last update [44d1ce9...acf6fe9](https://codecov.io/gh/apache/incubator-pinot/pull/4622?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
