[GitHub] [incubator-pinot] icefury71 commented on issue #5942: Better Table config validation

2020-09-29 Thread GitBox
icefury71 commented on issue #5942: URL: https://github.com/apache/incubator-pinot/issues/5942#issuecomment-701001585 > yes, that works as long as the same validations are performed. thanks Yes, its calling the same validation function underneath.

[GitHub] [incubator-pinot] icefury71 commented on issue #5942: Better Table config validation

2020-09-29 Thread GitBox
icefury71 commented on issue #5942: URL: https://github.com/apache/incubator-pinot/issues/5942#issuecomment-700900788 > +1 to a utility to validate, we can add a validate endpoint in the controller @kishoreg @mcvsubbu Seems like we already have a `/tables/validate` end-point in

[GitHub] [incubator-pinot] icefury71 commented on issue #5942: Better Table config validation

2020-09-29 Thread GitBox
icefury71 commented on issue #5942: URL: https://github.com/apache/incubator-pinot/issues/5942#issuecomment-700733890 What I meant is - technically it should be supported (it's not today and we should probably fix that). On Tue, Sep 29, 2020 at 12:31 AM Buchi Reddy Busi Reddy <

[GitHub] [incubator-pinot] icefury71 commented on issue #5942: Better Table config validation

2020-09-28 Thread GitBox
icefury71 commented on issue #5942: URL: https://github.com/apache/incubator-pinot/issues/5942#issuecomment-700296507 > Another use case: Validate that the bloomFilterColumns aren't BYTES type since that's not supported at this point. > > cc @kishoreg @icefury71 Looks like

[GitHub] [incubator-pinot] icefury71 commented on issue #5942: Better Table config validation

2020-09-21 Thread GitBox
icefury71 commented on issue #5942: URL: https://github.com/apache/incubator-pinot/issues/5942#issuecomment-696164071 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-pinot] icefury71 commented on issue #5942: Better Table config validation

2020-09-21 Thread GitBox
icefury71 commented on issue #5942: URL: https://github.com/apache/incubator-pinot/issues/5942#issuecomment-696260153 Updated ticket description with all the suggestions. This is an automated message from the Apache Git

[GitHub] [incubator-pinot] icefury71 commented on issue #5942: Better Table config validation

2020-09-21 Thread GitBox
icefury71 commented on issue #5942: URL: https://github.com/apache/incubator-pinot/issues/5942#issuecomment-696164071 One more check: Currently retention does not work if pushType is null (for real-time table). Check for a case where pushType is null and retention is configured for a