[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6044: Support for multi-threaded Group By reducer for SQL.

2020-10-13 Thread GitBox
mayankshriv commented on a change in pull request #6044: URL: https://github.com/apache/incubator-pinot/pull/6044#discussion_r504361583 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/reduce/GroupByDataTableReducer.java ## @@ -231,58 +255,134 @@ private

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6044: Support for multi-threaded Group By reducer for SQL.

2020-10-13 Thread GitBox
mayankshriv commented on a change in pull request #6044: URL: https://github.com/apache/incubator-pinot/pull/6044#discussion_r503640614 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/reduce/GroupByDataTableReducer.java ## @@ -231,58 +239,130 @@ private

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6044: Support for multi-threaded Group By reducer for SQL.

2020-10-13 Thread GitBox
mayankshriv commented on a change in pull request #6044: URL: https://github.com/apache/incubator-pinot/pull/6044#discussion_r504308428 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/reduce/GroupByDataTableReducer.java ## @@ -231,58 +239,130 @@ private

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6044: Support for multi-threaded Group By reducer for SQL.

2020-10-13 Thread GitBox
mayankshriv commented on a change in pull request #6044: URL: https://github.com/apache/incubator-pinot/pull/6044#discussion_r504308428 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/reduce/GroupByDataTableReducer.java ## @@ -231,58 +239,130 @@ private

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6044: Support for multi-threaded Group By reducer for SQL.

2020-10-12 Thread GitBox
mayankshriv commented on a change in pull request #6044: URL: https://github.com/apache/incubator-pinot/pull/6044#discussion_r503640614 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/reduce/GroupByDataTableReducer.java ## @@ -231,58 +239,130 @@ private

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6044: Support for multi-threaded Group By reducer for SQL.

2020-10-12 Thread GitBox
mayankshriv commented on a change in pull request #6044: URL: https://github.com/apache/incubator-pinot/pull/6044#discussion_r503640236 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/reduce/GroupByDataTableReducer.java ## @@ -231,58 +239,130 @@ private

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6044: Support for multi-threaded Group By reducer for SQL.

2020-10-12 Thread GitBox
mayankshriv commented on a change in pull request #6044: URL: https://github.com/apache/incubator-pinot/pull/6044#discussion_r503637782 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/reduce/BrokerReduceService.java ## @@ -47,8 +57,32 @@ @ThreadSafe

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6044: Support for multi-threaded Group By reducer for SQL.

2020-10-12 Thread GitBox
mayankshriv commented on a change in pull request #6044: URL: https://github.com/apache/incubator-pinot/pull/6044#discussion_r503637680 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/reduce/BrokerReduceService.java ## @@ -47,8 +57,32 @@ @ThreadSafe

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6044: Support for multi-threaded Group By reducer for SQL.

2020-10-12 Thread GitBox
mayankshriv commented on a change in pull request #6044: URL: https://github.com/apache/incubator-pinot/pull/6044#discussion_r503636090 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/CommonConstants.java ## @@ -166,6 +166,11 @@ public static final

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6044: Support for multi-threaded Group By reducer for SQL.

2020-10-12 Thread GitBox
mayankshriv commented on a change in pull request #6044: URL: https://github.com/apache/incubator-pinot/pull/6044#discussion_r503635525 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java ## @@ -102,7 +102,7 @@

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6044: Support for multi-threaded Group By reducer for SQL.

2020-09-22 Thread GitBox
mayankshriv commented on a change in pull request #6044: URL: https://github.com/apache/incubator-pinot/pull/6044#discussion_r492853736 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/CommonConstants.java ## @@ -161,6 +161,10 @@ public static final

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6044: Support for multi-threaded Group By reducer for SQL.

2020-09-22 Thread GitBox
mayankshriv commented on a change in pull request #6044: URL: https://github.com/apache/incubator-pinot/pull/6044#discussion_r492853736 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/CommonConstants.java ## @@ -161,6 +161,10 @@ public static final

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6044: Support for multi-threaded Group By reducer for SQL.

2020-09-22 Thread GitBox
mayankshriv commented on a change in pull request #6044: URL: https://github.com/apache/incubator-pinot/pull/6044#discussion_r492853736 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/CommonConstants.java ## @@ -161,6 +161,10 @@ public static final

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6044: Support for multi-threaded Group By reducer for SQL.

2020-09-22 Thread GitBox
mayankshriv commented on a change in pull request #6044: URL: https://github.com/apache/incubator-pinot/pull/6044#discussion_r492853736 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/CommonConstants.java ## @@ -161,6 +161,10 @@ public static final

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6044: Support for multi-threaded Group By reducer for SQL.

2020-09-22 Thread GitBox
mayankshriv commented on a change in pull request #6044: URL: https://github.com/apache/incubator-pinot/pull/6044#discussion_r492853736 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/CommonConstants.java ## @@ -161,6 +161,10 @@ public static final