[GitHub] [incubator-pinot] mayankshriv commented on pull request #6039: WIP: ServiceManager ADD_TABLE role

2020-10-05 Thread GitBox
mayankshriv commented on pull request #6039: URL: https://github.com/apache/incubator-pinot/pull/6039#issuecomment-703762755 I put some more thought on this, and still unable to convince myself about ServiceManager controlling when the service should announce health status (especially

[GitHub] [incubator-pinot] mayankshriv commented on pull request #6039: WIP: ServiceManager ADD_TABLE role

2020-09-28 Thread GitBox
mayankshriv commented on pull request #6039: URL: https://github.com/apache/incubator-pinot/pull/6039#issuecomment-700412009 > @mayankshriv in the case of ServiceManager, if I were to add tables as "bootstrap" I would expect those installed before things are healthy, intuitively. This is

[GitHub] [incubator-pinot] mayankshriv commented on pull request #6039: WIP: ServiceManager ADD_TABLE role

2020-09-28 Thread GitBox
mayankshriv commented on pull request #6039: URL: https://github.com/apache/incubator-pinot/pull/6039#issuecomment-700137273 If I get the context correctly, it seems we are trying to mix two things together? - Status of service being up and running - Status of a table being ready to