mcvsubbu commented on a change in pull request #6069:
URL: https://github.com/apache/incubator-pinot/pull/6069#discussion_r499900482
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/metadata/ZKMetadataProvider.java
##########
@@ -305,7 +308,7 @@ public static Schema getTableSchema(@Nonnull
ZkHelixPropertyStore<ZNRecord> prop
ZkHelixPropertyStore<ZNRecord> propertyStore, String tableName) {
String offlineTableName =
TableNameBuilder.OFFLINE.tableNameWithType(tableName);
String parentPath =
constructPropertyStorePathForResource(offlineTableName);
- List<ZNRecord> znRecords = propertyStore.getChildren(parentPath, null,
AccessOption.PERSISTENT);
+ List<ZNRecord> znRecords = propertyStore.getChildren(parentPath, null,
AccessOption.PERSISTENT, ZK_OP_RETRY_COUNT, ZK_OP_RETRY_INTERVAL_MS);
Review comment:
We are working with the helix team to give us a new version with the API
implemented. Since I took the trouble to trace all the APIs, I took the liberty
to modify them so that when we upgrade to newer helix version, we have the
right calls
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
