[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

mqliang commented on a change in pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r606099782 ## File path: pinot-core/src/main/java/org/apache/pinot/core/common/datatable/BaseDataTable.java ## @@ -0,0 +1,283 @@ +/** + * Licensed to the

[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

mqliang commented on a change in pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r606099731 ## File path: pinot-core/src/main/java/org/apache/pinot/core/common/datatable/BaseDataTable.java ## @@ -0,0 +1,283 @@ +/** + * Licensed to the

[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

mqliang commented on a change in pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r606099691 ## File path: pinot-core/src/main/java/org/apache/pinot/core/common/datatable/BaseDataTable.java ## @@ -0,0 +1,283 @@ +/** + * Licensed to the

[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

mqliang commented on a change in pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r606092021 ## File path: pinot-core/src/main/java/org/apache/pinot/core/common/datatable/BaseDataTable.java ## @@ -0,0 +1,283 @@ +/** + * Licensed to the

[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

mqliang commented on a change in pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r606070048 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/DataTable.java ## @@ -80,4 +85,85 @@ double[] getDoubleArray(int

[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

mqliang commented on a change in pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r605866370 ## File path: pinot-core/src/main/java/org/apache/pinot/core/common/datatable/DataTableImplV3.java ## @@ -0,0 +1,399 @@ +/** + * Licensed to the

[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

mqliang commented on a change in pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r605862022 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/DataTable.java ## @@ -80,4 +85,85 @@ double[] getDoubleArray(int

[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

mqliang commented on a change in pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r605222747 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/DataTable.java ## @@ -80,4 +85,87 @@ double[] getDoubleArray(int

[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

mqliang commented on a change in pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r605222747 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/DataTable.java ## @@ -80,4 +85,87 @@ double[] getDoubleArray(int

[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

mqliang commented on a change in pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r604531296 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/DataTable.java ## @@ -80,4 +85,87 @@ double[] getDoubleArray(int

[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

mqliang commented on a change in pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r605219147 ## File path: pinot-core/src/test/java/org/apache/pinot/core/common/datatable/DataTableSerDeTest.java ## @@ -96,22 +99,130 @@ public void

[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

mqliang commented on a change in pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r605218640 ## File path: pinot-core/src/main/java/org/apache/pinot/core/common/datatable/DataTableBuilder.java ## @@ -91,11 +94,16 @@ private ByteBuffer

[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

mqliang commented on a change in pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r604551363 ## File path: pinot-core/src/main/java/org/apache/pinot/core/common/datatable/DataTableImplBase.java ## @@ -0,0 +1,284 @@ +/** + * Licensed to

[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

mqliang commented on a change in pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r604531810 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/DataTable.java ## @@ -80,4 +85,87 @@ double[] getDoubleArray(int

[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

mqliang commented on a change in pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r604527967 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/DataTable.java ## @@ -80,4 +85,87 @@ double[] getDoubleArray(int

[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

mqliang commented on a change in pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r604551363 ## File path: pinot-core/src/main/java/org/apache/pinot/core/common/datatable/DataTableImplBase.java ## @@ -0,0 +1,284 @@ +/** + * Licensed to

[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

mqliang commented on a change in pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r604531810 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/DataTable.java ## @@ -80,4 +85,87 @@ double[] getDoubleArray(int

[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

mqliang commented on a change in pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r604531255 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/DataTable.java ## @@ -80,4 +85,87 @@ double[] getDoubleArray(int

[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

mqliang commented on a change in pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r604531148 ## File path: pinot-core/src/main/java/org/apache/pinot/core/common/datatable/DataTableBuilder.java ## @@ -77,6 +77,9 @@ // TODO: 3. Given a

[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

mqliang commented on a change in pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r604531148 ## File path: pinot-core/src/main/java/org/apache/pinot/core/common/datatable/DataTableBuilder.java ## @@ -77,6 +77,9 @@ // TODO: 3. Given a

[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

mqliang commented on a change in pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r604529060 ## File path: pinot-core/src/main/java/org/apache/pinot/core/common/datatable/DataTableBuilder.java ## @@ -77,6 +77,9 @@ // TODO: 3. Given a

[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

mqliang commented on a change in pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r604528494 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/DataTable.java ## @@ -80,4 +85,87 @@ double[] getDoubleArray(int

[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

mqliang commented on a change in pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r604527883 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/DataTable.java ## @@ -80,4 +85,87 @@ double[] getDoubleArray(int

[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

mqliang commented on a change in pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r604477092 ## File path: pinot-core/src/main/java/org/apache/pinot/core/common/datatable/DataTableBuilder.java ## @@ -96,6 +99,17 @@ public

[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

mqliang commented on a change in pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r604475304 ## File path: pinot-core/src/main/java/org/apache/pinot/core/common/datatable/DataTableBuilder.java ## @@ -77,6 +77,9 @@ // TODO: 3. Given a

[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

mqliang commented on a change in pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r604475304 ## File path: pinot-core/src/main/java/org/apache/pinot/core/common/datatable/DataTableBuilder.java ## @@ -77,6 +77,9 @@ // TODO: 3. Given a

[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

mqliang commented on a change in pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r604449557 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/scheduler/QueryScheduler.java ## @@ -315,7 +313,7 @@ private boolean

[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

mqliang commented on a change in pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r604447933 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/executor/ServerQueryExecutorV1Impl.java ## @@ -138,7 +138,7 @@ public

[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

mqliang commented on a change in pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r604447733 ## File path: pinot-core/src/main/java/org/apache/pinot/core/common/datatable/DataTableImplV3.java ## @@ -0,0 +1,397 @@ +/** + * Licensed to the

[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

mqliang commented on a change in pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r604446232 ## File path: pinot-core/src/main/java/org/apache/pinot/core/common/datatable/DataTableImplV3.java ## @@ -0,0 +1,397 @@ +/** + * Licensed to the

[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

mqliang commented on a change in pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r604415996 ## File path: pinot-core/src/test/java/org/apache/pinot/core/common/datatable/DataTableSerDeTest.java ## @@ -96,22 +99,130 @@ public void

[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

mqliang commented on a change in pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r604397222 ## File path: pinot-core/src/test/java/org/apache/pinot/core/common/datatable/DataTableSerDeTest.java ## @@ -96,22 +99,130 @@ public void

[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

mqliang commented on a change in pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r603806901 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/DataTable.java ## @@ -80,4 +85,88 @@ double[] getDoubleArray(int

[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

mqliang commented on a change in pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r603707132 ## File path: pinot-core/src/main/java/org/apache/pinot/core/common/datatable/DataTableImplV3.java ## @@ -0,0 +1,594 @@ +/** + * Licensed to the

[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

mqliang commented on a change in pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r603667157 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/DataTable.java ## @@ -80,4 +85,88 @@ double[] getDoubleArray(int

[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

mqliang commented on a change in pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r603655876 ## File path: pinot-core/src/main/java/org/apache/pinot/core/common/datatable/DataTableImplV3.java ## @@ -0,0 +1,594 @@ +/** + * Licensed to the

[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

mqliang commented on a change in pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r603655876 ## File path: pinot-core/src/main/java/org/apache/pinot/core/common/datatable/DataTableImplV3.java ## @@ -0,0 +1,594 @@ +/** + * Licensed to the

[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

mqliang commented on a change in pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r603637907 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/DataTable.java ## @@ -46,8 +52,120 @@ String

[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

mqliang commented on a change in pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r603634457 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/DataTable.java ## @@ -46,8 +52,120 @@ String

[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

mqliang commented on a change in pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r603634110 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/DataTable.java ## @@ -46,8 +52,120 @@ String

[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

mqliang commented on a change in pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r603634009 ## File path: pinot-core/src/main/java/org/apache/pinot/core/common/datatable/DataTableFactory.java ## @@ -32,7 +34,9 @@ public static DataTable

[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

mqliang commented on a change in pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r603632394 ## File path: pinot-core/src/main/java/org/apache/pinot/core/common/datatable/DataTableBuilder.java ## @@ -91,9 +107,17 @@ private ByteBuffer

[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

mqliang commented on a change in pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r603488335 ## File path: pinot-core/src/main/java/org/apache/pinot/core/common/datatable/DataTableBuilder.java ## @@ -91,9 +107,17 @@ private ByteBuffer

[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

mqliang commented on a change in pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r603052774 ## File path: pinot-core/src/main/java/org/apache/pinot/core/common/datatable/DataTableImplV3.java ## @@ -0,0 +1,702 @@ +/** + * Licensed to the

[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

mqliang commented on a change in pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r603032926 ## File path: pinot-core/src/main/java/org/apache/pinot/core/common/datatable/DataTableImplV2V3.java ## @@ -167,6 +178,18 @@ public

[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

mqliang commented on a change in pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r603028236 ## File path: pinot-core/src/main/java/org/apache/pinot/core/common/datatable/DataTableImplV3.java ## @@ -0,0 +1,702 @@ +/** + * Licensed to the

[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

mqliang commented on a change in pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r603022112 ## File path: pinot-core/src/main/java/org/apache/pinot/core/common/datatable/DataTableImplV3.java ## @@ -0,0 +1,702 @@ +/** + * Licensed to the

[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

mqliang commented on a change in pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r603021955 ## File path: pinot-core/src/main/java/org/apache/pinot/core/common/datatable/DataTableBuilder.java ## @@ -263,6 +263,14 @@ public void

[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

mqliang commented on a change in pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r603021339 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/DataTable.java ## @@ -45,9 +51,140 @@ String NUM_RESIZES_METADATA_KEY

[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

mqliang commented on a change in pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r603021060 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/DataTable.java ## @@ -45,9 +51,140 @@ String NUM_RESIZES_METADATA_KEY