npawar commented on a change in pull request #5005: Calcite SQL compiler syntax
support for order by expression and set LENIENT SQL conformance
URL: https://github.com/apache/incubator-pinot/pull/5005#discussion_r370427425
##########
File path:
pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java
##########
@@ -111,6 +112,7 @@ private static void setOptions(PinotQuery pinotQuery,
List<String> optionsStatem
private static PinotQuery compileCalciteSqlToPinotQuery(String sql) {
SqlParser.ConfigBuilder parserBuilder = SqlParser.configBuilder();
parserBuilder.setLex(PINOT_LEX);
+ parserBuilder.setConformance(SqlConformanceEnum.LENIENT);
Review comment:
@siddharthteotia we did an exercise at LI wherein we passed all possible
used queries though Calcite parser. We caught certain things which do not pass
under the default sql conformance level (`!=` and `LIMIT offset, count`). One
of the solutions for that we discussed was to set the conformance to be more
lenient.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
