[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #9802: Add memory optimized dimension table

Jackie-Jiang commented on code in PR #9802: URL: https://github.com/apache/pinot/pull/9802#discussion_r1152600051 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/offline/MemoryOptimizedDimensionTable.java: ## @@ -0,0 +1,93 @@ +/** + * Licensed to the Apache

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #9802: Add memory optimized dimension table

Jackie-Jiang commented on code in PR #9802: URL: https://github.com/apache/pinot/pull/9802#discussion_r1037455060 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/offline/DimensionTableDataManager.java: ## @@ -78,16 +81,32 @@ public static

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #9802: Add memory optimized dimension table

Jackie-Jiang commented on code in PR #9802: URL: https://github.com/apache/pinot/pull/9802#discussion_r1036358541 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/offline/DimensionTableDataManager.java: ## @@ -117,6 +135,26 @@ public void removeSegment(String

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #9802: Add memory optimized dimension table

Jackie-Jiang commented on code in PR #9802: URL: https://github.com/apache/pinot/pull/9802#discussion_r1034146942 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/offline/MemoryOptimizedDimensionTable.java: ## @@ -0,0 +1,71 @@ +/** + * Licensed to the Apache

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #9802: Add memory optimized dimension table

Jackie-Jiang commented on code in PR #9802: URL: https://github.com/apache/pinot/pull/9802#discussion_r1029878916 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/offline/MemoryOptimizedDimensionTable.java: ## @@ -0,0 +1,71 @@ +/** + * Licensed to the Apache

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #9802: Add memory optimized dimension table

Jackie-Jiang commented on code in PR #9802: URL: https://github.com/apache/pinot/pull/9802#discussion_r1028616845 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/offline/LookupRecordLocation.java: ## @@ -0,0 +1,40 @@ +/** + * Licensed to the Apache Software

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #9802: Add memory optimized dimension table

Jackie-Jiang commented on code in PR #9802: URL: https://github.com/apache/pinot/pull/9802#discussion_r1028546083 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/offline/DimensionTable.java: ## @@ -18,44 +18,21 @@ */ package