[GitHub] [pinot] Jackie-Jiang commented on issue #7264: Add exception to broker response when not all segments are available (partial response)

2021-08-20 Thread GitBox
Jackie-Jiang commented on issue #7264: URL: https://github.com/apache/pinot/issues/7264#issuecomment-903033843 @yupeng9 Current pinot behavior will always return the available results, and set exceptions for unexpected scenarios such as unable to reach to a server. For now I would suggest

[GitHub] [pinot] Jackie-Jiang commented on issue #7264: Add exception to broker response when not all segments are available (partial response)

2021-08-20 Thread GitBox
Jackie-Jiang commented on issue #7264: URL: https://github.com/apache/pinot/issues/7264#issuecomment-903026216 We need to think about how to set this `partialResponse` flag. What scenarios should be count as partial -- This is an automated message from the Apache Git Service. To respond

[GitHub] [pinot] Jackie-Jiang commented on issue #7264: Add exception to broker response when not all segments are available (partial response)

2021-08-19 Thread GitBox
Jackie-Jiang commented on issue #7264: URL: https://github.com/apache/pinot/issues/7264#issuecomment-902318772 I'd suggest adding different errors for each scenario described above to the `QueryException`, and users can decide on how to proceed based on the error type (error code). We

[GitHub] [pinot] Jackie-Jiang commented on issue #7264: Add exception to broker response when not all segments are available (partial response)

2021-08-16 Thread GitBox
Jackie-Jiang commented on issue #7264: URL: https://github.com/apache/pinot/issues/7264#issuecomment-98623 @amrishlal Partial and approximation are different, where approximation usually gives bounded error rate. The cases we want to notify the user here is when some segments are not

[GitHub] [pinot] Jackie-Jiang commented on issue #7264: Add exception to broker response when not all segments are available (partial response)

2021-08-09 Thread GitBox
Jackie-Jiang commented on issue #7264: URL: https://github.com/apache/pinot/issues/7264#issuecomment-895539754 We don't have that flag in OSS. IIRC the logic for that flag is check if `numServersQueried` matches `numServersResponded` and whether there are exceptions. We don't model

[GitHub] [pinot] Jackie-Jiang commented on issue #7264: Add exception to broker response when not all segments are available (partial response)

2021-08-09 Thread GitBox
Jackie-Jiang commented on issue #7264: URL: https://github.com/apache/pinot/issues/7264#issuecomment-895487473 We don't really have that for case 1 and 2. For case 3, we should not expect normal users to check `numServersQueried` and `numServersResponded` and compare them to tell whether