Re: [PR] Use RexList of carray pre agg arguments for intermediate stage [pinot]

2024-05-25 Thread via GitHub
xiangfu0 commented on code in PR #13217: URL: https://github.com/apache/pinot/pull/13217#discussion_r1615007974 ## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/RexExpression.java: ## @@ -117,6 +118,9 @@ class FunctionCall implements RexExpression {

Re: [PR] Use RexList of carray pre agg arguments for intermediate stage [pinot]

2024-05-25 Thread via GitHub
Jackie-Jiang commented on code in PR #13217: URL: https://github.com/apache/pinot/pull/13217#discussion_r1614910988 ## pinot-query-planner/src/main/java/org/apache/pinot/calcite/rel/rules/PinotQueryRuleSets.java: ## @@ -118,9 +118,7 @@ private PinotQueryRuleSets() { ); /

Re: [PR] Use RexList of carray pre agg arguments for intermediate stage [pinot]

2024-05-25 Thread via GitHub
Jackie-Jiang commented on code in PR #13217: URL: https://github.com/apache/pinot/pull/13217#discussion_r1614794331 ## pinot-common/src/main/java/org/apache/pinot/common/request/context/LiteralContext.java: ## @@ -162,7 +162,17 @@ public Object getValue() { public boolean get

Re: [PR] Use RexList of carray pre agg arguments for intermediate stage [pinot]

2024-05-25 Thread via GitHub
xiangfu0 commented on code in PR #13217: URL: https://github.com/apache/pinot/pull/13217#discussion_r1614683079 ## pinot-common/src/main/java/org/apache/pinot/common/request/context/LiteralContext.java: ## @@ -162,7 +162,17 @@ public Object getValue() { public boolean getBool

Re: [PR] Use RexList of carray pre agg arguments for intermediate stage [pinot]

2024-05-25 Thread via GitHub
xiangfu0 commented on code in PR #13217: URL: https://github.com/apache/pinot/pull/13217#discussion_r1614636247 ## pinot-common/src/main/java/org/apache/pinot/common/request/context/LiteralContext.java: ## @@ -162,7 +162,17 @@ public Object getValue() { public boolean getBool

Re: [PR] Use RexList of carray pre agg arguments for intermediate stage [pinot]

2024-05-25 Thread via GitHub
xiangfu0 commented on code in PR #13217: URL: https://github.com/apache/pinot/pull/13217#discussion_r1614638087 ## pinot-common/src/main/java/org/apache/pinot/common/request/context/LiteralContext.java: ## @@ -162,7 +162,17 @@ public Object getValue() { public boolean getBool

Re: [PR] Use RexList of carray pre agg arguments for intermediate stage [pinot]

2024-05-25 Thread via GitHub
xiangfu0 commented on code in PR #13217: URL: https://github.com/apache/pinot/pull/13217#discussion_r1614636247 ## pinot-common/src/main/java/org/apache/pinot/common/request/context/LiteralContext.java: ## @@ -162,7 +162,17 @@ public Object getValue() { public boolean getBool

Re: [PR] Use RexList of carray pre agg arguments for intermediate stage [pinot]

2024-05-24 Thread via GitHub
Jackie-Jiang commented on code in PR #13217: URL: https://github.com/apache/pinot/pull/13217#discussion_r1614056876 ## pinot-common/src/main/java/org/apache/pinot/common/request/context/LiteralContext.java: ## @@ -162,7 +162,17 @@ public Object getValue() { public boolean get

Re: [PR] Use RexList of carray pre agg arguments for intermediate stage [pinot]

2024-05-23 Thread via GitHub
codecov-commenter commented on PR #13217: URL: https://github.com/apache/pinot/pull/13217#issuecomment-2128290900 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13217?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Use RexList of carray pre agg arguments for intermediate stage [pinot]

2024-05-23 Thread via GitHub
xiangfu0 opened a new pull request, #13217: URL: https://github.com/apache/pinot/pull/13217 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m