[incubator-pinot] branch switch-ui-to-sql updated (f0576e5 -> b8e96d7)

2020-01-20 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch switch-ui-to-sql in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from f0576e5 Make sql as default query format. add b8e96d7 Update TransformExpressionTree.java

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4993: Support Text column type in Pinot (both offline and realtime)

2020-01-20 Thread GitBox
siddharthteotia commented on a change in pull request #4993: Support Text column type in Pinot (both offline and realtime) URL: https://github.com/apache/incubator-pinot/pull/4993#discussion_r368758007 ## File path:

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #4998: Fixing java 11 runtime issues

2020-01-20 Thread GitBox
fx19880617 commented on a change in pull request #4998: Fixing java 11 runtime issues URL: https://github.com/apache/incubator-pinot/pull/4998#discussion_r368764254 ## File path: pinot-distribution/pom.xml ## @@ -93,6 +93,26 @@ + Review

[GitHub] [incubator-pinot] siddharthteotia edited a comment on issue #4993: Support Text column type in Pinot (both offline and realtime)

2020-01-20 Thread GitBox
siddharthteotia edited a comment on issue #4993: Support Text column type in Pinot (both offline and realtime) URL: https://github.com/apache/incubator-pinot/pull/4993#issuecomment-576460048 > Also, is this supported in the SQL path? Yes it will be supported.

[GitHub] [incubator-pinot] siddharthteotia removed a comment on issue #4993: Support Text column type in Pinot (both offline and realtime)

2020-01-20 Thread GitBox
siddharthteotia removed a comment on issue #4993: Support Text column type in Pinot (both offline and realtime) URL: https://github.com/apache/incubator-pinot/pull/4993#issuecomment-576464652 TODOs (in addition to the ones added in the code) (1) Add the new data type. (2) Extend

[GitHub] [incubator-pinot] codecov-io commented on issue #4998: Fixing java 11 runtime issues

2020-01-20 Thread GitBox
codecov-io commented on issue #4998: Fixing java 11 runtime issues URL: https://github.com/apache/incubator-pinot/pull/4998#issuecomment-576480386 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4998?src=pr=h1) Report > Merging

[incubator-pinot] branch switch-ui-to-sql updated (7dd4559 -> 0cca514)

2020-01-20 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch switch-ui-to-sql in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 7dd4559 Adding sql endpoint in controller discard b8e96d7 Update TransformExpressionTree.java

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4998: Fixing java 11 runtime issues

2020-01-20 Thread GitBox
codecov-io edited a comment on issue #4998: Fixing java 11 runtime issues URL: https://github.com/apache/incubator-pinot/pull/4998#issuecomment-576480386 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4998?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4994: Make sql as default query format.

2020-01-20 Thread GitBox
codecov-io edited a comment on issue #4994: Make sql as default query format. URL: https://github.com/apache/incubator-pinot/pull/4994#issuecomment-575616116 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4994?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4993: Support Text column type in Pinot (both offline and realtime)

2020-01-20 Thread GitBox
siddharthteotia commented on a change in pull request #4993: Support Text column type in Pinot (both offline and realtime) URL: https://github.com/apache/incubator-pinot/pull/4993#discussion_r368759415 ## File path:

[GitHub] [incubator-pinot] siddharthteotia commented on issue #4993: Support Text column type in Pinot (both offline and realtime)

2020-01-20 Thread GitBox
siddharthteotia commented on issue #4993: Support Text column type in Pinot (both offline and realtime) URL: https://github.com/apache/incubator-pinot/pull/4993#issuecomment-576461826 @mcvsubbu , I have addressed your review comments. Please take another look.

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4993: Support Text column type in Pinot (both offline and realtime)

2020-01-20 Thread GitBox
siddharthteotia commented on a change in pull request #4993: Support Text column type in Pinot (both offline and realtime) URL: https://github.com/apache/incubator-pinot/pull/4993#discussion_r368757789 ## File path:

[incubator-pinot] branch fixing_packaging_issue updated (ea36238 -> 6295eab)

2020-01-20 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch fixing_packaging_issue in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from ea36238 Fixing java 11 runtime issue add 6295eab Address comments No new revisions

[incubator-pinot] branch fixing_packaging_issue updated (6295eab -> 661abf0)

2020-01-20 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch fixing_packaging_issue in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 6295eab Address comments add 661abf0 Address comments This update added new

[GitHub] [incubator-pinot] siddharthteotia commented on issue #4993: Support Text column type in Pinot (both offline and realtime)

2020-01-20 Thread GitBox
siddharthteotia commented on issue #4993: Support Text column type in Pinot (both offline and realtime) URL: https://github.com/apache/incubator-pinot/pull/4993#issuecomment-576460097 > This is an amazing feature. let's create an issue to add the user doc for this feature. Yes I

[GitHub] [incubator-pinot] siddharthteotia commented on issue #4993: Support Text column type in Pinot (both offline and realtime)

2020-01-20 Thread GitBox
siddharthteotia commented on issue #4993: Support Text column type in Pinot (both offline and realtime) URL: https://github.com/apache/incubator-pinot/pull/4993#issuecomment-576460048 > Also, is this supported in the SQL path? Yes it will be supported. As noted in my comments,

[GitHub] [incubator-pinot] kishoreg merged pull request #4983: Make PQL case insensitive

2020-01-20 Thread GitBox
kishoreg merged pull request #4983: Make PQL case insensitive URL: https://github.com/apache/incubator-pinot/pull/4983 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[incubator-pinot] branch master updated (f990656 -> e46eec3)

2020-01-20 Thread kishoreg
This is an automated email from the ASF dual-hosted git repository. kishoreg pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from f990656 Pinot batch ingestion hadoop (#4987) add e46eec3 Make PQL case insensitive (#4983) No new

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4979: Update quota manager to reduce zk access

2020-01-20 Thread GitBox
jackjlli commented on a change in pull request #4979: Update quota manager to reduce zk access URL: https://github.com/apache/incubator-pinot/pull/4979#discussion_r368771972 ## File path:

[GitHub] [incubator-pinot] jackjlli commented on issue #4979: Update quota manager to reduce zk access

2020-01-20 Thread GitBox
jackjlli commented on issue #4979: Update quota manager to reduce zk access URL: https://github.com/apache/incubator-pinot/pull/4979#issuecomment-576479299 @mcvsubbu Currently the rate has to be re-calculated when number of online brokers and table config exists, even these two don't

[GitHub] [incubator-pinot] fx19880617 opened a new pull request #4998: Fixing java 11 runtime issue

2020-01-20 Thread GitBox
fx19880617 opened a new pull request #4998: Fixing java 11 runtime issue URL: https://github.com/apache/incubator-pinot/pull/4998 This is an automated message from the Apache Git Service. To respond to the message, please

[incubator-pinot] 01/01: Fixing java 11 runtime issue

2020-01-20 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch fixing_packaging_issue in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit ea36238e636b1e0bfa788e0bc23b5f7731a04efd Author: Xiang Fu AuthorDate: Mon Jan 20 15:27:32

[incubator-pinot] branch fixing_packaging_issue created (now ea36238)

2020-01-20 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch fixing_packaging_issue in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at ea36238 Fixing java 11 runtime issue This branch includes the following new commits:

[GitHub] [incubator-pinot] siddharthteotia commented on issue #4993: Support Text column type in Pinot (both offline and realtime)

2020-01-20 Thread GitBox
siddharthteotia commented on issue #4993: Support Text column type in Pinot (both offline and realtime) URL: https://github.com/apache/incubator-pinot/pull/4993#issuecomment-576459692 > Related comment in PR 4954. I don't have an answer, but we do need to resolve it > > Also, are

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4993: Support Text column type in Pinot (both offline and realtime)

2020-01-20 Thread GitBox
siddharthteotia commented on a change in pull request #4993: Support Text column type in Pinot (both offline and realtime) URL: https://github.com/apache/incubator-pinot/pull/4993#discussion_r368758339 ## File path:

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4993: Support Text column type in Pinot (both offline and realtime)

2020-01-20 Thread GitBox
siddharthteotia commented on a change in pull request #4993: Support Text column type in Pinot (both offline and realtime) URL: https://github.com/apache/incubator-pinot/pull/4993#discussion_r368758547 ## File path:

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4993: Support Text column type in Pinot (both offline and realtime)

2020-01-20 Thread GitBox
siddharthteotia commented on a change in pull request #4993: Support Text column type in Pinot (both offline and realtime) URL: https://github.com/apache/incubator-pinot/pull/4993#discussion_r368759880 ## File path:

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4993: Support Text column type in Pinot (both offline and realtime)

2020-01-20 Thread GitBox
siddharthteotia commented on a change in pull request #4993: Support Text column type in Pinot (both offline and realtime) URL: https://github.com/apache/incubator-pinot/pull/4993#discussion_r368760225 ## File path:

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4998: Fixing java 11 runtime issues

2020-01-20 Thread GitBox
kishoreg commented on a change in pull request #4998: Fixing java 11 runtime issues URL: https://github.com/apache/incubator-pinot/pull/4998#discussion_r368759896 ## File path: pinot-tools/src/main/resources/appAssemblerScriptTemplate ## @@ -107,6 +107,37 @@ if [ -n

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4998: Fixing java 11 runtime issues

2020-01-20 Thread GitBox
kishoreg commented on a change in pull request #4998: Fixing java 11 runtime issues URL: https://github.com/apache/incubator-pinot/pull/4998#discussion_r368759279 ## File path: pinot-tools/src/main/resources/appAssemblerScriptTemplate ## @@ -107,6 +107,37 @@ if [ -n

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4998: Fixing java 11 runtime issues

2020-01-20 Thread GitBox
kishoreg commented on a change in pull request #4998: Fixing java 11 runtime issues URL: https://github.com/apache/incubator-pinot/pull/4998#discussion_r368758973 ## File path: pinot-distribution/pom.xml ## @@ -93,6 +93,26 @@ + Review

[GitHub] [incubator-pinot] siddharthteotia commented on issue #4993: Support Text column type in Pinot (both offline and realtime)

2020-01-20 Thread GitBox
siddharthteotia commented on issue #4993: Support Text column type in Pinot (both offline and realtime) URL: https://github.com/apache/incubator-pinot/pull/4993#issuecomment-576464652 TODOs: (1) Add the new column type (2) Extend Calcite SQL grammar and parser to support

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4994: Make sql as default query format.

2020-01-20 Thread GitBox
codecov-io edited a comment on issue #4994: Make sql as default query format. URL: https://github.com/apache/incubator-pinot/pull/4994#issuecomment-575616116 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4994?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4993: Support Text column type in Pinot (both offline and realtime)

2020-01-20 Thread GitBox
codecov-io edited a comment on issue #4993: Support Text column type in Pinot (both offline and realtime) URL: https://github.com/apache/incubator-pinot/pull/4993#issuecomment-575877560 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4993?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] siddharthteotia edited a comment on issue #4993: Support Text column type in Pinot (both offline and realtime)

2020-01-20 Thread GitBox
siddharthteotia edited a comment on issue #4993: Support Text column type in Pinot (both offline and realtime) URL: https://github.com/apache/incubator-pinot/pull/4993#issuecomment-576459692 > Related comment in PR 4954. I don't have an answer, but we do need to resolve it > >

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #4994: Make sql as default query format.

2020-01-20 Thread GitBox
fx19880617 commented on a change in pull request #4994: Make sql as default query format. URL: https://github.com/apache/incubator-pinot/pull/4994#discussion_r368786402 ## File path: pinot-controller/src/main/resources/static/js/init.js ## @@ -67,13 +67,13 @@

[incubator-pinot] branch switch-ui-to-sql updated (db98b2a -> e474484)

2020-01-20 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch switch-ui-to-sql in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard db98b2a Address comments add e474484 Address comments This update added new revisions

[incubator-pinot] branch master updated (e46eec3 -> e29b88a)

2020-01-20 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from e46eec3 Make PQL case insensitive (#4983) add e29b88a Fixing java 11 runtime issues (#4998) No new

[GitHub] [incubator-pinot] fx19880617 merged pull request #4998: Fixing java 11 runtime issues

2020-01-20 Thread GitBox
fx19880617 merged pull request #4998: Fixing java 11 runtime issues URL: https://github.com/apache/incubator-pinot/pull/4998 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4993: Support Text column type in Pinot (both offline and realtime)

2020-01-20 Thread GitBox
siddharthteotia commented on a change in pull request #4993: Support Text column type in Pinot (both offline and realtime) URL: https://github.com/apache/incubator-pinot/pull/4993#discussion_r368757857 ## File path:

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4993: Support Text column type in Pinot (both offline and realtime)

2020-01-20 Thread GitBox
siddharthteotia commented on a change in pull request #4993: Support Text column type in Pinot (both offline and realtime) URL: https://github.com/apache/incubator-pinot/pull/4993#discussion_r368757847 ## File path:

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4993: Support Text column type in Pinot (both offline and realtime)

2020-01-20 Thread GitBox
siddharthteotia commented on a change in pull request #4993: Support Text column type in Pinot (both offline and realtime) URL: https://github.com/apache/incubator-pinot/pull/4993#discussion_r368758087 ## File path:

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4993: Support Text column type in Pinot (both offline and realtime)

2020-01-20 Thread GitBox
siddharthteotia commented on a change in pull request #4993: Support Text column type in Pinot (both offline and realtime) URL: https://github.com/apache/incubator-pinot/pull/4993#discussion_r368758007 ## File path:

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4993: Support Text column type in Pinot (both offline and realtime)

2020-01-20 Thread GitBox
siddharthteotia commented on a change in pull request #4993: Support Text column type in Pinot (both offline and realtime) URL: https://github.com/apache/incubator-pinot/pull/4993#discussion_r368757789 ## File path:

[incubator-pinot] branch switch-ui-to-sql updated (b8e96d7 -> dfb36bf)

2020-01-20 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch switch-ui-to-sql in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from b8e96d7 Update TransformExpressionTree.java add dfb36bf Adding sql endpoint in controller

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4994: Make sql as default query format.

2020-01-20 Thread GitBox
kishoreg commented on a change in pull request #4994: Make sql as default query format. URL: https://github.com/apache/incubator-pinot/pull/4994#discussion_r368783669 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotQueryResource.java

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4994: Make sql as default query format.

2020-01-20 Thread GitBox
kishoreg commented on a change in pull request #4994: Make sql as default query format. URL: https://github.com/apache/incubator-pinot/pull/4994#discussion_r368784176 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotQueryResource.java

[GitHub] [incubator-pinot] siddharthteotia edited a comment on issue #4993: Support Text column type in Pinot (both offline and realtime)

2020-01-20 Thread GitBox
siddharthteotia edited a comment on issue #4993: Support Text column type in Pinot (both offline and realtime) URL: https://github.com/apache/incubator-pinot/pull/4993#issuecomment-576460048 > Also, is this supported in the SQL path? Yes it will be supported. As noted in my comments

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4993: Support Text column type in Pinot (both offline and realtime)

2020-01-20 Thread GitBox
siddharthteotia commented on a change in pull request #4993: Support Text column type in Pinot (both offline and realtime) URL: https://github.com/apache/incubator-pinot/pull/4993#discussion_r368759932 ## File path:

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4993: Support Text column type in Pinot (both offline and realtime)

2020-01-20 Thread GitBox
siddharthteotia commented on a change in pull request #4993: Support Text column type in Pinot (both offline and realtime) URL: https://github.com/apache/incubator-pinot/pull/4993#discussion_r368760010 ## File path:

[incubator-pinot] branch upgrade_docker_build_maven_to_3.6 updated (d9d02a3 -> 546382c)

2020-01-20 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch upgrade_docker_build_maven_to_3.6 in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard d9d02a3 update ingestion job specs for docker examples add 546382c

[GitHub] [incubator-pinot] siddharthteotia edited a comment on issue #4993: Support Text column type in Pinot (both offline and realtime)

2020-01-20 Thread GitBox
siddharthteotia edited a comment on issue #4993: Support Text column type in Pinot (both offline and realtime) URL: https://github.com/apache/incubator-pinot/pull/4993#issuecomment-576464652 TODOs: (1) Add the new data type. (2) Extend Calcite SQL grammar and parser to support

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4979: Update quota manager to reduce zk access

2020-01-20 Thread GitBox
jackjlli commented on a change in pull request #4979: Update quota manager to reduce zk access URL: https://github.com/apache/incubator-pinot/pull/4979#discussion_r368773524 ## File path:

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4979: Update quota manager to reduce zk access

2020-01-20 Thread GitBox
codecov-io edited a comment on issue #4979: Update quota manager to reduce zk access URL: https://github.com/apache/incubator-pinot/pull/4979#issuecomment-573975171 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4979?src=pr=h1) Report > Merging

[incubator-pinot] branch switch-ui-to-sql updated (dfb36bf -> 7dd4559)

2020-01-20 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch switch-ui-to-sql in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard dfb36bf Adding sql endpoint in controller add 7dd4559 Adding sql endpoint in controller

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4997: Update dockerfile for pinot image and pinot-presto image

2020-01-20 Thread GitBox
codecov-io edited a comment on issue #4997: Update dockerfile for pinot image and pinot-presto image URL: https://github.com/apache/incubator-pinot/pull/4997#issuecomment-575875680 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4997?src=pr=h1) Report > Merging

[incubator-pinot] branch switch-ui-to-sql updated (95ed4c2 -> db98b2a)

2020-01-20 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch switch-ui-to-sql in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 95ed4c2 Address comments add db98b2a Address comments This update added new revisions

[incubator-pinot] branch switch-ui-to-sql updated (0cca514 -> 95ed4c2)

2020-01-20 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch switch-ui-to-sql in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 0cca514 Adding sql endpoint in controller add 95ed4c2 Address comments No new revisions