[GitHub] [incubator-pinot] fx19880617 commented on issue #4041: Use hex string as the representation of byte array for queries

2019-03-29 Thread GitBox
fx19880617 commented on issue #4041: Use hex string as the representation of byte array for queries URL: https://github.com/apache/incubator-pinot/pull/4041#issuecomment-478213372 > can we add a test case? Modified existing dictionary test to let BYTES dictionary index values contai

[GitHub] [incubator-pinot] xiangfu1 removed a comment on issue #4041: Use hex string as the representation of byte array for queries

2019-03-29 Thread GitBox
xiangfu1 removed a comment on issue #4041: Use hex string as the representation of byte array for queries URL: https://github.com/apache/incubator-pinot/pull/4041#issuecomment-478213122 > can we add a test case? Modified existing dictionary test to let BYTES dictionary index values

[GitHub] [incubator-pinot] xiangfu1 commented on issue #4041: Use hex string as the representation of byte array for queries

2019-03-29 Thread GitBox
xiangfu1 commented on issue #4041: Use hex string as the representation of byte array for queries URL: https://github.com/apache/incubator-pinot/pull/4041#issuecomment-478213122 > can we add a test case? Modified existing dictionary test to let BYTES dictionary index values contain

[incubator-pinot] branch hex_string_for_byte_array updated: Adding test for indexing hexstring

2019-03-29 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch hex_string_for_byte_array in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/hex_string_for_byte_array by this push: new

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4041: Use hex string as the representation of byte array for queries

2019-03-29 Thread GitBox
codecov-io edited a comment on issue #4041: Use hex string as the representation of byte array for queries URL: https://github.com/apache/incubator-pinot/pull/4041#issuecomment-478197519 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4041?src=pr&el=h1) Report > Merging

[GitHub] [incubator-pinot] kishoreg commented on issue #4041: Use hex string as the representation of byte array for queries

2019-03-29 Thread GitBox
kishoreg commented on issue #4041: Use hex string as the representation of byte array for queries URL: https://github.com/apache/incubator-pinot/pull/4041#issuecomment-478210795 can we add a test case? This is an automated m

[GitHub] [incubator-pinot] xiangfu1 commented on a change in pull request #4041: Use hex string as the representation of byte array for queries

2019-03-29 Thread GitBox
xiangfu1 commented on a change in pull request #4041: Use hex string as the representation of byte array for queries URL: https://github.com/apache/incubator-pinot/pull/4041#discussion_r270614150 ## File path: pinot-core/src/main/java/org/apache/pinot/core/realtime/impl/dictionary/

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #4041: Use hex string as the representation of byte array for queries

2019-03-29 Thread GitBox
fx19880617 commented on a change in pull request #4041: Use hex string as the representation of byte array for queries URL: https://github.com/apache/incubator-pinot/pull/4041#discussion_r270614155 ## File path: pinot-core/src/main/java/org/apache/pinot/core/realtime/impl/dictionar

[GitHub] [incubator-pinot] xiangfu1 commented on a change in pull request #4041: Use hex string as the representation of byte array for queries

2019-03-29 Thread GitBox
xiangfu1 commented on a change in pull request #4041: Use hex string as the representation of byte array for queries URL: https://github.com/apache/incubator-pinot/pull/4041#discussion_r270614150 ## File path: pinot-core/src/main/java/org/apache/pinot/core/realtime/impl/dictionary/

[incubator-pinot] branch hex_string_for_byte_array updated (807e15c -> 79305e8)

2019-03-29 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch hex_string_for_byte_array in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 807e15c Use hex string as the representation of byte array for queries new 79305e8

[GitHub] [incubator-pinot] kishoreg commented on issue #4036: Reduce heap usage when building realtime segments

2019-03-29 Thread GitBox
kishoreg commented on issue #4036: Reduce heap usage when building realtime segments URL: https://github.com/apache/incubator-pinot/issues/4036#issuecomment-478204181 I am curious on knowing the heap usage if we use the offheap dictionary you built for realtime in segmentGenerator. Is tha

[GitHub] [incubator-pinot] codecov-io commented on issue #4041: Use hex string as the representation of byte array for queries

2019-03-29 Thread GitBox
codecov-io commented on issue #4041: Use hex string as the representation of byte array for queries URL: https://github.com/apache/incubator-pinot/pull/4041#issuecomment-478197519 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4041?src=pr&el=h1) Report > Merging [#4041]

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #4041: Use hex string as the representation of byte array for queries

2019-03-29 Thread GitBox
mayankshriv commented on a change in pull request #4041: Use hex string as the representation of byte array for queries URL: https://github.com/apache/incubator-pinot/pull/4041#discussion_r270608834 ## File path: pinot-core/src/main/java/org/apache/pinot/core/realtime/impl/dictiona

[incubator-pinot] branch hex_string_for_byte_array updated (0a7f4bf -> 807e15c)

2019-03-29 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch hex_string_for_byte_array in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 0a7f4bf Use hex string as the representation of byte array for queries new 807e15c

[GitHub] [incubator-pinot] fx19880617 opened a new pull request #4041: Use hex string as the representation of byte array for queries

2019-03-29 Thread GitBox
fx19880617 opened a new pull request #4041: Use hex string as the representation of byte array for queries URL: https://github.com/apache/incubator-pinot/pull/4041 Use hex string to represent byte[] value in query. Refer to https://github.com/apache/incubator-pinot/issues/4040 -

[incubator-pinot] 01/01: Use hex string as the representation of byte array for queries

2019-03-29 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch hex_string_for_byte_array in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit 0a7f4bf17662a7d801c07c88b05b00d31cf04be5 Author: Xiang Fu AuthorDate: Fri Mar 29 18:39:17 2

[incubator-pinot] branch hex_string_for_byte_array created (now 0a7f4bf)

2019-03-29 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch hex_string_for_byte_array in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 0a7f4bf Use hex string as the representation of byte array for queries This branch inc

[GitHub] [incubator-pinot] sunithabeeram commented on a change in pull request #4037: Add more logs to ServiceStatus

2019-03-29 Thread GitBox
sunithabeeram commented on a change in pull request #4037: Add more logs to ServiceStatus URL: https://github.com/apache/incubator-pinot/pull/4037#discussion_r270607608 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/ServiceStatus.java ## @@ -227,70

[GitHub] [incubator-pinot] sunithabeeram commented on a change in pull request #4037: Add more logs to ServiceStatus

2019-03-29 Thread GitBox
sunithabeeram commented on a change in pull request #4037: Add more logs to ServiceStatus URL: https://github.com/apache/incubator-pinot/pull/4037#discussion_r270607396 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/ServiceStatus.java ## @@ -227,70

[GitHub] [incubator-pinot] sunithabeeram commented on a change in pull request #4037: Add more logs to ServiceStatus

2019-03-29 Thread GitBox
sunithabeeram commented on a change in pull request #4037: Add more logs to ServiceStatus URL: https://github.com/apache/incubator-pinot/pull/4037#discussion_r270607485 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/ServiceStatus.java ## @@ -227,70

[GitHub] [incubator-pinot] sunithabeeram commented on a change in pull request #4037: Add more logs to ServiceStatus

2019-03-29 Thread GitBox
sunithabeeram commented on a change in pull request #4037: Add more logs to ServiceStatus URL: https://github.com/apache/incubator-pinot/pull/4037#discussion_r270585625 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/ServiceStatus.java ## @@ -24,6 +

[GitHub] [incubator-pinot] sunithabeeram commented on a change in pull request #4037: Add more logs to ServiceStatus

2019-03-29 Thread GitBox
sunithabeeram commented on a change in pull request #4037: Add more logs to ServiceStatus URL: https://github.com/apache/incubator-pinot/pull/4037#discussion_r270607581 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/ServiceStatus.java ## @@ -227,70

[GitHub] [incubator-pinot] jihaozh merged pull request #4038: [TE] filter out anomalies in the future

2019-03-29 Thread GitBox
jihaozh merged pull request #4038: [TE] filter out anomalies in the future URL: https://github.com/apache/incubator-pinot/pull/4038 This is an automated message from the Apache Git Service. To respond to the message, please l

[incubator-pinot] branch master updated: [TE] filter out anomalies in the future (#4038)

2019-03-29 Thread jihao
This is an automated email from the ASF dual-hosted git repository. jihao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 6c71c24 [TE] filter out anomalies in th

[GitHub] [incubator-pinot] codecov-io commented on issue #4037: Add more logs to ServiceStatus

2019-03-29 Thread GitBox
codecov-io commented on issue #4037: Add more logs to ServiceStatus URL: https://github.com/apache/incubator-pinot/pull/4037#issuecomment-478188986 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4037?src=pr&el=h1) Report > Merging [#4037](https://codecov.io/gh/apache/inc

[GitHub] [incubator-pinot] fx19880617 commented on issue #4040: Cannot filtering on bytes data type

2019-03-29 Thread GitBox
fx19880617 commented on issue #4040: Cannot filtering on bytes data type URL: https://github.com/apache/incubator-pinot/issues/4040#issuecomment-478188124 The assertion `assert rawValue instanceof byte[];` at `line 35`, file: `org.apache.pinot.core.realtime.impl.dictionary.BytesOnHeapMutab

[GitHub] [incubator-pinot] xiangfu1 closed issue #4039: Cannot filtering on bytes data type

2019-03-29 Thread GitBox
xiangfu1 closed issue #4039: Cannot filtering on bytes data type URL: https://github.com/apache/incubator-pinot/issues/4039 This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [incubator-pinot] fx19880617 opened a new issue #4040: Cannot filtering on bytes data type

2019-03-29 Thread GitBox
fx19880617 opened a new issue #4040: Cannot filtering on bytes data type URL: https://github.com/apache/incubator-pinot/issues/4040 Table schema: ``` { "metricFieldSpecs": [ ], "dimensionFieldSpecs": [ { "dataType": "BYTES", "name": "uuid"

[GitHub] [incubator-pinot] xiangfu1 opened a new issue #4039: Cannot filtering on bytes data type

2019-03-29 Thread GitBox
xiangfu1 opened a new issue #4039: Cannot filtering on bytes data type URL: https://github.com/apache/incubator-pinot/issues/4039 Table schema: ``` { "metricFieldSpecs": [ ], "dimensionFieldSpecs": [ { "dataType": "BYTES", "name": "uuid"

[GitHub] [incubator-pinot] jihaozh opened a new pull request #4038: [TE] filter out anomalies in the future

2019-03-29 Thread GitBox
jihaozh opened a new pull request #4038: [TE] filter out anomalies in the future URL: https://github.com/apache/incubator-pinot/pull/4038 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #3830: [TE] SQL Connector backend and front end, supporting Presto, MySQL, H2, with sample data in H2

2019-03-29 Thread GitBox
akshayrai commented on a change in pull request #3830: [TE] SQL Connector backend and front end, supporting Presto, MySQL, H2, with sample data in H2 URL: https://github.com/apache/incubator-pinot/pull/3830#discussion_r270601852 ## File path: thirdeye/thirdeye-pinot/src/main/java/o

[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #3830: [TE] SQL Connector backend and front end, supporting Presto, MySQL, H2, with sample data in H2

2019-03-29 Thread GitBox
akshayrai commented on a change in pull request #3830: [TE] SQL Connector backend and front end, supporting Presto, MySQL, H2, with sample data in H2 URL: https://github.com/apache/incubator-pinot/pull/3830#discussion_r270597954 ## File path: thirdeye/thirdeye-pinot/src/main/java/o

[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #3830: [TE] SQL Connector backend and front end, supporting Presto, MySQL, H2, with sample data in H2

2019-03-29 Thread GitBox
akshayrai commented on a change in pull request #3830: [TE] SQL Connector backend and front end, supporting Presto, MySQL, H2, with sample data in H2 URL: https://github.com/apache/incubator-pinot/pull/3830#discussion_r270599586 ## File path: thirdeye/thirdeye-pinot/src/main/resourc

[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #3830: [TE] SQL Connector backend and front end, supporting Presto, MySQL, H2, with sample data in H2

2019-03-29 Thread GitBox
akshayrai commented on a change in pull request #3830: [TE] SQL Connector backend and front end, supporting Presto, MySQL, H2, with sample data in H2 URL: https://github.com/apache/incubator-pinot/pull/3830#discussion_r270599104 ## File path: thirdeye/thirdeye-pinot/config/data/READ

[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #3830: [TE] SQL Connector backend and front end, supporting Presto, MySQL, H2, with sample data in H2

2019-03-29 Thread GitBox
akshayrai commented on a change in pull request #3830: [TE] SQL Connector backend and front end, supporting Presto, MySQL, H2, with sample data in H2 URL: https://github.com/apache/incubator-pinot/pull/3830#discussion_r270601243 ## File path: thirdeye/thirdeye-pinot/src/main/java/o

[GitHub] [incubator-pinot] mcvsubbu commented on issue #4036: Reduce heap usage when building realtime segments

2019-03-29 Thread GitBox
mcvsubbu commented on issue #4036: Reduce heap usage when building realtime segments URL: https://github.com/apache/incubator-pinot/issues/4036#issuecomment-478182583 @kishoreg I could not format the table correctly but pls take a look -

[GitHub] [incubator-pinot] mcvsubbu commented on issue #4036: Reduce heap usage when building realtime segments

2019-03-29 Thread GitBox
mcvsubbu commented on issue #4036: Reduce heap usage when building realtime segments URL: https://github.com/apache/incubator-pinot/issues/4036#issuecomment-478182468 I ran the prototype code on sample segments of 4 use cases in our cluster. In two of the use cases there was about 30% h

[GitHub] [incubator-pinot] npawar commented on issue #3513: DATETIMECONVERT udf does not work for customized timezone and bucket size > 1 day

2019-03-29 Thread GitBox
npawar commented on issue #3513: DATETIMECONVERT udf does not work for customized timezone and bucket size > 1 day URL: https://github.com/apache/incubator-pinot/issues/3513#issuecomment-478177692 Hey @chenboat and @weiwanning, I won't be able to get to this anytime soon. Would you lik

[incubator-pinot] branch master updated: [TE] do not automatically onboard millisecond level dataset (#4033)

2019-03-29 Thread jihao
This is an automated email from the ASF dual-hosted git repository. jihao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 823c801 [TE] do not automatically onboa

[GitHub] [incubator-pinot] jihaozh merged pull request #4033: [TE] do not automatically onboard millisecond level dataset

2019-03-29 Thread GitBox
jihaozh merged pull request #4033: [TE] do not automatically onboard millisecond level dataset URL: https://github.com/apache/incubator-pinot/pull/4033 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-pinot] xiaohui-sun merged pull request #4026: [TE] Reduce log for data insufficient exception.

2019-03-29 Thread GitBox
xiaohui-sun merged pull request #4026: [TE] Reduce log for data insufficient exception. URL: https://github.com/apache/incubator-pinot/pull/4026 This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [incubator-pinot] xiaohui-sun closed pull request #3875: [TE] detection add upper/lower bounds to detection output

2019-03-29 Thread GitBox
xiaohui-sun closed pull request #3875: [TE] detection add upper/lower bounds to detection output URL: https://github.com/apache/incubator-pinot/pull/3875 This is an automated message from the Apache Git Service. To respond t

[incubator-pinot] branch master updated: [TE] Reduce log for data insufficient exception. (#4026)

2019-03-29 Thread xhsun
This is an automated email from the ASF dual-hosted git repository. xhsun pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 35f058c [TE] Reduce log for data insuff

[GitHub] [incubator-pinot] xiaohui-sun closed pull request #3990: [TE] Add algorithm based configurations into template

2019-03-29 Thread GitBox
xiaohui-sun closed pull request #3990: [TE] Add algorithm based configurations into template URL: https://github.com/apache/incubator-pinot/pull/3990 This is an automated message from the Apache Git Service. To respond to th

[GitHub] [incubator-pinot] codecov-io commented on issue #4026: [TE] Reduce log for data insufficient exception.

2019-03-29 Thread GitBox
codecov-io commented on issue #4026: [TE] Reduce log for data insufficient exception. URL: https://github.com/apache/incubator-pinot/pull/4026#issuecomment-478150553 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4026?src=pr&el=h1) Report > Merging [#4026](https://codec

[GitHub] [incubator-pinot] mcvsubbu opened a new pull request #4037: Add more logs to ServiceStatus

2019-03-29 Thread GitBox
mcvsubbu opened a new pull request #4037: Add more logs to ServiceStatus URL: https://github.com/apache/incubator-pinot/pull/4037 When we declare a service good due to its reaching the percentage threshold, it is useful to log information about at least one partition in the resources tha

[GitHub] [incubator-pinot] kishoreg commented on issue #4036: Reduce heap usage when building realtime segments

2019-03-29 Thread GitBox
kishoreg commented on issue #4036: Reduce heap usage when building realtime segments URL: https://github.com/apache/incubator-pinot/issues/4036#issuecomment-478138214 Very nice. which data structures contributed to the heap usage. Is it mostly hashmap dictionary?

[GitHub] [incubator-pinot] xiaohui-sun merged pull request #4032: Fail pipeline all windows failed

2019-03-29 Thread GitBox
xiaohui-sun merged pull request #4032: Fail pipeline all windows failed URL: https://github.com/apache/incubator-pinot/pull/4032 This is an automated message from the Apache Git Service. To respond to the message, please log

[incubator-pinot] branch master updated: Fail pipeline all windows failed (#4032)

2019-03-29 Thread xhsun
This is an automated email from the ASF dual-hosted git repository. xhsun pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 334b918 Fail pipeline all windows faile

[GitHub] [incubator-pinot] xiaohui-sun commented on a change in pull request #4032: Fail pipeline all windows failed

2019-03-29 Thread GitBox
xiaohui-sun commented on a change in pull request #4032: Fail pipeline all windows failed URL: https://github.com/apache/incubator-pinot/pull/4032#discussion_r270558947 ## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/wrapper/AnomalyDetectorWr

[GitHub] [incubator-pinot] mcvsubbu opened a new issue #4036: Reduce heap usage when building realtime segments

2019-03-29 Thread GitBox
mcvsubbu opened a new issue #4036: Reduce heap usage when building realtime segments URL: https://github.com/apache/incubator-pinot/issues/4036 Reducing heap usage while building completed segments. Currently, the segment builder is designed to read incoming data row by row, and build dic

[GitHub] [incubator-pinot] mcvsubbu opened a new issue #4035: Need a tool to display realtime status of a table on a server

2019-03-29 Thread GitBox
mcvsubbu opened a new issue #4035: Need a tool to display realtime status of a table on a server URL: https://github.com/apache/incubator-pinot/issues/4035 Useful to have a pinot-admin tool that answers questions like: What does the zk metadata say about consuming segments? What are

[GitHub] [incubator-pinot] mcvsubbu opened a new issue #4034: Support variable byte no dictionary columns in Consuming segments

2019-03-29 Thread GitBox
mcvsubbu opened a new issue #4034: Support variable byte no dictionary columns in Consuming segments URL: https://github.com/apache/incubator-pinot/issues/4034 In realtime consuming segemnts, we don't support STRING or BYTES data type. We should be able to add it using the class MutableOff

[GitHub] [incubator-pinot] jihaozh opened a new pull request #4033: [TE] do not automatically onboard millisecond level dataset

2019-03-29 Thread GitBox
jihaozh opened a new pull request #4033: [TE] do not automatically onboard millisecond level dataset URL: https://github.com/apache/incubator-pinot/pull/4033 Do not automatically onboard millisecond level dataset. Onboard it as a minute-level instead to prevent it from taking too much memo

[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #4032: Fail pipeline all windows failed

2019-03-29 Thread GitBox
jihaozh commented on a change in pull request #4032: Fail pipeline all windows failed URL: https://github.com/apache/incubator-pinot/pull/4032#discussion_r270536527 ## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/wrapper/AnomalyDetectorWrappe

[GitHub] [incubator-pinot] xiaohui-sun opened a new pull request #4032: Fail pipeline all windows failed

2019-03-29 Thread GitBox
xiaohui-sun opened a new pull request #4032: Fail pipeline all windows failed URL: https://github.com/apache/incubator-pinot/pull/4032 1. Fail pipeline if all detection windows failed. 2. Set default cache warm up to 0 to fix the epoch time granularity issue. 3. Add more logs for merge

[GitHub] [incubator-pinot] xiaohui-sun merged pull request #4030: [TE] set max detection task window to 7 days

2019-03-29 Thread GitBox
xiaohui-sun merged pull request #4030: [TE] set max detection task window to 7 days URL: https://github.com/apache/incubator-pinot/pull/4030 This is an automated message from the Apache Git Service. To respond to the message

[incubator-pinot] branch master updated: [TE] set max detection task window to 7 days (#4030)

2019-03-29 Thread xhsun
This is an automated email from the ASF dual-hosted git repository. xhsun pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 3cd2082 [TE] set max detection task win

[GitHub] [incubator-pinot] sunithabeeram opened a new issue #4031: Define annotations to inform InterfaceAudience and Stability

2019-03-29 Thread GitBox
sunithabeeram opened a new issue #4031: Define annotations to inform InterfaceAudience and Stability URL: https://github.com/apache/incubator-pinot/issues/4031 Many Apache open-source projects (Hadoop, Kafka) provide annotations for interfaces around the audience and stability. We should h

[GitHub] [incubator-pinot] xiaohui-sun opened a new pull request #4030: [TE] set max detection task window to 7 days

2019-03-29 Thread GitBox
xiaohui-sun opened a new pull request #4030: [TE] set max detection task window to 7 days URL: https://github.com/apache/incubator-pinot/pull/4030 1. Set max detection task window to 7 days. 2. Move duplicate check to checkTaskAlreadyRun(). --

[GitHub] [incubator-pinot] sunithabeeram commented on a change in pull request #4025: Extend stream interfaces to expose message metadata like ingestion timestamp

2019-03-29 Thread GitBox
sunithabeeram commented on a change in pull request #4025: Extend stream interfaces to expose message metadata like ingestion timestamp URL: https://github.com/apache/incubator-pinot/pull/4025#discussion_r270425169 ## File path: pinot-core/src/main/java/org/apache/pinot/core/indexs

[GitHub] [incubator-pinot] sunithabeeram commented on issue #4025: Extend stream interfaces to expose message metadata like ingestion timestamp

2019-03-29 Thread GitBox
sunithabeeram commented on issue #4025: Extend stream interfaces to expose message metadata like ingestion timestamp URL: https://github.com/apache/incubator-pinot/pull/4025#issuecomment-478012157 >@mcvsubbu it’s about changing the indexsegment interface which now depends on stream package

[GitHub] [incubator-pinot] sunithabeeram commented on a change in pull request #4025: Extend stream interfaces to expose message metadata like ingestion timestamp

2019-03-29 Thread GitBox
sunithabeeram commented on a change in pull request #4025: Extend stream interfaces to expose message metadata like ingestion timestamp URL: https://github.com/apache/incubator-pinot/pull/4025#discussion_r270425135 ## File path: pinot-core/src/main/java/org/apache/pinot/core/realti