[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4243: Add support for passing headers in pinot client

codecov-io edited a comment on issue #4243: Add support for passing headers in pinot client URL: https://github.com/apache/incubator-pinot/pull/4243#issuecomment-496501504 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4243?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] jitendratheta commented on a change in pull request #4243: Add support for passing headers in pinot client

jitendratheta commented on a change in pull request #4243: Add support for passing headers in pinot client URL: https://github.com/apache/incubator-pinot/pull/4243#discussion_r288864053 ## File path: pinot-api/src/main/java/org/apache/pinot/client/PinotClientTransportFactory.java

[GitHub] [incubator-pinot] jitendratheta commented on a change in pull request #4243: Add support for passing headers in pinot client

jitendratheta commented on a change in pull request #4243: Add support for passing headers in pinot client URL: https://github.com/apache/incubator-pinot/pull/4243#discussion_r288864053 ## File path: pinot-api/src/main/java/org/apache/pinot/client/PinotClientTransportFactory.java

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4257: Unify controller base url in integration test

codecov-io edited a comment on issue #4257: Unify controller base url in integration test URL: https://github.com/apache/incubator-pinot/pull/4257#issuecomment-497194131 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4257?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] codecov-io commented on issue #4253: Add pre-compute Hadoop job

codecov-io commented on issue #4253: Add pre-compute Hadoop job URL: https://github.com/apache/incubator-pinot/pull/4253#issuecomment-497205230 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4253?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4257: Unify controller base url in integration test

Jackie-Jiang commented on a change in pull request #4257: Unify controller base url in integration test URL: https://github.com/apache/incubator-pinot/pull/4257#discussion_r288857493 ## File path: pinot-controller/src/test/java/org/apache/pinot/controller/helix/ControllerTest.java

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4257: Unify controller base url in integration test

jackjlli commented on a change in pull request #4257: Unify controller base url in integration test URL: https://github.com/apache/incubator-pinot/pull/4257#discussion_r288856335 ## File path:

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4257: Unify controller base url in integration test

jackjlli commented on a change in pull request #4257: Unify controller base url in integration test URL: https://github.com/apache/incubator-pinot/pull/4257#discussion_r288856315 ## File path:

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4257: Unify controller base url in integration test

jackjlli commented on a change in pull request #4257: Unify controller base url in integration test URL: https://github.com/apache/incubator-pinot/pull/4257#discussion_r288856303 ## File path: .gitignore ## @@ -20,6 +20,7 @@ pinot-dashboard/config.yml

[GitHub] [incubator-pinot] codecov-io commented on issue #4257: Unify controller base url in integration test

codecov-io commented on issue #4257: Unify controller base url in integration test URL: https://github.com/apache/incubator-pinot/pull/4257#issuecomment-497194131 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4257?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] kishoreg commented on issue #4230: NULL value support for all data types

kishoreg commented on issue #4230: NULL value support for all data types URL: https://github.com/apache/incubator-pinot/issues/4230#issuecomment-497193420 @Jackie-Jiang yes. Also, you logged an issue to document the behavior of default value #4188. Having that will definitely

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4257: Unify controller base url in integration test

Jackie-Jiang commented on a change in pull request #4257: Unify controller base url in integration test URL: https://github.com/apache/incubator-pinot/pull/4257#discussion_r288847396 ## File path:

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4257: Unify controller base url in integration test

Jackie-Jiang commented on a change in pull request #4257: Unify controller base url in integration test URL: https://github.com/apache/incubator-pinot/pull/4257#discussion_r288847237 ## File path: .gitignore ## @@ -20,6 +20,7 @@ pinot-dashboard/config.yml

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4257: Unify controller base url in integration test

Jackie-Jiang commented on a change in pull request #4257: Unify controller base url in integration test URL: https://github.com/apache/incubator-pinot/pull/4257#discussion_r288847477 ## File path:

[GitHub] [incubator-pinot] kishoreg commented on issue #4230: NULL value support for all data types

kishoreg commented on issue #4230: NULL value support for all data types URL: https://github.com/apache/incubator-pinot/issues/4230#issuecomment-497186980 @mcvsubbu there is absolutely no change in the existing behavior on what gets stored in the forward index in the segment. null values

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4218: Add RealtimeConsumptionCatchupServiceCallback

mcvsubbu commented on a change in pull request #4218: Add RealtimeConsumptionCatchupServiceCallback URL: https://github.com/apache/incubator-pinot/pull/4218#discussion_r288842354 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/HelixBrokerStarter.java

[GitHub] [incubator-pinot] mcvsubbu commented on issue #4230: NULL value support for all data types

mcvsubbu commented on issue #4230: NULL value support for all data types URL: https://github.com/apache/incubator-pinot/issues/4230#issuecomment-497181413 > @mcvsubbu is there an issue if the presence vector is always built? No issue, just that we change the behavior from what people

[GitHub] [incubator-pinot] mcvsubbu commented on issue #4230: NULL value support for all data types

mcvsubbu commented on issue #4230: NULL value support for all data types URL: https://github.com/apache/incubator-pinot/issues/4230#issuecomment-497180684 Exactly what I was thinking. However, don't we need a switch to decide whether to use presence vector or retain current behavior? Or,

[GitHub] [incubator-pinot] kishoreg commented on issue #4230: NULL value support for all data types

kishoreg commented on issue #4230: NULL value support for all data types URL: https://github.com/apache/incubator-pinot/issues/4230#issuecomment-497173351 @mcvsubbu Presence vector is nothing a but a single roaring bitmap for each column. When we ingest a row, we set the corresponding bit

[GitHub] [incubator-pinot] sunithabeeram commented on issue #4230: NULL value support for all data types

sunithabeeram commented on issue #4230: NULL value support for all data types URL: https://github.com/apache/incubator-pinot/issues/4230#issuecomment-497168781 @mcvsubbu is there an issue if the presence vector is always built? If I understand things correctly, I believe the current

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4218: Add RealtimeConsumptionCatchupServiceCallback

codecov-io edited a comment on issue #4218: Add RealtimeConsumptionCatchupServiceCallback URL: https://github.com/apache/incubator-pinot/pull/4218#issuecomment-493596443 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4218?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] npawar commented on a change in pull request #4218: Add RealtimeConsumptionCatchupServiceCallback

npawar commented on a change in pull request #4218: Add RealtimeConsumptionCatchupServiceCallback URL: https://github.com/apache/incubator-pinot/pull/4218#discussion_r288824009 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/ServiceStatus.java ##

[incubator-pinot] branch helix_084_release_branch deleted (was 1ebcfd9)

This is an automated email from the ASF dual-hosted git repository. nehapawar pushed a change to branch helix_084_release_branch in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. was 1ebcfd9 Release branch only:Upgrade helix to 0.8.4 for release This change

[GitHub] [incubator-pinot] mcvsubbu commented on issue #4230: NULL value support for all data types

mcvsubbu commented on issue #4230: NULL value support for all data types URL: https://github.com/apache/incubator-pinot/issues/4230#issuecomment-497154254 consuming segments will need a mutable presence vector. While committing the segment to persistent store, the presence vector should

[GitHub] [incubator-pinot] harleyjj opened a new pull request #4256: [TE] frontend - harleyjj/edit-alert - remove unnecessary flag for noE…

harleyjj opened a new pull request #4256: [TE] frontend - harleyjj/edit-alert - remove unnecessary flag for noE… URL: https://github.com/apache/incubator-pinot/pull/4256 …xistingSubscriptionGroup This is an automated message

[GitHub] [incubator-pinot] fredxfred edited a comment on issue #3675: Sslbranch

fredxfred edited a comment on issue #3675: Sslbranch URL: https://github.com/apache/incubator-pinot/pull/3675#issuecomment-497145527 Hi, yes I will work on splitting the PRs and addressing the code review soon (sometime in the next few days)

[GitHub] [incubator-pinot] fredxfred commented on issue #3675: Sslbranch

fredxfred commented on issue #3675: Sslbranch URL: https://github.com/apache/incubator-pinot/pull/3675#issuecomment-497145527 Hi, yes I will work on splitting the PRs and addressing the code review soon. This is an automated

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4047: Create leadControllerResource in helix cluster

mcvsubbu commented on a change in pull request #4047: Create leadControllerResource in helix cluster URL: https://github.com/apache/incubator-pinot/pull/4047#discussion_r288787662 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/CommonConstants.java

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4047: Create leadControllerResource in helix cluster

mcvsubbu commented on a change in pull request #4047: Create leadControllerResource in helix cluster URL: https://github.com/apache/incubator-pinot/pull/4047#discussion_r288792490 ## File path:

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4047: Create leadControllerResource in helix cluster

mcvsubbu commented on a change in pull request #4047: Create leadControllerResource in helix cluster URL: https://github.com/apache/incubator-pinot/pull/4047#discussion_r288792427 ## File path:

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4047: Create leadControllerResource in helix cluster

mcvsubbu commented on a change in pull request #4047: Create leadControllerResource in helix cluster URL: https://github.com/apache/incubator-pinot/pull/4047#discussion_r288807069 ## File path:

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4047: Create leadControllerResource in helix cluster

mcvsubbu commented on a change in pull request #4047: Create leadControllerResource in helix cluster URL: https://github.com/apache/incubator-pinot/pull/4047#discussion_r288793349 ## File path:

[GitHub] [incubator-pinot] kishoreg commented on issue #4230: NULL value support for all data types

kishoreg commented on issue #4230: NULL value support for all data types URL: https://github.com/apache/incubator-pinot/issues/4230#issuecomment-497144494 Good suggestions @mayankshriv @sunithabeeram. Yes, we can filter out NULLs for metrics automatically if we see the presence

[GitHub] [incubator-pinot] mayankshriv commented on issue #4230: NULL value support for all data types

mayankshriv commented on issue #4230: NULL value support for all data types URL: https://github.com/apache/incubator-pinot/issues/4230#issuecomment-497141988 @kishoreg for 4: If it is safe to assume that users would always want to filter out the NULL for metrics, why not implicitly

[GitHub] [incubator-pinot] sunithabeeram commented on issue #4230: NULL value support for all data types

sunithabeeram commented on issue #4230: NULL value support for all data types URL: https://github.com/apache/incubator-pinot/issues/4230#issuecomment-497139881 Interacting through the issue is a bit limiting as its hard to reference comments appropriately. Will try my best. For #1

[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #4250: SoC - Separate out Tuning from Translator

jihaozh commented on a change in pull request #4250: SoC - Separate out Tuning from Translator URL: https://github.com/apache/incubator-pinot/pull/4250#discussion_r288792879 ## File path:

[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #4250: SoC - Separate out Tuning from Translator

akshayrai commented on a change in pull request #4250: SoC - Separate out Tuning from Translator URL: https://github.com/apache/incubator-pinot/pull/4250#discussion_r288790759 ## File path:

[incubator-pinot] branch cleanup-autogen-files updated (5bd5f8e -> 18f21d9)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch cleanup-autogen-files in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 5bd5f8e update travis add 18f21d9 update travis This update added new revisions

[GitHub] [incubator-pinot] kishoreg commented on issue #4230: NULL value support for all data types

kishoreg commented on issue #4230: NULL value support for all data types URL: https://github.com/apache/incubator-pinot/issues/4230#issuecomment-497127167 Can't think of a case where users would NOT want to filter out NULL for metrics. I feel our first goal should be able to give the

[incubator-pinot] branch cleanup-autogen-files updated (c50ff42 -> 5bd5f8e)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch cleanup-autogen-files in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. omit c50ff42 update travis add 5bd5f8e update travis This update added new revisions

[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #4250: SoC - Separate out Tuning from Translator

jihaozh commented on a change in pull request #4250: SoC - Separate out Tuning from Translator URL: https://github.com/apache/incubator-pinot/pull/4250#discussion_r288785789 ## File path:

[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #4253: Add pre-compute Hadoop job

Jackie-Jiang commented on issue #4253: Add pre-compute Hadoop job URL: https://github.com/apache/incubator-pinot/pull/4253#issuecomment-497123165 @kishoreg We never convert segment generation config to table config, it's always from table config to segment generation config in order to

[GitHub] [incubator-pinot] xiaohui-sun commented on a change in pull request #4250: SoC - Separate out Tuning from Translator

xiaohui-sun commented on a change in pull request #4250: SoC - Separate out Tuning from Translator URL: https://github.com/apache/incubator-pinot/pull/4250#discussion_r288782520 ## File path:

[incubator-pinot] branch cleanup-autogen-files updated (3ab069b -> c50ff42)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch cleanup-autogen-files in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. omit 3ab069b update travis add c50ff42 update travis This update added new revisions

[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #4250: SoC - Separate out Tuning from Translator

akshayrai commented on a change in pull request #4250: SoC - Separate out Tuning from Translator URL: https://github.com/apache/incubator-pinot/pull/4250#discussion_r288760747 ## File path:

[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #4250: SoC - Separate out Tuning from Translator

akshayrai commented on a change in pull request #4250: SoC - Separate out Tuning from Translator URL: https://github.com/apache/incubator-pinot/pull/4250#discussion_r288762521 ## File path:

[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #4250: SoC - Separate out Tuning from Translator

akshayrai commented on a change in pull request #4250: SoC - Separate out Tuning from Translator URL: https://github.com/apache/incubator-pinot/pull/4250#discussion_r288775147 ## File path:

[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #4250: SoC - Separate out Tuning from Translator

akshayrai commented on a change in pull request #4250: SoC - Separate out Tuning from Translator URL: https://github.com/apache/incubator-pinot/pull/4250#discussion_r288762384 ## File path:

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4218: Add RealtimeConsumptionCatchupServiceCallback

mcvsubbu commented on a change in pull request #4218: Add RealtimeConsumptionCatchupServiceCallback URL: https://github.com/apache/incubator-pinot/pull/4218#discussion_r288774368 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/ServiceStatus.java ##

[incubator-pinot] branch cleanup-autogen-files updated (8b9cdaf -> 3ab069b)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch cleanup-autogen-files in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 8b9cdaf Update doc for thrift executable add 3ab069b update travis No new revisions

[GitHub] [incubator-pinot] mayankshriv commented on issue #4230: NULL value support for all data types

mayankshriv commented on issue #4230: NULL value support for all data types URL: https://github.com/apache/incubator-pinot/issues/4230#issuecomment-497112523 For 4: Is there a reason where users would not want to filter out NULL values for metrics? With default value of 0 for metrics,

[GitHub] [incubator-pinot] fx19880617 commented on issue #3723: Remove auto-gen class files that were checked-in

fx19880617 commented on issue #3723: Remove auto-gen class files that were checked-in URL: https://github.com/apache/incubator-pinot/pull/3723#issuecomment-497112465 Updated PR. You can run `mvn install package -DskipTests -Pbin-dist -Dthrift.executable=$(which thrift)`, if thrift

[incubator-pinot] branch cleanup-autogen-files updated (e0c2aa7 -> 8b9cdaf)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch cleanup-autogen-files in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from e0c2aa7 make thrift executable configurable add 8b9cdaf Update doc for thrift

[incubator-pinot] branch cleanup-autogen-files updated (3522e64 -> e0c2aa7)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch cleanup-autogen-files in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 3522e64 Address comments. Make default no profile for building thrift add e0c2aa7

[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #4246: [TE] Cube algorithm for ratio metrics

jihaozh commented on a change in pull request #4246: [TE] Cube algorithm for ratio metrics URL: https://github.com/apache/incubator-pinot/pull/4246#discussion_r288763065 ## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/cube/summary/Summary.java

[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #4246: [TE] Cube algorithm for ratio metrics

jihaozh commented on a change in pull request #4246: [TE] Cube algorithm for ratio metrics URL: https://github.com/apache/incubator-pinot/pull/4246#discussion_r288763834 ## File path:

[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #4246: [TE] Cube algorithm for ratio metrics

jihaozh commented on a change in pull request #4246: [TE] Cube algorithm for ratio metrics URL: https://github.com/apache/incubator-pinot/pull/4246#discussion_r288764666 ## File path:

[GitHub] [incubator-pinot] xiaohui-sun merged pull request #4238: [TE] frontend - harleyjj/application - redirect http to https

xiaohui-sun merged pull request #4238: [TE] frontend - harleyjj/application - redirect http to https URL: https://github.com/apache/incubator-pinot/pull/4238 This is an automated message from the Apache Git Service. To

[incubator-pinot] branch master updated: [TE] frontend - harleyjj/application - redirect http to https (#4238)

This is an automated email from the ASF dual-hosted git repository. xhsun pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 3ce335a [TE] frontend -

[incubator-pinot] branch master updated: [TE] Change process timeout to 2 minutes (#4255)

This is an automated email from the ASF dual-hosted git repository. xhsun pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new be62932 [TE] Change process timeout to

[GitHub] [incubator-pinot] xiaohui-sun merged pull request #4255: [TE] Change process timeout to 2 minutes

xiaohui-sun merged pull request #4255: [TE] Change process timeout to 2 minutes URL: https://github.com/apache/incubator-pinot/pull/4255 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-pinot] xiaohui-sun opened a new pull request #4255: [TE] Change process timeout to 2 minutes

xiaohui-sun opened a new pull request #4255: [TE] Change process timeout to 2 minutes URL: https://github.com/apache/incubator-pinot/pull/4255 Since the phantomJS process is started from a separate thread and this thread has a timeout of 3 minutes. Need to reduce the phantomJS process

[GitHub] [incubator-pinot] mcvsubbu commented on issue #3675: Sslbranch

mcvsubbu commented on issue #3675: Sslbranch URL: https://github.com/apache/incubator-pinot/pull/3675#issuecomment-497042930 Can you split this into two PRs? The broker one should be relatively simple, so let us get that out first.

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #3675: Sslbranch

mcvsubbu commented on a change in pull request #3675: Sslbranch URL: https://github.com/apache/incubator-pinot/pull/3675#discussion_r288693600 ## File path: pinot-controller/src/main/java/com/linkedin/pinot/controller/api/resources/PqlQueryResource.java ## @@ -108,32

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #3675: Sslbranch

mcvsubbu commented on a change in pull request #3675: Sslbranch URL: https://github.com/apache/incubator-pinot/pull/3675#discussion_r288689425 ## File path: pinot-controller/src/main/java/com/linkedin/pinot/controller/ControllerStarter.java ## @@ -244,15 +264,39 @@

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #3675: Sslbranch

mcvsubbu commented on a change in pull request #3675: Sslbranch URL: https://github.com/apache/incubator-pinot/pull/3675#discussion_r288685551 ## File path: pinot-broker/src/test/java/com/linkedin/pinot/broker/broker/HelixBrokerStarterTest.java ## @@ -76,7 +76,7 @@ public

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #3675: Sslbranch

mcvsubbu commented on a change in pull request #3675: Sslbranch URL: https://github.com/apache/incubator-pinot/pull/3675#discussion_r288681543 ## File path: pinot-broker/src/main/java/com/linkedin/pinot/broker/broker/BrokerAdminApiApplication.java ## @@ -70,7 +98,12 @@

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #3675: Sslbranch

mcvsubbu commented on a change in pull request #3675: Sslbranch URL: https://github.com/apache/incubator-pinot/pull/3675#discussion_r288681355 ## File path: pinot-broker/src/main/java/com/linkedin/pinot/broker/broker/BrokerAdminApiApplication.java ## @@ -57,10 +65,30 @@

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #3675: Sslbranch

mcvsubbu commented on a change in pull request #3675: Sslbranch URL: https://github.com/apache/incubator-pinot/pull/3675#discussion_r288692251 ## File path: pinot-controller/src/main/java/com/linkedin/pinot/controller/api/resources/PqlQueryResource.java ## @@ -108,32

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #3675: Sslbranch

mcvsubbu commented on a change in pull request #3675: Sslbranch URL: https://github.com/apache/incubator-pinot/pull/3675#discussion_r288688102 ## File path: pinot-controller/src/main/java/com/linkedin/pinot/controller/ControllerConf.java ## @@ -270,6 +333,14 @@ public

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #3675: Sslbranch

mcvsubbu commented on a change in pull request #3675: Sslbranch URL: https://github.com/apache/incubator-pinot/pull/3675#discussion_r288691507 ## File path: pinot-controller/src/main/java/com/linkedin/pinot/controller/api/resources/PqlQueryResource.java ## @@ -108,32

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #3675: Sslbranch

mcvsubbu commented on a change in pull request #3675: Sslbranch URL: https://github.com/apache/incubator-pinot/pull/3675#discussion_r288693041 ## File path: pinot-controller/src/main/java/com/linkedin/pinot/controller/ControllerConf.java ## @@ -200,12 +207,64 @@ public

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #3675: Sslbranch

mcvsubbu commented on a change in pull request #3675: Sslbranch URL: https://github.com/apache/incubator-pinot/pull/3675#discussion_r288688917 ## File path: pinot-controller/src/main/java/com/linkedin/pinot/controller/ControllerStarter.java ## @@ -97,7 +98,24 @@

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #3675: Sslbranch

mcvsubbu commented on a change in pull request #3675: Sslbranch URL: https://github.com/apache/incubator-pinot/pull/3675#discussion_r288693910 ## File path: pinot-controller/src/main/java/com/linkedin/pinot/controller/api/resources/PqlQueryResource.java ## @@ -108,32

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #3675: Sslbranch

mcvsubbu commented on a change in pull request #3675: Sslbranch URL: https://github.com/apache/incubator-pinot/pull/3675#discussion_r288680489 ## File path: pinot-broker/src/main/java/com/linkedin/pinot/broker/broker/BrokerAdminApiApplication.java ## @@ -57,10 +65,30 @@

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #3675: Sslbranch

mcvsubbu commented on a change in pull request #3675: Sslbranch URL: https://github.com/apache/incubator-pinot/pull/3675#discussion_r288687574 ## File path: pinot-controller/src/main/java/com/linkedin/pinot/controller/ControllerConf.java ## @@ -200,12 +207,64 @@ public

[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #4250: SoC - Separate out Tuning from Translator

jihaozh commented on a change in pull request #4250: SoC - Separate out Tuning from Translator URL: https://github.com/apache/incubator-pinot/pull/4250#discussion_r288686323 ## File path:

[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #4250: SoC - Separate out Tuning from Translator

jihaozh commented on a change in pull request #4250: SoC - Separate out Tuning from Translator URL: https://github.com/apache/incubator-pinot/pull/4250#discussion_r288332301 ## File path:

[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #4250: SoC - Separate out Tuning from Translator

jihaozh commented on a change in pull request #4250: SoC - Separate out Tuning from Translator URL: https://github.com/apache/incubator-pinot/pull/4250#discussion_r288683060 ## File path:

[GitHub] [incubator-pinot] snleee removed a comment on issue #3723: Remove auto-gen class files that were checked-in

snleee removed a comment on issue #3723: Remove auto-gen class files that were checked-in URL: https://github.com/apache/incubator-pinot/pull/3723#issuecomment-497030557 @fx19880617 Is it possible to pass the following as a parameter and use the following value as a default value? Moving

[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #4250: SoC - Separate out Tuning from Translator

akshayrai commented on a change in pull request #4250: SoC - Separate out Tuning from Translator URL: https://github.com/apache/incubator-pinot/pull/4250#discussion_r288670294 ## File path:

[GitHub] [incubator-pinot] kishoreg commented on issue #4230: NULL value support for all data types

kishoreg commented on issue #4230: NULL value support for all data types URL: https://github.com/apache/incubator-pinot/issues/4230#issuecomment-497020435 Good questions. 1. We will still return the defaultValues 2. The only reason we need defaultValue is to avoid storing NULL in

[GitHub] [incubator-pinot] jackjlli merged pull request #4235: Add config to disable HLC realtime segment completion

jackjlli merged pull request #4235: Add config to disable HLC realtime segment completion URL: https://github.com/apache/incubator-pinot/pull/4235 This is an automated message from the Apache Git Service. To respond to the

[incubator-pinot] branch master updated: Add config to disable HLC realtime segment completion (#4235)

This is an automated email from the ASF dual-hosted git repository. jlli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 8c8c0ae Add config to disable HLC

[GitHub] [incubator-pinot] mcvsubbu commented on issue #4252: pinot_kafka_0.9.0.1 module

mcvsubbu commented on issue #4252: pinot_kafka_0.9.0.1 module URL: https://github.com/apache/incubator-pinot/pull/4252#issuecomment-497013608 > > > > > What is the plan on the naming for the module for different Kafka version implementation? I think that we should keep one implementation

[GitHub] [incubator-pinot] mayankshriv commented on issue #4230: NULL value support for all data types

mayankshriv commented on issue #4230: NULL value support for all data types URL: https://github.com/apache/incubator-pinot/issues/4230#issuecomment-497012617 A few questions: 1. How do we return NULL in response for selection queries? 2. If we don't change what is stored in the fwd

[GitHub] [incubator-pinot] mcvsubbu commented on issue #3675: Sslbranch

mcvsubbu commented on issue #3675: Sslbranch URL: https://github.com/apache/incubator-pinot/pull/3675#issuecomment-497004402 @fredxfred I missed this again. I will resolve this today. cc: @kishoreg This is an automated

[GitHub] [incubator-pinot] xiaohui-sun commented on a change in pull request #4250: SoC - Separate out Tuning from Translator

xiaohui-sun commented on a change in pull request #4250: SoC - Separate out Tuning from Translator URL: https://github.com/apache/incubator-pinot/pull/4250#discussion_r288647806 ## File path:

[GitHub] [incubator-pinot] xiaohui-sun commented on a change in pull request #4250: SoC - Separate out Tuning from Translator

xiaohui-sun commented on a change in pull request #4250: SoC - Separate out Tuning from Translator URL: https://github.com/apache/incubator-pinot/pull/4250#discussion_r288648096 ## File path:

[GitHub] [incubator-pinot] kishoreg commented on issue #3675: Sslbranch

kishoreg commented on issue #3675: Sslbranch URL: https://github.com/apache/incubator-pinot/pull/3675#issuecomment-497002909 @mcvsubbu Can you take a look at this PR and see if there is anything pending? @fredxfred, can you please rebase this. I think the conflicts are mostly because of

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4243: Add support for passing headers in pinot client

kishoreg commented on a change in pull request #4243: Add support for passing headers in pinot client URL: https://github.com/apache/incubator-pinot/pull/4243#discussion_r288641904 ## File path: pinot-api/src/main/java/org/apache/pinot/client/PinotClientTransportFactory.java

[GitHub] [incubator-pinot] sunithabeeram commented on a change in pull request #4243: Add support for passing headers in pinot client

sunithabeeram commented on a change in pull request #4243: Add support for passing headers in pinot client URL: https://github.com/apache/incubator-pinot/pull/4243#discussion_r288641571 ## File path: pinot-api/src/main/java/org/apache/pinot/client/PinotClientTransportFactory.java

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #4243: Add support for passing headers in pinot client

mayankshriv commented on a change in pull request #4243: Add support for passing headers in pinot client URL: https://github.com/apache/incubator-pinot/pull/4243#discussion_r288616010 ## File path: pinot-api/src/main/java/org/apache/pinot/client/PinotClientTransportFactory.java

[GitHub] [incubator-pinot] sunny209868 commented on issue #4219: Support SQL in Pinot.

sunny209868 commented on issue #4219: Support SQL in Pinot. URL: https://github.com/apache/incubator-pinot/issues/4219#issuecomment-496802595 @kishoreg @Jackie-Jiang ,I am also a pinot user at present. When will this be online? I think it's great and I'm looking forward to it

[GitHub] [incubator-pinot] sunny209868 removed a comment on issue #4219: Support SQL in Pinot.

sunny209868 removed a comment on issue #4219: Support SQL in Pinot. URL: https://github.com/apache/incubator-pinot/issues/4219#issuecomment-493643346 @sunny209868 sorry, I removed the quoted reply That's great @Jackie-Jiang