[GitHub] [incubator-pinot] fx19880617 edited a comment on pull request #5456: Single Quote String Literal for function invoker results

2020-05-27 Thread GitBox
fx19880617 edited a comment on pull request #5456: URL: https://github.com/apache/incubator-pinot/pull/5456#issuecomment-635100955 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-pinot] fx19880617 commented on pull request #5456: Single Quote String Literal for function invoker results

2020-05-27 Thread GitBox
fx19880617 commented on pull request #5456: URL: https://github.com/apache/incubator-pinot/pull/5456#issuecomment-635100955 > I think the real issue is BrokerRequest is incapable of storing expressions correctly, it converts them to String. This seems like a temp workaround (approving it

[GitHub] [incubator-pinot] kishoreg merged pull request #5456: Single Quote String Literal for function invoker results

2020-05-27 Thread GitBox
kishoreg merged pull request #5456: URL: https://github.com/apache/incubator-pinot/pull/5456 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[incubator-pinot] branch master updated: Single Quote String Literal for function invoker results (#5456)

2020-05-27 Thread kishoreg
This is an automated email from the ASF dual-hosted git repository. kishoreg pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 7f10c5c Single Quote String Literal

[GitHub] [incubator-pinot] mayankshriv edited a comment on pull request #5456: Single Quote String Literal for function invoker results

2020-05-27 Thread GitBox
mayankshriv edited a comment on pull request #5456: URL: https://github.com/apache/incubator-pinot/pull/5456#issuecomment-635099149 I think the real issue is BrokerRequest is incapable of storing expressions correctly, it converts them to String. This seems like a temp workaround

[GitHub] [incubator-pinot] mayankshriv commented on pull request #5456: Single Quote String Literal for function invoker results

2020-05-27 Thread GitBox
mayankshriv commented on pull request #5456: URL: https://github.com/apache/incubator-pinot/pull/5456#issuecomment-635099149 I think the real issue is BrokerRequest is incapable of storing expressions correctly, it converts them to String. This seems like a temp workaround (approving it

[incubator-pinot] tag release-0.4.0 created (now 3f81191)

2020-05-27 Thread haibow
This is an automated email from the ASF dual-hosted git repository. haibow pushed a change to tag release-0.4.0 in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 3f81191 (commit) No new revisions were added by this update.

[GitHub] [incubator-pinot] akshayrai merged pull request #5458: [TE] clean up some code - moved task creation methods under util

2020-05-27 Thread GitBox
akshayrai merged pull request #5458: URL: https://github.com/apache/incubator-pinot/pull/5458 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-pinot] branch master updated (4988d72 -> b6cb44c)

2020-05-27 Thread akshayrai09
This is an automated email from the ASF dual-hosted git repository. akshayrai09 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 4988d72 [TE] add back frontend as submodule (#5457) add b6cb44c [TE] clean up somce code and

[GitHub] [incubator-pinot] vincentchenjl commented on a change in pull request #5435: [TE] clean up decprecated/unused code

2020-05-27 Thread GitBox
vincentchenjl commented on a change in pull request #5435: URL: https://github.com/apache/incubator-pinot/pull/5435#discussion_r431529266 ## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/dashboard/resources/AnomalyResource.java ## @@ -101,21

[GitHub] [incubator-pinot] vincentchenjl commented on a change in pull request #5435: [TE] clean up decprecated/unused code

2020-05-27 Thread GitBox
vincentchenjl commented on a change in pull request #5435: URL: https://github.com/apache/incubator-pinot/pull/5435#discussion_r431528717 ## File path: thirdeye/thirdeye-pinot/src/test/java/org/apache/pinot/thirdeye/datalayer/DaoTestUtils.java ## @@ -275,22 +273,6 @@ public

[GitHub] [incubator-pinot] vincentchenjl commented on a change in pull request #5435: [TE] clean up decprecated/unused code

2020-05-27 Thread GitBox
vincentchenjl commented on a change in pull request #5435: URL: https://github.com/apache/incubator-pinot/pull/5435#discussion_r431528040 ## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/dashboard/resources/AnomalyResource.java ## @@ -101,21

[GitHub] [incubator-pinot] vincentchenjl commented on a change in pull request #5435: [TE] clean up decprecated/unused code

2020-05-27 Thread GitBox
vincentchenjl commented on a change in pull request #5435: URL: https://github.com/apache/incubator-pinot/pull/5435#discussion_r431527731 ## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/dashboard/ThirdEyeDashboardApplication.java ## @@ -160,14

[GitHub] [incubator-pinot] vincentchenjl commented on a change in pull request #5435: [TE] clean up decprecated/unused code

2020-05-27 Thread GitBox
vincentchenjl commented on a change in pull request #5435: URL: https://github.com/apache/incubator-pinot/pull/5435#discussion_r431526938 ## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/dashboard/ThirdEyeDashboardApplication.java ## @@ -160,14

[GitHub] [incubator-pinot] vincentchenjl commented on a change in pull request #5435: [TE] clean up decprecated/unused code

2020-05-27 Thread GitBox
vincentchenjl commented on a change in pull request #5435: URL: https://github.com/apache/incubator-pinot/pull/5435#discussion_r431522638 ## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/anomaly/task/TaskConstants.java ## @@ -26,15 +26,8 @@

[GitHub] [incubator-pinot] Jackie-Jiang opened a new pull request #5459: [Cleanup] Merge RealtimeSegmentOnlineOfflineStateModel and SegmentOnlineOfflineStateModel in CommonConstants

2020-05-27 Thread GitBox
Jackie-Jiang opened a new pull request #5459: URL: https://github.com/apache/incubator-pinot/pull/5459 We only have one SegmentOnlineOfflineStateModel, so there is no value keeping both of them ## Description Add a description of your PR here. A good description should

[GitHub] [incubator-pinot] akshayrai opened a new pull request #5458: [TE] clean up some code and disable sla alerts till we have the ramp feature

2020-05-27 Thread GitBox
akshayrai opened a new pull request #5458: URL: https://github.com/apache/incubator-pinot/pull/5458 * Move all the task creation methods under TaskUtils * Disable SLA alerts and wait till the experiment/ramp feature

[GitHub] [incubator-pinot] akshayrai merged pull request #5457: [TE] add back frontend as submodule

2020-05-27 Thread GitBox
akshayrai merged pull request #5457: URL: https://github.com/apache/incubator-pinot/pull/5457 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-pinot] branch master updated (d8ea89c -> 4988d72)

2020-05-27 Thread akshayrai09
This is an automated email from the ASF dual-hosted git repository. akshayrai09 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from d8ea89c Create PULL_REQUEST_TEMPLATE.md (#5345) add 4988d72 [TE] add back frontend as submodule

[GitHub] [incubator-pinot] vincentchenjl opened a new pull request #5457: [TE] add back frontend as submodule

2020-05-27 Thread GitBox
vincentchenjl opened a new pull request #5457: URL: https://github.com/apache/incubator-pinot/pull/5457 This PR is to achieve the following items. - Fix open source build by adding back frontend as submodule. - Ensure that frontend is built based on packages from open source NPM.

[GitHub] [incubator-pinot] mcvsubbu merged pull request #5345: Create PULL_REQUEST_TEMPLATE.md

2020-05-27 Thread GitBox
mcvsubbu merged pull request #5345: URL: https://github.com/apache/incubator-pinot/pull/5345 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[incubator-pinot] branch master updated (cee2b23 -> d8ea89c)

2020-05-27 Thread mcvsubbu
This is an automated email from the ASF dual-hosted git repository. mcvsubbu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from cee2b23 [TE] add mock events loader to pinot-thirdeye docker defaults (#5454) add d8ea89c Create

[GitHub] [incubator-pinot] fx19880617 commented on pull request #5456: Single Quote String Literal for function invoker results

2020-05-27 Thread GitBox
fx19880617 commented on pull request #5456: URL: https://github.com/apache/incubator-pinot/pull/5456#issuecomment-634954131 > looks like this fix is a workaround to hide the actual problem in transform function? > > What would be the exception/error in transformfunction without this

[GitHub] [incubator-pinot] kishoreg commented on pull request #5456: Single Quote String Literal for function invoker results

2020-05-27 Thread GitBox
kishoreg commented on pull request #5456: URL: https://github.com/apache/incubator-pinot/pull/5456#issuecomment-634948647 looks like this fix is a workaround to hide the actual problem in transform function? What would be the exception/error in transformfunction without this fix

[GitHub] [incubator-pinot] fx19880617 opened a new pull request #5456: Single Quote String Literal for function invoker results

2020-05-27 Thread GitBox
fx19880617 opened a new pull request #5456: URL: https://github.com/apache/incubator-pinot/pull/5456 This fix the issue that of function invoker string output breaks query syntax. E.g. query: `SELECT toDateTime(now(), '-MM-dd z') FROM mytable` becomes: `SELECT 2020-05-27 UTC

[incubator-pinot] branch single_quote_string_literal_for_function_invoke_result created (now 948062a)

2020-05-27 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch single_quote_string_literal_for_function_invoke_result in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 948062a Single Quote String Literal for function invoker

[incubator-pinot] 01/01: Single Quote String Literal for function invoker results

2020-05-27 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch single_quote_string_literal_for_function_invoke_result in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit 948062aa5f82a2fb508b5f3990e64bd10ccfa553 Author: Xiang Fu

[GitHub] [incubator-pinot] npawar opened a new pull request #5455: Use java.io.tmpdir in KafkaStarterUtils

2020-05-27 Thread GitBox
npawar opened a new pull request #5455: URL: https://github.com/apache/incubator-pinot/pull/5455 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-pinot] branch master updated: [TE] add mock events loader to pinot-thirdeye docker defaults (#5454)

2020-05-27 Thread apucher
This is an automated email from the ASF dual-hosted git repository. apucher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new cee2b23 [TE] add mock events loader

[GitHub] [incubator-pinot] apucher merged pull request #5454: [TE] add mock events loader to pinot-thirdeye docker defaults

2020-05-27 Thread GitBox
apucher merged pull request #5454: URL: https://github.com/apache/incubator-pinot/pull/5454 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[incubator-pinot] branch adding-pr-template updated (ebfad8f -> 7b2b0a8)

2020-05-27 Thread mcvsubbu
This is an automated email from the ASF dual-hosted git repository. mcvsubbu pushed a change to branch adding-pr-template in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from ebfad8f Update PULL_REQUEST_TEMPLATE.md add 7b2b0a8 Update PULL_REQUEST_TEMPLATE.md

[GitHub] [incubator-pinot] apucher opened a new pull request #5454: [TE] add mock events loader to pinot-thirdeye docker defaults

2020-05-27 Thread GitBox
apucher opened a new pull request #5454: URL: https://github.com/apache/incubator-pinot/pull/5454 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-pinot] branch mock-events-for-pinot-thirdeye-docker created (now b218d32)

2020-05-27 Thread apucher
This is an automated email from the ASF dual-hosted git repository. apucher pushed a change to branch mock-events-for-pinot-thirdeye-docker in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at b218d32 [TE] add mock events loader to pinot-thirdeye docker defaults

[incubator-pinot] 01/01: [TE] add mock events loader to pinot-thirdeye docker defaults

2020-05-27 Thread apucher
This is an automated email from the ASF dual-hosted git repository. apucher pushed a commit to branch mock-events-for-pinot-thirdeye-docker in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit b218d32bd4e9731d90c2abfd71e1e0331e2f08cd Author: Alexander Pucher AuthorDate:

[GitHub] [incubator-pinot] npawar closed issue #5269: Add support for protobuf input format

2020-05-27 Thread GitBox
npawar closed issue #5269: URL: https://github.com/apache/incubator-pinot/issues/5269 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[incubator-pinot] branch master updated: Adding support for Protobuf input format (#5293)

2020-05-27 Thread nehapawar
This is an automated email from the ASF dual-hosted git repository. nehapawar pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new b69453e Adding support for

[GitHub] [incubator-pinot] npawar merged pull request #5293: Adding support for Protobuf input format

2020-05-27 Thread GitBox
npawar merged pull request #5293: URL: https://github.com/apache/incubator-pinot/pull/5293 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-pinot] npawar commented on pull request #5293: Adding support for Protobuf input format

2020-05-27 Thread GitBox
npawar commented on pull request #5293: URL: https://github.com/apache/incubator-pinot/pull/5293#issuecomment-634850943 Linking to issue https://github.com/apache/incubator-pinot/issues/5269 This is an automated message from

[incubator-pinot] branch master updated (008be2d -> 3514a17)

2020-05-27 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 008be2d Make Literal transformer return string literals (#5453) add 3514a17 Add PinotServiceManager

[incubator-pinot] branch master updated (008be2d -> 3514a17)

2020-05-27 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 008be2d Make Literal transformer return string literals (#5453) add 3514a17 Add PinotServiceManager

[GitHub] [incubator-pinot] fx19880617 commented on pull request #5266: Add PinotServiceManager to start Pinot components

2020-05-27 Thread GitBox
fx19880617 commented on pull request #5266: URL: https://github.com/apache/incubator-pinot/pull/5266#issuecomment-634823281 > We will fix the incompat at our end. If for some reason we need some changes, we will come back with those. thanks Thanks for taking time to review on this !

[GitHub] [incubator-pinot] fx19880617 merged pull request #5266: Add PinotServiceManager to start Pinot components

2020-05-27 Thread GitBox
fx19880617 merged pull request #5266: URL: https://github.com/apache/incubator-pinot/pull/5266 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-pinot] KKcorps commented on a change in pull request #5293: Adding support for Protobuf input format

2020-05-27 Thread GitBox
KKcorps commented on a change in pull request #5293: URL: https://github.com/apache/incubator-pinot/pull/5293#discussion_r431309682 ## File path: pinot-plugins/pinot-input-format/pinot-protobuf/src/main/java/org/apache/pinot/plugin/inputformat/protobuf/ProtoBufRecordReader.java

[GitHub] [incubator-pinot] jamesyfshao commented on pull request #5394: add callback interface for upsert component

2020-05-27 Thread GitBox
jamesyfshao commented on pull request #5394: URL: https://github.com/apache/incubator-pinot/pull/5394#issuecomment-634800807 @kishoreg @mcvsubbu @Jackie-Jiang appreciated if you guys can take a look at the diff this week when you have time

[GitHub] [incubator-pinot] npawar commented on a change in pull request #5293: Adding support for Protobuf input format

2020-05-27 Thread GitBox
npawar commented on a change in pull request #5293: URL: https://github.com/apache/incubator-pinot/pull/5293#discussion_r431285868 ## File path: pinot-plugins/pinot-input-format/pinot-protobuf/src/main/java/org/apache/pinot/plugin/inputformat/protobuf/ProtoBufRecordReader.java

[GitHub] [incubator-pinot] fx19880617 merged pull request #5453: Make Literal transformer return string literals

2020-05-27 Thread GitBox
fx19880617 merged pull request #5453: URL: https://github.com/apache/incubator-pinot/pull/5453 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-pinot] branch master updated: Make Literal transformer return string literals (#5453)

2020-05-27 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 008be2d Make Literal transformer

[incubator-pinot] annotated tag pinot-0.4.0 updated (fb62e74 -> 22452aa)

2020-05-27 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to annotated tag pinot-0.4.0 in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. *** WARNING: tag pinot-0.4.0 was modified! *** from fb62e74 (commit) to 22452aa (tag)

[incubator-pinot] branch release-0.4.0-rc1 updated: [maven-release-plugin] prepare for next development iteration

2020-05-27 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch release-0.4.0-rc1 in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/release-0.4.0-rc1 by this push: new 3f81191

[incubator-pinot] branch release-0.4.0-rc1 updated: [maven-release-plugin] prepare release pinot-0.4.0

2020-05-27 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch release-0.4.0-rc1 in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/release-0.4.0-rc1 by this push: new fb62e74

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5266: Add PinotServiceManager to start Pinot components

2020-05-27 Thread GitBox
fx19880617 commented on a change in pull request #5266: URL: https://github.com/apache/incubator-pinot/pull/5266#discussion_r430928817 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/ServiceStatus.java ## @@ -43,17 +44,79 @@ */

[incubator-pinot] branch master updated: [TE] fix dockerfile to account for #5428 changes (#5452)

2020-05-27 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new ac443f4 [TE] fix dockerfile to

[GitHub] [incubator-pinot] fx19880617 merged pull request #5452: [TE] fix dockerfile to account for #5428 changes

2020-05-27 Thread GitBox
fx19880617 merged pull request #5452: URL: https://github.com/apache/incubator-pinot/pull/5452 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-pinot] branch fixing_literal_in_selection updated (ca63e41 -> 04c437a)

2020-05-27 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch fixing_literal_in_selection in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard ca63e41 Make Literal transformer return string literals add 04c437a Make

[GitHub] [incubator-pinot] kishoreg commented on pull request #5453: Make Literal transformer return string literals

2020-05-27 Thread GitBox
kishoreg commented on pull request #5453: URL: https://github.com/apache/incubator-pinot/pull/5453#issuecomment-634469047 Add a test case please This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-pinot] fx19880617 opened a new pull request #5453: Make Literal transformer return string literals

2020-05-27 Thread GitBox
fx19880617 opened a new pull request #5453: URL: https://github.com/apache/incubator-pinot/pull/5453 - Let LiteralTransformFunction return strings. - Convert Literal object to string for Selection List This is an

[incubator-pinot] branch fixing_literal_in_selection created (now ca63e41)

2020-05-27 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch fixing_literal_in_selection in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at ca63e41 Make Literal transformer return string literals This branch includes the

[incubator-pinot] 01/01: Make Literal transformer return string literals

2020-05-27 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch fixing_literal_in_selection in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit ca63e41d1ba9f690e12e4d98e2c6078d0b689c0e Author: Xiang Fu AuthorDate: Tue May 26