[GitHub] [incubator-pinot] chenboat commented on pull request #5478: Add a new table config field for peer segment download.

2020-06-01 Thread GitBox
chenboat commented on pull request #5478: URL: https://github.com/apache/incubator-pinot/pull/5478#issuecomment-637276829 > Please add validation code ("Must be http or https") in TableConfigUtils.validate() thanks > Also, add more documentation on the new config variable (at least a

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5440: Add GenericTransformFunction wrapper for simple ScalarFunctions

2020-06-01 Thread GitBox
Jackie-Jiang commented on a change in pull request #5440: URL: https://github.com/apache/incubator-pinot/pull/5440#discussion_r433616803 ## File path: pinot-common/pom.xml ## @@ -33,6 +33,7 @@ https://pinot.apache.org/ ${basedir}/.. +0.9.11 Review comment:

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5440: Add GenericTransformFunction wrapper for simple ScalarFunctions

2020-06-01 Thread GitBox
Jackie-Jiang commented on a change in pull request #5440: URL: https://github.com/apache/incubator-pinot/pull/5440#discussion_r433616232 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/ScalarTransformFunctionWrapper.java ## @@ -0,0

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5440: Add GenericTransformFunction wrapper for simple ScalarFunctions

2020-06-01 Thread GitBox
Jackie-Jiang commented on a change in pull request #5440: URL: https://github.com/apache/incubator-pinot/pull/5440#discussion_r433615835 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/TransformFunctionFactory.java ## @@ -112,13

[incubator-pinot] branch release-0.4.0-rc-2 updated: [maven-release-plugin] prepare for next development iteration

2020-06-01 Thread haibow
This is an automated email from the ASF dual-hosted git repository. haibow pushed a commit to branch release-0.4.0-rc-2 in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/release-0.4.0-rc-2 by this push: new 28efe1d

[incubator-pinot] annotated tag release-0.4.0-rc2 updated (8355d2e -> 88accfc)

2020-06-01 Thread haibow
This is an automated email from the ASF dual-hosted git repository. haibow pushed a change to annotated tag release-0.4.0-rc2 in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. *** WARNING: tag release-0.4.0-rc2 was modified! *** from 8355d2e (commit) to 88accfc

[incubator-pinot] branch release-0.4.0-rc-2 updated: [maven-release-plugin] prepare release release-0.4.0-rc2

2020-06-01 Thread haibow
This is an automated email from the ASF dual-hosted git repository. haibow pushed a commit to branch release-0.4.0-rc-2 in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/release-0.4.0-rc-2 by this push: new 8355d2e

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5483: Add ServerQuery to replace BrokerRequest in server execution engine

2020-06-01 Thread GitBox
Jackie-Jiang commented on a change in pull request #5483: URL: https://github.com/apache/incubator-pinot/pull/5483#discussion_r433615031 ## File path: pinot-common/src/main/java/org/apache/pinot/common/request/v2/ServerQuery.java ## @@ -0,0 +1,181 @@ +/** + * Licensed to the

[incubator-pinot] 02/02: Initialize _aggregateMetric in constructor (#5472)

2020-06-01 Thread haibow
This is an automated email from the ASF dual-hosted git repository. haibow pushed a commit to branch release-0.4.0-rc-2 in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit 9e0bb880366fc3e895c097b37e0accbeb28ab586 Author: Sidd AuthorDate: Sun May 31 15:35:46 2020 -0700

[incubator-pinot] branch release-0.4.0-rc-2 created (now 9e0bb88)

2020-06-01 Thread haibow
This is an automated email from the ASF dual-hosted git repository. haibow pushed a change to branch release-0.4.0-rc-2 in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 9e0bb88 Initialize _aggregateMetric in constructor (#5472) This branch includes the following

[incubator-pinot] 01/02: Two changes: (#5470)

2020-06-01 Thread haibow
This is an automated email from the ASF dual-hosted git repository. haibow pushed a commit to branch release-0.4.0-rc-2 in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit fe3b98ea8d2283d4b67b0bdb8622cbf4490f2cc1 Author: Sidd AuthorDate: Sat May 30 19:21:23 2020 -0700

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #5483: Add ServerQuery to replace BrokerRequest in server execution engine

2020-06-01 Thread GitBox
kishoreg commented on a change in pull request #5483: URL: https://github.com/apache/incubator-pinot/pull/5483#discussion_r433593063 ## File path: pinot-common/src/main/java/org/apache/pinot/common/request/v2/ServerQuery.java ## @@ -0,0 +1,181 @@ +/** + * Licensed to the

[GitHub] [incubator-pinot] npawar opened a new pull request #5484: Extract all fields if fieldsToRead is null/empty

2020-06-01 Thread GitBox
npawar opened a new pull request #5484: URL: https://github.com/apache/incubator-pinot/pull/5484 ## Description In the RecordExtractors, if `fieldsToRead` is null/empty, extract all fields from the record. The fieldsToRead can become as the "includeList". In the future we can introduce

[GitHub] [incubator-pinot] Jackie-Jiang opened a new pull request #5483: Add ServerQuery to replace BrokerRequest in server execution engine

2020-06-01 Thread GitBox
Jackie-Jiang opened a new pull request #5483: URL: https://github.com/apache/incubator-pinot/pull/5483 Motivation: For historic reason, BrokerRequest does not support expressions natively. In order to support expressions (transform), the current solution is to store the expressions

[GitHub] [incubator-pinot] quietgopher commented on issue #5479: Vague error message during SegmentINdexCreation if column is not found

2020-06-01 Thread GitBox
quietgopher commented on issue #5479: URL: https://github.com/apache/incubator-pinot/issues/5479#issuecomment-637213927 https://github.com/apache/incubator-pinot/pull/5482 This is an automated message from the Apache Git

[GitHub] [incubator-pinot] quietgopher opened a new pull request #5482: Change a NPE to have a better error message

2020-06-01 Thread GitBox
quietgopher opened a new pull request #5482: URL: https://github.com/apache/incubator-pinot/pull/5482 ## Description Improve an error message when a table spec is missing a dimension that is specified in a star tree schema. https://github.com/apache/incubator-pinot/issues/5479

[GitHub] [incubator-pinot] akshayrai opened a new pull request #5481: [TE] Fix the run-backend and run-frontend scripts

2020-06-01 Thread GitBox
akshayrai opened a new pull request #5481: URL: https://github.com/apache/incubator-pinot/pull/5481 Updated the demo scripts to point to the right jar path. This is an automated message from the Apache Git Service. To

[GitHub] [incubator-pinot] fx19880617 opened a new pull request #5480: Adding more information into jar manifest

2020-06-01 Thread GitBox
fx19880617 opened a new pull request #5480: URL: https://github.com/apache/incubator-pinot/pull/5480 ## Description Adding build time and branch into jar manifest Sample output from: `pinot-distribution/target/pinot-distribution-0.4.0-SNAPSHOT-shaded.jar:META-INF/MANIFEST.MF`

[incubator-pinot] branch git_plugin updated: Adding more information into jar manifest

2020-06-01 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch git_plugin in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/git_plugin by this push: new c96c73a Adding more

[incubator-pinot] branch git_plugin created (now ed26e85)

2020-06-01 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch git_plugin in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at ed26e85 [TE] fix document for adding new application (#5473) No new revisions were added by this

[GitHub] [incubator-pinot] quietgopher opened a new issue #5479: Vague error message during SegmentINdexCreation if column is not found

2020-06-01 Thread GitBox
quietgopher opened a new issue #5479: URL: https://github.com/apache/incubator-pinot/issues/5479 I haven't tracked down the issue with my schema. I'm guessing I have another typo. The logs look like this. I'm going to improve the error message. ```

[GitHub] [incubator-pinot] chenboat opened a new pull request #5478: Add a new table config field for peer segment download.

2020-06-01 Thread GitBox
chenboat opened a new pull request #5478: URL: https://github.com/apache/incubator-pinot/pull/5478 ## Description Add a new optional string field peerSegmentDownloadScheme to the SegmentsValidationAndRetentionConfig in the TableConfig. The value can be http or https. The field will

[GitHub] [incubator-pinot] fx19880617 opened a new pull request #5477: Upgrade pinot docker packaging and adding jmx agent

2020-06-01 Thread GitBox
fx19880617 opened a new pull request #5477: URL: https://github.com/apache/incubator-pinot/pull/5477 ## Description Update docker packaging to be more intuitive. Adding jmx as etc to pinot docker image. ## Release Notes No

[incubator-pinot] branch adding_jmx_to_pinot_docker_image created (now 77de993)

2020-06-01 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch adding_jmx_to_pinot_docker_image in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 77de993 Upgrade pinot docker packaging and adding jmx agent This branch

[incubator-pinot] 01/01: Upgrade pinot docker packaging and adding jmx agent

2020-06-01 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch adding_jmx_to_pinot_docker_image in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit 77de99331542c4147a5371bb6850934770d49cc4 Author: Xiang Fu AuthorDate: Mon Jun 1

[incubator-pinot] branch master updated: [TE] fix document for adding new application (#5473)

2020-06-01 Thread xhsun
This is an automated email from the ASF dual-hosted git repository. xhsun pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new ed26e85 [TE] fix document for adding

[GitHub] [incubator-pinot] xiaohui-sun merged pull request #5473: [TE] fix document for adding new applications

2020-06-01 Thread GitBox
xiaohui-sun merged pull request #5473: URL: https://github.com/apache/incubator-pinot/pull/5473 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-pinot] KKcorps commented on a change in pull request #5440: Add GenericTransformFunction wrapper for simple ScalarFunctions

2020-06-01 Thread GitBox
KKcorps commented on a change in pull request #5440: URL: https://github.com/apache/incubator-pinot/pull/5440#discussion_r433466964 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/TransformFunctionFactory.java ## @@ -112,13 +115,24 @@

[GitHub] [incubator-pinot] KKcorps commented on a change in pull request #5440: Add GenericTransformFunction wrapper for simple ScalarFunctions

2020-06-01 Thread GitBox
KKcorps commented on a change in pull request #5440: URL: https://github.com/apache/incubator-pinot/pull/5440#discussion_r433462644 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/ScalarTransformFunctionWrapper.java ## @@ -0,0 +1,301

[GitHub] [incubator-pinot] KKcorps commented on a change in pull request #5440: Add GenericTransformFunction wrapper for simple ScalarFunctions

2020-06-01 Thread GitBox
KKcorps commented on a change in pull request #5440: URL: https://github.com/apache/incubator-pinot/pull/5440#discussion_r433450882 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/ScalarTransformFunctionWrapper.java ## @@ -0,0 +1,301

[GitHub] [incubator-pinot] KKcorps commented on a change in pull request #5440: Add GenericTransformFunction wrapper for simple ScalarFunctions

2020-06-01 Thread GitBox
KKcorps commented on a change in pull request #5440: URL: https://github.com/apache/incubator-pinot/pull/5440#discussion_r433450882 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/ScalarTransformFunctionWrapper.java ## @@ -0,0 +1,301

[incubator-pinot] 01/01: bring pinot mock data generator.sh script in line with TE mock data generator

2020-06-01 Thread apucher
This is an automated email from the ASF dual-hosted git repository. apucher pushed a commit to branch mock-data-generator-range-extension in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit 8cde6b9738284b6d19e111322dd9cf0a99f22735 Author: Alexander Pucher AuthorDate:

[incubator-pinot] branch mock-data-generator-range-extension created (now 8cde6b9)

2020-06-01 Thread apucher
This is an automated email from the ASF dual-hosted git repository. apucher pushed a change to branch mock-data-generator-range-extension in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 8cde6b9 bring pinot mock data generator.sh script in line with TE mock data

[incubator-pinot] branch mock-data-generator-range-extension created (now 8cde6b9)

2020-06-01 Thread apucher
This is an automated email from the ASF dual-hosted git repository. apucher pushed a change to branch mock-data-generator-range-extension in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 8cde6b9 bring pinot mock data generator.sh script in line with TE mock data

[incubator-pinot] 01/01: bring pinot mock data generator.sh script in line with TE mock data generator

2020-06-01 Thread apucher
This is an automated email from the ASF dual-hosted git repository. apucher pushed a commit to branch mock-data-generator-range-extension in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit 8cde6b9738284b6d19e111322dd9cf0a99f22735 Author: Alexander Pucher AuthorDate:

[GitHub] [incubator-pinot] quietgopher commented on issue #5474: Vague error message when building startree schema if there is a typo in the aggregate columns

2020-06-01 Thread GitBox
quietgopher commented on issue #5474: URL: https://github.com/apache/incubator-pinot/issues/5474#issuecomment-636970008 https://github.com/apache/incubator-pinot/pull/5476 This is an automated message from the Apache Git

[GitHub] [incubator-pinot] quietgopher opened a new pull request #5476: Improve error message on NPE related to typo in star schema column names

2020-06-01 Thread GitBox
quietgopher opened a new pull request #5476: URL: https://github.com/apache/incubator-pinot/pull/5476 ## Description I hit an NPE due to a typo in my star tree schema. This diff includes the invalid column name in the NPE now (to make it easier to debug).

[GitHub] [incubator-pinot] quietgopher commented on issue #5474: Vague error message when building startree schema if there is a typo in the aggregate columns

2020-06-01 Thread GitBox
quietgopher commented on issue #5474: URL: https://github.com/apache/incubator-pinot/issues/5474#issuecomment-636968434 I'm working on a diff. Here's an example of the copy/paste issue (simplified since I don't want to post the full config). in the table config: ```

[GitHub] [incubator-pinot] Sreemanth opened a new issue #5475: GuavaOnHeapBloomFilter can be constructed with _bloomFilter as null

2020-06-01 Thread GitBox
Sreemanth opened a new issue #5475: URL: https://github.com/apache/incubator-pinot/issues/5475 https://github.com/apache/incubator-pinot/blob/a314d42e8744549e5c182383445f11c60ac4ae4a/pinot-core/src/main/java/org/apache/pinot/core/bloom/GuavaOnHeapBloomFilter.java#L37 Because

[GitHub] [incubator-pinot] kishoreg commented on issue #5474: Vague error message when building startree schema if there is a typo in the aggregate columns

2020-06-01 Thread GitBox
kishoreg commented on issue #5474: URL: https://github.com/apache/incubator-pinot/issues/5474#issuecomment-636669663 can you paste the sample config This is an automated message from the Apache Git Service. To respond to