[incubator-pinot] branch support_case_when_statement updated (9fbd589 -> eeccadb)

2020-06-09 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch support_case_when_statement in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 9fbd589 update case statement to skip some conditions won't happen discard ebc1c27

[incubator-pinot] branch release-0.4.0-update-binary updated (0872dbc -> 21b7604)

2020-06-09 Thread haibow
This is an automated email from the ASF dual-hosted git repository. haibow pushed a change to branch release-0.4.0-update-binary in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 0872dbc Update license add 21b7604 Update license No new revisions were added

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #5513: Return Select only Literal Expression at Broker

2020-06-09 Thread GitBox
codecov-commenter edited a comment on pull request #5513: URL: https://github.com/apache/incubator-pinot/pull/5513#issuecomment-641655758 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5513?src=pr=h1) Report > Merging

[incubator-pinot] branch master updated: Enhance quickstart script for CI tests (#5508)

2020-06-09 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 2d28c0f Enhance quickstart script for

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #5508: Enhance quickstart script for CI tests

2020-06-09 Thread GitBox
Jackie-Jiang merged pull request #5508: URL: https://github.com/apache/incubator-pinot/pull/5508 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #5513: Return Select only Literal Expression at Broker

2020-06-09 Thread GitBox
codecov-commenter edited a comment on pull request #5513: URL: https://github.com/apache/incubator-pinot/pull/5513#issuecomment-641655758 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5513?src=pr=h1) Report > Merging

[incubator-pinot] branch support_case_when_statement updated (012776a -> 9fbd589)

2020-06-09 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch support_case_when_statement in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 012776a update case statement to skip some conditions won't happen discard 496c44c

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5461: Adding Support for SQL CASE Statement

2020-06-09 Thread GitBox
fx19880617 commented on a change in pull request #5461: URL: https://github.com/apache/incubator-pinot/pull/5461#discussion_r437853396 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/CaseTransformFunction.java ## @@ -0,0 +1,436 @@ +/**

[incubator-pinot] branch support_case_when_statement updated (496c44c -> 012776a)

2020-06-09 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch support_case_when_statement in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 496c44c Address comments add 012776a update case statement to skip some

[incubator-pinot] branch pinot_query_literal_only updated (a579612 -> c682c95)

2020-06-09 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch pinot_query_literal_only in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard a579612 Address comments discard 89c1eff Support Selection Literal only queries

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #5532: Fixing grep thirdeye changes in github action scripts

2020-06-09 Thread GitBox
codecov-commenter edited a comment on pull request #5532: URL: https://github.com/apache/incubator-pinot/pull/5532#issuecomment-641673683 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5532?src=pr=h1) Report > Merging

[incubator-pinot] branch master updated: Fix the failure caused by Reflections in FunctionRegistry (#5531)

2020-06-09 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 5390698 Fix the failure caused by

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #5531: Fix the failure caused by Reflections in FunctionRegistry

2020-06-09 Thread GitBox
Jackie-Jiang merged pull request #5531: URL: https://github.com/apache/incubator-pinot/pull/5531 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #5531: Fix the failure caused by Reflections in FunctionRegistry

2020-06-09 Thread GitBox
codecov-commenter commented on pull request #5531: URL: https://github.com/apache/incubator-pinot/pull/5531#issuecomment-641673684 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5531?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #5532: Fixing grep thirdeye changes in github action scripts

2020-06-09 Thread GitBox
codecov-commenter commented on pull request #5532: URL: https://github.com/apache/incubator-pinot/pull/5532#issuecomment-641673683 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5532?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] Jackie-Jiang commented on pull request #5483: Add QueryContext to replace BrokerRequest in the query engine

2020-06-09 Thread GitBox
Jackie-Jiang commented on pull request #5483: URL: https://github.com/apache/incubator-pinot/pull/5483#issuecomment-641663429 @kishoreg @mayankshriv @siddharthteotia This PR is ready for review. This is an automated message

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5532: Fixing grep thirdeye changes in github action scripts

2020-06-09 Thread GitBox
Jackie-Jiang commented on a change in pull request #5532: URL: https://github.com/apache/incubator-pinot/pull/5532#discussion_r437804646 ## File path: .github/workflows/scripts/.pinot_test.sh ## @@ -44,17 +44,9 @@ if [ $? -eq 0 ]; then fi Review comment: line 38-44

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #5513: Return Select only Literal Expression at Broker

2020-06-09 Thread GitBox
codecov-commenter edited a comment on pull request #5513: URL: https://github.com/apache/incubator-pinot/pull/5513#issuecomment-641655758 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5513?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #5513: Return Select only Literal Expression at Broker

2020-06-09 Thread GitBox
codecov-commenter edited a comment on pull request #5513: URL: https://github.com/apache/incubator-pinot/pull/5513#issuecomment-641655758 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5513?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #5513: Return Select only Literal Expression at Broker

2020-06-09 Thread GitBox
codecov-commenter commented on pull request #5513: URL: https://github.com/apache/incubator-pinot/pull/5513#issuecomment-641655758 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5513?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5532: Fixing grep thirdeye changes in github action scripts

2020-06-09 Thread GitBox
Jackie-Jiang commented on a change in pull request #5532: URL: https://github.com/apache/incubator-pinot/pull/5532#discussion_r437784293 ## File path: .github/workflows/scripts/.pinot_test.sh ## @@ -25,7 +25,7 @@ java -version COMMIT_BEFORE=$(jq -r ".pull_request.base.sha"

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #5510: Remove BlockValIterator and directly read values from BlockValSet with docId

2020-06-09 Thread GitBox
Jackie-Jiang merged pull request #5510: URL: https://github.com/apache/incubator-pinot/pull/5510 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-pinot] branch master updated: Remove BlockValIterator and directly read values from BlockValSet with docId (#5510)

2020-06-09 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new a1a2434 Remove BlockValIterator and

[GitHub] [incubator-pinot] fx19880617 opened a new pull request #5532: Fixing grep thirdeye changes in github action scripts

2020-06-09 Thread GitBox
fx19880617 opened a new pull request #5532: URL: https://github.com/apache/incubator-pinot/pull/5532 ## Description Fixing grep thirdeye changes in github action scripts This is an automated message from the Apache Git

[incubator-pinot] branch pinot_query_literal_only updated (09e54fb -> a579612)

2020-06-09 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch pinot_query_literal_only in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 09e54fb Address comments add a579612 Address comments This update added new

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5513: Return Select only Literal Expression at Broker

2020-06-09 Thread GitBox
fx19880617 commented on a change in pull request #5513: URL: https://github.com/apache/incubator-pinot/pull/5513#discussion_r437774641 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java ## @@ -435,6 +455,115 @@ static

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5508: Fix Travis quickstart tests

2020-06-09 Thread GitBox
Jackie-Jiang commented on a change in pull request #5508: URL: https://github.com/apache/incubator-pinot/pull/5508#discussion_r437773389 ## File path: .travis/.travis_quickstart.sh ## @@ -30,60 +30,75 @@ java -version # Quickstart DIST_BIN_DIR=`ls -d

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5513: Return Select only Literal Expression at Broker

2020-06-09 Thread GitBox
fx19880617 commented on a change in pull request #5513: URL: https://github.com/apache/incubator-pinot/pull/5513#discussion_r437772483 ## File path: pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java ## @@ -278,7 +278,9 @@ private static PinotQuery

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5513: Return Select only Literal Expression at Broker

2020-06-09 Thread GitBox
fx19880617 commented on a change in pull request #5513: URL: https://github.com/apache/incubator-pinot/pull/5513#discussion_r437772483 ## File path: pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java ## @@ -278,7 +278,9 @@ private static PinotQuery

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5513: Return Select only Literal Expression at Broker

2020-06-09 Thread GitBox
fx19880617 commented on a change in pull request #5513: URL: https://github.com/apache/incubator-pinot/pull/5513#discussion_r437772150 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java ## @@ -435,6 +455,115 @@ static

[incubator-pinot] branch pinot_query_literal_only updated (c1da5c0 -> 09e54fb)

2020-06-09 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch pinot_query_literal_only in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard c1da5c0 Address comments add 09e54fb Address comments This update added new

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5513: Return Select only Literal Expression at Broker

2020-06-09 Thread GitBox
fx19880617 commented on a change in pull request #5513: URL: https://github.com/apache/incubator-pinot/pull/5513#discussion_r437771739 ## File path: pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/OfflineClusterIntegrationTest.java ## @@ -318,6

[incubator-pinot] branch pinot_query_literal_only updated (1fabecc -> c1da5c0)

2020-06-09 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch pinot_query_literal_only in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 1fabecc Address comments discard e3392d7 Support Selection Literal only queries

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5513: Return Select only Literal Expression at Broker

2020-06-09 Thread GitBox
fx19880617 commented on a change in pull request #5513: URL: https://github.com/apache/incubator-pinot/pull/5513#discussion_r437766763 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java ## @@ -184,6 +192,18 @@ public

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5461: Adding Support for SQL CASE Statement

2020-06-09 Thread GitBox
Jackie-Jiang commented on a change in pull request #5461: URL: https://github.com/apache/incubator-pinot/pull/5461#discussion_r437766091 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/CaseTransformFunction.java ## @@ -0,0 +1,436 @@

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5513: Return Select only Literal Expression at Broker

2020-06-09 Thread GitBox
Jackie-Jiang commented on a change in pull request #5513: URL: https://github.com/apache/incubator-pinot/pull/5513#discussion_r437758422 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java ## @@ -435,6 +455,115 @@

[GitHub] [incubator-pinot] mcvsubbu commented on pull request #5512: [CI] Adding github actions for pinot tests

2020-06-09 Thread GitBox
mcvsubbu commented on pull request #5512: URL: https://github.com/apache/incubator-pinot/pull/5512#issuecomment-641612903 > > Let's keep both Github Action and Travis running for a while until we feel Github Action is stable enough to kill Travis completely. > > Agreed, we can let

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5476: Improve error message on NPE related to typo in star schema column names

2020-06-09 Thread GitBox
Jackie-Jiang commented on a change in pull request #5476: URL: https://github.com/apache/incubator-pinot/pull/5476#discussion_r437753947 ## File path: pinot-core/src/main/java/org/apache/pinot/core/startree/v2/builder/BaseSingleTreeBuilder.java ## @@ -150,7 +151,11 @@

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5531: Fix the failure caused by Reflections in FunctionRegistry

2020-06-09 Thread GitBox
Jackie-Jiang commented on a change in pull request #5531: URL: https://github.com/apache/incubator-pinot/pull/5531#discussion_r437750886 ## File path: pinot-common/src/main/java/org/apache/pinot/common/function/FunctionRegistry.java ## @@ -39,62 +38,63 @@ */ public class

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5531: Fix the failure caused by Reflections in FunctionRegistry

2020-06-09 Thread GitBox
Jackie-Jiang commented on a change in pull request #5531: URL: https://github.com/apache/incubator-pinot/pull/5531#discussion_r437749424 ## File path: pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java ## @@ -667,21 +666,23 @@ protected static

[GitHub] [incubator-pinot] sajjad-moradi commented on a change in pull request #5531: Fix the failure caused by Reflections in FunctionRegistry

2020-06-09 Thread GitBox
sajjad-moradi commented on a change in pull request #5531: URL: https://github.com/apache/incubator-pinot/pull/5531#discussion_r437740412 ## File path: pinot-common/src/main/java/org/apache/pinot/common/function/FunctionRegistry.java ## @@ -39,62 +38,63 @@ */ public class

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5531: Fix the failure caused by Reflections in FunctionRegistry

2020-06-09 Thread GitBox
Jackie-Jiang commented on a change in pull request #5531: URL: https://github.com/apache/incubator-pinot/pull/5531#discussion_r437745012 ## File path: pinot-common/src/main/java/org/apache/pinot/common/function/FunctionRegistry.java ## @@ -39,62 +38,63 @@ */ public class

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5531: Fix the failure caused by Reflections in FunctionRegistry

2020-06-09 Thread GitBox
Jackie-Jiang commented on a change in pull request #5531: URL: https://github.com/apache/incubator-pinot/pull/5531#discussion_r437743484 ## File path: pinot-common/src/main/java/org/apache/pinot/common/function/FunctionRegistry.java ## @@ -39,62 +38,63 @@ */ public class

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #5531: Fix the failure caused by Reflections in FunctionRegistry

2020-06-09 Thread GitBox
mcvsubbu commented on a change in pull request #5531: URL: https://github.com/apache/incubator-pinot/pull/5531#discussion_r437729537 ## File path: pinot-common/src/main/java/org/apache/pinot/common/function/FunctionRegistry.java ## @@ -39,62 +38,63 @@ */ public class

[incubator-pinot] branch master updated (15fda7f -> 5b3837c)

2020-06-09 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 15fda7f Update Pinot quickstart to use sql mode (#5530) add 5b3837c Adding github actions for pinot

[GitHub] [incubator-pinot] fx19880617 merged pull request #5512: [CI] Adding github actions for pinot tests

2020-06-09 Thread GitBox
fx19880617 merged pull request #5512: URL: https://github.com/apache/incubator-pinot/pull/5512 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-pinot] fx19880617 commented on pull request #5512: [CI] Adding github actions for pinot tests

2020-06-09 Thread GitBox
fx19880617 commented on pull request #5512: URL: https://github.com/apache/incubator-pinot/pull/5512#issuecomment-641587051 > Let's keep both Github Action and Travis running for a while until we feel Github Action is stable enough to kill Travis completely. Agreed, we can let both

[incubator-pinot] branch master updated (2b09676 -> 15fda7f)

2020-06-09 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 2b09676 One to many records from record reader/decoder (#5430) add 15fda7f Update Pinot quickstart

[GitHub] [incubator-pinot] fx19880617 merged pull request #5530: Update Pinot quickstart to use sql mode

2020-06-09 Thread GitBox
fx19880617 merged pull request #5530: URL: https://github.com/apache/incubator-pinot/pull/5530 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-pinot] fx19880617 closed issue #5516: Move quickstart examples to use SQL Mode

2020-06-09 Thread GitBox
fx19880617 closed issue #5516: URL: https://github.com/apache/incubator-pinot/issues/5516 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #5531: Fix the failure caused by Reflections in FunctionRegistry

2020-06-09 Thread GitBox
mayankshriv commented on a change in pull request #5531: URL: https://github.com/apache/incubator-pinot/pull/5531#discussion_r437703543 ## File path: pinot-common/src/main/java/org/apache/pinot/common/function/FunctionRegistry.java ## @@ -39,62 +38,63 @@ */ public class

[GitHub] [incubator-pinot] mayankshriv commented on pull request #5531: Fix the failure caused by Reflections in FunctionRegistry

2020-06-09 Thread GitBox
mayankshriv commented on pull request #5531: URL: https://github.com/apache/incubator-pinot/pull/5531#issuecomment-641553854 Thanks a lot for identifying this issue, and providing a fix. Could you please elaborate a bit on how the thread safety issue leads to query compilation error?

[GitHub] [incubator-pinot] Jackie-Jiang opened a new pull request #5531: Fix the failure caused by Reflections in FunctionRegistry

2020-06-09 Thread GitBox
Jackie-Jiang opened a new pull request #5531: URL: https://github.com/apache/incubator-pinot/pull/5531 The problem is caused by Reflections library not being thread-safe when multiple threads are accessing the same jar file. Read more about the thread-safety issue here:

[GitHub] [incubator-pinot] snleee commented on pull request #5512: [CI] Adding github actions for pinot tests

2020-06-09 Thread GitBox
snleee commented on pull request #5512: URL: https://github.com/apache/incubator-pinot/pull/5512#issuecomment-641543455 +1 on 20 concurrent jobs. @jackjlli Can you review this PR and make sure that our CRON job is also correctly migrated to Github Action?

[GitHub] [incubator-pinot] snleee commented on a change in pull request #5529: Update license and notice for 0.4.0 release

2020-06-09 Thread GitBox
snleee commented on a change in pull request #5529: URL: https://github.com/apache/incubator-pinot/pull/5529#discussion_r437687448 ## File path: licenses-binary/LICENSE-gpl-2.0.txt ## @@ -0,0 +1,641 @@ +Apache Pinot (incubating) Review comment: This is not the license

[GitHub] [incubator-pinot] npawar merged pull request #5430: One to many records from record reader/decoder

2020-06-09 Thread GitBox
npawar merged pull request #5430: URL: https://github.com/apache/incubator-pinot/pull/5430 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[incubator-pinot] branch master updated: One to many records from record reader/decoder (#5430)

2020-06-09 Thread nehapawar
This is an automated email from the ASF dual-hosted git repository. nehapawar pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 2b09676 One to many records from

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5461: Adding Support for SQL CASE Statement

2020-06-09 Thread GitBox
fx19880617 commented on a change in pull request #5461: URL: https://github.com/apache/incubator-pinot/pull/5461#discussion_r437654871 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/CaseTransformFunction.java ## @@ -0,0 +1,436 @@ +/**

[incubator-pinot] branch support_case_when_statement updated (82955f6 -> 496c44c)

2020-06-09 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch support_case_when_statement in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 82955f6 Address comments add 496c44c Address comments This update added new

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5461: Adding Support for SQL CASE Statement

2020-06-09 Thread GitBox
fx19880617 commented on a change in pull request #5461: URL: https://github.com/apache/incubator-pinot/pull/5461#discussion_r437650377 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/CaseTransformFunction.java ## @@ -0,0 +1,436 @@ +/**

[incubator-pinot] branch support_case_when_statement updated (d6c0ca8 -> 82955f6)

2020-06-09 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch support_case_when_statement in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard d6c0ca8 Address comments add 82955f6 Address comments This update added new

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5461: Adding Support for SQL CASE Statement

2020-06-09 Thread GitBox
fx19880617 commented on a change in pull request #5461: URL: https://github.com/apache/incubator-pinot/pull/5461#discussion_r437650377 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/CaseTransformFunction.java ## @@ -0,0 +1,436 @@ +/**

[GitHub] [incubator-pinot] mcvsubbu merged pull request #5506: Moved StreamPartitionMsgOffset to be an interface

2020-06-09 Thread GitBox
mcvsubbu merged pull request #5506: URL: https://github.com/apache/incubator-pinot/pull/5506 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-pinot] akshayrai opened a new pull request #5515: [TE] Add data quality/sla rule to the detection template

2020-06-09 Thread GitBox
akshayrai opened a new pull request #5515: URL: https://github.com/apache/incubator-pinot/pull/5515 * Add sla rule to the detection onboarding template This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #5336: [Part 4] Deep-store bypass for LLC: Add a peer to peer segment fetcher.

2020-06-09 Thread GitBox
mcvsubbu commented on a change in pull request #5336: URL: https://github.com/apache/incubator-pinot/pull/5336#discussion_r436849376 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java ## @@ -268,20 +273,81 @@

[GitHub] [incubator-pinot] snleee commented on a change in pull request #5476: Improve error message on NPE related to typo in star schema column names

2020-06-09 Thread GitBox
snleee commented on a change in pull request #5476: URL: https://github.com/apache/incubator-pinot/pull/5476#discussion_r437027028 ## File path: pinot-core/src/main/java/org/apache/pinot/core/startree/v2/builder/BaseSingleTreeBuilder.java ## @@ -150,7 +151,11 @@ //

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #5514: Add integration test for theta sketches

2020-06-09 Thread GitBox
mayankshriv commented on a change in pull request #5514: URL: https://github.com/apache/incubator-pinot/pull/5514#discussion_r436750863 ## File path: pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/ThetaSketchIntegrationTest.java ## @@ -0,0 +1,263 @@

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5513: Return Select only Literal Expression at Broker

2020-06-09 Thread GitBox
Jackie-Jiang commented on a change in pull request #5513: URL: https://github.com/apache/incubator-pinot/pull/5513#discussion_r437008430 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java ## @@ -184,6 +192,18 @@

[GitHub] [incubator-pinot] akshayrai opened a new issue #5519: [Preview][UI] New Settings Anomalies on the time-series legend is confusing

2020-06-09 Thread GitBox
akshayrai opened a new issue #5519: URL: https://github.com/apache/incubator-pinot/issues/5519 In the UI legend rephrase New Settings Anomalies to anomalies **Priority:** Low **Solution:** “Current Anomalies” -> “Anomalies” “New Setting Anomalies” -> “Preview Anomalies”

[GitHub] [incubator-pinot] mayankshriv commented on pull request #5511: WIP: Support LITTLE ENDIAN indexes

2020-06-09 Thread GitBox
mayankshriv commented on pull request #5511: URL: https://github.com/apache/incubator-pinot/pull/5511#issuecomment-640681656 Interesting, I was under the impression that JVM is big-endian regardless of the host endianness. Would be good if you can share any stats on the speed up seen in

[GitHub] [incubator-pinot] akshayrai opened a new issue #5526: [TE-demo][Backend] cannot run frontend and backend simultaneously in demo mode

2020-06-09 Thread GitBox
akshayrai opened a new issue #5526: URL: https://github.com/apache/incubator-pinot/issues/5526 Currently we cannot run backend and frontend at the same time as it will lock the h2 db. can we think of another approach? **Priority:** N/A **Solution:** h2 is only for demo frontend.

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #5430: One to many records from record reader/decoder

2020-06-09 Thread GitBox
kishoreg commented on a change in pull request #5430: URL: https://github.com/apache/incubator-pinot/pull/5430#discussion_r436887390 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java ## @@ -466,19 +469,28 @@

[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #5515: [TE] Add data quality/sla rule to the detection template

2020-06-09 Thread GitBox
akshayrai commented on a change in pull request #5515: URL: https://github.com/apache/incubator-pinot/pull/5515#discussion_r436891442 ## File path: thirdeye/thirdeye-frontend/app/utils/yaml-tools.js ## @@ -11,24 +11,29 @@ dataset: dataset_to_which_this_metric_belongs #

[GitHub] [incubator-pinot] akshayrai opened a new issue #5517: UI - [RCA] refresh and open a fresh rca tab for new metrics

2020-06-09 Thread GitBox
akshayrai opened a new issue #5517: URL: https://github.com/apache/incubator-pinot/issues/5517 UI - [RCA] After feeding a metric on the RCA page, it is hard to go back and view the rca for another metric. The page automatically loads the previous metric unless we manually modify the url.

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #5513: Return Select only Literal Expression at Broker

2020-06-09 Thread GitBox
mayankshriv commented on a change in pull request #5513: URL: https://github.com/apache/incubator-pinot/pull/5513#discussion_r436764713 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java ## @@ -435,6 +455,116 @@

[GitHub] [incubator-pinot] akshayrai merged pull request #5515: [TE] Add data quality/sla rule to the detection template

2020-06-09 Thread GitBox
akshayrai merged pull request #5515: URL: https://github.com/apache/incubator-pinot/pull/5515 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-pinot] xiaohui-sun commented on a change in pull request #5515: [TE] Add data quality/sla rule to the detection template

2020-06-09 Thread GitBox
xiaohui-sun commented on a change in pull request #5515: URL: https://github.com/apache/incubator-pinot/pull/5515#discussion_r436876820 ## File path: thirdeye/thirdeye-frontend/app/utils/yaml-tools.js ## @@ -11,24 +11,29 @@ dataset: dataset_to_which_this_metric_belongs #

[GitHub] [incubator-pinot] chenboat commented on a change in pull request #5336: [Part 4] Deep-store bypass for LLC: Add a peer to peer segment fetcher.

2020-06-09 Thread GitBox
chenboat commented on a change in pull request #5336: URL: https://github.com/apache/incubator-pinot/pull/5336#discussion_r437074675 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java ## @@ -268,20 +273,81 @@

[GitHub] [incubator-pinot] siddharthteotia merged pull request #5503: Config for raw index writer version

2020-06-09 Thread GitBox
siddharthteotia merged pull request #5503: URL: https://github.com/apache/incubator-pinot/pull/5503 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #5502: Support expression as the left-hand side for BETWEEN and IN clause

2020-06-09 Thread GitBox
Jackie-Jiang merged pull request #5502: URL: https://github.com/apache/incubator-pinot/pull/5502 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-pinot] akshayrai opened a new issue #5524: [Subscription Group][UI] Hide the internal subscription group id on the UI

2020-06-09 Thread GitBox
akshayrai opened a new issue #5524: URL: https://github.com/apache/incubator-pinot/issues/5524 Do not display the internal subscription id in the subscription list. It is very misleading. People will think it is the number of anomalies or alerts etc. **Priority:** Low

[GitHub] [incubator-pinot] akshayrai opened a new pull request #5528: [TE] Add maxValueDaily and maxValueHourly data filters

2020-06-09 Thread GitBox
akshayrai opened a new pull request #5528: URL: https://github.com/apache/incubator-pinot/pull/5528 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [incubator-pinot] snleee commented on a change in pull request #5482: Change a NPE to have a better error message

2020-06-09 Thread GitBox
snleee commented on a change in pull request #5482: URL: https://github.com/apache/incubator-pinot/pull/5482#discussion_r437024926 ## File path: pinot-core/src/main/java/org/apache/pinot/core/indexsegment/immutable/ImmutableSegmentImpl.java ## @@ -60,7 +60,11 @@ public

[GitHub] [incubator-pinot] fx19880617 opened a new pull request #5530: Update Pinot quickstart to use sql mode

2020-06-09 Thread GitBox
fx19880617 opened a new pull request #5530: URL: https://github.com/apache/incubator-pinot/pull/5530 ## Description Move Pinot Quickstart to use SQL query mode This is an automated message from the Apache Git Service. To

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #5513: Return Select only Literal Expression at Broker

2020-06-09 Thread GitBox
kishoreg commented on a change in pull request #5513: URL: https://github.com/apache/incubator-pinot/pull/5513#discussion_r437011477 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java ## @@ -435,6 +455,116 @@ static

[GitHub] [incubator-pinot] akshayrai opened a new issue #5522: [TE-Admin][UI] Ability to create new applications from admin page

2020-06-09 Thread GitBox
akshayrai opened a new issue #5522: URL: https://github.com/apache/incubator-pinot/issues/5522 Add a button to create a new application. This is mainly helpful when booting ThirdEye for the first time with 0 applications. **Priority:** High **Possible Solution:** Add an entry to

[GitHub] [incubator-pinot] snleee closed pull request #5319: Add segment merge-rollup task executor

2020-06-09 Thread GitBox
snleee closed pull request #5319: URL: https://github.com/apache/incubator-pinot/pull/5319 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-pinot] akshayrai opened a new issue #5525: [TE-demo][Backend] Have a default application auto-created in demo mode

2020-06-09 Thread GitBox
akshayrai opened a new issue #5525: URL: https://github.com/apache/incubator-pinot/issues/5525 We should have a default application auto-created in the demo mode. For example, sandbox application. **Priority:** Low **Solution:** Automatically populate “sandbox” entry to the

[GitHub] [incubator-pinot] fx19880617 opened a new issue #5516: Move quickstart examples to use SQL Mode

2020-06-09 Thread GitBox
fx19880617 opened a new issue #5516: URL: https://github.com/apache/incubator-pinot/issues/5516 Current Pinot Quickstart is still using PQL mode, we should move to SQL mode. This is an automated message from the Apache Git

[GitHub] [incubator-pinot] npawar commented on a change in pull request #5506: Moved StreamPartitionMsgOffset to be an interface

2020-06-09 Thread GitBox
npawar commented on a change in pull request #5506: URL: https://github.com/apache/incubator-pinot/pull/5506#discussion_r437112256 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java ## @@ -515,7

[GitHub] [incubator-pinot] akshayrai opened a new issue #5521: [Preview][UI] Request top make the default preview end time set to the dataset watermark

2020-06-09 Thread GitBox
akshayrai opened a new issue #5521: URL: https://github.com/apache/incubator-pinot/issues/5521 Can we default the preview time-window to the max dataset timestamp so that users can always preview some data? **Priority:** Low **Possible Solution:** Query the end time of the

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #5501: Support escaping single quote for SQL literal

2020-06-09 Thread GitBox
Jackie-Jiang merged pull request #5501: URL: https://github.com/apache/incubator-pinot/pull/5501 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5513: Return Select only Literal Expression at Broker

2020-06-09 Thread GitBox
fx19880617 commented on a change in pull request #5513: URL: https://github.com/apache/incubator-pinot/pull/5513#discussion_r436894620 ## File path: pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java ## @@ -676,14 +678,25 @@ protected static

[GitHub] [incubator-pinot] fx19880617 commented on pull request #5438: Add additional datetime functionality

2020-06-09 Thread GitBox
fx19880617 commented on pull request #5438: URL: https://github.com/apache/incubator-pinot/pull/5438#issuecomment-640925133 Could you try to resolve the conflict and then we can merge this. This is an automated message from

[GitHub] [incubator-pinot] akshayrai opened a new issue #5520: [Preview][UI] The terms old and new on the preview table are not intuitive.

2020-06-09 Thread GitBox
akshayrai opened a new issue #5520: URL: https://github.com/apache/incubator-pinot/issues/5520 The Detection Settings column in the preview table with Old and New values is confusing. Can we redesign it and make it more intuitive? **Priority:** Low **Solution:** “Old” ->

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #5508: In Travis quickstart, wait for process finishing clean up and terminate

2020-06-09 Thread GitBox
mcvsubbu commented on a change in pull request #5508: URL: https://github.com/apache/incubator-pinot/pull/5508#discussion_r436891528 ## File path: .travis/.travis_quickstart.sh ## @@ -69,7 +75,7 @@ sleep 30 for i in $(seq 1 200) do COUNT_STAR_RES=`curl -X POST --header

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5508: Fix Travis quickstart tests

2020-06-09 Thread GitBox
fx19880617 commented on a change in pull request #5508: URL: https://github.com/apache/incubator-pinot/pull/5508#discussion_r437130895 ## File path: .travis/.travis_quickstart.sh ## @@ -30,60 +30,75 @@ java -version # Quickstart DIST_BIN_DIR=`ls -d

[GitHub] [incubator-pinot] npawar commented on a change in pull request #5430: One to many records from record reader/decoder

2020-06-09 Thread GitBox
npawar commented on a change in pull request #5430: URL: https://github.com/apache/incubator-pinot/pull/5430#discussion_r437095719 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java ## @@ -466,19 +469,28 @@

[GitHub] [incubator-pinot] akshayrai opened a new issue #5527: [TE-doc] Require better documentation on the items listed

2020-06-09 Thread GitBox
akshayrai opened a new issue #5527: URL: https://github.com/apache/incubator-pinot/issues/5527 Doc - How to configure monitoringGranularity? Priority: Low Solution: Document it. Effort: Low Doc - How to add a row count metric/alert? Priority: Low Solution: Add document

[GitHub] [incubator-pinot] akshayrai opened a new issue #5518: [RCA][UI] Need a quick way to know what metrics exist on ThirdEye

2020-06-09 Thread GitBox
akshayrai opened a new issue #5518: URL: https://github.com/apache/incubator-pinot/issues/5518 Currently there is no place to search for metrics. The drop-down in the RCA doesn't list unless we type a few characters. Can we make it list a few metrics by default? **Priority:** Low

  1   2   >