[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #5483: Add QueryContext to replace BrokerRequest in the query engine

2020-06-12 Thread GitBox
siddharthteotia commented on a change in pull request #5483: URL: https://github.com/apache/incubator-pinot/pull/5483#discussion_r439706205 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/request/context/utils/BrokerRequestToQueryContextConverter.java ## @@

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #5483: Add QueryContext to replace BrokerRequest in the query engine

2020-06-12 Thread GitBox
siddharthteotia commented on a change in pull request #5483: URL: https://github.com/apache/incubator-pinot/pull/5483#discussion_r439706205 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/request/context/utils/BrokerRequestToQueryContextConverter.java ## @@

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #5543: Added configurable http listeners for controller API

2020-06-12 Thread GitBox
codecov-commenter edited a comment on pull request #5543: URL: https://github.com/apache/incubator-pinot/pull/5543#issuecomment-643503193 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5543?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #5538: In ServerQueryRequest and ColumnValueSegmentPruner, replace BrokerRequest with QueryContext

2020-06-12 Thread GitBox
codecov-commenter edited a comment on pull request #5538: URL: https://github.com/apache/incubator-pinot/pull/5538#issuecomment-643550221 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5538?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #5483: Add QueryContext to replace BrokerRequest in the query engine

2020-06-12 Thread GitBox
codecov-commenter edited a comment on pull request #5483: URL: https://github.com/apache/incubator-pinot/pull/5483#issuecomment-642283701 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5483?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5548: Integrate vectorized bit-unpacking

2020-06-12 Thread GitBox
Jackie-Jiang commented on a change in pull request #5548: URL: https://github.com/apache/incubator-pinot/pull/5548#discussion_r439701135 ## File path: pinot-core/src/main/java/org/apache/pinot/core/io/util/PinotDataBitSetV2.java ## @@ -632,98 +654,39 @@ public void

[GitHub] [incubator-pinot] npawar opened a new issue #5559: Table truncate command

2020-06-12 Thread GitBox
npawar opened a new issue #5559: URL: https://github.com/apache/incubator-pinot/issues/5559 Add truncate operation i.e. delete all contents of table, without removing table config and schema. For offline, this means disabling the table and then deleting all segments (everything a

[GitHub] [incubator-pinot] npawar opened a new issue #5558: Do not allow realtime table creation if timeColumnName is null

2020-06-12 Thread GitBox
npawar opened a new issue #5558: URL: https://github.com/apache/incubator-pinot/issues/5558 A realtime table doesn't work in Pinot without a timeColumnName defined in the table config. However, we do no validation to ensure that the table config we are creating has a valid time column

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #5538: In ServerQueryRequest and ColumnValueSegmentPruner, replace BrokerRequest with QueryContext

2020-06-12 Thread GitBox
codecov-commenter commented on pull request #5538: URL: https://github.com/apache/incubator-pinot/pull/5538#issuecomment-643550221 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5538?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #5483: Add QueryContext to replace BrokerRequest in the query engine

2020-06-12 Thread GitBox
codecov-commenter edited a comment on pull request #5483: URL: https://github.com/apache/incubator-pinot/pull/5483#issuecomment-642283701 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5483?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] snleee commented on a change in pull request #5534: Replace SegmentMergeLineage to SegmentLineage

2020-06-12 Thread GitBox
snleee commented on a change in pull request #5534: URL: https://github.com/apache/incubator-pinot/pull/5534#discussion_r439697142 ## File path: pinot-common/src/main/java/org/apache/pinot/common/lineage/SegmentLineage.java ## @@ -0,0 +1,153 @@ +/** + * Licensed to the Apache

[GitHub] [incubator-pinot] snleee commented on a change in pull request #5534: Replace SegmentMergeLineage to SegmentLineage

2020-06-12 Thread GitBox
snleee commented on a change in pull request #5534: URL: https://github.com/apache/incubator-pinot/pull/5534#discussion_r439697142 ## File path: pinot-common/src/main/java/org/apache/pinot/common/lineage/SegmentLineage.java ## @@ -0,0 +1,153 @@ +/** + * Licensed to the Apache

[GitHub] [incubator-pinot] akshayrai merged pull request #5556: [TE] recover deleted api enpoints

2020-06-12 Thread GitBox
akshayrai merged pull request #5556: URL: https://github.com/apache/incubator-pinot/pull/5556 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-pinot] branch master updated: [TE] recover deleted api enpoints (#5556)

2020-06-12 Thread akshayrai09
This is an automated email from the ASF dual-hosted git repository. akshayrai09 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 33578ac [TE] recover deleted api

[GitHub] [incubator-pinot] mcvsubbu merged pull request #5557: Fix backward incompatibility in StreamFactoryConsumerProvider

2020-06-12 Thread GitBox
mcvsubbu merged pull request #5557: URL: https://github.com/apache/incubator-pinot/pull/5557 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[incubator-pinot] branch master updated: Fix backward incompatibility in StreamFactoryConsumerProvider (#5557)

2020-06-12 Thread mcvsubbu
This is an automated email from the ASF dual-hosted git repository. mcvsubbu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 5e532ec Fix backward

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #5557: Fix backward incompatibility in StreamFactoryConsumerProvider

2020-06-12 Thread GitBox
codecov-commenter commented on pull request #5557: URL: https://github.com/apache/incubator-pinot/pull/5557#issuecomment-643528515 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5557?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #5555: Enable logging for github actions

2020-06-12 Thread GitBox
codecov-commenter edited a comment on pull request #: URL: https://github.com/apache/incubator-pinot/pull/#issuecomment-643485612 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] mcvsubbu opened a new pull request #5557: Fix backward incompatibility in StreamFactoryConsumerProvider

2020-06-12 Thread GitBox
mcvsubbu opened a new pull request #5557: URL: https://github.com/apache/incubator-pinot/pull/5557 PR #5542 introduced a backward incompatibility in this class that would cause existing stream implementations to break when they use pinot 0.5.0. This commit re-introduces the deleted

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #5555: Enable logging for github actions

2020-06-12 Thread GitBox
codecov-commenter edited a comment on pull request #: URL: https://github.com/apache/incubator-pinot/pull/#issuecomment-643485612 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] vincentchenjl opened a new pull request #5556: [TE] recover deleted api enpoints

2020-06-12 Thread GitBox
vincentchenjl opened a new pull request #5556: URL: https://github.com/apache/incubator-pinot/pull/5556 This PR is to add back deleted API endponts used in /app/#/anomalies?anomalyIds=. This is an automated message from the

[GitHub] [incubator-pinot] Jackie-Jiang commented on pull request #5483: Add QueryContext to replace BrokerRequest in the query engine

2020-06-12 Thread GitBox
Jackie-Jiang commented on pull request #5483: URL: https://github.com/apache/incubator-pinot/pull/5483#issuecomment-643508353 > In general this looks fine to me. I am just worried about the confusion that having so many classes with duplicate names will cause. @mayankshriv I thought

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #5546: Handle case sensitivity for PinotQuery within BrokerRequest

2020-06-12 Thread GitBox
Jackie-Jiang merged pull request #5546: URL: https://github.com/apache/incubator-pinot/pull/5546 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-pinot] branch master updated (fcc3144 -> f16522a)

2020-06-12 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from fcc3144 Add SCALAR type into TransformFunctionType (#5544) add f16522a Handle case sensitivity for

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #5546: Handle case sensitivity for PinotQuery within BrokerRequest

2020-06-12 Thread GitBox
codecov-commenter edited a comment on pull request #5546: URL: https://github.com/apache/incubator-pinot/pull/5546#issuecomment-643030356 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5546?src=pr=h1) Report > Merging

[incubator-pinot] branch enable_logs_in_integration_test_github_actions updated (86640ad -> 04b6c16)

2020-06-12 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch enable_logs_in_integration_test_github_actions in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 86640ad Enable logging for github actions add 04b6c16

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #5543: Added configurable http listeners for controller API

2020-06-12 Thread GitBox
codecov-commenter commented on pull request #5543: URL: https://github.com/apache/incubator-pinot/pull/5543#issuecomment-643503193 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5543?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #5555: Enable logging for github actions

2020-06-12 Thread GitBox
codecov-commenter edited a comment on pull request #: URL: https://github.com/apache/incubator-pinot/pull/#issuecomment-643485612 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #5534: Replace SegmentMergeLineage to SegmentLineage

2020-06-12 Thread GitBox
mayankshriv commented on a change in pull request #5534: URL: https://github.com/apache/incubator-pinot/pull/5534#discussion_r439658171 ## File path: pinot-common/src/main/java/org/apache/pinot/common/lineage/SegmentLineage.java ## @@ -0,0 +1,153 @@ +/** + * Licensed to the

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #5555: Enable logging for github actions

2020-06-12 Thread GitBox
codecov-commenter edited a comment on pull request #: URL: https://github.com/apache/incubator-pinot/pull/#issuecomment-643485612 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/?src=pr=h1) Report > Merging

[incubator-pinot] branch default_pinot_startable_to_use_config_files updated (84ff2ff -> 538955c)

2020-06-12 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch default_pinot_startable_to_use_config_files in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 84ff2ff Adding more config alias discard 41e4604 Make Pinot

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #5555: Enable logging for github actions

2020-06-12 Thread GitBox
codecov-commenter edited a comment on pull request #: URL: https://github.com/apache/incubator-pinot/pull/#issuecomment-643485612 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5546: Handle case sensitivity for PinotQuery within BrokerRequest

2020-06-12 Thread GitBox
Jackie-Jiang commented on a change in pull request #5546: URL: https://github.com/apache/incubator-pinot/pull/5546#discussion_r439645105 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/CommonConstants.java ## @@ -40,6 +40,7 @@ public static final

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #5555: Enable logging for github actions

2020-06-12 Thread GitBox
codecov-commenter commented on pull request #: URL: https://github.com/apache/incubator-pinot/pull/#issuecomment-643485612 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/?src=pr=h1) Report > Merging

[incubator-pinot] branch master updated: Add SCALAR type into TransformFunctionType (#5544)

2020-06-12 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new fcc3144 Add SCALAR type into

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #5544: Add SCALAR type into TransformFunctionType

2020-06-12 Thread GitBox
Jackie-Jiang merged pull request #5544: URL: https://github.com/apache/incubator-pinot/pull/5544 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-pinot] branch enable_logs_in_integration_test_github_actions updated (4a4dd37 -> 86640ad)

2020-06-12 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch enable_logs_in_integration_test_github_actions in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 4a4dd37 Enable logging for github actions add 86640ad

[incubator-pinot] branch enable_logs_in_integration_test_github_actions updated (4f2b193 -> 4a4dd37)

2020-06-12 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch enable_logs_in_integration_test_github_actions in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 4f2b193 Enable logging for github actions add 4a4dd37

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #5546: Handle case sensitivity for PinotQuery within BrokerRequest

2020-06-12 Thread GitBox
codecov-commenter edited a comment on pull request #5546: URL: https://github.com/apache/incubator-pinot/pull/5546#issuecomment-643030356 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5546?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #5546: Handle case sensitivity for PinotQuery within BrokerRequest

2020-06-12 Thread GitBox
codecov-commenter edited a comment on pull request #5546: URL: https://github.com/apache/incubator-pinot/pull/5546#issuecomment-643030356 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5546?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base

[incubator-pinot] branch master updated (cd774c7 -> 91f8844)

2020-06-12 Thread akshayrai09
This is an automated email from the ASF dual-hosted git repository. akshayrai09 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from cd774c7 Return Select only Literal Expression at Broker (#5513) add 91f8844 [TE][subscription]

[GitHub] [incubator-pinot] akshayrai merged pull request #5545: [TE][subscription] Bug fix to fix the notification pipeline when detections are disabled

2020-06-12 Thread GitBox
akshayrai merged pull request #5545: URL: https://github.com/apache/incubator-pinot/pull/5545 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #5544: Add SCALAR type into TransformFunctionType

2020-06-12 Thread GitBox
codecov-commenter edited a comment on pull request #5544: URL: https://github.com/apache/incubator-pinot/pull/5544#issuecomment-643034473 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5544?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base

[GitHub] [incubator-pinot] fx19880617 opened a new pull request #5555: Enable logging for github actions

2020-06-12 Thread GitBox
fx19880617 opened a new pull request #: URL: https://github.com/apache/incubator-pinot/pull/ ## Description Enable Logging in Github Action This is an automated message from the Apache Git Service. To respond to

[incubator-pinot] branch enable_logs_in_integration_test_github_actions created (now 4f2b193)

2020-06-12 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch enable_logs_in_integration_test_github_actions in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 4f2b193 Enable logging for github actions This branch includes

[incubator-pinot] 01/01: Enable logging for github actions

2020-06-12 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch enable_logs_in_integration_test_github_actions in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit 4f2b193e740ba36e35e5db99b9df523a203719cf Author: Xiang Fu AuthorDate:

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #5544: Add SCALAR type into TransformFunctionType

2020-06-12 Thread GitBox
siddharthteotia commented on a change in pull request #5544: URL: https://github.com/apache/incubator-pinot/pull/5544#discussion_r439587265 ## File path: pinot-common/src/main/java/org/apache/pinot/common/function/TransformFunctionType.java ## @@ -70,6 +73,9 @@ public static

[GitHub] [incubator-pinot] fx19880617 merged pull request #5513: Return Select only Literal Expression at Broker

2020-06-12 Thread GitBox
fx19880617 merged pull request #5513: URL: https://github.com/apache/incubator-pinot/pull/5513 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-pinot] fx19880617 closed issue #5504: Support syntax `SELECT literal`

2020-06-12 Thread GitBox
fx19880617 closed issue #5504: URL: https://github.com/apache/incubator-pinot/issues/5504 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[incubator-pinot] branch master updated (7326d4a -> cd774c7)

2020-06-12 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 7326d4a Fixed backward incompatibility for existing stream implementations (#5549) add cd774c7

[GitHub] [incubator-pinot] pradeepgv42 commented on issue #5552: Deduping mechanism in pinot

2020-06-12 Thread GitBox
pradeepgv42 commented on issue #5552: URL: https://github.com/apache/incubator-pinot/issues/5552#issuecomment-643426034 nm, I could actually just do count(*) instead of sum(count column) 臘 This is an automated message from

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #5483: Add QueryContext to replace BrokerRequest in the query engine

2020-06-12 Thread GitBox
mayankshriv commented on a change in pull request #5483: URL: https://github.com/apache/incubator-pinot/pull/5483#discussion_r439577300 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/request/context/Expression.java ## @@ -0,0 +1,119 @@ +/** + * Licensed to

[GitHub] [incubator-pinot] pradeepgv42 commented on issue #5552: Deduping mechanism in pinot

2020-06-12 Thread GitBox
pradeepgv42 commented on issue #5552: URL: https://github.com/apache/incubator-pinot/issues/5552#issuecomment-643424042 I could use aggregate and unique, but I am thinking of following case which I believe wouldn't return accurate results, correct me if I am wrong or if there is an

[GitHub] [incubator-pinot] pradeepgv42 opened a new issue #5554: Using deep storage as a tiered storage

2020-06-12 Thread GitBox
pradeepgv42 opened a new issue #5554: URL: https://github.com/apache/incubator-pinot/issues/5554 Currently IIUC all the segments need to be on disk to be able to query them. Usually, queries to older data tends to be lower or clients would be okay with in-curing latency for queries

[GitHub] [incubator-pinot] kishoreg closed issue #5551: Provide config to pass consumer group name when using kafka as ingestion mechanism

2020-06-12 Thread GitBox
kishoreg closed issue #5551: URL: https://github.com/apache/incubator-pinot/issues/5551 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-pinot] kishoreg commented on issue #5551: Provide config to pass consumer group name when using kafka as ingestion mechanism

2020-06-12 Thread GitBox
kishoreg commented on issue #5551: URL: https://github.com/apache/incubator-pinot/issues/5551#issuecomment-643413562 Closing as this is applicable only to high-level consumers and it's already supported. This is an

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5544: Add SCALAR type into TransformFunctionType

2020-06-12 Thread GitBox
Jackie-Jiang commented on a change in pull request #5544: URL: https://github.com/apache/incubator-pinot/pull/5544#discussion_r439567697 ## File path: pinot-common/src/main/java/org/apache/pinot/common/function/TransformFunctionType.java ## @@ -70,6 +73,9 @@ public static

[GitHub] [incubator-pinot] mcvsubbu commented on issue #5552: Deduping mechanism in pinot

2020-06-12 Thread GitBox
mcvsubbu commented on issue #5552: URL: https://github.com/apache/incubator-pinot/issues/5552#issuecomment-643408607 https://docs.pinot.apache.org/basics/components/table#tableindexconfig This is an automated message from

[GitHub] [incubator-pinot] npawar opened a new issue #5553: Tiered storage support

2020-06-12 Thread GitBox
npawar opened a new issue #5553: URL: https://github.com/apache/incubator-pinot/issues/5553 Motivation: Consider use cases which have Pinot tables that have very large retention, but typically only query the most recent segments. Or use cases where very low latency is expected when

[GitHub] [incubator-pinot] mcvsubbu commented on issue #5552: Deduping mechanism in pinot

2020-06-12 Thread GitBox
mcvsubbu commented on issue #5552: URL: https://github.com/apache/incubator-pinot/issues/5552#issuecomment-643407832 There is a table config setting to aggregate metrics. If all your dimension values are same, then the metric values are added, and the rows are squished. Is this what you

[GitHub] [incubator-pinot] mcvsubbu commented on issue #5359: Extend offset support for other streams

2020-06-12 Thread GitBox
mcvsubbu commented on issue #5359: URL: https://github.com/apache/incubator-pinot/issues/5359#issuecomment-643406985 Keeping the issue open until @KKcorps verifies things This is an automated message from the Apache Git

[GitHub] [incubator-pinot] kishoreg commented on issue #5551: Provide config to pass consumer group name when using kafka as ingestion mechanism

2020-06-12 Thread GitBox
kishoreg commented on issue #5551: URL: https://github.com/apache/incubator-pinot/issues/5551#issuecomment-643406335 why is this needed? This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-pinot] kishoreg commented on issue #5552: Deduping mechanism in pinot

2020-06-12 Thread GitBox
kishoreg commented on issue #5552: URL: https://github.com/apache/incubator-pinot/issues/5552#issuecomment-643405763 @npawar This can be a good transformer to add to filter duplicate events. This is an automated

[incubator-pinot] branch master updated: Fixed backward incompatibility for existing stream implementations (#5549)

2020-06-12 Thread mcvsubbu
This is an automated email from the ASF dual-hosted git repository. mcvsubbu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 7326d4a Fixed backward

[GitHub] [incubator-pinot] mcvsubbu closed issue #5359: Extend offset support for other streams

2020-06-12 Thread GitBox
mcvsubbu closed issue #5359: URL: https://github.com/apache/incubator-pinot/issues/5359 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-pinot] mcvsubbu merged pull request #5549: Fixed backward incompatibility for existing stream implementations

2020-06-12 Thread GitBox
mcvsubbu merged pull request #5549: URL: https://github.com/apache/incubator-pinot/pull/5549 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-pinot] pradeepgv42 opened a new issue #5552: Deduping mechanism in pinot

2020-06-12 Thread GitBox
pradeepgv42 opened a new issue #5552: URL: https://github.com/apache/incubator-pinot/issues/5552 Is there a way to dedup similar rows? Will help with dealing with duplicate rows during kafka consumption and if partial data is ingested through batch mechanism (dedup the overlapping segment

[GitHub] [incubator-pinot] kishoreg commented on issue #5550: Expose lag metrics when consuming from kafka

2020-06-12 Thread GitBox
kishoreg commented on issue #5550: URL: https://github.com/apache/incubator-pinot/issues/5550#issuecomment-643399886 Relevant links - https://twitter.com/KishoreBytes/status/1250557828500090880 - https://github.com/lightbend/kafka-lag-exporter -

[GitHub] [incubator-pinot] pradeepgv42 opened a new issue #5551: Provide config to pass consumer group name when using kafka as ingestion mechanism

2020-06-12 Thread GitBox
pradeepgv42 opened a new issue #5551: URL: https://github.com/apache/incubator-pinot/issues/5551 Currently I see that consumer group name is defaulting to empty string, it would be nice to pass consumer group as a parameter to the pinot table config.

[GitHub] [incubator-pinot] pradeepgv42 opened a new issue #5550: Expose lag metrics when consuming from kafka

2020-06-12 Thread GitBox
pradeepgv42 opened a new issue #5550: URL: https://github.com/apache/incubator-pinot/issues/5550 Expose lag metrics when consuming from kafka, this could be sum across all partitions of (approx offset at broker - latest offset consumed) which would be very accurate but should be a close

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #5549: Fixed backward incompatibility for existing stream implementations

2020-06-12 Thread GitBox
codecov-commenter commented on pull request #5549: URL: https://github.com/apache/incubator-pinot/pull/5549#issuecomment-643388945 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5549?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] mcvsubbu opened a new pull request #5549: Fixed backward incompatibility for existing stream implementations

2020-06-12 Thread GitBox
mcvsubbu opened a new pull request #5549: URL: https://github.com/apache/incubator-pinot/pull/5549 PR #5542 introduced incompatibility in the interfaces for existing stream implementations (like eventhub or other kafka implementations) Added default implementations so that the other

[GitHub] [incubator-pinot] siddharthteotia commented on pull request #5483: Add QueryContext to replace BrokerRequest in the query engine

2020-06-12 Thread GitBox
siddharthteotia commented on pull request #5483: URL: https://github.com/apache/incubator-pinot/pull/5483#issuecomment-643344043 I missed reviewing the converter earlier. Will do another pass today. This is an automated

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #5544: Add SCALAR type into TransformFunctionType

2020-06-12 Thread GitBox
siddharthteotia commented on a change in pull request #5544: URL: https://github.com/apache/incubator-pinot/pull/5544#discussion_r439497342 ## File path: pinot-common/src/main/java/org/apache/pinot/common/function/TransformFunctionType.java ## @@ -70,6 +73,9 @@ public static

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #5534: Replace SegmentMergeLineage to SegmentLineage

2020-06-12 Thread GitBox
codecov-commenter edited a comment on pull request #5534: URL: https://github.com/apache/incubator-pinot/pull/5534#issuecomment-642525270 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5534?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #5534: Replace SegmentMergeLineage to SegmentLineage

2020-06-12 Thread GitBox
codecov-commenter edited a comment on pull request #5534: URL: https://github.com/apache/incubator-pinot/pull/5534#issuecomment-642525270 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5534?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base

[GitHub] [incubator-pinot] daniellavoie commented on a change in pull request #5543: Added configurable http listeners for controller API

2020-06-12 Thread GitBox
daniellavoie commented on a change in pull request #5543: URL: https://github.com/apache/incubator-pinot/pull/5543#discussion_r439368799 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java ## @@ -29,21 +29,28 @@ import

[incubator-pinot] annotated tag release-0.4.0 updated (8355d2e -> 99df950)

2020-06-12 Thread haibow
This is an automated email from the ASF dual-hosted git repository. haibow pushed a change to annotated tag release-0.4.0 in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. *** WARNING: tag release-0.4.0 was modified! *** from 8355d2e (commit) to 99df950 (tag)

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #5513: Return Select only Literal Expression at Broker

2020-06-12 Thread GitBox
codecov-commenter edited a comment on pull request #5513: URL: https://github.com/apache/incubator-pinot/pull/5513#issuecomment-641655758 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #5513: Return Select only Literal Expression at Broker

2020-06-12 Thread GitBox
codecov-commenter edited a comment on pull request #5513: URL: https://github.com/apache/incubator-pinot/pull/5513#issuecomment-641655758 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5513?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base

svn commit: r40022 - /dev/incubator/pinot/apache-pinot-incubating-0.4.0-rc2/ /release/incubator/pinot/apache-pinot-incubating-0.4.0/

2020-06-12 Thread haibow
Author: haibow Date: Fri Jun 12 07:43:46 2020 New Revision: 40022 Log: Release apache-pinot-incubating-0.4.0-rc2 Added: release/incubator/pinot/apache-pinot-incubating-0.4.0/ - copied from r40021, dev/incubator/pinot/apache-pinot-incubating-0.4.0-rc2/ Removed:

[GitHub] [incubator-pinot] siddharthteotia opened a new pull request #5548: Integrate vectorized bit-unpacking

2020-06-12 Thread GitBox
siddharthteotia opened a new pull request #5548: URL: https://github.com/apache/incubator-pinot/pull/5548 ## Description In PR https://github.com/apache/incubator-pinot/pull/5409, we implement efficient vectorized bit unpacking reader (no format change, just new algorithms) for

[GitHub] [incubator-pinot] haibow merged pull request #5547: Update year in NOTICE-binary

2020-06-12 Thread GitBox
haibow merged pull request #5547: URL: https://github.com/apache/incubator-pinot/pull/5547 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[incubator-pinot] branch master updated: Update year in NOTICE-binary (#5547)

2020-06-12 Thread haibow
This is an automated email from the ASF dual-hosted git repository. haibow pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 2692d9f Update year in NOTICE-binary