navina opened a new pull request, #9851:
URL: https://github.com/apache/pinot/pull/9851
Related to #9771
After a schema evolves (eg. new column added), the column is not treated as
an upsert column by the partition upsert manager because it is not part of
codecov-commenter commented on PR #9849:
URL: https://github.com/apache/pinot/pull/9849#issuecomment-1324630346
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/9849?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
Report
codecov-commenter commented on PR #9850:
URL: https://github.com/apache/pinot/pull/9850#issuecomment-1324626639
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/9850?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
Report
61yao opened a new pull request, #9850:
URL: https://github.com/apache/pinot/pull/9850
1) Add basic math func test
2) Add between literal test
3) Add between test for string type
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
snleee commented on PR #9849:
URL: https://github.com/apache/pinot/pull/9849#issuecomment-1324586307
https://github.com/apache/pinot/issues/8804
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
snleee opened a new pull request, #9849:
URL: https://github.com/apache/pinot/pull/9849
Currently, we have a separate configuration for replication. Offline and HLC
reads from `replication` and LLC reads from `replicasPerPartition`. This PR
combines the read access for the replication
yupeng9 commented on issue #8804:
URL: https://github.com/apache/pinot/issues/8804#issuecomment-1324529479
Missed this thread. Uber uses LLC only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
snleee opened a new issue, #9847:
URL: https://github.com/apache/pinot/issues/9847
Currently, many record reader implementation supports to read either raw
file or gzip file as an input. For instance, csv record reader can understand
both `data.csv` and `data.csv.gz`.
Here are the
61yao commented on code in PR #9832:
URL: https://github.com/apache/pinot/pull/9832#discussion_r1029934624
##
pinot-query-runtime/src/test/resources/queries/OrderBy.json:
##
@@ -0,0 +1,221 @@
+{
+ "basic_order_by": {
+"tables": {
+ "basic": {
+"schema": [
+
Jackie-Jiang commented on issue #9820:
URL: https://github.com/apache/pinot/issues/9820#issuecomment-1324399426
Not all expressions work though. If the result of the expression is type
`INT`, then it won't work, and the current optimizer cannot fix it
--
This is an automated message from
amrishlal commented on issue #9820:
URL: https://github.com/apache/pinot/issues/9820#issuecomment-1324397213
> After a second thought, should we consider handling it in the
PredicateEvaluatorFactory where the data type is already known? That way we can
also handle arbitrary expressions on
Jackie-Jiang commented on issue #9812:
URL: https://github.com/apache/pinot/issues/9812#issuecomment-1324396500
Actually this is not an aggregation group-by. Is the intention to get the
distinct values? It didn't fail in `0.10.0` probably because the `GROUP BY` is
ignored?
To get the
Jackie-Jiang commented on code in PR #9802:
URL: https://github.com/apache/pinot/pull/9802#discussion_r1029878916
##
pinot-core/src/main/java/org/apache/pinot/core/data/manager/offline/MemoryOptimizedDimensionTable.java:
##
@@ -0,0 +1,71 @@
+/**
+ * Licensed to the Apache
61yao commented on code in PR #9832:
URL: https://github.com/apache/pinot/pull/9832#discussion_r1029892679
##
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/IntExprRexVisitor.java:
##
@@ -0,0 +1,126 @@
+/**
+ * Licensed to the Apache Software
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new d62a867d46 Add max merger and min mergers for
Jackie-Jiang merged PR #9665:
URL: https://github.com/apache/pinot/pull/9665
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
codecov-commenter commented on PR #9846:
URL: https://github.com/apache/pinot/pull/9846#issuecomment-1324362961
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/9846?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)
Report
agavra opened a new pull request, #9846:
URL: https://github.com/apache/pinot/pull/9846
- tests various types for CASE WHEN statements
- tests nested CASE WHEN statements with aggs/joins
- fixes a bug with literals and ' '-padding behavior
--
This is an automated message from the
mndoping1 commented on issue #9845:
URL: https://github.com/apache/pinot/issues/9845#issuecomment-1324322101
closing as created the issue in approprate repository here:
https://github.com/python-pinot-dbapi/pinot-dbapi/issues/52
--
This is an automated message from the Apache Git
mndoping1 closed issue #9845: Allow Pinotdb client to hit v2 engine
URL: https://github.com/apache/pinot/issues/9845
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
ankitsultana commented on code in PR #9808:
URL: https://github.com/apache/pinot/pull/9808#discussion_r1029878486
##
pinot-broker/src/test/java/org/apache/pinot/broker/routing/instanceselector/InstanceSelectorTest.java:
##
@@ -814,14 +837,121 @@ public void
Jackie-Jiang commented on issue #9788:
URL: https://github.com/apache/pinot/issues/9788#issuecomment-1324317790
On the server side, we have
`pinot.query.scheduler.query.log.maxRatePerSecond` which is similar to the
config on the broker side. More configs can be found here:
mndoping1 opened a new issue, #9845:
URL: https://github.com/apache/pinot/issues/9845
Python's Pinotdb client version 0.4.5 does not support `table aliasing`. For
example, queries such as `SELECT "tbl1"."x" FROM "y" "tbl1"` aren't able to
run. However, Pinot's v2 engine allows table
jadami10 opened a new pull request, #9844:
URL: https://github.com/apache/pinot/pull/9844
addresses #9843
this is a `ui` `bugfix`
This is probably not the greatest way to do this. Transforming the data from
bytes -> humanized -> bytes just to sort it feels hacky. But short of
KKcorps commented on issue #9840:
URL: https://github.com/apache/pinot/issues/9840#issuecomment-1324271076
Agreed. Will add the update functionality in the command.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
agavra commented on PR #9832:
URL: https://github.com/apache/pinot/pull/9832#issuecomment-1324225162
> Is it possible we re-arrange columns in intermediate stage instead if we
pass data schema to intermediate stage? This way we can leave the leaf stage
untouched.
@61yao no it isn't,
Jackie-Jiang commented on code in PR #9804:
URL: https://github.com/apache/pinot/pull/9804#discussion_r1029762721
##
pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java:
##
@@ -91,6 +91,7 @@ public abstract class BaseTableDataManager implements
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 32314bb433 Fix Spark connector empty datatable
Jackie-Jiang merged PR #9837:
URL: https://github.com/apache/pinot/pull/9837
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Jackie-Jiang commented on issue #9840:
URL: https://github.com/apache/pinot/issues/9840#issuecomment-1324156875
Link #9834 which is for the same topic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
Jackie-Jiang commented on issue #9840:
URL: https://github.com/apache/pinot/issues/9840#issuecomment-1324154183
We should either add a `-update` flag in the `AddTableCommand` or provide a
`UpdateTableCommand` to update the table. Also, seems we also need the
`DeleteTableCommand`.
cc
61yao commented on code in PR #9832:
URL: https://github.com/apache/pinot/pull/9832#discussion_r1029748399
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/plan/ServerRequestPlanVisitor.java:
##
@@ -90,6 +92,9 @@ public static ServerPlanRequestContext
Jackie-Jiang commented on issue #9839:
URL: https://github.com/apache/pinot/issues/9839#issuecomment-1324150138
@ashishkf Good point! There are actually some discussion about providing
reversed doc iterator in #8979. We should consider adding a method to return
the reversed iterator, and
61yao commented on PR #9832:
URL: https://github.com/apache/pinot/pull/9832#issuecomment-1324147001
> @Jackie-Jiang - yes, the V2 engine requires that the server returns
columns in the order that would be the result of the logical plan (and also
that it doesn't have extra or missing
Jackie-Jiang commented on issue #9393:
URL: https://github.com/apache/pinot/issues/9393#issuecomment-1324144928
This is a known issue, which is tracked here #9102
Is the problem resolved after removing these 2 extra entries?
--
This is an automated message from the Apache Git
agavra commented on PR #9832:
URL: https://github.com/apache/pinot/pull/9832#issuecomment-1324124148
@Jackie-Jiang - yes, the V2 engine requires that the server returns columns
in the order that would be the result of the logical plan (and also that it
doesn't have extra or missing
Jackie-Jiang commented on issue #9843:
URL: https://github.com/apache/pinot/issues/9843#issuecomment-1324066979
cc @joshigaurava @jayeshchoudhary @jadami10
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
Jackie-Jiang opened a new issue, #9843:
URL: https://github.com/apache/pinot/issues/9843
It should be size order instead with regard to unit (e.g. GB before MB)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
siddharthteotia commented on PR #9727:
URL: https://github.com/apache/pinot/pull/9727#issuecomment-1324035346
@jasperjiaguo might want to share some example validation we did internally
on PROD use case to demonstrate killing.
Let's also make sure to address any comments that come
siddharthteotia merged PR #9727:
URL: https://github.com/apache/pinot/pull/9727
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
tingchen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 6cfa6dca8b Download offline segments from
chenboat merged PR #9710:
URL: https://github.com/apache/pinot/pull/9710
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
gortiz commented on PR #9842:
URL: https://github.com/apache/pinot/pull/9842#issuecomment-1323953675
This first commit is a draft. Tests need to be extended to cover the new
implementation and I would also add at least one benchmark to verify that there
is no performance degradation. It
gortiz opened a new pull request, #9842:
URL: https://github.com/apache/pinot/pull/9842
This PR explores the possibility of using [Chronicle
Bytes](https://github.com/OpenHFT/Chronicle-Bytes) as an implementation of
PinotDataBuffer instead of LArray. The main reason to do that is to be
vmarchaud commented on issue #9812:
URL: https://github.com/apache/pinot/issues/9812#issuecomment-1323886488
@Jackie-Jiang I'm using the default
(https://github.com/apache/pinot/blob/master/pinot-tools/src/main/resources/conf/log4j2.xml)
log4j and i can't find any stacktrace in the log
61yao commented on PR #9836:
URL: https://github.com/apache/pinot/pull/9836#issuecomment-1323298327
I took a look again about the fairness scheduling. This PR has nothing to do
with that because it only deals with sending mailbox instead of receiving. I
agree receiving side needs more
46 matches
Mail list logo
