[GitHub] [incubator-pinot] jihaozh merged pull request #5855: [TE] Fix wrong task pickup logic

2020-08-13 Thread GitBox
jihaozh merged pull request #5855: URL: https://github.com/apache/incubator-pinot/pull/5855 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-pinot] lgo opened a new issue #5859: Lack of documentation about cluster networking

2020-08-13 Thread GitBox
lgo opened a new issue #5859: URL: https://github.com/apache/incubator-pinot/issues/5859 While setting up a Pinot cluster in an environment with strict egress/ingress rules it has been a challenge to bump into various cluster interop that wasn't documented. Based on the docs I

[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #5702: Fix the issue of group-by not working on strings with "\t"

2020-08-13 Thread GitBox
Jackie-Jiang commented on issue #5702: URL: https://github.com/apache/incubator-pinot/issues/5702#issuecomment-673310604 #5858 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-pinot] Jackie-Jiang opened a new pull request #5858: Change group key delimiter from '\t' to '\0'

2020-08-13 Thread GitBox
Jackie-Jiang opened a new pull request #5858: URL: https://github.com/apache/incubator-pinot/pull/5858 ## Description Using '\t' as the group key delimiter will cause unexpected behavior when grouping on string value with '\t' inside. To solve it, we can use '\0' as the delimiter which

[GitHub] [incubator-pinot] chenboat opened a new pull request #5857: Add a Deepstore bypass integration test without minor bug fixes to make the feature work.

2020-08-13 Thread GitBox
chenboat opened a new pull request #5857: URL: https://github.com/apache/incubator-pinot/pull/5857 ## Description Add an integration test that extends RealtimeClusterIntegrationTest but uses 2 servers and a fake PinotFS as the deep store for segments. This test enables the peer to peer

[GitHub] [incubator-pinot] guruguha commented on pull request #5718: Feature/#5390 segment indexing reload status api

2020-08-13 Thread GitBox
guruguha commented on pull request #5718: URL: https://github.com/apache/incubator-pinot/pull/5718#issuecomment-673286243 > > A lot of code duplication with the existing table size reader. Please find ways to use a common base class if possible > > Is this addressed? Oh!

[GitHub] [incubator-pinot] kishoreg commented on pull request #5718: Feature/#5390 segment indexing reload status api

2020-08-13 Thread GitBox
kishoreg commented on pull request #5718: URL: https://github.com/apache/incubator-pinot/pull/5718#issuecomment-673284226 > A lot of code duplication with the existing table size reader. Please find ways to use a common base class if possible Is this addressed?

[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #5738: HAVING and Post-Aggregation Support

2020-08-12 Thread GitBox
Jackie-Jiang commented on issue #5738: URL: https://github.com/apache/incubator-pinot/issues/5738#issuecomment-673192834 Order-by post-aggregation support: #5856 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-pinot] Jackie-Jiang opened a new pull request #5856: [Post-Aggregation] Support post-aggregation in ORDER-BY

2020-08-12 Thread GitBox
Jackie-Jiang opened a new pull request #5856: URL: https://github.com/apache/incubator-pinot/pull/5856 ## Description Enhance `TableResizer` to support post-aggregation in ORDER-BY clause This is an automated message from

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #5849: [Post-aggregation] Support type conversion for all scalar functions

2020-08-12 Thread GitBox
Jackie-Jiang merged pull request #5849: URL: https://github.com/apache/incubator-pinot/pull/5849 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-pinot] jasonyanwenl opened a new pull request #5855: [TE] Fix wrong task pickup logic

2020-08-12 Thread GitBox
jasonyanwenl opened a new pull request #5855: URL: https://github.com/apache/incubator-pinot/pull/5855 The logic in the `TaskDriver` for picking a task is wrong in #5769. This is the PR for fixing it. This is an automated

[GitHub] [incubator-pinot] fx19880617 commented on issue #5820: Query execution error when grouping by multi-value dimension and non-dictionary encoded dimension

2020-08-12 Thread GitBox
fx19880617 commented on issue #5820: URL: https://github.com/apache/incubator-pinot/issues/5820#issuecomment-673164217 Pinot doesn't support non-dictionary index on multi-value column, so the dictionary is still there even if it's configured. The real issue is that the code goes to

[GitHub] [incubator-pinot] fx19880617 merged pull request #5851: Support multi-value non-dictionary group by

2020-08-12 Thread GitBox
fx19880617 merged pull request #5851: URL: https://github.com/apache/incubator-pinot/pull/5851 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-pinot] jasonyanwenl commented on a change in pull request #5769: [TE] add anomaly detection as a service - Phase 1

2020-08-12 Thread GitBox
jasonyanwenl commented on a change in pull request #5769: URL: https://github.com/apache/incubator-pinot/pull/5769#discussion_r469606604 ## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/anomaly/task/TaskDriver.java ## @@ -183,8 +192,11 @@ private

[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #5769: [TE] add anomaly detection as a service - Phase 1

2020-08-12 Thread GitBox
jihaozh commented on a change in pull request #5769: URL: https://github.com/apache/incubator-pinot/pull/5769#discussion_r469601236 ## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/anomaly/task/TaskDriver.java ## @@ -183,8 +192,11 @@ private

[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #5769: [TE] add anomaly detection as a service - Phase 1

2020-08-12 Thread GitBox
jihaozh commented on a change in pull request #5769: URL: https://github.com/apache/incubator-pinot/pull/5769#discussion_r469601236 ## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/anomaly/task/TaskDriver.java ## @@ -183,8 +192,11 @@ private

[GitHub] [incubator-pinot] Jackie-Jiang commented on pull request #5851: Support multi-value non-dictionary group by

2020-08-12 Thread GitBox
Jackie-Jiang commented on pull request #5851: URL: https://github.com/apache/incubator-pinot/pull/5851#issuecomment-673128645 I think H2 does not support MV columns, so you might need to add the test into `MultiValueQueriesTest`

[GitHub] [incubator-pinot] kishoreg commented on issue #5837: Apache Pulsar integration

2020-08-12 Thread GitBox
kishoreg commented on issue #5837: URL: https://github.com/apache/incubator-pinot/issues/5837#issuecomment-673117272 Sure, let me assign this to you. This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-pinot] mangrrua closed issue #5598: Spark-Pinot connector to read and write data from/to Pinot directly

2020-08-12 Thread GitBox
mangrrua closed issue #5598: URL: https://github.com/apache/incubator-pinot/issues/5598 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-pinot] npawar edited a comment on pull request #5438: Add additional datetime functionality

2020-08-12 Thread GitBox
npawar edited a comment on pull request #5438: URL: https://github.com/apache/incubator-pinot/pull/5438#issuecomment-673033710 > @reallocf Can we keep java function names in camelCase and use @ScalarFunction annotation's name parameter to provide names to be used in queries? >

[GitHub] [incubator-pinot] mayankshriv merged pull request #5854: Fix encrypted file path in Segment Fetcher

2020-08-12 Thread GitBox
mayankshriv merged pull request #5854: URL: https://github.com/apache/incubator-pinot/pull/5854 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-pinot] kishoreg commented on pull request #5249: Adding Pinot S3 Filesystem Plugin

2020-08-12 Thread GitBox
kishoreg commented on pull request #5249: URL: https://github.com/apache/incubator-pinot/pull/5249#issuecomment-673045678 @kunaldawn can you create another issue to add support for minio? This is an automated message from

[GitHub] [incubator-pinot] fx19880617 edited a comment on pull request #5249: Adding Pinot S3 Filesystem Plugin

2020-08-12 Thread GitBox
fx19880617 edited a comment on pull request #5249: URL: https://github.com/apache/incubator-pinot/pull/5249#issuecomment-673043114 > how do I connect with [minio](https://min.io/)? If minio provides native posix api, then you can mount it and treat it as local filesystem to use the

[GitHub] [incubator-pinot] fx19880617 commented on pull request #5249: Adding Pinot S3 Filesystem Plugin

2020-08-12 Thread GitBox
fx19880617 commented on pull request #5249: URL: https://github.com/apache/incubator-pinot/pull/5249#issuecomment-673043114 > how do I connect with [minio](https://min.io/)? If minio provides native posix api, then you can mount it and treat it as local filesystem to use the path

[GitHub] [incubator-pinot] kunaldawn commented on pull request #5249: Adding Pinot S3 Filesystem Plugin

2020-08-12 Thread GitBox
kunaldawn commented on pull request #5249: URL: https://github.com/apache/incubator-pinot/pull/5249#issuecomment-673037326 how do I connect with [minio](https://min.io/ )? This is an automated message from the Apache Git

[GitHub] [incubator-pinot] npawar commented on pull request #5438: Add additional datetime functionality

2020-08-12 Thread GitBox
npawar commented on pull request #5438: URL: https://github.com/apache/incubator-pinot/pull/5438#issuecomment-673033710 > @reallocf Can we keep java function names in camelCase and use @ScalarFunction annotation's name parameter to provide names to be used in queries? > Otherwise LGTM!

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5851: Support multi-value non-dictionary group by

2020-08-12 Thread GitBox
Jackie-Jiang commented on a change in pull request #5851: URL: https://github.com/apache/incubator-pinot/pull/5851#discussion_r469439805 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/groupby/NoDictionaryMultiColumnGroupKeyGenerator.java ## @@

[GitHub] [incubator-pinot] KKcorps commented on pull request #5438: Add additional datetime functionality

2020-08-12 Thread GitBox
KKcorps commented on pull request #5438: URL: https://github.com/apache/incubator-pinot/pull/5438#issuecomment-673017035 @reallocf Can we keep java function names in camelCase and use @ScalarFunction annotation's name parameter to provide names to be used in queries? Otherwise LGTM!

[GitHub] [incubator-pinot] npawar commented on pull request #5438: Add additional datetime functionality

2020-08-12 Thread GitBox
npawar commented on pull request #5438: URL: https://github.com/apache/incubator-pinot/pull/5438#issuecomment-673003546 @fx19880617 i've resolved the merge conflicts on this one. could you take a look again? @KKcorps i had to change the ScalarTransformFunctionWrapper constructor.

[GitHub] [incubator-pinot] sajjad-moradi opened a new pull request #5854: Fix encrypted file path in Segment Fetcher

2020-08-12 Thread GitBox
sajjad-moradi opened a new pull request #5854: URL: https://github.com/apache/incubator-pinot/pull/5854 ## Description The encoded suffix `.enc` needs to be added to the destination path to make a separate temporary file. For example, for destination file `foo/bar`, currently the temp

[GitHub] [incubator-pinot] KKcorps opened a new pull request #5853: Add Range Indexing support for raw values

2020-08-12 Thread GitBox
KKcorps opened a new pull request #5853: URL: https://github.com/apache/incubator-pinot/pull/5853 This PR involves the following changes * Create new interface RawValueBasedRangeIndexCreator * Add support for raw value in existing Range indexer.

[GitHub] [incubator-pinot] adriancole commented on pull request #5818: Makes Pinot work on Alpine Linux or Distroless + BusyBox

2020-08-12 Thread GitBox
adriancole commented on pull request #5818: URL: https://github.com/apache/incubator-pinot/pull/5818#issuecomment-672845582 thanks for the fast turnaround and the help fixing the branch to make it work @fx19880617 This is

[GitHub] [incubator-pinot] snleee opened a new pull request #5852: Fix the variable names for off-heap alloc configs

2020-08-12 Thread GitBox
snleee opened a new pull request #5852: URL: https://github.com/apache/incubator-pinot/pull/5852 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-pinot] fx19880617 edited a comment on pull request #5818: Makes Pinot work on Alpine Linux or Distroless + BusyBox

2020-08-12 Thread GitBox
fx19880617 edited a comment on pull request #5818: URL: https://github.com/apache/incubator-pinot/pull/5818#issuecomment-672728402 > PS I had a bug in my comment [#5818 (comment)](https://github.com/apache/incubator-pinot/pull/5818#issuecomment-670817753) now is fixed. I didn't notice the

[GitHub] [incubator-pinot] fx19880617 merged pull request #5818: Makes Pinot work on Alpine Linux or Distroless + BusyBox

2020-08-12 Thread GitBox
fx19880617 merged pull request #5818: URL: https://github.com/apache/incubator-pinot/pull/5818 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-pinot] fx19880617 closed issue #5809: Make at least pinot-admin.sh work with BusyBox (/bin/sh)

2020-08-12 Thread GitBox
fx19880617 closed issue #5809: URL: https://github.com/apache/incubator-pinot/issues/5809 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-pinot] fx19880617 commented on pull request #5818: Makes Pinot work on Alpine Linux or Distroless + BusyBox

2020-08-12 Thread GitBox
fx19880617 commented on pull request #5818: URL: https://github.com/apache/incubator-pinot/pull/5818#issuecomment-672728402 > PS I had a bug in my comment [#5818 (comment)](https://github.com/apache/incubator-pinot/pull/5818#issuecomment-670817753) now is fixed. I didn't notice the fork

[GitHub] [incubator-pinot] fx19880617 opened a new pull request #5851: Support multi-value non-dictionary group by

2020-08-12 Thread GitBox
fx19880617 opened a new pull request #5851: URL: https://github.com/apache/incubator-pinot/pull/5851 ## Description Support multi-value non-dictionary group by This is an automated message from the Apache Git Service.

[GitHub] [incubator-pinot] fx19880617 merged pull request #5787: [Feature] - Spark Pinot Connector

2020-08-12 Thread GitBox
fx19880617 merged pull request #5787: URL: https://github.com/apache/incubator-pinot/pull/5787 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-pinot] kishoreg commented on issue #5850: Docker HEALTHCHECK guidance

2020-08-12 Thread GitBox
kishoreg commented on issue #5850: URL: https://github.com/apache/incubator-pinot/issues/5850#issuecomment-672634078 providing a /health end point should be possible, we also need a swagger endpoint This is an automated

[GitHub] [incubator-pinot] kishoreg edited a comment on issue #5850: Docker HEALTHCHECK guidance

2020-08-12 Thread GitBox
kishoreg edited a comment on issue #5850: URL: https://github.com/apache/incubator-pinot/issues/5850#issuecomment-672634078 providing a /health end point should be possible, we also need a swagger resource This is an

[GitHub] [incubator-pinot] adriancole opened a new issue #5850: Docker HEALTHCHECK guidance

2020-08-11 Thread GitBox
adriancole opened a new issue #5850: URL: https://github.com/apache/incubator-pinot/issues/5850 There is awesome flexibility we allow with anything from all-in-one until distributed deployment. I love it. This presents a healthcheck challenge as certain ordering constraints remain

[GitHub] [incubator-pinot] mangrrua edited a comment on pull request #5787: [Feature] - Spark Pinot Connector

2020-08-11 Thread GitBox
mangrrua edited a comment on pull request #5787: URL: https://github.com/apache/incubator-pinot/pull/5787#issuecomment-672613922 > @fx19880617 @mangrrua anything pending on this? Seems no @kishoreg This is an

[GitHub] [incubator-pinot] mangrrua commented on pull request #5787: [Feature] - Spark Pinot Connector

2020-08-11 Thread GitBox
mangrrua commented on pull request #5787: URL: https://github.com/apache/incubator-pinot/pull/5787#issuecomment-672613922 > @fx19880617 @mangrrua anything pending on this? Seems no This is an automated message from

[GitHub] [incubator-pinot] mangrrua commented on a change in pull request #5787: [Feature] - Spark Pinot Connector

2020-08-11 Thread GitBox
mangrrua commented on a change in pull request #5787: URL: https://github.com/apache/incubator-pinot/pull/5787#discussion_r468554247 ## File path: pinot-connectors/pinot-spark-connector/src/main/scala/org/apache/pinot/connector/spark/connector/PinotServerDataFetcher.scala ##

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #5718: Feature/#5390 segment indexing reload status api

2020-08-11 Thread GitBox
kishoreg commented on a change in pull request #5718: URL: https://github.com/apache/incubator-pinot/pull/5718#discussion_r469006145 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java ## @@ -485,4 +503,80 @@

[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #5738: HAVING and Post-Aggregation Support

2020-08-11 Thread GitBox
Jackie-Jiang commented on issue #5738: URL: https://github.com/apache/incubator-pinot/issues/5738#issuecomment-672571284 Scalar function type conversion support: #5849 This is an automated message from the Apache Git

[GitHub] [incubator-pinot] Jackie-Jiang opened a new pull request #5849: [Post-aggregation] Support type conversion for all scalar functions

2020-08-11 Thread GitBox
Jackie-Jiang opened a new pull request #5849: URL: https://github.com/apache/incubator-pinot/pull/5849 ## Description Support type conversion for all scalar functions. Parameter classes supported for type conversion using `PinotDataType`: - int/Integer - long/Long -

[GitHub] [incubator-pinot] apucher merged pull request #5848: DataGenerator should tolerate DATE_TIME and COMPLEX fields

2020-08-11 Thread GitBox
apucher merged pull request #5848: URL: https://github.com/apache/incubator-pinot/pull/5848 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-pinot] fx19880617 commented on issue #5820: Query execution error when grouping by multi-value dimension and non-dictionary encoded dimension

2020-08-11 Thread GitBox
fx19880617 commented on issue #5820: URL: https://github.com/apache/incubator-pinot/issues/5820#issuecomment-672493742 Currently we are not supporting No-Dictionary multi-value column in groupby right now. The relative code path is in

[GitHub] [incubator-pinot] apucher commented on pull request #5848: DataGenerator should tolerate DATE_TIME and COMPLEX fields

2020-08-11 Thread GitBox
apucher commented on pull request #5848: URL: https://github.com/apache/incubator-pinot/pull/5848#issuecomment-672448160 we may actually consider removing it. afaik there's no active use of it This is an automated message

[GitHub] [incubator-pinot] apucher commented on pull request #5848: DataGenerator should tolerate DATE_TIME and COMPLEX fields

2020-08-11 Thread GitBox
apucher commented on pull request #5848: URL: https://github.com/apache/incubator-pinot/pull/5848#issuecomment-672447672 @Jackie-Jiang we already do when using the pattern data generator. the crappy old code is around for backwards compatibility only.

[GitHub] [incubator-pinot] npawar commented on pull request #5848: DataGenerator should tolerate DATE_TIME and COMPLEX fields

2020-08-11 Thread GitBox
npawar commented on pull request #5848: URL: https://github.com/apache/incubator-pinot/pull/5848#issuecomment-672446619 it should be fine to ignore the field for now. Eventually we want to handle it just like TIME case This

[GitHub] [incubator-pinot] Jackie-Jiang commented on pull request #5848: DataGenerator should tolerate DATE_TIME and COMPLEX fields

2020-08-11 Thread GitBox
Jackie-Jiang commented on pull request #5848: URL: https://github.com/apache/incubator-pinot/pull/5848#issuecomment-672440092 @npawar Please take a look and see whether we should support generating data for date time fields

[GitHub] [incubator-pinot] apucher opened a new pull request #5848: tolerate DATE_TIME and COMPLEX fields

2020-08-11 Thread GitBox
apucher opened a new pull request #5848: URL: https://github.com/apache/incubator-pinot/pull/5848 ## Description Fixes a forward compatibility issue with DATE_TIME fields in the data generator ## Upgrade Notes Does this PR prevent a zero down-time upgrade? **no**

[GitHub] [incubator-pinot] akshayrai merged pull request #5847: [TE] Added /application/reset API +refactor

2020-08-11 Thread GitBox
akshayrai merged pull request #5847: URL: https://github.com/apache/incubator-pinot/pull/5847 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-pinot] suvodeep-pyne commented on pull request #5847: [TE] Added /application/reset API +refactor

2020-08-11 Thread GitBox
suvodeep-pyne commented on pull request #5847: URL: https://github.com/apache/incubator-pinot/pull/5847#issuecomment-672416913 Thanks a lot @akshayrai ! This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-pinot] suvodeep-pyne opened a new pull request #5847: [TE] Added /application/reset API +refactor

2020-08-11 Thread GitBox
suvodeep-pyne opened a new pull request #5847: URL: https://github.com/apache/incubator-pinot/pull/5847 ## Description - Added /application/reset/{name}. Resets an application - Reset Usage: Primarily for demo purposes. It cleans up all old alerts and anomalies - Refactored

[GitHub] [incubator-pinot] adriancole commented on pull request #5818: Makes Pinot work on Alpine Linux or Distroless + BusyBox

2020-08-11 Thread GitBox
adriancole commented on pull request #5818: URL: https://github.com/apache/incubator-pinot/pull/5818#issuecomment-672397474 PS I had a bug in my comment https://github.com/apache/incubator-pinot/pull/5818#issuecomment-670817753 now is fixed. I didn't notice the fork about JRE 9+ needing

[GitHub] [incubator-pinot] adriancole edited a comment on pull request #5818: Makes Pinot work on Alpine Linux or Distroless + BusyBox

2020-08-11 Thread GitBox
adriancole edited a comment on pull request #5818: URL: https://github.com/apache/incubator-pinot/pull/5818#issuecomment-670817753 fyi I'm currently inlining a script as when you consider docker knows the only image it will run on, the script doesn't need to do work like detect OS, JVM

[GitHub] [incubator-pinot] fx19880617 merged pull request #5846: Adding controller healthcheck endpoint: /health

2020-08-11 Thread GitBox
fx19880617 merged pull request #5846: URL: https://github.com/apache/incubator-pinot/pull/5846 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-pinot] fx19880617 closed issue #5803: Controllers do not have a `/health` resource

2020-08-11 Thread GitBox
fx19880617 closed issue #5803: URL: https://github.com/apache/incubator-pinot/issues/5803 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-pinot] fx19880617 opened a new pull request #5846: Adding controller healthcheck endpoint: /health

2020-08-11 Thread GitBox
fx19880617 opened a new pull request #5846: URL: https://github.com/apache/incubator-pinot/pull/5846 ## Description Adding controller health check endpoint: /health to be on par with other pinot components. Existing check: `/pinot-controller/admin` is still available without any

[GitHub] [incubator-pinot] kishoreg commented on pull request #5787: [Feature] - Spark Pinot Connector

2020-08-11 Thread GitBox
kishoreg commented on pull request #5787: URL: https://github.com/apache/incubator-pinot/pull/5787#issuecomment-672287954 @fx19880617 @mangrrua anything pending on this? This is an automated message from the Apache Git

[GitHub] [incubator-pinot] fx19880617 commented on issue #5803: Controllers do not have a `/health` resource

2020-08-11 Thread GitBox
fx19880617 commented on issue #5803: URL: https://github.com/apache/incubator-pinot/issues/5803#issuecomment-672278520 Make sense, we will add `/health` to controller. Current health check for controller is using `/pinot-controller/admin`

[GitHub] [incubator-pinot] fx19880617 commented on issue #5802: Running Pinot with an invalid zookeeper service name seems to error during clean-up (in addition to connection error)

2020-08-11 Thread GitBox
fx19880617 commented on issue #5802: URL: https://github.com/apache/incubator-pinot/issues/5802#issuecomment-672277394 This will error out during start up as controller cannot connect to zookeeper for further processing. And you can safely ignore this helix cleanup as there is no

[GitHub] [incubator-pinot] kishoreg merged pull request #5808: [TE] Dashboard Resource Refactor

2020-08-11 Thread GitBox
kishoreg merged pull request #5808: URL: https://github.com/apache/incubator-pinot/pull/5808 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-pinot] suvodeep-pyne commented on pull request #5808: [TE] Dashboard Resource Refactor

2020-08-11 Thread GitBox
suvodeep-pyne commented on pull request #5808: URL: https://github.com/apache/incubator-pinot/pull/5808#issuecomment-672266277 You are very welcome @akshayrai ! And thanks a lot for the approval. This is an automated message

[GitHub] [incubator-pinot] kishoreg closed issue #5835: Problem when streaming data from S3 - 'Bucket' not found

2020-08-11 Thread GitBox
kishoreg closed issue #5835: URL: https://github.com/apache/incubator-pinot/issues/5835 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-pinot] yupeng9 commented on issue #5843: Public API checker before release

2020-08-11 Thread GitBox
yupeng9 commented on issue #5843: URL: https://github.com/apache/incubator-pinot/issues/5843#issuecomment-672199407 > Related Issue #4854 +1 to adding it to the testing tool This is an automated message from the

[GitHub] [incubator-pinot] mayankshriv merged pull request #5832: Added set-diff operators and changed distinctCountThetaSketch syntax

2020-08-11 Thread GitBox
mayankshriv merged pull request #5832: URL: https://github.com/apache/incubator-pinot/pull/5832 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-pinot] jihaozh merged pull request #5769: [TE] add anomaly detection as a service - Phase 1

2020-08-11 Thread GitBox
jihaozh merged pull request #5769: URL: https://github.com/apache/incubator-pinot/pull/5769 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-pinot] jasonyanwenl commented on pull request #5769: [TE] add anomaly detection as a service - Phase 1

2020-08-11 Thread GitBox
jasonyanwenl commented on pull request #5769: URL: https://github.com/apache/incubator-pinot/pull/5769#issuecomment-672181314 Thank you so much for the quick review. Really appreciate it! This is an automated message from

[GitHub] [incubator-pinot] jasonyanwenl commented on a change in pull request #5769: [TE] add anomaly detection as a service - Phase 1

2020-08-11 Thread GitBox
jasonyanwenl commented on a change in pull request #5769: URL: https://github.com/apache/incubator-pinot/pull/5769#discussion_r467200428 ## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/api/detection/AnomalyDetectionResource.java ## @@ -0,0 +1,756

[GitHub] [incubator-pinot] KKcorps edited a comment on issue #5845: String date format - not working on data ingestion

2020-08-11 Thread GitBox
KKcorps edited a comment on issue #5845: URL: https://github.com/apache/incubator-pinot/issues/5845#issuecomment-672149764 For future reference, add the following to the job spec if your time column is in `String` format ```yaml segmentNameGeneratorSpec: type: normalizedDate

[GitHub] [incubator-pinot] KKcorps commented on issue #5845: String date format - not working on data ingestion

2020-08-11 Thread GitBox
KKcorps commented on issue #5845: URL: https://github.com/apache/incubator-pinot/issues/5845#issuecomment-672149764 For future reference, add the following to the job spec ```yaml segmentNameGeneratorSpec: type: normalizedDate ```

[GitHub] [incubator-pinot] itzikiusa closed issue #5845: String date format - not working on data ingestion

2020-08-11 Thread GitBox
itzikiusa closed issue #5845: URL: https://github.com/apache/incubator-pinot/issues/5845 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-pinot] itzikiusa commented on issue #5845: String date format - not working on data ingestion

2020-08-11 Thread GitBox
itzikiusa commented on issue #5845: URL: https://github.com/apache/incubator-pinot/issues/5845#issuecomment-672147212 thanks @KKcorps can use the following config to solve the issue: ``` segmentNameGeneratorSpec: type: normalizedDate configs:

[GitHub] [incubator-pinot] itzikiusa opened a new issue #5845: String date format - not working on data ingestion

2020-08-11 Thread GitBox
itzikiusa opened a new issue #5845: URL: https://github.com/apache/incubator-pinot/issues/5845 Hi, trying to ingest data with timestamp in a format of: '-MM-dd HH:mm:ss' scheme: ``` { "schemaName": "transcript", "dimensionFieldSpecs": [ { "name":

[GitHub] [incubator-pinot] itzikiusa commented on issue #5835: Problem when streaming data from S3 - 'Bucket' not found

2020-08-11 Thread GitBox
itzikiusa commented on issue #5835: URL: https://github.com/apache/incubator-pinot/issues/5835#issuecomment-672082911 fixed on merged version This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-pinot] mcvsubbu commented on issue #5843: Public API checker before release

2020-08-11 Thread GitBox
mcvsubbu commented on issue #5843: URL: https://github.com/apache/incubator-pinot/issues/5843#issuecomment-672053619 Related Issue #4854 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-pinot] kishoreg closed issue #5814: Pinot's swagger pages does not work on HTTPS-only environments

2020-08-11 Thread GitBox
kishoreg closed issue #5814: URL: https://github.com/apache/incubator-pinot/issues/5814 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-pinot] mcvsubbu commented on issue #4854: Compatibility regression testing tool

2020-08-11 Thread GitBox
mcvsubbu commented on issue #4854: URL: https://github.com/apache/incubator-pinot/issues/4854#issuecomment-672053230 Related issue #5843 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-pinot] kishoreg merged pull request #5817: update Swagger (OpenAPI) configuration for HTTP+HTTPS

2020-08-11 Thread GitBox
kishoreg merged pull request #5817: URL: https://github.com/apache/incubator-pinot/pull/5817 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-pinot] fx19880617 merged pull request #5836: Fix data ingestion from Amazon S3 bucket

2020-08-11 Thread GitBox
fx19880617 merged pull request #5836: URL: https://github.com/apache/incubator-pinot/pull/5836 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-pinot] fx19880617 commented on issue #5704: Support toWeek/toMonth/toYear in datetimeConvertUdf

2020-08-11 Thread GitBox
fx19880617 commented on issue #5704: URL: https://github.com/apache/incubator-pinot/issues/5704#issuecomment-671852467 We may also want to support this as granular in `datetimeConvertUdf`, so that we can take the pushdown from presto side for function:

[GitHub] [incubator-pinot] KKcorps commented on a change in pull request #5836: Fix data ingestion from Amazon S3 bucket

2020-08-11 Thread GitBox
KKcorps commented on a change in pull request #5836: URL: https://github.com/apache/incubator-pinot/pull/5836#discussion_r468406304 ## File path: pinot-plugins/pinot-file-system/pinot-s3/src/test/java/org/apache/pinot/plugin/filesystem/S3PinotFSTest.java ## @@ -28,12 +28,16

[GitHub] [incubator-pinot] fx19880617 merged pull request #5844: Move quickstart tests to use Java 14 release

2020-08-11 Thread GitBox
fx19880617 merged pull request #5844: URL: https://github.com/apache/incubator-pinot/pull/5844 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-pinot] adriancole opened a new pull request #5844: Move quickstart tests to use Java 14 release

2020-08-10 Thread GitBox
adriancole opened a new pull request #5844: URL: https://github.com/apache/incubator-pinot/pull/5844 Java 14 is patch 2 at this point, but we were using early access still. ## Description Add a description of your PR here. A good description should include pointers to an issue

[GitHub] [incubator-pinot] yupeng9 edited a comment on issue #5843: Public API checker before release

2020-08-10 Thread GitBox
yupeng9 edited a comment on issue #5843: URL: https://github.com/apache/incubator-pinot/issues/5843#issuecomment-671677633 A checker will help detect the breaks, either we want to disallow it or document it in the release notes will depend on the policy we set up on 0.x releases. So it

[GitHub] [incubator-pinot] yupeng9 commented on issue #5843: Public API checker before release

2020-08-10 Thread GitBox
yupeng9 commented on issue #5843: URL: https://github.com/apache/incubator-pinot/issues/5843#issuecomment-671677633 A checker will help detect the breaks, either we want to disallow it or document it in the release notes will depend on the policy we set up on 0.x releases. So it will be

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5787: [Feature] - Spark Pinot Connector

2020-08-10 Thread GitBox
fx19880617 commented on a change in pull request #5787: URL: https://github.com/apache/incubator-pinot/pull/5787#discussion_r468275673 ## File path: pinot-connectors/pinot-spark-connector/src/main/scala/org/apache/pinot/connector/spark/datasource/PinotDataSourceReader.scala

[GitHub] [incubator-pinot] snleee merged pull request #5828: Improving retention manager to handle segment lineage clean-up

2020-08-10 Thread GitBox
snleee merged pull request #5828: URL: https://github.com/apache/incubator-pinot/pull/5828 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-pinot] fx19880617 commented on issue #5837: Apache Pulsar integration

2020-08-10 Thread GitBox
fx19880617 commented on issue #5837: URL: https://github.com/apache/incubator-pinot/issues/5837#issuecomment-671670690 Please take it @SandishKumarHN . Thanks! This is an automated message from the Apache Git Service. To

[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #5843: Public API checker before release

2020-08-10 Thread GitBox
Jackie-Jiang commented on issue #5843: URL: https://github.com/apache/incubator-pinot/issues/5843#issuecomment-671664434 Does adding a checker mean not allowing changing of public API? For certain features, we might have to change the interface (e.g. the diff is to support transform

[GitHub] [incubator-pinot] yupeng9 opened a new issue #5843: Public API checker before release

2020-08-10 Thread GitBox
yupeng9 opened a new issue #5843: URL: https://github.com/apache/incubator-pinot/issues/5843 It will be good to have a checker to scan the breaks on the APIs marked as `Public` and `Stable` as part of the release process. For example, this

[GitHub] [incubator-pinot] akshayrai opened a new pull request #5842: [TE] clean up legacy code

2020-08-10 Thread GitBox
akshayrai opened a new pull request #5842: URL: https://github.com/apache/incubator-pinot/pull/5842 * Removed the unused ContributorDataForDataReport related lines of code. * Removed logging of payload while creating/editing yaml configs.

[GitHub] [incubator-pinot] jihaozh merged pull request #5841: [TE] Presto JDBC lib upgrade

2020-08-10 Thread GitBox
jihaozh merged pull request #5841: URL: https://github.com/apache/incubator-pinot/pull/5841 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-pinot] vincentchenjl opened a new pull request #5841: [TE] Presto JDBC lib upgrade

2020-08-10 Thread GitBox
vincentchenjl opened a new pull request #5841: URL: https://github.com/apache/incubator-pinot/pull/5841 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [incubator-pinot] npawar merged pull request #5793: Tiered storage

2020-08-10 Thread GitBox
npawar merged pull request #5793: URL: https://github.com/apache/incubator-pinot/pull/5793 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

  1   2   3   4   5   6   7   8   9   10   >