[GitHub] [incubator-pinot] adriancole commented on pull request #5818: Makes Pinot work on Alpine Linux or Distroless + BusyBox

2020-08-12 Thread GitBox
adriancole commented on pull request #5818: URL: https://github.com/apache/incubator-pinot/pull/5818#issuecomment-672845582 thanks for the fast turnaround and the help fixing the branch to make it work @fx19880617 This is a

[GitHub] [incubator-pinot] adriancole commented on pull request #5818: Makes Pinot work on Alpine Linux or Distroless + BusyBox

2020-08-11 Thread GitBox
adriancole commented on pull request #5818: URL: https://github.com/apache/incubator-pinot/pull/5818#issuecomment-672397474 PS I had a bug in my comment https://github.com/apache/incubator-pinot/pull/5818#issuecomment-670817753 now is fixed. I didn't notice the fork about JRE 9+ needing pl

[GitHub] [incubator-pinot] adriancole commented on pull request #5818: Makes Pinot work on Alpine Linux or Distroless + BusyBox

2020-08-09 Thread GitBox
adriancole commented on pull request #5818: URL: https://github.com/apache/incubator-pinot/pull/5818#issuecomment-671135796 Tested on Zulu+Alpine JRE 1.8 and Distroless+BusyBox JRE 14 :shipit: This is an automated message fr

[GitHub] [incubator-pinot] adriancole commented on pull request #5818: Makes Pinot work on Alpine Linux or Distroless + BusyBox

2020-08-07 Thread GitBox
adriancole commented on pull request #5818: URL: https://github.com/apache/incubator-pinot/pull/5818#issuecomment-670818315 for completion, here's a Dockerfile that uses it. Maybe not perfect, but possibly helpful in showing where the script is useful. ```Dockerfile FROM alpine:3.

[GitHub] [incubator-pinot] adriancole commented on pull request #5818: Makes Pinot work on Alpine Linux or Distroless + BusyBox

2020-08-07 Thread GitBox
adriancole commented on pull request #5818: URL: https://github.com/apache/incubator-pinot/pull/5818#issuecomment-670817753 fyi I'm currently inlining a script as when you consider docker knows the only image it will run on, the script doesn't need to do work like detect OS, JVM etc.