[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5266: Add PinotServiceManager to start Pinot components

2020-05-27 Thread GitBox
fx19880617 commented on a change in pull request #5266: URL: https://github.com/apache/incubator-pinot/pull/5266#discussion_r430928817 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/ServiceStatus.java ## @@ -43,17 +44,79 @@ */

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5266: Add PinotServiceManager to start Pinot components

2020-05-22 Thread GitBox
fx19880617 commented on a change in pull request #5266: URL: https://github.com/apache/incubator-pinot/pull/5266#discussion_r429422165 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/services/ServiceStartable.java ## @@ -0,0 +1,40 @@ +/** + * Licensed to the Apache

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5266: Add PinotServiceManager to start Pinot components

2020-05-22 Thread GitBox
fx19880617 commented on a change in pull request #5266: URL: https://github.com/apache/incubator-pinot/pull/5266#discussion_r429123256 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/ServiceStatus.java ## @@ -43,17 +44,79 @@ */

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5266: Add PinotServiceManager to start Pinot components

2020-05-22 Thread GitBox
fx19880617 commented on a change in pull request #5266: URL: https://github.com/apache/incubator-pinot/pull/5266#discussion_r429120606 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/ServiceStatus.java ## @@ -43,17 +44,79 @@ */

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5266: Add PinotServiceManager to start Pinot components

2020-05-22 Thread GitBox
fx19880617 commented on a change in pull request #5266: URL: https://github.com/apache/incubator-pinot/pull/5266#discussion_r429119690 ## File path: pinot-tools/src/main/java/org/apache/pinot/tools/service/api/resources/PinotServiceManagerInstanceResource.java ## @@ -0,0

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5266: Add PinotServiceManager to start Pinot components

2020-05-22 Thread GitBox
fx19880617 commented on a change in pull request #5266: URL: https://github.com/apache/incubator-pinot/pull/5266#discussion_r429111535 ## File path: pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/StartServiceManagerCommand.java ## @@ -0,0 +1,213 @@ +/** + *

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5266: Add PinotServiceManager to start Pinot components

2020-05-22 Thread GitBox
fx19880617 commented on a change in pull request #5266: URL: https://github.com/apache/incubator-pinot/pull/5266#discussion_r429111007 ## File path: pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/StartServiceManagerCommand.java ## @@ -0,0 +1,213 @@ +/** + *