[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5406: Adding support to execute functions during query compilation

2020-05-22 Thread GitBox
fx19880617 commented on a change in pull request #5406: URL: https://github.com/apache/incubator-pinot/pull/5406#discussion_r429511368 ## File path: pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java ## @@ -593,29 +596,77 @@ private static

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5406: Adding support to execute functions during query compilation

2020-05-22 Thread GitBox
fx19880617 commented on a change in pull request #5406: URL: https://github.com/apache/incubator-pinot/pull/5406#discussion_r429511102 ## File path: pinot-common/src/main/java/org/apache/pinot/common/function/DateTimeFunctions.java ## @@ -216,4 +217,18 @@ static String

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5406: Adding support to execute functions during query compilation

2020-05-19 Thread GitBox
fx19880617 commented on a change in pull request #5406: URL: https://github.com/apache/incubator-pinot/pull/5406#discussion_r427744783 ## File path: pinot-common/src/main/java/org/apache/pinot/common/function/ScalarFunctionType.java ## @@ -0,0 +1,69 @@ +/** + * Licensed to

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5406: Adding support to execute functions during query compilation

2020-05-19 Thread GitBox
fx19880617 commented on a change in pull request #5406: URL: https://github.com/apache/incubator-pinot/pull/5406#discussion_r427744550 ## File path: pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java ## @@ -615,7 +618,47 @@ private static Expression

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5406: Adding support to execute functions during query compilation

2020-05-19 Thread GitBox
fx19880617 commented on a change in pull request #5406: URL: https://github.com/apache/incubator-pinot/pull/5406#discussion_r427596245 ## File path: pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java ## @@ -615,7 +620,44 @@ private static Expression

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5406: Adding support to execute functions during query compilation

2020-05-18 Thread GitBox
fx19880617 commented on a change in pull request #5406: URL: https://github.com/apache/incubator-pinot/pull/5406#discussion_r426983997 ## File path: pinot-common/src/main/java/org/apache/pinot/common/function/ScalarFunctionType.java ## @@ -0,0 +1,69 @@ +/** + * Licensed to

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5406: Adding support to execute functions during query compilation

2020-05-18 Thread GitBox
fx19880617 commented on a change in pull request #5406: URL: https://github.com/apache/incubator-pinot/pull/5406#discussion_r426983585 ## File path: pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java ## @@ -615,7 +618,47 @@ private static Expression

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5406: Adding support to execute functions during query compilation

2020-05-18 Thread GitBox
fx19880617 commented on a change in pull request #5406: URL: https://github.com/apache/incubator-pinot/pull/5406#discussion_r426983585 ## File path: pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java ## @@ -615,7 +618,47 @@ private static Expression

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5406: Adding support to execute functions during query compilation

2020-05-18 Thread GitBox
fx19880617 commented on a change in pull request #5406: URL: https://github.com/apache/incubator-pinot/pull/5406#discussion_r426983294 ## File path: pinot-common/src/main/java/org/apache/pinot/common/function/ScalarFunctionType.java ## @@ -0,0 +1,69 @@ +/** + * Licensed to

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5406: Adding support to execute functions during query compilation

2020-05-18 Thread GitBox
fx19880617 commented on a change in pull request #5406: URL: https://github.com/apache/incubator-pinot/pull/5406#discussion_r426428899 ## File path: pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java ## @@ -615,7 +618,47 @@ private static Expression