[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5513: Return Select only Literal Expression at Broker

2020-06-11 Thread GitBox
fx19880617 commented on a change in pull request #5513: URL: https://github.com/apache/incubator-pinot/pull/5513#discussion_r439214719 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java ## @@ -184,6 +192,18 @@ public

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5513: Return Select only Literal Expression at Broker

2020-06-11 Thread GitBox
fx19880617 commented on a change in pull request #5513: URL: https://github.com/apache/incubator-pinot/pull/5513#discussion_r439201178 ## File path: pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/OfflineClusterIntegrationTest.java ## @@ -317,6

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5513: Return Select only Literal Expression at Broker

2020-06-09 Thread GitBox
fx19880617 commented on a change in pull request #5513: URL: https://github.com/apache/incubator-pinot/pull/5513#discussion_r437774641 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java ## @@ -435,6 +455,115 @@ static

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5513: Return Select only Literal Expression at Broker

2020-06-09 Thread GitBox
fx19880617 commented on a change in pull request #5513: URL: https://github.com/apache/incubator-pinot/pull/5513#discussion_r437772483 ## File path: pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java ## @@ -278,7 +278,9 @@ private static PinotQuery

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5513: Return Select only Literal Expression at Broker

2020-06-09 Thread GitBox
fx19880617 commented on a change in pull request #5513: URL: https://github.com/apache/incubator-pinot/pull/5513#discussion_r437772483 ## File path: pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java ## @@ -278,7 +278,9 @@ private static PinotQuery

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5513: Return Select only Literal Expression at Broker

2020-06-09 Thread GitBox
fx19880617 commented on a change in pull request #5513: URL: https://github.com/apache/incubator-pinot/pull/5513#discussion_r437772150 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java ## @@ -435,6 +455,115 @@ static

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5513: Return Select only Literal Expression at Broker

2020-06-09 Thread GitBox
fx19880617 commented on a change in pull request #5513: URL: https://github.com/apache/incubator-pinot/pull/5513#discussion_r437771739 ## File path: pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/OfflineClusterIntegrationTest.java ## @@ -318,6

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5513: Return Select only Literal Expression at Broker

2020-06-09 Thread GitBox
fx19880617 commented on a change in pull request #5513: URL: https://github.com/apache/incubator-pinot/pull/5513#discussion_r437766763 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java ## @@ -184,6 +192,18 @@ public

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5513: Return Select only Literal Expression at Broker

2020-06-09 Thread GitBox
fx19880617 commented on a change in pull request #5513: URL: https://github.com/apache/incubator-pinot/pull/5513#discussion_r436894620 ## File path: pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java ## @@ -676,14 +678,25 @@ protected static