mayankshriv commented on a change in pull request #6009: URL: https://github.com/apache/incubator-pinot/pull/6009#discussion_r488129792
########## File path: pinot-plugins/pinot-input-format/pinot-avro-base/src/main/java/org/apache/pinot/plugin/inputformat/avro/AvroIngestionSchemaValidator.java ########## @@ -111,36 +112,56 @@ private void validateSchemas() { } } if (nonNullSchema != null) { + avroColumnSchema = nonNullSchema; avroColumnType = nonNullSchema.getType(); } } - if (!fieldSpec.getDataType().name().equalsIgnoreCase(avroColumnType.toString())) { - _dataTypeMismatch.addMismatchReason(String - .format("The Pinot column: (%s: %s) doesn't match with the column (%s: %s) in input %s schema.", columnName, - fieldSpec.getDataType().name(), avroColumnSchema.getName(), avroColumnType.toString(), - getInputSchemaType())); - } - if (fieldSpec.isSingleValueField()) { + // check data type mismatch + if (!fieldSpec.getDataType().name().equalsIgnoreCase(avroColumnType.toString())) { + getDataTypeMismatchResult().addMismatchReason(String + .format("The Pinot column: (%s: %s) doesn't match with the column (%s: %s) in input %s schema.", columnName, + fieldSpec.getDataType().name(), avroColumnName, avroColumnType.toString(), Review comment: Is this called before or after the ingestion transformation functions? For example, an ingestion transform function could change the name/type of data in input? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org