[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #5399: DATE_TIME should work as the primary time column for Pinot tables

2020-05-19 Thread GitBox
mcvsubbu commented on a change in pull request #5399: URL: https://github.com/apache/incubator-pinot/pull/5399#discussion_r427479912 ## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/creator/impl/V1Constants.java ## @@ -51,6 +51,10 @@ public static fi

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #5399: DATE_TIME should work as the primary time column for Pinot tables

2020-05-16 Thread GitBox
mcvsubbu commented on a change in pull request #5399: URL: https://github.com/apache/incubator-pinot/pull/5399#discussion_r426197422 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/data/TimeFieldSpec.java ## @@ -28,6 +28,12 @@ @SuppressWarnings("unused") @JsonIgn