[GitHub] [incubator-pinot] sajjad-moradi opened a new pull request #6037: Add whitelist for emitting table level metrics

[GitBox]

sajjad-moradi opened a new pull request #6037:
URL: https://github.com/apache/incubator-pinot/pull/6037


   ## Description
   Currently there is one config to enable/disable emitting table level metrics 
for all tables in a cluster. For big clusters, let's say the ones with a few 
thousands tables, this is problematic as one might need to set up 
alerts/monitoring on some the tables that have higher priority than others in 
the cluster. This PR introduces a config for whitelisted tables to address this 
problem. Table level metrics are still emitted for whitelisted tables even if 
emitting table level metrics is disabled for the whole cluster.
   
   ## Testing Done
   For the following scenarios, deployed pinot locally; ran quick-start-batch 
script; and took a snapshot of metrics using `jvisualvm`.
   1) `enableTableLevelMetrics = false` and added `baseballStats` to the 
whitelist
   
   
![image](https://user-images.githubusercontent.com/8548220/93656263-ded7e180-f9dd-11ea-9556-4372aaa76b83.png)
   
   2) `enableTableLevelMetrics = false` and empty whitelist
   
   
![image](https://user-images.githubusercontent.com/8548220/93656265-e7c8b300-f9dd-11ea-85b6-dcba2fd5c350.png)
   
   3) `enableTableLevelMetrics = true`
   
   
![image](https://user-images.githubusercontent.com/8548220/93656308-31190280-f9de-11ea-94de-6a799208794a.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org