[GitHub] [incubator-pinot] siddharthteotia edited a comment on pull request #5483: Add QueryContext to replace BrokerRequest in the query engine

2020-06-11 Thread GitBox
siddharthteotia edited a comment on pull request #5483: URL: https://github.com/apache/incubator-pinot/pull/5483#issuecomment-642662988 It seems like we are adding some duplicate code (like Predicate, FilterInfo). We already have them. I agree that on server we can move to QueryRequ

[GitHub] [incubator-pinot] siddharthteotia edited a comment on pull request #5483: Add QueryContext to replace BrokerRequest in the query engine

2020-06-11 Thread GitBox
siddharthteotia edited a comment on pull request #5483: URL: https://github.com/apache/incubator-pinot/pull/5483#issuecomment-642662988 It seems like we are adding some duplicate code (like Predicate, FilterInfo). We already have them. I agree that on server we can move to QueryRequ