[GitHub] [incubator-pinot] snleee commented on pull request #6030: Prevent the table creation when the time column name config is invalid

2020-09-17 Thread GitBox
snleee commented on pull request #6030: URL: https://github.com/apache/incubator-pinot/pull/6030#issuecomment-694553611 Closing the pull request since the current code correctly validates the time column that I would like to do.

[GitHub] [incubator-pinot] snleee commented on pull request #6030: Prevent the table creation when the time column name config is invalid

2020-09-17 Thread GitBox
snleee commented on pull request #6030: URL: https://github.com/apache/incubator-pinot/pull/6030#issuecomment-694543559 @jackjlli @kishoreg Thank you for the pointer. Actually, #5966 adds the validation and already fixed this issue. I slightly improved the validation and keep the test

[GitHub] [incubator-pinot] snleee commented on pull request #6030: Prevent the table creation when the time column name config is invalid

2020-09-17 Thread GitBox
snleee commented on pull request #6030: URL: https://github.com/apache/incubator-pinot/pull/6030#issuecomment-694539036 ``` 2020/09/17 20:36:52.666 ERROR [SegmentCompletionFSM_X__3__0__20200915T2142Z] [grizzly-http-server-3] [pinot-controller] [] Caught exception while committing