[GitHub] [incubator-pinot] sunithabeeram commented on issue #4230: NULL value support for all data types

2019-05-29 Thread GitBox
sunithabeeram commented on issue #4230: NULL value support for all data types URL: https://github.com/apache/incubator-pinot/issues/4230#issuecomment-497168781 @mcvsubbu is there an issue if the presence vector is always built? If I understand things correctly, I believe the current

[GitHub] [incubator-pinot] sunithabeeram commented on issue #4230: NULL value support for all data types

2019-05-29 Thread GitBox
sunithabeeram commented on issue #4230: NULL value support for all data types URL: https://github.com/apache/incubator-pinot/issues/4230#issuecomment-497139881 Interacting through the issue is a bit limiting as its hard to reference comments appropriately. Will try my best. For #1

[GitHub] [incubator-pinot] sunithabeeram commented on issue #4230: NULL value support for all data types

2019-05-28 Thread GitBox
sunithabeeram commented on issue #4230: NULL value support for all data types URL: https://github.com/apache/incubator-pinot/issues/4230#issuecomment-496588574 Few thoughts: - How would defaultValue and isNullable in the FieldSpec work? Does one take precedence over the other? -