Re: [PR] add changes to release resources when the channel becomes inactive

2025-09-03 Thread via GitHub
frankpuppa commented on PR #2241: URL: https://github.com/apache/plc4x/pull/2241#issuecomment-3248602642 > Hi Frank, do I understand things correctly? The main difference is that you're overriding channelInactive in Plc4xNettyWrapper and forwarding that to the individual implementations? De

Re: [PR] add changes to release resources when the channel becomes inactive

2025-09-03 Thread via GitHub
chrisdutz commented on code in PR #2241: URL: https://github.com/apache/plc4x/pull/2241#discussion_r2318382862 ## plc4j/spi/src/main/java/org/apache/plc4x/java/spi/Plc4xNettyWrapper.java: ## @@ -136,10 +136,19 @@ public ExpectRequestContext expectRequest(Class clazz, Duration t

Re: [PR] add changes to release resources when the channel becomes inactive

2025-09-03 Thread via GitHub
chrisdutz commented on PR #2241: URL: https://github.com/apache/plc4x/pull/2241#issuecomment-3248466930 Could you please increase the log level for your additional log output to something "debug" or "trace"? "info" makes the drivers quite noisy. -- This is an automated message from the Ap

Re: [PR] add changes to release resources when the channel becomes inactive

2025-09-03 Thread via GitHub
chrisdutz commented on PR #2241: URL: https://github.com/apache/plc4x/pull/2241#issuecomment-3248460922 Hi Frank, do I understand things correctly? The main difference is that you're overriding channelInactive in Plc4xNettyWrapper and forwarding that to the individual implementations?

[PR] add changes to release resources when the channel becomes inactive

2025-09-03 Thread via GitHub
frankpuppa opened a new pull request, #2241: URL: https://github.com/apache/plc4x/pull/2241 While I was looking into this issue I found out that there are two leaks. The first is related to the RequestTransactionManager and the other is from the NettyHashTimerTimeoutManager. As I was mentio