This is an automated email from the ASF dual-hosted git repository. sruehl pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-plc4x.git.
from 7d2458d + extracted getByteBuf to own supplier method. + included buildByteBuff into ByteReadable new e6c3fc3 javadoc and cleanup for amstcp header new 3cb1ea6 added more javadoc for ams net id and port new 339b220 renamed package netty to protocol new 3fe3974 include source ref for documentation new 965f1e5 added ads serial protocol implementation new 493190a separated tcp from ads protocol new 1a3cfe6 fix leftover from refactoring new ab1a277 fixed renaming messup The 8 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../java/ads/api/commands/ADSAbstractRequest.java | 9 +- .../java/ads/api/commands/ADSAbstractResponse.java | 9 +- .../commands/ADSAddDeviceNotificationRequest.java | 16 --- .../commands/ADSAddDeviceNotificationResponse.java | 11 +- .../ADSDeleteDeviceNotificationRequest.java | 10 -- .../ADSDeleteDeviceNotificationResponse.java | 9 +- .../api/commands/ADSDeviceNotificationRequest.java | 15 +- .../commands/ADSDeviceNotificationResponse.java | 2 +- .../ads/api/commands/ADSReadDeviceInfoRequest.java | 9 -- .../api/commands/ADSReadDeviceInfoResponse.java | 12 +- .../java/ads/api/commands/ADSReadRequest.java | 14 +- .../java/ads/api/commands/ADSReadResponse.java | 11 +- .../java/ads/api/commands/ADSReadStateRequest.java | 9 -- .../ads/api/commands/ADSReadStateResponse.java | 9 +- .../java/ads/api/commands/ADSReadWriteRequest.java | 17 +-- .../ads/api/commands/ADSReadWriteResponse.java | 9 +- .../ads/api/commands/ADSWriteControlRequest.java | 16 +-- .../ads/api/commands/ADSWriteControlResponse.java | 9 +- .../java/ads/api/commands/ADSWriteRequest.java | 16 +-- .../java/ads/api/commands/ADSWriteResponse.java | 9 +- .../java/ads/api/commands/UnknownCommand.java | 13 +- .../generic/{AMSTCPPacket.java => AMSPacket.java} | 66 ++++----- .../plc4x/java/ads/api/generic/types/AMSNetId.java | 19 ++- .../plc4x/java/ads/api/generic/types/AMSPort.java | 25 ++++ .../ads/api/serial/AMSSerialAcknowledgeFrame.java | 114 +++++++++++++++ .../plc4x/java/ads/api/serial/AMSSerialFrame.java | 134 +++++++++++++++++ .../java/ads/api/serial/AMSSerialResetFrame.java | 113 +++++++++++++++ .../types/ADSState.java => serial/types/CRC.java} | 30 ++-- .../types/FragmentNumber.java} | 27 +++- .../Version.java => serial/types/MagicCookie.java} | 31 ++-- .../types/ReceiverAddress.java} | 29 +++- .../types/TransmitterAddress.java} | 32 ++--- .../types/Data.java => serial/types/UserData.java} | 22 +-- .../types/UserDataLength.java} | 27 +++- .../ads/api/{generic => tcp}/AMSTCPHeader.java | 26 ++-- .../plc4x/java/ads/api/tcp/AMSTCPPacket.java | 100 +++++++++++++ .../ads/api/{generic => tcp}/types/TcpLength.java | 2 +- .../java/ads/connection/ADSPlcConnection.java | 8 +- .../ADS2TcpProtocol.java} | 160 ++++++++++----------- .../Plc4X2ADSProtocol.java} | 70 ++++----- .../util/LittleEndianDecoder.java | 2 +- .../util/LittleEndianEncoder.java | 2 +- .../ads/api/generic/GenericFactoryMethodTest.java | 2 + .../types/GenericTypesFactoryMethodTest.java | 1 + .../java/ads/api/generic/types/TcpLengthTest.java | 1 + .../ADS2TcpProtocolTest.java} | 60 ++++---- .../Plc4X2ADS2TcpProtocolTest.java} | 34 ++--- .../{netty => protocol}/ADSProtocolBenchmark.java | 4 +- 48 files changed, 896 insertions(+), 479 deletions(-) rename plc4j/protocols/ads/src/main/java/org/apache/plc4x/java/ads/api/generic/{AMSTCPPacket.java => AMSPacket.java} (57%) create mode 100644 plc4j/protocols/ads/src/main/java/org/apache/plc4x/java/ads/api/serial/AMSSerialAcknowledgeFrame.java create mode 100644 plc4j/protocols/ads/src/main/java/org/apache/plc4x/java/ads/api/serial/AMSSerialFrame.java create mode 100644 plc4j/protocols/ads/src/main/java/org/apache/plc4x/java/ads/api/serial/AMSSerialResetFrame.java copy plc4j/protocols/ads/src/main/java/org/apache/plc4x/java/ads/api/{commands/types/ADSState.java => serial/types/CRC.java} (64%) copy plc4j/protocols/ads/src/main/java/org/apache/plc4x/java/ads/api/{util/ByteBufSupplier.java => serial/types/FragmentNumber.java} (59%) copy plc4j/protocols/ads/src/main/java/org/apache/plc4x/java/ads/api/{commands/types/Version.java => serial/types/MagicCookie.java} (62%) copy plc4j/protocols/ads/src/main/java/org/apache/plc4x/java/ads/api/{util/ByteBufSupplier.java => serial/types/ReceiverAddress.java} (55%) copy plc4j/protocols/ads/src/main/java/org/apache/plc4x/java/ads/api/{commands/types/Data.java => serial/types/TransmitterAddress.java} (54%) copy plc4j/protocols/ads/src/main/java/org/apache/plc4x/java/ads/api/{commands/types/Data.java => serial/types/UserData.java} (70%) copy plc4j/protocols/ads/src/main/java/org/apache/plc4x/java/ads/api/{util/ByteBufSupplier.java => serial/types/UserDataLength.java} (59%) rename plc4j/protocols/ads/src/main/java/org/apache/plc4x/java/ads/api/{generic => tcp}/AMSTCPHeader.java (81%) create mode 100644 plc4j/protocols/ads/src/main/java/org/apache/plc4x/java/ads/api/tcp/AMSTCPPacket.java rename plc4j/protocols/ads/src/main/java/org/apache/plc4x/java/ads/api/{generic => tcp}/types/TcpLength.java (97%) rename plc4j/protocols/ads/src/main/java/org/apache/plc4x/java/ads/{netty/ADSProtocol.java => protocol/ADS2TcpProtocol.java} (64%) rename plc4j/protocols/ads/src/main/java/org/apache/plc4x/java/ads/{netty/Plc4XADSProtocol.java => protocol/Plc4X2ADSProtocol.java} (84%) rename plc4j/protocols/ads/src/main/java/org/apache/plc4x/java/ads/{netty => protocol}/util/LittleEndianDecoder.java (99%) rename plc4j/protocols/ads/src/main/java/org/apache/plc4x/java/ads/{netty => protocol}/util/LittleEndianEncoder.java (99%) rename plc4j/protocols/ads/src/test/java/org/apache/plc4x/java/ads/{netty/ADSProtocolTest.java => protocol/ADS2TcpProtocolTest.java} (84%) rename plc4j/protocols/ads/src/test/java/org/apache/plc4x/java/ads/{netty/Plc4XADSProtocolTest.java => protocol/Plc4X2ADS2TcpProtocolTest.java} (92%) rename plc4j/protocols/benchmarks/src/main/java/org/apache/plc4x/java/ads/{netty => protocol}/ADSProtocolBenchmark.java (98%) -- To stop receiving notification emails like this one, please contact sru...@apache.org.