[incubator-plc4x] branch master updated: use java8 streams api for address mapping

[sruehl]

This is an automated email from the ASF dual-hosted git repository.

sruehl pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-plc4x.git


The following commit(s) were added to refs/heads/master by this push:
     new ea8ed3f  use java8 streams api for address mapping
ea8ed3f is described below

commit ea8ed3f89e61e94c805008e454b01b914990d8af
Author: Sebastian Rühl <sru...@apache.org>
AuthorDate: Fri May 18 09:14:45 2018 +0200

    use java8 streams api for address mapping
---
 .../plc4x/java/ads/connection/AdsAbstractPlcConnection.java   | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git 
a/plc4j/protocols/ads/src/main/java/org/apache/plc4x/java/ads/connection/AdsAbstractPlcConnection.java
 
b/plc4j/protocols/ads/src/main/java/org/apache/plc4x/java/ads/connection/AdsAbstractPlcConnection.java
index 7c5412a..6dd01bb 100644
--- 
a/plc4j/protocols/ads/src/main/java/org/apache/plc4x/java/ads/connection/AdsAbstractPlcConnection.java
+++ 
b/plc4j/protocols/ads/src/main/java/org/apache/plc4x/java/ads/connection/AdsAbstractPlcConnection.java
@@ -140,9 +140,11 @@ public abstract class AdsAbstractPlcConnection extends 
AbstractPlcConnection imp
     }
 
     private void mapAddresses(PlcRequest<?> request) {
-        for (RequestItem requestItem : request.getRequestItems()) {
-            if (requestItem.getAddress() instanceof SymbolicAdsAddress) {
-                SymbolicAdsAddress symbolicAdsAddress = (SymbolicAdsAddress) 
requestItem.getAddress();
+        request.getRequestItems().stream()
+            .map(RequestItem::getAddress)
+            .filter(SymbolicAdsAddress.class::isInstance)
+            .map(SymbolicAdsAddress.class::cast)
+            .forEach(symbolicAdsAddress -> {
                 addressMapping.computeIfAbsent(symbolicAdsAddress, 
symbolicAdsAddressInternal -> {
                     LOGGER.debug("Resolving {}", symbolicAdsAddressInternal);
                     AdsReadWriteRequest adsReadWriteRequest = 
AdsReadWriteRequest.of(
@@ -176,8 +178,7 @@ public abstract class AdsAbstractPlcConnection extends 
AbstractPlcConnection imp
                     IndexOffset symbolHandle = 
IndexOffset.of(response.getData().getBytes());
                     return 
AdsAddress.of(IndexGroup.ReservedGroups.ADSIGRP_SYM_VALBYHND.getAsLong(), 
symbolHandle.getAsLong());
                 });
-            }
-        }
+            });
     }
 
     protected static AmsNetId generateAMSNetId() {

-- 
To stop receiving notification emails like this one, please contact
sru...@apache.org.