Author: fanningpj
Date: Wed Apr 29 21:18:18 2020
New Revision: 1877177
URL: http://svn.apache.org/viewvc?rev=1877177&view=rev
Log:
[github-176] Remove limit on number of rules in XSSFSheetConditionalFormatting.
Modified:
poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestConditionalFormatting.java
Modified:
poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestConditionalFormatting.java
URL:
http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestConditionalFormatting.java?rev=1877177&r1=1877176&r2=1877177&view=diff
==============================================================================
---
poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestConditionalFormatting.java
(original)
+++
poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestConditionalFormatting.java
Wed Apr 29 21:18:18 2020
@@ -42,10 +42,12 @@ import org.junit.Test;
public abstract class BaseTestConditionalFormatting {
private final ITestDataProvider _testDataProvider;
- protected BaseTestConditionalFormatting(ITestDataProvider
testDataProvider){
+ protected BaseTestConditionalFormatting(ITestDataProvider
testDataProvider) {
_testDataProvider = testDataProvider;
}
+ protected boolean applyLimitOf3 = true;
+
protected abstract void assertColour(String hexExpected, Color actual);
@Test
@@ -97,10 +99,20 @@ public abstract class BaseTestConditiona
assertTrue(e.getMessage().startsWith("cfRules must not be
empty"));
}
- //this is now allowed
- sheetCF.addConditionalFormatting(
- new CellRangeAddress[]{CellRangeAddress.valueOf("A1:A3")},
- new ConditionalFormattingRule[]{rule1, rule2, rule3,
rule4});
+ if (applyLimitOf3) {
+ try {
+ sheetCF.addConditionalFormatting(
+ new
CellRangeAddress[]{CellRangeAddress.valueOf("A1:A3")},
+ new ConditionalFormattingRule[]{rule1, rule2,
rule3, rule4});
+ fail("expected exception");
+ } catch (IllegalArgumentException e) {
+ assertTrue(e.getMessage().startsWith("Number of rules must
not exceed 3"));
+ }
+ } else {
+ sheetCF.addConditionalFormatting(
+ new
CellRangeAddress[]{CellRangeAddress.valueOf("A1:A3")},
+ new ConditionalFormattingRule[]{rule1, rule2, rule3,
rule4});
+ }
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@poi.apache.org
For additional commands, e-mail: commits-h...@poi.apache.org
