Modified: poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestFormulaEvaluatorBugs.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestFormulaEvaluatorBugs.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestFormulaEvaluatorBugs.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestFormulaEvaluatorBugs.java Fri Jan 8 23:50:02 2021 @@ -75,7 +75,7 @@ public final class TestFormulaEvaluatorB * open up excel */ @Test - public void test44636() throws Exception { + void test44636() throws Exception { // Open the existing file, tweak one value and // re-calculate @@ -130,7 +130,7 @@ public final class TestFormulaEvaluatorB * if a formula has values in the interval [Short.MAX_VALUE, (Short.MAX_VALUE+1)*2] */ @Test - public void test44297() throws Exception { + void test44297() throws Exception { HSSFWorkbook wb = openSampleWorkbook("44297.xls"); @@ -194,7 +194,7 @@ public final class TestFormulaEvaluatorB * of all the rows in Column C */ @Test - public void test44410() throws Exception { + void test44410() throws Exception { HSSFWorkbook wb = openSampleWorkbook("SingleLetterRanges.xls"); HSSFSheet sheet = wb.getSheetAt(0); @@ -254,7 +254,7 @@ public final class TestFormulaEvaluatorB * Tests that we can evaluate boolean cells properly */ @Test - public void testEvaluateBooleanInCell_bug44508() throws Exception { + void testEvaluateBooleanInCell_bug44508() throws Exception { HSSFWorkbook wb = new HSSFWorkbook(); HSSFSheet sheet = wb.createSheet(); wb.setSheetName(0, "Sheet1"); @@ -275,7 +275,7 @@ public final class TestFormulaEvaluatorB } @Test - public void testClassCast_bug44861() throws Exception { + void testClassCast_bug44861() throws Exception { try (HSSFWorkbook wb = openSampleWorkbook("44861.xls")) { // Check direct HSSFFormulaEvaluator.evaluateAllFormulaCells(wb); @@ -296,7 +296,7 @@ public final class TestFormulaEvaluatorB } @Test - public void testEvaluateInCellWithErrorCode_bug44950() throws Exception { + void testEvaluateInCellWithErrorCode_bug44950() throws Exception { try (HSSFWorkbook wb = new HSSFWorkbook()) { HSSFSheet sheet = wb.createSheet("Sheet1"); HSSFRow row = sheet.createRow(1); @@ -313,7 +313,7 @@ public final class TestFormulaEvaluatorB } @Test - public void testDateWithNegativeParts_bug48528() throws Exception { + void testDateWithNegativeParts_bug48528() throws Exception { HSSFWorkbook wb = new HSSFWorkbook(); HSSFSheet sheet = wb.createSheet("Sheet1"); HSSFRow row = sheet.createRow(1); @@ -386,7 +386,7 @@ public final class TestFormulaEvaluatorB * The HSSFFormula evaluator performance benefits greatly from caching of intermediate cell values */ @Test - public void testSlowEvaluate45376() throws Exception { + void testSlowEvaluate45376() throws Exception { /* * Note - to observe behaviour without caching, disable the call to * updateValue() from FormulaCellCacheEntry.updateFormulaResult(). @@ -440,7 +440,7 @@ public final class TestFormulaEvaluatorB @SuppressWarnings("resource") @Test - public void test55747_55324() throws Exception { + void test55747_55324() throws Exception { HSSFWorkbook wb = new HSSFWorkbook(); HSSFFormulaEvaluator ev = wb.getCreationHelper().createFormulaEvaluator(); HSSFSheet ws = wb.createSheet();
Modified: poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestFormulaEvaluatorDocs.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestFormulaEvaluatorDocs.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestFormulaEvaluatorDocs.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestFormulaEvaluatorDocs.java Fri Jan 8 23:50:02 2021 @@ -38,7 +38,7 @@ public final class TestFormulaEvaluatorD * https://poi.apache.org/hssf/eval.html#EvaluateAll */ @Test - public void testEvaluateAll() throws IOException { + void testEvaluateAll() throws IOException { try (HSSFWorkbook wb = new HSSFWorkbook()) { HSSFSheet s1 = wb.createSheet(); HSSFSheet s2 = wb.createSheet(); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestFormulas.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestFormulas.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestFormulas.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestFormulas.java Fri Jan 8 23:50:02 2021 @@ -53,7 +53,7 @@ public final class TestFormulas { * Add 1+1 -- WHoohoo! */ @Test - public void testBasicAddIntegers() throws IOException { + void testBasicAddIntegers() throws IOException { try (HSSFWorkbook wb1 = new HSSFWorkbook()) { HSSFSheet s = wb1.createSheet(); @@ -76,7 +76,7 @@ public final class TestFormulas { * Add various integers */ @Test - public void testAddIntegers() throws IOException { + void testAddIntegers() throws IOException { binomialOperator("+"); } @@ -84,7 +84,7 @@ public final class TestFormulas { * Multiply various integers */ @Test - public void testMultplyIntegers() throws IOException { + void testMultplyIntegers() throws IOException { binomialOperator("*"); } @@ -92,7 +92,7 @@ public final class TestFormulas { * Subtract various integers */ @Test - public void testSubtractIntegers() throws IOException { + void testSubtractIntegers() throws IOException { binomialOperator("-"); } @@ -100,7 +100,7 @@ public final class TestFormulas { * Subtract various integers */ @Test - public void testDivideIntegers() throws IOException { + void testDivideIntegers() throws IOException { binomialOperator("/"); } @@ -108,7 +108,7 @@ public final class TestFormulas { * Exponentialize various integers; */ @Test - public void testPowerIntegers() throws IOException { + void testPowerIntegers() throws IOException { binomialOperator("^"); } @@ -116,7 +116,7 @@ public final class TestFormulas { * Concatenate two numbers 1&2 = 12 */ @Test - public void testConcatIntegers() throws IOException { + void testConcatIntegers() throws IOException { binomialOperator("&"); } @@ -124,7 +124,7 @@ public final class TestFormulas { * tests 1*2+3*4 */ @Test - public void testOrderOfOperationsMultiply() throws IOException { + void testOrderOfOperationsMultiply() throws IOException { orderTest("1*2+3*4"); } @@ -132,7 +132,7 @@ public final class TestFormulas { * tests 1*2+3^4 */ @Test - public void testOrderOfOperationsPower() throws IOException { + void testOrderOfOperationsPower() throws IOException { orderTest("1*2+3^4"); } @@ -140,12 +140,12 @@ public final class TestFormulas { * Tests that parenthesis are obeyed */ @Test - public void testParenthesis() throws IOException { + void testParenthesis() throws IOException { orderTest("(1*3)+2+(1+2)*(3^4)^5"); } @Test - public void testReferencesOpr() throws IOException { + void testReferencesOpr() throws IOException { String[] operation = new String[] { "+", "-", "*", "/", "^", "&" }; @@ -159,7 +159,7 @@ public final class TestFormulas { * */ @Test - public void testFloat() throws IOException { + void testFloat() throws IOException { floatTest("*"); floatTest("/"); } @@ -211,22 +211,22 @@ public final class TestFormulas { } @Test - public void testAreaSum() throws IOException { + void testAreaSum() throws IOException { areaFunctionTest("SUM"); } @Test - public void testAreaAverage() throws IOException { + void testAreaAverage() throws IOException { areaFunctionTest("AVERAGE"); } @Test - public void testRefArraySum() throws IOException { + void testRefArraySum() throws IOException { refArrayFunctionTest("SUM"); } @Test - public void testAreaArraySum() throws IOException { + void testAreaArraySum() throws IOException { refAreaArrayFunctionTest("SUM"); } @@ -479,7 +479,7 @@ public final class TestFormulas { @Test - public void testAbsRefs() throws IOException { + void testAbsRefs() throws IOException { try (HSSFWorkbook wb1 = new HSSFWorkbook()) { HSSFSheet s = wb1.createSheet(); HSSFRow r = s.createRow(0); @@ -512,7 +512,7 @@ public final class TestFormulas { } @Test - public void testSheetFunctions() throws IOException { + void testSheetFunctions() throws IOException { try (HSSFWorkbook wb1 = new HSSFWorkbook()) { HSSFSheet s = wb1.createSheet("A"); HSSFRow r = s.createRow(0); @@ -544,7 +544,7 @@ public final class TestFormulas { } @Test - public void testRVAoperands() throws IOException { + void testRVAoperands() throws IOException { File file = TempFile.createTempFile("testFormulaRVA",".xls"); try (HSSFWorkbook wb = new HSSFWorkbook()) { HSSFSheet s = wb.createSheet(); @@ -583,7 +583,7 @@ public final class TestFormulas { } @Test - public void testStringFormulas() throws IOException { + void testStringFormulas() throws IOException { try (HSSFWorkbook wb = new HSSFWorkbook()) { HSSFSheet s = wb.createSheet("A"); HSSFRow r = s.createRow(0); @@ -606,7 +606,7 @@ public final class TestFormulas { } @Test - public void testLogicalFormulas() throws IOException { + void testLogicalFormulas() throws IOException { try (HSSFWorkbook wb1 = new HSSFWorkbook()) { HSSFSheet s = wb1.createSheet("A"); HSSFRow r = s.createRow(0); @@ -623,7 +623,7 @@ public final class TestFormulas { } @Test - public void testDateFormulas() throws IOException { + void testDateFormulas() throws IOException { try (HSSFWorkbook wb = new HSSFWorkbook()) { HSSFSheet s = wb.createSheet("testSheet1"); HSSFRow r = s.createRow(0); @@ -653,7 +653,7 @@ public final class TestFormulas { } @Test - public void testIfFormulas() throws IOException { + void testIfFormulas() throws IOException { try (HSSFWorkbook wb1 = new HSSFWorkbook()) { HSSFSheet s = wb1.createSheet("testSheet1"); HSSFRow r = s.createRow(0); @@ -722,7 +722,7 @@ public final class TestFormulas { } @Test - public void testSumIf() throws IOException { + void testSumIf() throws IOException { String function ="SUMIF(A1:A5,\">4000\",B1:B5)"; try (HSSFWorkbook wb = openSample("sumifformula.xls")) { @@ -774,7 +774,7 @@ public final class TestFormulas { } @Test - public void testSquareMacro() throws IOException { + void testSquareMacro() throws IOException { try (HSSFWorkbook w = openSample("SquareMacro.xls")) { HSSFSheet s0 = w.getSheetAt(0); HSSFRow[] r = {s0.getRow(0), s0.getRow(1)}; @@ -814,7 +814,7 @@ public final class TestFormulas { } @Test - public void testStringFormulaRead() throws IOException { + void testStringFormulaRead() throws IOException { try (HSSFWorkbook w = openSample("StringFormulas.xls")) { HSSFCell c = w.getSheetAt(0).getRow(0).getCell(0); assertEquals("XYZ", c.getRichStringCellValue().getString(), "String Cell value"); @@ -823,7 +823,7 @@ public final class TestFormulas { /** test for bug 34021*/ @Test - public void testComplexSheetRefs() throws IOException { + void testComplexSheetRefs() throws IOException { try (HSSFWorkbook wb1 = new HSSFWorkbook()) { HSSFSheet s1 = wb1.createSheet("Sheet a.1"); HSSFSheet s2 = wb1.createSheet("Sheet.A"); @@ -843,7 +843,7 @@ public final class TestFormulas { /** Unknown Ptg 3C*/ @Test - public void test27272_1() throws IOException { + void test27272_1() throws IOException { try (HSSFWorkbook wb = openSample("27272_1.xls")) { wb.getSheetAt(0); assertEquals("Compliance!#REF!", wb.getNameAt(0).getRefersToFormula(), "Reference for named range"); @@ -853,7 +853,7 @@ public final class TestFormulas { /** Unknown Ptg 3D*/ @Test - public void test27272_2() throws IOException { + void test27272_2() throws IOException { try (HSSFWorkbook wb = openSample("27272_2.xls")) { assertEquals("LOAD.POD_HISTORIES!#REF!", wb.getNameAt(0).getRefersToFormula(), "Reference for named range"); writeOutAndReadBack(wb).close(); @@ -862,7 +862,7 @@ public final class TestFormulas { /** MissingArgPtg */ @Test - public void testMissingArgPtg() throws IOException { + void testMissingArgPtg() throws IOException { try (HSSFWorkbook wb = new HSSFWorkbook()) { HSSFCell cell = wb.createSheet("Sheet1").createRow(4).createCell(0); assertDoesNotThrow(() -> cell.setCellFormula("IF(A1=\"A\",1,)")); @@ -870,7 +870,7 @@ public final class TestFormulas { } @Test - public void testSharedFormula() throws IOException { + void testSharedFormula() throws IOException { try (HSSFWorkbook wb = openSample("SharedFormulaTest.xls")) { assertEquals("A$1*2", wb.getSheetAt(0).getRow(1).getCell(1).toString()); assertEquals("$A11*2", wb.getSheetAt(0).getRow(11).getCell(1).toString()); @@ -883,7 +883,7 @@ public final class TestFormulas { * Test creation / evaluation of formulas with sheet-level names */ @Test - public void testSheetLevelFormulas() throws IOException { + void testSheetLevelFormulas() throws IOException { try (HSSFWorkbook wb = new HSSFWorkbook()) { HSSFSheet sh1 = wb.createSheet("Sheet1"); HSSFName nm1 = wb.createName(); @@ -931,7 +931,7 @@ public final class TestFormulas { * see Bug #49640 */ @Test - public void testFormulasWithUnderscore() throws IOException{ + void testFormulasWithUnderscore() throws IOException{ try (HSSFWorkbook wb = new HSSFWorkbook()) { Name nm1 = wb.createName(); nm1.setNameName("_score1"); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFCell.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFCell.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFCell.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFCell.java Fri Jan 8 23:50:02 2021 @@ -63,7 +63,7 @@ public final class TestHSSFCell extends * but there's a separate unit test for that. */ @Test - public void testDateWindowingRead() throws IOException { + void testDateWindowingRead() throws IOException { Calendar cal = LocaleUtil.getLocaleCalendar(2000, 0, 1, 0, 0, 0);// Jan. 1, 2000 Date date = cal.getTime(); @@ -95,7 +95,7 @@ public final class TestHSSFCell extends * results of this test are meaningless. */ @Test - public void testDateWindowingWrite() throws IOException { + void testDateWindowingWrite() throws IOException { Calendar cal = LocaleUtil.getLocaleCalendar(2000,0,1,0,0,0); // Jan. 1, 2000 Date date = cal.getTime(); @@ -144,7 +144,7 @@ public final class TestHSSFCell extends * Tests that the active cell can be correctly read and set */ @Test - public void testActiveCell() throws IOException { + void testActiveCell() throws IOException { //read in sample try (HSSFWorkbook wb1 = HSSFTestDataSamples.openSampleWorkbook("Simple.xls")) { @@ -173,7 +173,7 @@ public final class TestHSSFCell extends @Test - public void testActiveCellBug56114() throws IOException { + void testActiveCellBug56114() throws IOException { try (Workbook wb = new HSSFWorkbook()) { Sheet sh = wb.createSheet(); @@ -215,7 +215,7 @@ public final class TestHSSFCell extends * Test reading hyperlinks */ @Test - public void testWithHyperlink() throws IOException { + void testWithHyperlink() throws IOException { try (HSSFWorkbook wb = HSSFTestDataSamples.openSampleWorkbook("WithHyperlink.xls")) { HSSFSheet sheet = wb.getSheetAt(0); @@ -234,7 +234,7 @@ public final class TestHSSFCell extends * Test reading hyperlinks */ @Test - public void testWithTwoHyperlinks() throws IOException { + void testWithTwoHyperlinks() throws IOException { try (HSSFWorkbook wb = HSSFTestDataSamples.openSampleWorkbook("WithTwoHyperLinks.xls")) { HSSFSheet sheet = wb.getSheetAt(0); @@ -262,7 +262,7 @@ public final class TestHSSFCell extends * to our workbook, and not those from other workbooks. */ @Test - public void testCellStyleWorkbookMatch() throws IOException { + void testCellStyleWorkbookMatch() throws IOException { try (HSSFWorkbook wbA = new HSSFWorkbook(); HSSFWorkbook wbB = new HSSFWorkbook()) { @@ -291,7 +291,7 @@ public final class TestHSSFCell extends * versions (prior to bug 46213 / r717883) crash instead. */ @Test - public void testCachedTypeChange() throws IOException { + void testCachedTypeChange() throws IOException { try (HSSFWorkbook wb = new HSSFWorkbook()) { HSSFSheet sheet = wb.createSheet("Sheet1"); Cell cell = sheet.createRow(0).createCell(0); @@ -336,14 +336,14 @@ public final class TestHSSFCell extends * HSSF prior to version 3.7 had a bug: it could write a NaN but could not read such a file back. */ @Test - public void testReadNaN() throws IOException { + void testReadNaN() throws IOException { try (HSSFWorkbook wb = HSSFTestDataSamples.openSampleWorkbook("49761.xls")) { assertNotNull(wb); } } @Test - public void testHSSFCell() throws IOException { + void testHSSFCell() throws IOException { try (HSSFWorkbook wb = new HSSFWorkbook()) { HSSFSheet sheet = wb.createSheet(); HSSFRow row = sheet.createRow(0); @@ -354,7 +354,7 @@ public final class TestHSSFCell extends } @Test - public void testDeprecatedMethods() throws IOException { + void testDeprecatedMethods() throws IOException { try (HSSFWorkbook wb = new HSSFWorkbook()) { HSSFSheet sheet = wb.createSheet(); HSSFRow row = sheet.createRow(0); @@ -371,7 +371,7 @@ public final class TestHSSFCell extends } @Test - public void testCellType() throws IOException { + void testCellType() throws IOException { try (Workbook wb = _testDataProvider.createWorkbook()) { Sheet sheet = wb.createSheet(); Row row = sheet.createRow(0); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFChart.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFChart.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFChart.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFChart.java Fri Jan 8 23:50:02 2021 @@ -39,7 +39,7 @@ import org.junit.jupiter.api.Test; public final class TestHSSFChart { @Test - public void testSingleChart() { + void testSingleChart() { HSSFWorkbook wb = openSampleWorkbook("WithChart.xls"); HSSFSheet s1 = wb.getSheetAt(0); @@ -69,7 +69,7 @@ public final class TestHSSFChart { } @Test - public void testTwoCharts() { + void testTwoCharts() { HSSFWorkbook wb = openSampleWorkbook("WithTwoCharts.xls"); HSSFSheet s1 = wb.getSheetAt(0); @@ -102,7 +102,7 @@ public final class TestHSSFChart { } @Test - public void testThreeCharts() { + void testThreeCharts() { HSSFWorkbook wb = openSampleWorkbook("WithThreeCharts.xls"); HSSFSheet s1 = wb.getSheetAt(0); @@ -143,7 +143,7 @@ public final class TestHSSFChart { } @Test - public void testExistingSheet3() throws Exception { + void testExistingSheet3() throws Exception { HSSFWorkbook wb = openSampleWorkbook("49581.xls"); HSSFSheet sheet = wb.getSheetAt( 2 ) ; @@ -166,7 +166,7 @@ public final class TestHSSFChart { } @Test - public void testExistingSheet2() throws Exception { + void testExistingSheet2() throws Exception { HSSFWorkbook wb = openSampleWorkbook("49581.xls"); HSSFSheet sheet = wb.getSheetAt( 1 ) ; HSSFChart[] charts = HSSFChart.getSheetCharts( sheet ) ; @@ -198,7 +198,7 @@ public final class TestHSSFChart { } @Test - public void testExistingSheet1() throws Exception { + void testExistingSheet1() throws Exception { try (HSSFWorkbook wb = openSampleWorkbook("49581.xls")) { HSSFSheet sheet = wb.getSheetAt(0); HSSFChart[] charts = HSSFChart.getSheetCharts(sheet); @@ -237,7 +237,7 @@ public final class TestHSSFChart { * Bug 26862: HSSFWorkbook.cloneSheet copies charts */ @Test - public void test26862() throws IOException, Exception { + void test26862() throws IOException, Exception { HSSFWorkbook wb = openSampleWorkbook("SimpleChart.xls"); HSSFSheet srcSheet = wb.getSheetAt(0); HSSFChart[] srcCharts = HSSFChart.getSheetCharts(srcSheet); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFClientAnchor.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFClientAnchor.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFClientAnchor.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFClientAnchor.java Fri Jan 8 23:50:02 2021 @@ -31,7 +31,7 @@ import org.junit.jupiter.api.Test; */ public final class TestHSSFClientAnchor { @Test - public void testGetAnchorHeightInPoints() throws IOException { + void testGetAnchorHeightInPoints() throws IOException { try (HSSFWorkbook wb = new HSSFWorkbook()) { HSSFSheet sheet = wb.createSheet("test"); HSSFClientAnchor a = new HSSFClientAnchor(0, 0, 1023, 255, (short) 0, 0, (short) 0, 0); @@ -68,7 +68,7 @@ public final class TestHSSFClientAnchor * (Bug 42999 reported that dx1 and dx2 are swapped if dx1>dx2. It doesn't make sense for client anchors.) */ @Test - public void testConvertAnchor() { + void testConvertAnchor() { HSSFClientAnchor[] anchors = { new HSSFClientAnchor( 0 , 0 , 0 , 0 ,(short)0, 1,(short)1,3), new HSSFClientAnchor( 100 , 0 , 900 , 255 ,(short)0, 1,(short)1,3), @@ -88,7 +88,7 @@ public final class TestHSSFClientAnchor } @Test - public void testAnchorHeightInPoints() throws IOException { + void testAnchorHeightInPoints() throws IOException { try (HSSFWorkbook wb = new HSSFWorkbook()) { HSSFSheet sheet = wb.createSheet(); @@ -110,7 +110,7 @@ public final class TestHSSFClientAnchor * Check {@link HSSFClientAnchor} constructor does not treat 32768 as -32768. */ @Test - public void testCanHaveRowGreaterThan32767() { + void testCanHaveRowGreaterThan32767() { // Maximum permitted row number should be 65535. HSSFClientAnchor anchor = new HSSFClientAnchor(0, 0, 0, 0, (short) 0, 32768, (short) 0, 32768); @@ -122,7 +122,7 @@ public final class TestHSSFClientAnchor * Check the maximum is not set at 255*256 instead of 256*256 - 1. */ @Test - public void testCanHaveRowUpTo65535() { + void testCanHaveRowUpTo65535() { HSSFClientAnchor anchor = new HSSFClientAnchor(0, 0, 0, 0, (short) 0, 65535, (short) 0, 65535); assertEquals(65535, anchor.getRow1()); @@ -130,7 +130,7 @@ public final class TestHSSFClientAnchor } @Test - public void testCannotHaveRowGreaterThan65535() { + void testCannotHaveRowGreaterThan65535() { assertThrows(IllegalArgumentException.class, () -> new HSSFClientAnchor(0, 0, 0, 0, (short) 0, 65536, (short) 0, 65536)); } @@ -139,7 +139,7 @@ public final class TestHSSFClientAnchor * Check the same maximum value enforced when using {@link HSSFClientAnchor#setRow1}. */ @Test - public void testCanSetRowUpTo65535() { + void testCanSetRowUpTo65535() { HSSFClientAnchor anchor = new HSSFClientAnchor(); anchor.setRow1(65535); anchor.setRow2(65535); @@ -149,13 +149,13 @@ public final class TestHSSFClientAnchor } @Test - public void testCannotSetRow1GreaterThan65535() { + void testCannotSetRow1GreaterThan65535() { assertThrows(IllegalArgumentException.class, () -> new HSSFClientAnchor().setRow1(65536)); } @Test - public void testCannotSetRow2GreaterThan65535() { + void testCannotSetRow2GreaterThan65535() { assertThrows(IllegalArgumentException.class, () -> new HSSFClientAnchor().setRow2(65536)); } Modified: poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFComment.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFComment.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFComment.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFComment.java Fri Jan 8 23:50:02 2021 @@ -102,7 +102,7 @@ public final class TestHSSFComment exten } @Test - public void testBug56380InsertComments() throws Exception { + void testBug56380InsertComments() throws Exception { HSSFWorkbook workbook = new HSSFWorkbook(); Sheet sheet = workbook.createSheet(); Drawing<?> drawing = sheet.createDrawingPatriarch(); @@ -138,7 +138,7 @@ public final class TestHSSFComment exten } @Test - public void testBug56380InsertTooManyComments() throws Exception { + void testBug56380InsertTooManyComments() throws Exception { try (HSSFWorkbook workbook = new HSSFWorkbook()) { Sheet sheet = workbook.createSheet(); Drawing<?> drawing = sheet.createDrawingPatriarch(); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFConditionalFormatting.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFConditionalFormatting.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFConditionalFormatting.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFConditionalFormatting.java Fri Jan 8 23:50:02 2021 @@ -56,17 +56,17 @@ public final class TestHSSFConditionalFo } @Test - public void testRead() throws IOException { + void testRead() throws IOException { testRead("WithConditionalFormatting.xls"); } @Test - public void testReadOffice2007() throws IOException { + void testReadOffice2007() throws IOException { testReadOffice2007("NewStyleConditionalFormattings.xls"); } @Test - public void test53691() throws IOException { + void test53691() throws IOException { SheetConditionalFormatting cf; final Workbook wb = HSSFITestDataProvider.instance.openSampleWorkbook("53691.xls"); /* Modified: poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFDataFormat.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFDataFormat.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFDataFormat.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFDataFormat.java Fri Jan 8 23:50:02 2021 @@ -49,7 +49,7 @@ public final class TestHSSFDataFormat ex * Bug 51378: getDataFormatString method call crashes when reading the test file */ @Test - public void test51378() throws IOException { + void test51378() throws IOException { List<String> expNull = Arrays.asList( "0-3-0","0-43-11" ); try (HSSFWorkbook wb = openSampleWorkbook("12561-1.xls")) { for (Sheet sheet : wb) { Modified: poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFDataFormatter.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFDataFormatter.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFDataFormatter.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFDataFormatter.java Fri Jan 8 23:50:02 2021 @@ -229,7 +229,7 @@ public final class TestHSSFDataFormatter * Test getting formatted values from numeric and date cells. */ @Test - public void testGetFormattedCellValueHSSFCell() { + void testGetFormattedCellValueHSSFCell() { // Valid date formats -- cell values should be date formatted & not "555.555" HSSFRow row = wb.getSheetAt(0).getRow(0); Iterator<Cell> it = row.cellIterator(); @@ -332,7 +332,7 @@ public final class TestHSSFDataFormatter } @Test - public void testGetFormattedCellValueHSSFCellHSSFFormulaEvaluator() { + void testGetFormattedCellValueHSSFCellHSSFFormulaEvaluator() { // test formula format HSSFRow row = wb.getSheetAt(0).getRow(7); HSSFCell cell = row.getCell(0); @@ -355,7 +355,7 @@ public final class TestHSSFDataFormatter * format pattern cannot be parsed by DecimalFormat. */ @Test - public void testSetDefaultNumberFormat() { + void testSetDefaultNumberFormat() { HSSFRow row = wb.getSheetAt(0).getRow(3); Iterator<Cell> it = row.cellIterator(); DecimalFormatSymbols dfs = DecimalFormatSymbols.getInstance(LocaleUtil.getUserLocale()); @@ -378,7 +378,7 @@ public final class TestHSSFDataFormatter * A format of "@" means use the general format */ @Test - public void testGeneralAtFormat() { + void testGeneralAtFormat() { HSSFWorkbook workbook = HSSFTestDataSamples.openSampleWorkbook("47154.xls"); HSSFSheet sheet = workbook.getSheetAt(0); HSSFRow row = sheet.getRow(0); @@ -397,7 +397,7 @@ public final class TestHSSFDataFormatter * Tests various formattings of dates and numbers */ @Test - public void testFromFile() { + void testFromFile() { HSSFWorkbook workbook = HSSFTestDataSamples.openSampleWorkbook("Formatting.xls"); HSSFSheet sheet = workbook.getSheetAt(0); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFEvaluationSheet.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFEvaluationSheet.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFEvaluationSheet.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFEvaluationSheet.java Fri Jan 8 23:50:02 2021 @@ -37,7 +37,7 @@ public class TestHSSFEvaluationSheet ext } @Test - public void testMissingExternalName() throws IOException { + void testMissingExternalName() throws IOException { try (HSSFWorkbook wb = openSampleWorkbook("external_name.xls")) { // this sometimes causes exceptions wb.getAllNames().stream().filter(n -> !n.isFunctionName()).forEach( Modified: poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFFormulaEvaluator.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFFormulaEvaluator.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFFormulaEvaluator.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFFormulaEvaluator.java Fri Jan 8 23:50:02 2021 @@ -50,7 +50,7 @@ public final class TestHSSFFormulaEvalua * (single cells and rectangular areas) */ @Test - public void testEvaluateSimple() throws IOException { + void testEvaluateSimple() throws IOException { HSSFWorkbook wb = HSSFTestDataSamples.openSampleWorkbook("testNames.xls"); HSSFSheet sheet = wb.getSheetAt(0); HSSFCell cell = sheet.getRow(8).getCell(0); @@ -69,7 +69,7 @@ public final class TestHSSFFormulaEvalua * for but POI should look elsewhere to decide whether it can evaluate the name. */ @Test - public void testDefinedNameWithComplexFlag_bug47048() throws IOException { + void testDefinedNameWithComplexFlag_bug47048() throws IOException { // Mock up a spreadsheet to match the critical details of the sample HSSFWorkbook wb = new HSSFWorkbook(); HSSFSheet sheet = wb.createSheet("Input"); @@ -130,7 +130,7 @@ public final class TestHSSFFormulaEvalua * The HSSFFormula evaluator performance benefits greatly from caching of intermediate cell values */ @Test - public void testShortCircuitIfEvaluation() throws IOException { + void testShortCircuitIfEvaluation() throws IOException { // Set up a simple IF() formula that has measurable evaluation cost for its operands. try (HSSFWorkbook wb = new HSSFWorkbook()) { HSSFSheet sheet = wb.createSheet("Sheet1"); @@ -160,7 +160,7 @@ public final class TestHSSFFormulaEvalua * we parse. */ @Test - public void testXRefs() throws IOException { + void testXRefs() throws IOException { try (HSSFWorkbook wb1 = HSSFTestDataSamples.openSampleWorkbook("XRefCalc.xls"); HSSFWorkbook wb2 = HSSFTestDataSamples.openSampleWorkbook("XRefCalcData.xls")) { Cell cell; Modified: poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFHeaderFooter.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFHeaderFooter.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFHeaderFooter.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFHeaderFooter.java Fri Jan 8 23:50:02 2021 @@ -34,7 +34,7 @@ public final class TestHSSFHeaderFooter * Tests that get header retrieves the proper values. */ @Test - public void testRetrieveCorrectHeader() throws IOException { + void testRetrieveCorrectHeader() throws IOException { try (HSSFWorkbook wb = openSampleWorkbook("EmbeddedChartHeaderTest.xls")) { HSSFSheet s = wb.getSheetAt(0); @@ -47,7 +47,7 @@ public final class TestHSSFHeaderFooter } @Test - public void testSpecialChars() { + void testSpecialChars() { assertEquals("&U", HSSFHeader.startUnderline()); assertEquals("&U", HSSFHeader.endUnderline()); assertEquals("&P", HSSFHeader.page()); @@ -57,7 +57,7 @@ public final class TestHSSFHeaderFooter } @Test - public void testStripFields() throws IOException { + void testStripFields() throws IOException { String simple = "I am a test header"; String withPage = "I am a&P test header"; String withLots = "I&A am&N a&P test&T header&U"; @@ -96,7 +96,7 @@ public final class TestHSSFHeaderFooter * Tests that get header retrieves the proper values. */ @Test - public void testRetrieveCorrectFooter() throws IOException { + void testRetrieveCorrectFooter() throws IOException { try (HSSFWorkbook wb = openSampleWorkbook("EmbeddedChartHeaderTest.xls")) { HSSFSheet s = wb.getSheetAt(0); HSSFFooter foot = s.getFooter(); @@ -111,7 +111,7 @@ public final class TestHSSFHeaderFooter * Testcase for Bug 17039 HSSFHeader does not support DBCS */ @Test - public void testHeaderHas16bitCharacter() throws IOException { + void testHeaderHas16bitCharacter() throws IOException { try (HSSFWorkbook b = new HSSFWorkbook()) { HSSFSheet s = b.createSheet("Test"); HSSFHeader h = s.getHeader(); @@ -133,7 +133,7 @@ public final class TestHSSFHeaderFooter * Testcase for Bug 17039 HSSFFooter does not support DBCS */ @Test - public void testFooterHas16bitCharacter() throws IOException { + void testFooterHas16bitCharacter() throws IOException { try (HSSFWorkbook b = new HSSFWorkbook()) { HSSFSheet s = b.createSheet("Test"); HSSFFooter f = s.getFooter(); @@ -152,7 +152,7 @@ public final class TestHSSFHeaderFooter } @Test - public void testReadDBCSHeaderFooter() throws IOException { + void testReadDBCSHeaderFooter() throws IOException { try (HSSFWorkbook wb = openSampleWorkbook("DBCSHeader.xls")) { HSSFSheet s = wb.getSheetAt(0); HSSFHeader h = s.getHeader(); @@ -171,7 +171,7 @@ public final class TestHSSFHeaderFooter * Excel tolerates files with missing HEADER/FOOTER records. POI should do the same. */ @Test - public void testMissingHeaderFooterRecord_bug47244() throws IOException { + void testMissingHeaderFooterRecord_bug47244() throws IOException { // noHeaderFooter47244.xls was created by a slightly modified POI // which omitted the HEADER/FOOTER records try (HSSFWorkbook wb = openSampleWorkbook("noHeaderFooter47244.xls")) { Modified: poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFHyperlink.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFHyperlink.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFHyperlink.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFHyperlink.java Fri Jan 8 23:50:02 2021 @@ -44,7 +44,7 @@ public final class TestHSSFHyperlink ext * Test that we can read hyperlinks. */ @Test - public void testRead() { + void testRead() { HSSFWorkbook wb = HSSFTestDataSamples.openSampleWorkbook("HyperlinksOnManySheets.xls"); @@ -90,7 +90,7 @@ public final class TestHSSFHyperlink ext } @Test - public void testModify() { + void testModify() { HSSFWorkbook wb = HSSFTestDataSamples.openSampleWorkbook("HyperlinksOnManySheets.xls"); HSSFSheet sheet; @@ -121,7 +121,7 @@ public final class TestHSSFHyperlink ext * @throws IOException */ @Test - public void testCreateDocumentLink() throws IOException { + void testCreateDocumentLink() throws IOException { HSSFWorkbook wb = new HSSFWorkbook(); //link to a place in this workbook @@ -168,7 +168,7 @@ public final class TestHSSFHyperlink ext } @Test - public void testCloneSheet() { + void testCloneSheet() { HSSFWorkbook wb = HSSFTestDataSamples.openSampleWorkbook("HyperlinksOnManySheets.xls"); HSSFCell cell; @@ -188,7 +188,7 @@ public final class TestHSSFHyperlink ext } @Test - public void testCreate() throws IOException { + void testCreate() throws IOException { HSSFWorkbook wb = new HSSFWorkbook(); HSSFHyperlink link; @@ -220,7 +220,7 @@ public final class TestHSSFHyperlink ext * see bugs #46445 and #29957 */ @Test - public void testShiftRows(){ + void testShiftRows(){ HSSFWorkbook wb = HSSFTestDataSamples.openSampleWorkbook("46445.xls"); @@ -268,7 +268,7 @@ public final class TestHSSFHyperlink ext /* @Test - public void testCopyXSSFHyperlink() throws IOException { + void testCopyXSSFHyperlink() throws IOException { XSSFWorkbook wb = new XSSFWorkbook(); XSSFCreationHelper helper = wb.getCreationHelper(); XSSFHyperlink xlink = helper.createHyperlink(Hyperlink.LINK_URL); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFName.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFName.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFName.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFName.java Fri Jan 8 23:50:02 2021 @@ -55,7 +55,7 @@ public final class TestHSSFName extends } @Test - public void testRepeatingRowsAndColumnsNames() throws Exception { + void testRepeatingRowsAndColumnsNames() throws Exception { // First test that setting RR&C for same sheet more than once only creates a // single Print_Titles built-in record HSSFWorkbook wb = new HSSFWorkbook(); @@ -103,7 +103,7 @@ public final class TestHSSFName extends } @Test - public void testNamedRange() throws Exception { + void testNamedRange() throws Exception { HSSFWorkbook wb1 = HSSFTestDataSamples.openSampleWorkbook("Simple.xls"); //Creating new Named Range @@ -141,7 +141,7 @@ public final class TestHSSFName extends * Addresses Bug <a href="http://issues.apache.org/bugzilla/show_bug.cgi?id=9632"; target="_bug">#9632</a> */ @Test - public void testNamedRead() throws Exception { + void testNamedRead() throws Exception { HSSFWorkbook wb = HSSFTestDataSamples.openSampleWorkbook("namedinput.xls"); //Get index of the named range with the name = "NamedRangeName" , which was defined in input.xls as A1:D10 @@ -174,7 +174,7 @@ public final class TestHSSFName extends * Addresses Bug <a href="http://issues.apache.org/bugzilla/show_bug.cgi?id=16411"; target="_bug">#16411</a> */ @Test - public void testNamedReadModify() throws Exception { + void testNamedReadModify() throws Exception { HSSFWorkbook wb = HSSFTestDataSamples.openSampleWorkbook("namedinput.xls"); HSSFName name = wb.getNameAt(0); @@ -195,7 +195,7 @@ public final class TestHSSFName extends * Test to see if the print area can be retrieved from an excel created file */ @Test - public void testPrintAreaFileRead() throws Exception { + void testPrintAreaFileRead() throws Exception { HSSFWorkbook workbook = HSSFTestDataSamples.openSampleWorkbook("SimpleWithPrintArea.xls"); String sheetName = workbook.getSheetName(0); @@ -206,7 +206,7 @@ public final class TestHSSFName extends } @Test - public void testDeletedReference() throws Exception { + void testDeletedReference() throws Exception { try (HSSFWorkbook wb = HSSFTestDataSamples.openSampleWorkbook("24207.xls")) { assertEquals(2, wb.getNumberOfNames()); @@ -232,7 +232,7 @@ public final class TestHSSFName extends * otherwise created named don't appear in the drop-down to the left of formula bar in Excel */ @Test - public void testTypeOfRootPtg() throws Exception { + void testTypeOfRootPtg() throws Exception { HSSFWorkbook wb = new HSSFWorkbook(); wb.createSheet("CSCO"); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFOptimiser.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFOptimiser.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFOptimiser.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFOptimiser.java Fri Jan 8 23:50:02 2021 @@ -30,7 +30,7 @@ import org.junit.jupiter.api.Test; public final class TestHSSFOptimiser { @Test - public void testDoesNoHarmIfNothingToDo() { + void testDoesNoHarmIfNothingToDo() { HSSFWorkbook wb = new HSSFWorkbook(); // New files start with 4 built in fonts, and 21 built in styles @@ -69,7 +69,7 @@ public final class TestHSSFOptimiser { } @Test - public void testOptimiseFonts() { + void testOptimiseFonts() { HSSFWorkbook wb = new HSSFWorkbook(); // Add 6 fonts, some duplicates @@ -168,7 +168,7 @@ public final class TestHSSFOptimiser { } @Test - public void testOptimiseStyles() { + void testOptimiseStyles() { HSSFWorkbook wb = new HSSFWorkbook(); // Two fonts @@ -285,7 +285,7 @@ public final class TestHSSFOptimiser { } @Test - public void testOptimiseStylesCheckActualStyles() { + void testOptimiseStylesCheckActualStyles() { HSSFWorkbook wb = new HSSFWorkbook(); // Several styles @@ -326,7 +326,7 @@ public final class TestHSSFOptimiser { } @Test - public void testColumnAndRowStyles() { + void testColumnAndRowStyles() { HSSFWorkbook wb = new HSSFWorkbook(); assertEquals(21, wb.getNumCellStyles(), "Usually we have 21 pre-defined styles in a newly created Workbook, see InternalWorkbook.createWorkbook()"); @@ -359,7 +359,7 @@ public final class TestHSSFOptimiser { } @Test - public void testUnusedStyle() { + void testUnusedStyle() { HSSFWorkbook wb = new HSSFWorkbook(); assertEquals(21, wb.getNumCellStyles(), "Usually we have 21 pre-defined styles in a newly created Workbook, see InternalWorkbook.createWorkbook()"); @@ -397,7 +397,7 @@ public final class TestHSSFOptimiser { } @Test - public void testUnusedStyleOneUsed() { + void testUnusedStyleOneUsed() { HSSFWorkbook wb = new HSSFWorkbook(); assertEquals(21, wb.getNumCellStyles(), "Usually we have 21 pre-defined styles in a newly created Workbook, see InternalWorkbook.createWorkbook()"); @@ -435,7 +435,7 @@ public final class TestHSSFOptimiser { } @Test - public void testDefaultColumnStyleWitoutCell() { + void testDefaultColumnStyleWitoutCell() { HSSFWorkbook wb = new HSSFWorkbook(); assertEquals(21, wb.getNumCellStyles(), "Usually we have 21 pre-defined styles in a newly created Workbook, see InternalWorkbook.createWorkbook()"); @@ -477,7 +477,7 @@ public final class TestHSSFOptimiser { } @Test - public void testUserDefinedStylesAreNeverOptimizedAway() { + void testUserDefinedStylesAreNeverOptimizedAway() { HSSFWorkbook wb = new HSSFWorkbook(); assertEquals(21, wb.getNumCellStyles(), "Usually we have 21 pre-defined styles in a newly created Workbook, see InternalWorkbook.createWorkbook()"); @@ -536,7 +536,7 @@ public final class TestHSSFOptimiser { } @Test - public void testBug57517() { + void testBug57517() { HSSFWorkbook wb = new HSSFWorkbook(); assertEquals(21, wb.getNumCellStyles(), "Usually we have 21 pre-defined styles in a newly created Workbook, see InternalWorkbook.createWorkbook()"); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFPalette.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFPalette.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFPalette.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFPalette.java Fri Jan 8 23:50:02 2021 @@ -50,7 +50,7 @@ public final class TestHSSFPalette { * Verifies that a custom palette can be created, saved, and reloaded */ @Test - public void testCustomPalette() { + void testCustomPalette() { //reading sample xls HSSFWorkbook book = HSSFTestDataSamples.openSampleWorkbook("Simple.xls"); @@ -86,7 +86,7 @@ public final class TestHSSFPalette { */ @SuppressWarnings("ConstantConditions") @Test - public void testPaletteFromCellColours() { + void testPaletteFromCellColours() { HSSFWorkbook book = HSSFTestDataSamples.openSampleWorkbook("SimpleWithColours.xls"); HSSFPalette p = book.getCustomPalette(); @@ -146,7 +146,7 @@ public final class TestHSSFPalette { @SuppressWarnings("ConstantConditions") @Test - public void testFindSimilar() throws IOException { + void testFindSimilar() throws IOException { HSSFWorkbook book = new HSSFWorkbook(); HSSFPalette p = book.getCustomPalette(); @@ -237,7 +237,7 @@ public final class TestHSSFPalette { * hardcoded values in the HSSFColor default color palette */ @Test - public void testGnumericStrings() { + void testGnumericStrings() { compareToDefaults((expected, palette) -> assertEquals(expected.getHexString(), palette.getHexString())); } @@ -245,7 +245,7 @@ public final class TestHSSFPalette { * Verifies that the palette handles invalid palette indexes */ @Test - public void testBadIndexes() { + void testBadIndexes() { //too small _hssfPalette.setColorAtIndex((short) 2, (byte) 255, (byte) 255, (byte) 255); //too large @@ -271,7 +271,7 @@ public final class TestHSSFPalette { } @Test - public void testAddColor() { + void testAddColor() { assertThrows(RuntimeException.class, () -> _hssfPalette.addColor((byte)10,(byte)10,(byte)10), "Failing because by default there are no colours left in the palette."); } @@ -281,7 +281,7 @@ public final class TestHSSFPalette { } @Test - public void test48403() throws Exception { + void test48403() throws Exception { HSSFWorkbook wb = new HSSFWorkbook(); Color color = Color.decode("#006B6B"); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFPatriarch.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFPatriarch.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFPatriarch.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFPatriarch.java Fri Jan 8 23:50:02 2021 @@ -28,7 +28,7 @@ import org.junit.jupiter.api.Test; public final class TestHSSFPatriarch { @Test - public void testBasic() throws IOException { + void testBasic() throws IOException { try (HSSFWorkbook wb = new HSSFWorkbook()) { HSSFSheet sheet = wb.createSheet(); @@ -38,7 +38,7 @@ public final class TestHSSFPatriarch { } @Test - public void test44916() throws IOException { + void test44916() throws IOException { try (HSSFWorkbook wb = new HSSFWorkbook()) { HSSFSheet sheet = wb.createSheet(); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFPictureData.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFPictureData.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFPictureData.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFPictureData.java Fri Jan 8 23:50:02 2021 @@ -54,7 +54,7 @@ public final class TestHSSFPictureData { } @Test - public void testPictures() throws IOException { + void testPictures() throws IOException { HSSFWorkbook wb = HSSFTestDataSamples.openSampleWorkbook("SimpleWithImages.xls"); // TODO - add getFormat() to interface PictureData and genericise wb.getAllPictures() @@ -91,7 +91,7 @@ public final class TestHSSFPictureData { } @Test - public void testMacPicture() throws IOException { + void testMacPicture() throws IOException { HSSFWorkbook wb = HSSFTestDataSamples.openSampleWorkbook("53446.xls"); try{ @@ -116,7 +116,7 @@ public final class TestHSSFPictureData { } @Test - public void testNotNullPictures() { + void testNotNullPictures() { HSSFWorkbook wb = HSSFTestDataSamples.openSampleWorkbook("SheetWithDrawing.xls"); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFRichTextString.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFRichTextString.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFRichTextString.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFRichTextString.java Fri Jan 8 23:50:02 2021 @@ -23,7 +23,7 @@ import org.junit.jupiter.api.Test; public final class TestHSSFRichTextString { @Test - public void testApplyFont() { + void testApplyFont() { HSSFRichTextString r = new HSSFRichTextString("testing"); assertEquals(0,r.numFormattingRuns()); r.applyFont(2,4, new HSSFFont((short)1, null)); @@ -64,7 +64,7 @@ public final class TestHSSFRichTextStrin } @Test - public void testClearFormatting() { + void testClearFormatting() { HSSFRichTextString r = new HSSFRichTextString("testing"); assertEquals(0, r.numFormattingRuns()); r.applyFont(2, 4, new HSSFFont( (short) 1, null)); @@ -78,7 +78,7 @@ public final class TestHSSFRichTextStrin * Test case proposed in Bug 40520: formated twice => will format whole String */ @Test - public void test40520_1() { + void test40520_1() { short font = 3; HSSFRichTextString r = new HSSFRichTextString("f0_123456789012345678901234567890123456789012345678901234567890"); @@ -95,7 +95,7 @@ public final class TestHSSFRichTextStrin * Test case proposed in Bug 40520: overlapped range => will format whole String */ @Test - public void test40520_2() { + void test40520_2() { short font = 3; HSSFRichTextString r = new HSSFRichTextString("f0_123456789012345678901234567890123456789012345678901234567890"); @@ -112,7 +112,7 @@ public final class TestHSSFRichTextStrin * Test case proposed in Bug 40520: formated twice => will format whole String */ @Test - public void test40520_3() { + void test40520_3() { short font = 3; HSSFRichTextString r = new HSSFRichTextString("f0_123456789012345678901234567890123456789012345678901234567890"); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFRow.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFRow.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFRow.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFRow.java Fri Jan 8 23:50:02 2021 @@ -44,7 +44,7 @@ public final class TestHSSFRow extends B } @Test - public void testLastAndFirstColumns_bug46654() throws IOException { + void testLastAndFirstColumns_bug46654() throws IOException { int ROW_IX = 10; int COL_IX = 3; HSSFWorkbook workbook = new HSSFWorkbook(); @@ -73,7 +73,7 @@ public final class TestHSSFRow extends B } @Test - public void testMoveCell() throws IOException { + void testMoveCell() throws IOException { HSSFWorkbook workbook = new HSSFWorkbook(); HSSFSheet sheet = workbook.createSheet(); HSSFRow row = sheet.createRow(0); @@ -113,7 +113,7 @@ public final class TestHSSFRow extends B @Override @Test - public void testRowHeight() throws IOException{ + protected void testRowHeight() throws IOException{ HSSFWorkbook workbook = new HSSFWorkbook(); HSSFSheet sheet = workbook.createSheet(); HSSFRow row = sheet.createRow(0); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFSheet.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFSheet.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFSheet.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFSheet.java Fri Jan 8 23:50:02 2021 @@ -1067,7 +1067,7 @@ public final class TestHSSFSheet extends } @Test - public void test58746() throws IOException { + void test58746() throws IOException { try (HSSFWorkbook wb = new HSSFWorkbook()) { HSSFSheet first = wb.createSheet("first"); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFSheetShiftColumns.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFSheetShiftColumns.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFSheetShiftColumns.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFSheetShiftColumns.java Fri Jan 8 23:50:02 2021 @@ -60,21 +60,21 @@ public class TestHSSFSheetShiftColumns e @Override @Disabled("see <https://bz.apache.org/bugzilla/show_bug.cgi?id=62030>") @Test - public void testBug54524() throws IOException { + protected void testBug54524() throws IOException { // This override is used only in order to test failing for HSSF. Please remove method after code is fixed on hssf, // so that original method from BaseTestSheetShiftColumns can be executed. } @Override @Disabled("see <https://bz.apache.org/bugzilla/show_bug.cgi?id=62030>") @Test - public void testCommentsShifting() throws IOException { + protected void testCommentsShifting() throws IOException { // This override is used only in order to test failing for HSSF. Please remove method after code is fixed on hssf, // so that original method from BaseTestSheetShiftColumns can be executed. } @Override @Disabled("see <https://bz.apache.org/bugzilla/show_bug.cgi?id=62030>") @Test - public void testShiftWithMergedRegions() throws IOException { + protected void testShiftWithMergedRegions() throws IOException { // This override is used only in order to test failing for HSSF. Please remove method after code is fixed on hssf, // so that original method from BaseTestSheetShiftColumns can be executed. // After removing, you can re-add 'final' keyword to specification of original method. @@ -82,5 +82,5 @@ public class TestHSSFSheetShiftColumns e @Override @Disabled("see <https://bz.apache.org/bugzilla/show_bug.cgi?id=62030>") @Test - public void testShiftHyperlinks() throws IOException {} + protected void testShiftHyperlinks() throws IOException {} } Modified: poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFSheetUpdateArrayFormulas.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFSheetUpdateArrayFormulas.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFSheetUpdateArrayFormulas.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFSheetUpdateArrayFormulas.java Fri Jan 8 23:50:02 2021 @@ -53,7 +53,7 @@ public final class TestHSSFSheetUpdateAr // Test methods common with XSSF are in superclass // Local methods here test HSSF-specific details of updating array formulas @Test - public void testHSSFSetArrayFormula_singleCell() throws IOException { + void testHSSFSetArrayFormula_singleCell() throws IOException { try (HSSFWorkbook workbook = new HSSFWorkbook()) { HSSFSheet sheet = workbook.createSheet("Sheet1"); @@ -80,7 +80,7 @@ public final class TestHSSFSheetUpdateAr * Makes sure the internal state of HSSFSheet is consistent after removing array formulas */ @Test - public void testAddRemoveArrayFormulas_recordUpdates() throws IOException { + void testAddRemoveArrayFormulas_recordUpdates() throws IOException { try (HSSFWorkbook wb = new HSSFWorkbook()) { HSSFSheet s = wb.createSheet("Sheet1"); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFTextbox.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFTextbox.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFTextbox.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFTextbox.java Fri Jan 8 23:50:02 2021 @@ -32,7 +32,7 @@ public final class TestHSSFTextbox { * Test that accessors to horizontal and vertical alignment work properly */ @Test - public void testAlignment() throws IOException { + void testAlignment() throws IOException { try (HSSFWorkbook wb = new HSSFWorkbook()) { HSSFSheet sh1 = wb.createSheet(); HSSFPatriarch patriarch = sh1.createDrawingPatriarch(); @@ -53,7 +53,7 @@ public final class TestHSSFTextbox { * When inserting text make sure that if font is not set we must set the default one. */ @Test - public void testSetDeafultTextFormat() throws IOException { + void testSetDeafultTextFormat() throws IOException { try (HSSFWorkbook wb = new HSSFWorkbook()) { HSSFSheet sheet = wb.createSheet(); HSSFPatriarch patriarch = sheet.createDrawingPatriarch(); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFWorkbook.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFWorkbook.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFWorkbook.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFWorkbook.java Fri Jan 8 23:50:02 2021 @@ -857,7 +857,7 @@ public final class TestHSSFWorkbook exte } @Test - public void testMethods() throws IOException { + void testMethods() throws IOException { try (HSSFWorkbook wb=new HSSFWorkbook()) { assertDoesNotThrow(wb::insertChartRecord); //wb.dumpDrawingGroupRecords(true); @@ -1012,7 +1012,7 @@ public final class TestHSSFWorkbook exte } @Test - public void test49423() throws Exception + void test49423() throws Exception { HSSFWorkbook workbook = openSampleWorkbook("49423.xls"); @@ -1045,7 +1045,7 @@ public final class TestHSSFWorkbook exte } @Test - public void testRewriteFileBug58480() throws IOException { + void testRewriteFileBug58480() throws IOException { final File file = TempFile.createTempFile("TestHSSFWorkbook", ".xls"); try { @@ -1167,7 +1167,7 @@ public final class TestHSSFWorkbook exte } @Test - public void testWriteToNewFile() throws Exception { + void testWriteToNewFile() throws Exception { // Save to a new temp file final File file = TempFile.createTempFile("TestHSSFWorkbook", ".xls"); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestNonStandardWorkbookStreamNames.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestNonStandardWorkbookStreamNames.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestNonStandardWorkbookStreamNames.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestNonStandardWorkbookStreamNames.java Fri Jan 8 23:50:02 2021 @@ -41,7 +41,7 @@ public final class TestNonStandardWorkbo * Test that we can open a file with WORKBOOK */ @Test - public void testOpenWORKBOOK() throws IOException { + void testOpenWORKBOOK() throws IOException { // Try to open the workbook InputStream is = HSSFTestDataSamples.openSampleFileStream(xlsA); HSSFWorkbook wb = new HSSFWorkbook(is); @@ -62,7 +62,7 @@ public final class TestNonStandardWorkbo * Test that we can open a file with BOOK */ @Test - public void testOpenBOOK() throws IOException { + void testOpenBOOK() throws IOException { // Try to open the workbook InputStream is = HSSFTestDataSamples.openSampleFileStream(xlsB); HSSFWorkbook wb = new HSSFWorkbook(is); @@ -83,7 +83,7 @@ public final class TestNonStandardWorkbo * Test that when we write out, we go back to the correct case */ @Test - public void testWrite() throws IOException { + void testWrite() throws IOException { for (String file : new String[] {xlsA, xlsB}) { // Open the workbook, not preserving nodes InputStream is = HSSFTestDataSamples.openSampleFileStream(file); @@ -110,7 +110,7 @@ public final class TestNonStandardWorkbo * correct case */ @Test - public void testWritePreserve() throws IOException { + void testWritePreserve() throws IOException { // Open the workbook, not preserving nodes InputStream is = HSSFTestDataSamples.openSampleFileStream(xlsA); HSSFWorkbook wb = new HSSFWorkbook(is,true); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestOLE2Embeding.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestOLE2Embeding.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestOLE2Embeding.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestOLE2Embeding.java Fri Jan 8 23:50:02 2021 @@ -40,7 +40,7 @@ import org.junit.jupiter.api.Test; public final class TestOLE2Embeding { @Test - public void testEmbeding() throws Exception { + void testEmbeding() throws Exception { // This used to break, until bug #43116 was fixed try (HSSFWorkbook workbook = HSSFTestDataSamples.openSampleWorkbook("ole2-embedding.xls")) { // Check we can get at the Escher layer still @@ -49,7 +49,7 @@ public final class TestOLE2Embeding { } @Test - public void testEmbeddedObjects() throws Exception { + void testEmbeddedObjects() throws Exception { try (HSSFWorkbook workbook = HSSFTestDataSamples.openSampleWorkbook("ole2-embedding.xls")) { List<HSSFObjectData> objects = workbook.getAllEmbeddedObjects(); assertEquals(2, objects.size(), "Wrong number of objects"); @@ -59,7 +59,7 @@ public final class TestOLE2Embeding { } @Test - public void testReallyEmbedSomething() throws Exception { + void testReallyEmbedSomething() throws Exception { HSSFWorkbook wb1 = new HSSFWorkbook(); HSSFSheet sheet = wb1.createSheet(); HSSFPatriarch patriarch = sheet.createDrawingPatriarch(); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestPOIFSProperties.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestPOIFSProperties.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestPOIFSProperties.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestPOIFSProperties.java Fri Jan 8 23:50:02 2021 @@ -38,7 +38,7 @@ public class TestPOIFSProperties { private static final String title = "Testing POIFS properties"; @Test - public void testFail() throws Exception { + void testFail() throws Exception { ByteArrayOutputStream out = new ByteArrayOutputStream(); { // read the workbook, adjust the SummaryInformation and write the data to a byte array POIFSFileSystem fs = openFileSystem(); @@ -60,7 +60,7 @@ public class TestPOIFSProperties { } @Test - public void testOK() throws Exception { + void testOK() throws Exception { ByteArrayOutputStream out = new ByteArrayOutputStream(); { // read the workbook, adjust the SummaryInformation and write the data to a byte array POIFSFileSystem fs = openFileSystem(); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestPatriarch.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestPatriarch.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestPatriarch.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestPatriarch.java Fri Jan 8 23:50:02 2021 @@ -29,7 +29,7 @@ import org.junit.jupiter.api.Test; public class TestPatriarch { @Test - public void testGetPatriarch(){ + void testGetPatriarch(){ HSSFWorkbook wb = new HSSFWorkbook(); HSSFSheet sh = wb.createSheet(); assertNull(sh.getDrawingPatriarch()); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestPolygon.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestPolygon.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestPolygon.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestPolygon.java Fri Jan 8 23:50:02 2021 @@ -33,7 +33,7 @@ import org.junit.jupiter.api.Test; public class TestPolygon { @Test - public void testResultEqualsToAbstractShape() throws IOException { + void testResultEqualsToAbstractShape() throws IOException { HSSFWorkbook wb = new HSSFWorkbook(); HSSFSheet sh = wb.createSheet(); HSSFPatriarch patriarch = sh.createDrawingPatriarch(); @@ -76,7 +76,7 @@ public class TestPolygon { } @Test - public void testPolygonPoints() throws IOException { + void testPolygonPoints() throws IOException { HSSFWorkbook wb = new HSSFWorkbook(); HSSFSheet sh = wb.createSheet(); HSSFPatriarch patriarch = sh.createDrawingPatriarch(); @@ -129,7 +129,7 @@ public class TestPolygon { } @Test - public void testSetGetProperties() throws IOException { + void testSetGetProperties() throws IOException { HSSFWorkbook wb1 = new HSSFWorkbook(); HSSFSheet sh = wb1.createSheet(); HSSFPatriarch patriarch = sh.createDrawingPatriarch(); @@ -178,7 +178,7 @@ public class TestPolygon { } @Test - public void testAddToExistingFile() throws IOException { + void testAddToExistingFile() throws IOException { HSSFWorkbook wb1 = new HSSFWorkbook(); HSSFSheet sh = wb1.createSheet(); HSSFPatriarch patriarch = sh.createDrawingPatriarch(); @@ -232,7 +232,7 @@ public class TestPolygon { } @Test - public void testExistingFile() throws IOException { + void testExistingFile() throws IOException { HSSFWorkbook wb = HSSFTestDataSamples.openSampleWorkbook("drawings.xls"); HSSFSheet sheet = wb.getSheet("polygon"); HSSFPatriarch drawing = sheet.getDrawingPatriarch(); @@ -248,7 +248,7 @@ public class TestPolygon { } @Test - public void testPolygonType() throws IOException { + void testPolygonType() throws IOException { HSSFWorkbook wb1 = new HSSFWorkbook(); HSSFSheet sh = wb1.createSheet(); HSSFPatriarch patriarch = sh.createDrawingPatriarch(); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestReadWriteChart.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestReadWriteChart.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestReadWriteChart.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestReadWriteChart.java Fri Jan 8 23:50:02 2021 @@ -42,7 +42,7 @@ public final class TestReadWriteChart { * In the presence of a chart we need to make sure BOF/EOF records still exist. */ @Test - public void testBOFandEOFRecords() throws Exception { + void testBOFandEOFRecords() throws Exception { HSSFWorkbook workbook = HSSFTestDataSamples.openSampleWorkbook("SimpleChart.xls"); HSSFSheet sheet = workbook.getSheetAt(0); HSSFRow firstRow = sheet.getRow(0); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestRowStyle.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestRowStyle.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestRowStyle.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestRowStyle.java Fri Jan 8 23:50:02 2021 @@ -41,7 +41,7 @@ public final class TestRowStyle { * HSSFSheet last row or first row is incorrect. <P> */ @Test - public void testWriteSheetFont() throws IOException { + void testWriteSheetFont() throws IOException { try (HSSFWorkbook wb = new HSSFWorkbook()) { HSSFSheet s = wb.createSheet(); HSSFFont fnt = wb.createFont(); @@ -68,7 +68,7 @@ public final class TestRowStyle { * Tests that is creating a file with a date or an calendar works correctly. */ @Test - public void testDataStyle() throws IOException { + void testDataStyle() throws IOException { try (HSSFWorkbook wb = new HSSFWorkbook()) { HSSFSheet s = wb.createSheet(); HSSFCellStyle cs = wb.createCellStyle(); @@ -106,7 +106,7 @@ public final class TestRowStyle { * HSSFSheet last row or first row is incorrect. <P> */ @Test - public void testWriteSheetStyle() throws IOException { + void testWriteSheetStyle() throws IOException { try (HSSFWorkbook wb = new HSSFWorkbook()) { HSSFSheet s = wb.createSheet(); HSSFFont fnt = wb.createFont(); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestSanityChecker.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestSanityChecker.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestSanityChecker.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestSanityChecker.java Fri Jan 8 23:50:02 2021 @@ -46,7 +46,7 @@ public final class TestSanityChecker { } @Test - public void testCheckRecordOrder() { + void testCheckRecordOrder() { final SanityChecker c = new SanityChecker(); List<org.apache.poi.hssf.record.Record> records = new ArrayList<>(); records.add(new BOFRecord()); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestShapeGroup.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestShapeGroup.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestShapeGroup.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestShapeGroup.java Fri Jan 8 23:50:02 2021 @@ -33,7 +33,7 @@ import org.junit.jupiter.api.Test; public class TestShapeGroup { @Test - public void testSetGetCoordinates() throws IOException { + void testSetGetCoordinates() throws IOException { HSSFWorkbook wb1 = new HSSFWorkbook(); HSSFSheet sh = wb1.createSheet(); HSSFPatriarch patriarch = sh.createDrawingPatriarch(); @@ -64,7 +64,7 @@ public class TestShapeGroup { } @Test - public void testAddToExistingFile() throws IOException { + void testAddToExistingFile() throws IOException { HSSFWorkbook wb1 = new HSSFWorkbook(); HSSFSheet sh = wb1.createSheet(); HSSFPatriarch patriarch = sh.createDrawingPatriarch(); @@ -94,7 +94,7 @@ public class TestShapeGroup { } @Test - public void testModify() throws IOException { + void testModify() throws IOException { HSSFWorkbook wb1 = new HSSFWorkbook(); // create a sheet with a text box @@ -172,7 +172,7 @@ public class TestShapeGroup { } @Test - public void testAddShapesToGroup() throws IOException { + void testAddShapesToGroup() throws IOException { HSSFWorkbook wb1 = new HSSFWorkbook(); // create a sheet with a text box @@ -234,7 +234,7 @@ public class TestShapeGroup { } @Test - public void testSpgrRecord() throws IOException { + void testSpgrRecord() throws IOException { HSSFWorkbook wb = new HSSFWorkbook(); // create a sheet with a text box @@ -251,7 +251,7 @@ public class TestShapeGroup { } @Test - public void testClearShapes() throws IOException { + void testClearShapes() throws IOException { HSSFWorkbook wb1 = new HSSFWorkbook(); HSSFSheet sheet = wb1.createSheet(); HSSFPatriarch patriarch = sheet.createDrawingPatriarch(); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestSheetHiding.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestSheetHiding.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestSheetHiding.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestSheetHiding.java Fri Jan 8 23:50:02 2021 @@ -36,7 +36,7 @@ public final class TestSheetHiding exten } @Test - public void testInternalWorkbookHidden() { + void testInternalWorkbookHidden() { HSSFWorkbook wb = new HSSFWorkbook(); wb.createSheet("MySheet"); InternalWorkbook intWb = wb.getWorkbook(); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestText.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestText.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestText.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestText.java Fri Jan 8 23:50:02 2021 @@ -35,7 +35,7 @@ import org.junit.jupiter.api.Test; public class TestText { @Test - public void testResultEqualsToNonExistingAbstractShape() throws IOException { + void testResultEqualsToNonExistingAbstractShape() throws IOException { HSSFWorkbook wb = new HSSFWorkbook(); HSSFSheet sh = wb.createSheet(); HSSFPatriarch patriarch = sh.createDrawingPatriarch(); @@ -88,7 +88,7 @@ public class TestText { } @Test - public void testAddTextToExistingFile() throws Exception { + void testAddTextToExistingFile() throws Exception { HSSFWorkbook wb1 = new HSSFWorkbook(); HSSFSheet sh = wb1.createSheet(); HSSFPatriarch patriarch = sh.createDrawingPatriarch(); @@ -123,7 +123,7 @@ public class TestText { } @Test - public void testSetGetProperties() throws Exception { + void testSetGetProperties() throws Exception { HSSFWorkbook wb1 = new HSSFWorkbook(); HSSFSheet sh = wb1.createSheet(); HSSFPatriarch patriarch = sh.createDrawingPatriarch(); @@ -196,7 +196,7 @@ public class TestText { } @Test - public void testExistingFileWithText() throws Exception { + void testExistingFileWithText() throws Exception { HSSFWorkbook wb = HSSFTestDataSamples.openSampleWorkbook("drawings.xls"); HSSFSheet sheet = wb.getSheet("text"); HSSFPatriarch drawing = sheet.getDrawingPatriarch(); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestUnfixedBugs.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestUnfixedBugs.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestUnfixedBugs.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestUnfixedBugs.java Fri Jan 8 23:50:02 2021 @@ -42,7 +42,7 @@ import org.junit.jupiter.api.Test; */ public final class TestUnfixedBugs { @Test - public void testFormulaRecordAggregate_1() throws Exception { + void testFormulaRecordAggregate_1() throws Exception { // fails at formula "=MEHRFACH.OPERATIONEN(E$3;$B$5;$D4)" try (Workbook wb = HSSFTestDataSamples.openSampleWorkbook("44958_1.xls")) { for (int i = 0; i < wb.getNumberOfSheets(); i++) { @@ -66,7 +66,7 @@ public final class TestUnfixedBugs { } @Test - public void testFormulaRecordAggregate() throws Exception { + void testFormulaRecordAggregate() throws Exception { // fails at formula "=MEHRFACH.OPERATIONEN(E$3;$B$5;$D4)" try (Workbook wb = HSSFTestDataSamples.openSampleWorkbook("44958.xls")) { for (int i = 0; i < wb.getNumberOfSheets(); i++) { @@ -90,7 +90,7 @@ public final class TestUnfixedBugs { } @Test - public void testBug57074() throws IOException { + void testBug57074() throws IOException { Workbook wb = HSSFTestDataSamples.openSampleWorkbook("57074.xls"); Sheet sheet = wb.getSheet("Sheet1"); Row row = sheet.getRow(0); @@ -109,13 +109,13 @@ public final class TestUnfixedBugs { } @Test - public void testBug62242() { + void testBug62242() { CellFormat cfUK = CellFormat.getInstance("_ * #,##0.00_ ;_ * \\-#,##0.00_ ;_ * \"-\"??_ ;_ @_"); assertEquals(" - ", cfUK.apply((double) 0).text); } @Test - public void testDataFormattingWithQuestionMarkBug62242() { + void testDataFormattingWithQuestionMarkBug62242() { // The question mark in the format should be replaced by blanks, but // this is currently not handled when producing the Java formatting and // so we end up with a trailing zero here @@ -124,7 +124,7 @@ public final class TestUnfixedBugs { } @Test - public void testDataFormattingWithQuestionMarkAndPoundBug62242() { + void testDataFormattingWithQuestionMarkAndPoundBug62242() { char pound = '\u00A3'; // The question mark in the format should be replaced by blanks, but Modified: poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestUnicodeWorkbook.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestUnicodeWorkbook.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestUnicodeWorkbook.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestUnicodeWorkbook.java Fri Jan 8 23:50:02 2021 @@ -33,7 +33,7 @@ public final class TestUnicodeWorkbook { * It should have been written as a compressed unicode. */ @Test - public void testUmlatReadWrite() throws IOException { + void testUmlatReadWrite() throws IOException { try (HSSFWorkbook wb1 = new HSSFWorkbook()) { //Create a unicode sheet name (euro symbol) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@poi.apache.org For additional commands, e-mail: commits-h...@poi.apache.org
