This is an automated email from the ASF dual-hosted git repository. shimamoto pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/predictionio-template-ecom-recommender.git
The following commit(s) were added to refs/heads/develop by this push: new 2d312eb Mark override methods new df4ecd4 Merge pull request #17 from takezoe/mark-override 2d312eb is described below commit 2d312ebb9bc818fdae43cf39aa2414536c5c2c50 Author: Naoki Takezoe <take...@apache.org> AuthorDate: Thu May 30 20:13:47 2019 +0900 Mark override methods --- src/main/scala/ECommAlgorithm.scala | 2 ++ src/main/scala/Preparator.scala | 1 + 2 files changed, 3 insertions(+) diff --git a/src/main/scala/ECommAlgorithm.scala b/src/main/scala/ECommAlgorithm.scala index f812619..e10ff8f 100644 --- a/src/main/scala/ECommAlgorithm.scala +++ b/src/main/scala/ECommAlgorithm.scala @@ -62,6 +62,7 @@ class ECommAlgorithm(val ap: ECommAlgorithmParams) @transient lazy val logger = Logger[this.type] + override def train(sc: SparkContext, data: PreparedData): ECommModel = { require(!data.viewEvents.take(1).isEmpty, s"viewEvents in PreparedData cannot be empty." + @@ -214,6 +215,7 @@ class ECommAlgorithm(val ap: ECommAlgorithmParams) buyCountsRDD.collectAsMap.toMap } + override def predict(model: ECommModel, query: Query): PredictedResult = { val userFeatures = model.userFeatures diff --git a/src/main/scala/Preparator.scala b/src/main/scala/Preparator.scala index 3878ef3..731cca6 100644 --- a/src/main/scala/Preparator.scala +++ b/src/main/scala/Preparator.scala @@ -8,6 +8,7 @@ import org.apache.spark.rdd.RDD class Preparator extends PPreparator[TrainingData, PreparedData] { + override def prepare(sc: SparkContext, trainingData: TrainingData): PreparedData = { new PreparedData( users = trainingData.users,