[GitHub] skyrocknroll commented on issue #2792: support auto.offset.reset on the Pulsar adaptor for Apache Kafka

2018-10-26 Thread GitBox
skyrocknroll commented on issue #2792: support auto.offset.reset on the Pulsar adaptor for Apache Kafka URL: https://github.com/apache/pulsar/issues/2792#issuecomment-433592430 @ivankelly https://kafka.apache.org/documentation.html#newconsumerconfigs . What to do when there is no initial

[GitHub] sijie commented on issue #2858: What official pulsar helm chart request 15GB memory for bookeeper, zookeeper and broker?

2018-10-26 Thread GitBox
sijie commented on issue #2858: What official pulsar helm chart request 15GB memory for bookeeper,zookeeper and broker? URL: https://github.com/apache/pulsar/issues/2858#issuecomment-433592171 @benjaminhuo > Official pulsar helm chart request 15GB memory for bookeeper,zookeeper and

[GitHub] sijie closed pull request #2814: Fix memory issue in cpp ZTSClient

2018-10-26 Thread GitBox
sijie closed pull request #2814: Fix memory issue in cpp ZTSClient URL: https://github.com/apache/pulsar/pull/2814 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[pulsar] branch master updated: Fix memory issue in cpp ZTSClient (#2814)

2018-10-26 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new c518247 Fix memory issue in cpp ZTSClient

[pulsar] branch master updated: Added ability for the kubernetes to poll a configmap to look out for changes (#2856)

2018-10-26 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 2d208c5 Added ability for the kubernetes to

[GitHub] sijie closed pull request #2857: Reduce memory reserved for prometheus

2018-10-26 Thread GitBox
sijie closed pull request #2857: Reduce memory reserved for prometheus URL: https://github.com/apache/pulsar/pull/2857 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] benjaminhuo opened a new issue #2858: What official pulsar helm chart request 15GB memory for bookeeper, zookeeper and broker?

2018-10-26 Thread GitBox
benjaminhuo opened a new issue #2858: What official pulsar helm chart request 15GB memory for bookeeper,zookeeper and broker? URL: https://github.com/apache/pulsar/issues/2858 Expected behavior The memory should be set to a reasonable size Actual behavior Tell us

[GitHub] srkukarni opened a new pull request #2857: Reduce memory reserved for prometheus

2018-10-26 Thread GitBox
srkukarni opened a new pull request #2857: Reduce memory reserved for prometheus URL: https://github.com/apache/pulsar/pull/2857 ### Motivation Explain here the context, and why you're making that change. What is the problem you're trying to solve. ### Modifications

[GitHub] srkukarni opened a new pull request #2856: Added ability for the kubernetes to poll a configmap to look out for changes

2018-10-26 Thread GitBox
srkukarni opened a new pull request #2856: Added ability for the kubernetes to poll a configmap to look out for changes URL: https://github.com/apache/pulsar/pull/2856 ### Motivation While running functions worker in kubernetes, it might be hard to update any kind of config of the

[GitHub] srkukarni opened a new pull request #2855: Secretprovider interfaces and some default implementations

2018-10-26 Thread GitBox
srkukarni opened a new pull request #2855: Secretprovider interfaces and some default implementations URL: https://github.com/apache/pulsar/pull/2855 ### Motivation This pr defines the SecretsProviderConfigurator that configures the function instances/containers and plugs in the

[GitHub] srkukarni commented on issue #2855: Secretprovider interfaces and some default implementations

2018-10-26 Thread GitBox
srkukarni commented on issue #2855: Secretprovider interfaces and some default implementations URL: https://github.com/apache/pulsar/pull/2855#issuecomment-433562824 @cckellogg This is an automated message from the Apache

[GitHub] srkukarni commented on issue #2853: Secrets Frontend

2018-10-26 Thread GitBox
srkukarni commented on issue #2853: Secrets Frontend URL: https://github.com/apache/pulsar/pull/2853#issuecomment-433541994 rerun java8 tests This is an automated message from the Apache Git Service. To respond to the

[GitHub] merlimat commented on issue #2852: Add connection timeout client configuration option

2018-10-26 Thread GitBox
merlimat commented on issue #2852: Add connection timeout client configuration option URL: https://github.com/apache/pulsar/pull/2852#issuecomment-433535510 run integration tests This is an automated message from the Apache

[GitHub] merlimat opened a new pull request #2854: Fixed ZLib decompression in C++ client

2018-10-26 Thread GitBox
merlimat opened a new pull request #2854: Fixed ZLib decompression in C++ client URL: https://github.com/apache/pulsar/pull/2854 ### Motivation The ZLib method `uncompress()` is not able to process data that was compressed from Pulsar Java producer with ZLib. This is due to

[GitHub] srkukarni commented on issue #2853: Secrets Frontend

2018-10-26 Thread GitBox
srkukarni commented on issue #2853: Secrets Frontend URL: https://github.com/apache/pulsar/pull/2853#issuecomment-433526803 rerun java8 tests This is an automated message from the Apache Git Service. To respond to the

[GitHub] srkukarni commented on issue #2853: Secrets Frontend

2018-10-26 Thread GitBox
srkukarni commented on issue #2853: Secrets Frontend URL: https://github.com/apache/pulsar/pull/2853#issuecomment-433515376 rerun java8 tests This is an automated message from the Apache Git Service. To respond to the

[GitHub] srkukarni commented on issue #2853: Secrets Frontend

2018-10-26 Thread GitBox
srkukarni commented on issue #2853: Secrets Frontend URL: https://github.com/apache/pulsar/pull/2853#issuecomment-433515089 rerun java8 tests This is an automated message from the Apache Git Service. To respond to the

[GitHub] merlimat closed pull request #2829: Fix Websocket Consume Messages in Partitioned Topics

2018-10-26 Thread GitBox
merlimat closed pull request #2829: Fix Websocket Consume Messages in Partitioned Topics URL: https://github.com/apache/pulsar/pull/2829 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] merlimat commented on issue #1070: Provide a nodejs client

2018-10-26 Thread GitBox
merlimat commented on issue #1070: Provide a nodejs client URL: https://github.com/apache/pulsar/issues/1070#issuecomment-433491319 @mujimu There are indeed plans to start soon working on this. Thanks for the link. If you have JS experience it would be also good to have feedback on API

[pulsar] branch master updated: Fix Websocket Consume Messages in Partitioned Topics (#2829)

2018-10-26 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new d79499d Fix Websocket Consume Messages in

[GitHub] jerrypeng commented on a change in pull request #2826: Secrets Interface

2018-10-26 Thread GitBox
jerrypeng commented on a change in pull request #2826: Secrets Interface URL: https://github.com/apache/pulsar/pull/2826#discussion_r228607992 ## File path:

[GitHub] jerrypeng commented on a change in pull request #2826: Secrets Interface

2018-10-26 Thread GitBox
jerrypeng commented on a change in pull request #2826: Secrets Interface URL: https://github.com/apache/pulsar/pull/2826#discussion_r228606081 ## File path: pulsar-functions/secretsprovider/src/main/java/org/apache/pulsar/functions/secretsprovider/SecretsProvider.java ##

[pulsar] branch master updated: adding Python function instance unit test (#2850)

2018-10-26 Thread jerrypeng
This is an automated email from the ASF dual-hosted git repository. jerrypeng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 1a1cf22 adding Python function instance

[pulsar] branch master updated: Cleanup Logging for python functions (#2847)

2018-10-26 Thread jerrypeng
This is an automated email from the ASF dual-hosted git repository. jerrypeng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new fa212bc Cleanup Logging for python

[GitHub] jerrypeng closed pull request #2850: adding Python function instance unit test

2018-10-26 Thread GitBox
jerrypeng closed pull request #2850: adding Python function instance unit test URL: https://github.com/apache/pulsar/pull/2850 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] jerrypeng closed pull request #2847: Cleanup Logging for python functions

2018-10-26 Thread GitBox
jerrypeng closed pull request #2847: Cleanup Logging for python functions URL: https://github.com/apache/pulsar/pull/2847 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] srkukarni opened a new pull request #2853: Secrets Frontend

2018-10-26 Thread GitBox
srkukarni opened a new pull request #2853: Secrets Frontend URL: https://github.com/apache/pulsar/pull/2853 ### Motivation This pr defines the FunctionConfig part of secrets implementation. It defines how users can define secrets in their function/source/sink configs and how they

[GitHub] srkukarni commented on issue #2853: Secrets Frontend

2018-10-26 Thread GitBox
srkukarni commented on issue #2853: Secrets Frontend URL: https://github.com/apache/pulsar/pull/2853#issuecomment-433473480 @cckellogg Please take a look. Thanks! This is an automated message from the Apache Git Service. To

[GitHub] srkukarni commented on issue #2826: Secrets Interface

2018-10-26 Thread GitBox
srkukarni commented on issue #2826: Secrets Interface URL: https://github.com/apache/pulsar/pull/2826#issuecomment-433470126 I will break the change into smaller changes and it might be best to comment on each individual pr

[GitHub] mujimu commented on issue #1070: Provide a nodejs client

2018-10-26 Thread GitBox
mujimu commented on issue #1070: Provide a nodejs client URL: https://github.com/apache/pulsar/issues/1070#issuecomment-433457173 more recent example of wrapping an underlying C++ lib as a node library: https://github.com/Blizzard/node-rdkafka

[GitHub] cckellogg commented on a change in pull request #2826: Secrets Interface

2018-10-26 Thread GitBox
cckellogg commented on a change in pull request #2826: Secrets Interface URL: https://github.com/apache/pulsar/pull/2826#discussion_r228576463 ## File path: pulsar-functions/instance/src/main/python/secretsprovider.py ## @@ -0,0 +1,61 @@ +#!/usr/bin/env python +# +#

[GitHub] cckellogg commented on a change in pull request #2826: Secrets Interface

2018-10-26 Thread GitBox
cckellogg commented on a change in pull request #2826: Secrets Interface URL: https://github.com/apache/pulsar/pull/2826#discussion_r228569533 ## File path: pulsar-functions/instance/src/main/python/secretsprovider.py ## @@ -0,0 +1,61 @@ +#!/usr/bin/env python +# +#

[GitHub] ivankelly commented on issue #2852: Add connection timeout client configuration option

2018-10-26 Thread GitBox
ivankelly commented on issue #2852: Add connection timeout client configuration option URL: https://github.com/apache/pulsar/pull/2852#issuecomment-433399375 @cckellogg This is an automated message from the Apache Git

[GitHub] ivankelly opened a new pull request #2852: Add connection timeout client configuration option

2018-10-26 Thread GitBox
ivankelly opened a new pull request #2852: Add connection timeout client configuration option URL: https://github.com/apache/pulsar/pull/2852 Allows the client to specify how long to wait for brokers to respond. This is

[GitHub] srkukarni commented on issue #2826: Secrets Interface

2018-10-26 Thread GitBox
srkukarni commented on issue #2826: Secrets Interface URL: https://github.com/apache/pulsar/pull/2826#issuecomment-433365590 @merlimat @cckellogg I've made the changes as requested. Please take a look again This is an

[pulsar] branch master updated: Use the right field to get the filename (#2851)

2018-10-26 Thread sanjeevrk
This is an automated email from the ASF dual-hosted git repository. sanjeevrk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 138c863 Use the right field to get the

[GitHub] srkukarni closed pull request #2848: Make IdentitySerde handle bytes as well

2018-10-26 Thread GitBox
srkukarni closed pull request #2848: Make IdentitySerde handle bytes as well URL: https://github.com/apache/pulsar/pull/2848 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] maskit commented on a change in pull request #2829: Fix Websocket Consume Messages in Partitioned Topics

2018-10-26 Thread GitBox
maskit commented on a change in pull request #2829: Fix Websocket Consume Messages in Partitioned Topics URL: https://github.com/apache/pulsar/pull/2829#discussion_r228456096 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/MessageIdImpl.java ## @@

[GitHub] maskit commented on a change in pull request #2829: Fix Websocket Consume Messages in Partitioned Topics

2018-10-26 Thread GitBox
maskit commented on a change in pull request #2829: Fix Websocket Consume Messages in Partitioned Topics URL: https://github.com/apache/pulsar/pull/2829#discussion_r228454245 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/TopicMessageIdImpl.java

[GitHub] maskit commented on issue #2814: Fix memory issue in cpp ZTSClient

2018-10-26 Thread GitBox
maskit commented on issue #2814: Fix memory issue in cpp ZTSClient URL: https://github.com/apache/pulsar/pull/2814#issuecomment-47349 run java8 tests This is an automated message from the Apache Git Service. To respond to

[GitHub] srkukarni commented on issue #2851: Use the right field to get the filename

2018-10-26 Thread GitBox
srkukarni commented on issue #2851: Use the right field to get the filename URL: https://github.com/apache/pulsar/pull/2851#issuecomment-41679 rerun java8 tests This is an automated message from the Apache Git Service. To

[GitHub] srkukarni commented on issue #2848: Make IdentitySerde handle bytes as well

2018-10-26 Thread GitBox
srkukarni commented on issue #2848: Make IdentitySerde handle bytes as well URL: https://github.com/apache/pulsar/pull/2848#issuecomment-41483 rerun java8 tests This is an automated message from the Apache Git Service. To

[pulsar] branch master updated: Fix: schema init for topic-name with special char (#2836)

2018-10-26 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 000cc22 Fix: schema init for topic-name with

[GitHub] merlimat closed pull request #2836: Fix: schema init for topic-name with special char

2018-10-26 Thread GitBox
merlimat closed pull request #2836: Fix: schema init for topic-name with special char URL: https://github.com/apache/pulsar/pull/2836 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[pulsar] branch master updated: Make proxy advertise protocol version of client to broker (#2845)

2018-10-26 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 5bdcdc5 Make proxy advertise protocol version

[GitHub] merlimat closed pull request #2849: fixing/adding sql docs to correct locations

2018-10-26 Thread GitBox
merlimat closed pull request #2849: fixing/adding sql docs to correct locations URL: https://github.com/apache/pulsar/pull/2849 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] merlimat closed pull request #2845: Make proxy advertise protocol version of client to broker

2018-10-26 Thread GitBox
merlimat closed pull request #2845: Make proxy advertise protocol version of client to broker URL: https://github.com/apache/pulsar/pull/2845 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[pulsar] branch master updated: fixing/adding sql docs to correct locations (#2849)

2018-10-26 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new b797d7b fixing/adding sql docs to correct

[pulsar] branch master updated: Add "dashboard" to list of modules so that pom version gets auto updated (#2838)

2018-10-26 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 519cbe9 Add "dashboard" to list of modules so

[GitHub] merlimat closed pull request #2838: Add "dashboard" to list of modules so that pom version gets auto updated

2018-10-26 Thread GitBox
merlimat closed pull request #2838: Add "dashboard" to list of modules so that pom version gets auto updated URL: https://github.com/apache/pulsar/pull/2838 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] jerrypeng commented on issue #2850: adding Python function instance unit test

2018-10-26 Thread GitBox
jerrypeng commented on issue #2850: adding Python function instance unit test URL: https://github.com/apache/pulsar/pull/2850#issuecomment-433296762 rerun java8 tests This is an automated message from the Apache Git Service.