[GitHub] grantwwu commented on issue #3127: Python Pulsar client appears to throw regular `Exception`s instead of `PulsarException`s

2018-12-06 Thread GitBox
grantwwu commented on issue #3127: Python Pulsar client appears to throw regular `Exception`s instead of `PulsarException`s URL: https://github.com/apache/pulsar/issues/3127#issuecomment-445142119 Ah, well, I'm not going to stop you :) I tried to look at the source, but couldn't figure o

[GitHub] sijie commented on issue #3129: [bookkeeper] bump bookkeeper version to 4.7.3

2018-12-06 Thread GitBox
sijie commented on issue #3129: [bookkeeper] bump bookkeeper version to 4.7.3 URL: https://github.com/apache/pulsar/pull/3129#issuecomment-445132658 run java8 tests This is an automated message from the Apache Git Service. To

[GitHub] legendtkl commented on issue #3127: Python Pulsar client appears to throw regular `Exception`s instead of `PulsarException`s

2018-12-06 Thread GitBox
legendtkl commented on issue #3127: Python Pulsar client appears to throw regular `Exception`s instead of `PulsarException`s URL: https://github.com/apache/pulsar/issues/3127#issuecomment-445130918 I would like to work on this issue -

[GitHub] jiazhai commented on issue #3042: Get stats on a exist topic but got topic not found error

2018-12-06 Thread GitBox
jiazhai commented on issue #3042: Get stats on a exist topic but got topic not found error URL: https://github.com/apache/pulsar/issues/3042#issuecomment-445117189 #3111 merged, would like to close this issue. This is an auto

[GitHub] jiazhai closed issue #3042: Get stats on a exist topic but got topic not found error

2018-12-06 Thread GitBox
jiazhai closed issue #3042: Get stats on a exist topic but got topic not found error URL: https://github.com/apache/pulsar/issues/3042 This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] jiazhai closed pull request #3111: Improve user prompts on get topic reference

2018-12-06 Thread GitBox
jiazhai closed pull request #3111: Improve user prompts on get topic reference URL: https://github.com/apache/pulsar/pull/3111 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[pulsar] branch master updated: Improve user prompts on get topic reference (#3111)

2018-12-06 Thread zhaijia
This is an automated email from the ASF dual-hosted git repository. zhaijia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 64b1b80 Improve user prompts on get topic ref

[GitHub] srkukarni closed issue #3132: Pulsar Functions (Python SDK) : Implement getCurrentRecord in contenxtimpl

2018-12-06 Thread GitBox
srkukarni closed issue #3132: Pulsar Functions (Python SDK) : Implement getCurrentRecord in contenxtimpl URL: https://github.com/apache/pulsar/issues/3132 This is an automated message from the Apache Git Service. To respond

[pulsar] branch master updated: Enhanced Pulsar Message API as well as functions context to get more details about messages (#3136)

2018-12-06 Thread sanjeevrk
This is an automated email from the ASF dual-hosted git repository. sanjeevrk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 736d82d Enhanced Pulsar Message API as well

[GitHub] srkukarni closed pull request #3136: Enhanced Pulsar Message API as well as functions context to get more message details

2018-12-06 Thread GitBox
srkukarni closed pull request #3136: Enhanced Pulsar Message API as well as functions context to get more message details URL: https://github.com/apache/pulsar/pull/3136 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] srkukarni commented on issue #3138: Fix Spellings

2018-12-06 Thread GitBox
srkukarni commented on issue #3138: Fix Spellings URL: https://github.com/apache/pulsar/pull/3138#issuecomment-445102756 run java8 tests This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] merlimat commented on a change in pull request #3139: more optimizations for sql

2018-12-06 Thread GitBox
merlimat commented on a change in pull request #3139: more optimizations for sql URL: https://github.com/apache/pulsar/pull/3139#discussion_r239676569 ## File path: pulsar-sql/presto-pulsar/pom.xml ## @@ -39,6 +39,7 @@ 1.1.0.Final 1 24.1-jre +

[GitHub] merlimat commented on a change in pull request #3126: [Message Routing] Set CustomPartition implicitly when messageRouter is set

2018-12-06 Thread GitBox
merlimat commented on a change in pull request #3126: [Message Routing] Set CustomPartition implicitly when messageRouter is set URL: https://github.com/apache/pulsar/pull/3126#discussion_r239668621 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerBui

[pulsar] branch master updated: Use BK v2 protocol from Presto connector (#3135)

2018-12-06 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 44f8386 Use BK v2 protocol from Presto connecto

[GitHub] merlimat closed pull request #3135: Use BK v2 protocol from Presto connector

2018-12-06 Thread GitBox
merlimat closed pull request #3135: Use BK v2 protocol from Presto connector URL: https://github.com/apache/pulsar/pull/3135 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pul

[GitHub] jerrypeng opened a new pull request #3139: more optimizations for sql

2018-12-06 Thread GitBox
jerrypeng opened a new pull request #3139: more optimizations for sql URL: https://github.com/apache/pulsar/pull/3139 ### Motivation Change from ArrayBlockingQueue to use SpscArrayQueue from JCTools Change some variables from atomics to just regular ---

[GitHub] aahmed-se opened a new pull request #3138: Fix Spellings

2018-12-06 Thread GitBox
aahmed-se opened a new pull request #3138: Fix Spellings URL: https://github.com/apache/pulsar/pull/3138 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the UR

[GitHub] sijie commented on issue #3129: [bookkeeper] bump bookkeeper version to 4.7.3

2018-12-06 Thread GitBox
sijie commented on issue #3129: [bookkeeper] bump bookkeeper version to 4.7.3 URL: https://github.com/apache/pulsar/pull/3129#issuecomment-445070405 retest this please This is an automated message from the Apache Git Service.

[GitHub] merlimat commented on issue #3135: Use BK v2 protocol from Presto connector

2018-12-06 Thread GitBox
merlimat commented on issue #3135: Use BK v2 protocol from Presto connector URL: https://github.com/apache/pulsar/pull/3135#issuecomment-445062137 run java8 tests This is an automated message from the Apache Git Service. To re

[GitHub] srkukarni opened a new pull request #3137: Make Source/Sink status Source/Sink specific

2018-12-06 Thread GitBox
srkukarni opened a new pull request #3137: Make Source/Sink status Source/Sink specific URL: https://github.com/apache/pulsar/pull/3137 ### Motivation Continuing the process of making sources/sinks distinct from functions, this pr modifies the SourceStatus/SinkStatus to be Source/Si

[GitHub] sijie commented on issue #3126: [Message Routing] Set CustomPartition implicitly when messageRouter is set

2018-12-06 Thread GitBox
sijie commented on issue #3126: [Message Routing] Set CustomPartition implicitly when messageRouter is set URL: https://github.com/apache/pulsar/pull/3126#issuecomment-445046604 > My concern was the following case while messageRoutingMode is not set by user and it comes as RoundRobinPartit

[pulsar] branch master updated: Force to load LZ4 JNI wrapper (#3134)

2018-12-06 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 2c0cf59 Force to load LZ4 JNI wrapper (#3134) 2c

[GitHub] sijie closed pull request #3134: Force to load LZ4 JNI wrapper

2018-12-06 Thread GitBox
sijie closed pull request #3134: Force to load LZ4 JNI wrapper URL: https://github.com/apache/pulsar/pull/3134 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (fro

[GitHub] erenavsarogullari commented on a change in pull request #3126: [Message Routing] Set CustomPartition implicitly when messageRouter is set

2018-12-06 Thread GitBox
erenavsarogullari commented on a change in pull request #3126: [Message Routing] Set CustomPartition implicitly when messageRouter is set URL: https://github.com/apache/pulsar/pull/3126#discussion_r239618235 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/Pr

[GitHub] erenavsarogullari commented on a change in pull request #3126: [Message Routing] Set CustomPartition implicitly when messageRouter is set

2018-12-06 Thread GitBox
erenavsarogullari commented on a change in pull request #3126: [Message Routing] Set CustomPartition implicitly when messageRouter is set URL: https://github.com/apache/pulsar/pull/3126#discussion_r239618235 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/Pr

[GitHub] erenavsarogullari commented on a change in pull request #3126: [Message Routing] Set CustomPartition implicitly when messageRouter is set

2018-12-06 Thread GitBox
erenavsarogullari commented on a change in pull request #3126: [Message Routing] Set CustomPartition implicitly when messageRouter is set URL: https://github.com/apache/pulsar/pull/3126#discussion_r239618235 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/Pr

[GitHub] erenavsarogullari commented on a change in pull request #3126: [Message Routing] Set CustomPartition implicitly when messageRouter is set

2018-12-06 Thread GitBox
erenavsarogullari commented on a change in pull request #3126: [Message Routing] Set CustomPartition implicitly when messageRouter is set URL: https://github.com/apache/pulsar/pull/3126#discussion_r239618983 ## File path: site2/docs/cookbooks-partitioned.md ## @@ -65,7 +65

[GitHub] erenavsarogullari commented on a change in pull request #3126: [Message Routing] Set CustomPartition implicitly when messageRouter is set

2018-12-06 Thread GitBox
erenavsarogullari commented on a change in pull request #3126: [Message Routing] Set CustomPartition implicitly when messageRouter is set URL: https://github.com/apache/pulsar/pull/3126#discussion_r239618752 ## File path: site/docs/latest/cookbooks/PartitionedTopics.md ##

[GitHub] erenavsarogullari commented on a change in pull request #3126: [Message Routing] Set CustomPartition implicitly when messageRouter is set

2018-12-06 Thread GitBox
erenavsarogullari commented on a change in pull request #3126: [Message Routing] Set CustomPartition implicitly when messageRouter is set URL: https://github.com/apache/pulsar/pull/3126#discussion_r239618235 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/Pr

[GitHub] srkukarni closed pull request #3133: Cleanup Exception thrown during error

2018-12-06 Thread GitBox
srkukarni closed pull request #3133: Cleanup Exception thrown during error URL: https://github.com/apache/pulsar/pull/3133 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[pulsar] branch master updated: Cleanup Exception thrown during error (#3133)

2018-12-06 Thread sanjeevrk
This is an automated email from the ASF dual-hosted git repository. sanjeevrk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new d76dfe2 Cleanup Exception thrown during erro

[GitHub] merlimat commented on a change in pull request #3126: [Message Routing] Set CustomPartition implicitly when messageRouter is set

2018-12-06 Thread GitBox
merlimat commented on a change in pull request #3126: [Message Routing] Set CustomPartition implicitly when messageRouter is set URL: https://github.com/apache/pulsar/pull/3126#discussion_r239600044 ## File path: site/docs/latest/cookbooks/PartitionedTopics.md ## @@ -91,7

[GitHub] merlimat commented on a change in pull request #3126: [Message Routing] Set CustomPartition implicitly when messageRouter is set

2018-12-06 Thread GitBox
merlimat commented on a change in pull request #3126: [Message Routing] Set CustomPartition implicitly when messageRouter is set URL: https://github.com/apache/pulsar/pull/3126#discussion_r239600291 ## File path: site2/docs/cookbooks-partitioned.md ## @@ -65,7 +65,7 @@ Str

[GitHub] merlimat commented on a change in pull request #3126: [Message Routing] Set CustomPartition implicitly when messageRouter is set

2018-12-06 Thread GitBox
merlimat commented on a change in pull request #3126: [Message Routing] Set CustomPartition implicitly when messageRouter is set URL: https://github.com/apache/pulsar/pull/3126#discussion_r239599561 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerBui

[GitHub] merlimat commented on issue #3134: Force to load LZ4 JNI wrapper

2018-12-06 Thread GitBox
merlimat commented on issue #3134: Force to load LZ4 JNI wrapper URL: https://github.com/apache/pulsar/pull/3134#issuecomment-445013239 run java8 tests This is an automated message from the Apache Git Service. To respond to th

[GitHub] srkukarni commented on issue #3136: Enhanced Pulsar Message API as well as functions context to get more message details

2018-12-06 Thread GitBox
srkukarni commented on issue #3136: Enhanced Pulsar Message API as well as functions context to get more message details URL: https://github.com/apache/pulsar/pull/3136#issuecomment-444996124 #3132 This is an automated messag

[GitHub] srkukarni opened a new pull request #3136: Enhanced Pulsar Message API as well as functions context to get more message details

2018-12-06 Thread GitBox
srkukarni opened a new pull request #3136: Enhanced Pulsar Message API as well as functions context to get more message details URL: https://github.com/apache/pulsar/pull/3136 ### Motivation This pr adds the following enhancements for python api 1. Ability to specify event tim

[GitHub] merlimat opened a new pull request #3135: Use BK v2 protocol from Presto connector

2018-12-06 Thread GitBox
merlimat opened a new pull request #3135: Use BK v2 protocol from Presto connector URL: https://github.com/apache/pulsar/pull/3135 ### Motivation We should read with BK v2 protocol to ensure all buffers are pooled and coming from direct memory. -

[GitHub] merlimat opened a new pull request #3134: Force to load LZ4 JNI wrapper

2018-12-06 Thread GitBox
merlimat opened a new pull request #3134: Force to load LZ4 JNI wrapper URL: https://github.com/apache/pulsar/pull/3134 ### Motivation In newer `lz4-java` JNI wrapper, the JNI library is not automatically loaded (or attempted to be loaded): calling explicitly so that we use the more

[pulsar] branch master updated: Fix calendar link (#3120)

2018-12-06 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new e8fac57 Fix calendar link (#3120) e8fac57 is de

[GitHub] merlimat closed pull request #3120: Fix calendar link

2018-12-06 Thread GitBox
merlimat closed pull request #3120: Fix calendar link URL: https://github.com/apache/pulsar/pull/3120 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork)

[GitHub] srkukarni opened a new pull request #3133: Cleanup Exception thrown during error

2018-12-06 Thread GitBox
srkukarni opened a new pull request #3133: Cleanup Exception thrown during error URL: https://github.com/apache/pulsar/pull/3133 ### Motivation Explain here the context, and why you're making that change. What is the problem you're trying to solve. ### Modifications D

[GitHub] merlimat commented on issue #3129: [bookkeeper] bump bookkeeper version to 4.7.3

2018-12-06 Thread GitBox
merlimat commented on issue #3129: [bookkeeper] bump bookkeeper version to 4.7.3 URL: https://github.com/apache/pulsar/pull/3129#issuecomment-444964301 retest this please This is an automated message from the Apache Gi

[GitHub] shalinseban opened a new issue #3132: Pulsar Functions (Python SDK) : Implement getCurrentRecord in contenxtimpl

2018-12-06 Thread GitBox
shalinseban opened a new issue #3132: Pulsar Functions (Python SDK) : Implement getCurrentRecord in contenxtimpl URL: https://github.com/apache/pulsar/issues/3132 Implement `getCurrentRecord` functionality for `contextimpl` in pulsar functions python sdk. This will be useful for accessing

[GitHub] srkukarni closed pull request #3130: Ensure that the input topic exists before doing trigger

2018-12-06 Thread GitBox
srkukarni closed pull request #3130: Ensure that the input topic exists before doing trigger URL: https://github.com/apache/pulsar/pull/3130 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[pulsar] branch master updated: Ensure that the input topic exists before doing trigger (#3130)

2018-12-06 Thread sanjeevrk
This is an automated email from the ASF dual-hosted git repository. sanjeevrk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 499ffd7 Ensure that the input topic exists b

[GitHub] sijie closed pull request #3095: [Pulsar-Netty] Add Netty Connector Support for Tcp Messages

2018-12-06 Thread GitBox
sijie closed pull request #3095: [Pulsar-Netty] Add Netty Connector Support for Tcp Messages URL: https://github.com/apache/pulsar/pull/3095 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] sijie commented on issue #3095: [Pulsar-Netty] Add Netty Connector Support for Tcp Messages

2018-12-06 Thread GitBox
sijie commented on issue #3095: [Pulsar-Netty] Add Netty Connector Support for Tcp Messages URL: https://github.com/apache/pulsar/pull/3095#issuecomment-444870952 closed this PR as discussed. a separated PR will introduce this feature to pulsar-io -

[GitHub] sijie commented on issue #2477: Reader Interceptor

2018-12-06 Thread GitBox
sijie commented on issue #2477: Reader Interceptor URL: https://github.com/apache/pulsar/issues/2477#issuecomment-444870534 Closed this since interceptors are merged. This is an automated message from the Apache Git Service.

[GitHub] sijie closed issue #2476: PIP-23: Pulsar Interceptors

2018-12-06 Thread GitBox
sijie closed issue #2476: PIP-23: Pulsar Interceptors URL: https://github.com/apache/pulsar/issues/2476 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL

[GitHub] sijie commented on issue #2478: Pulsar Client Interceptor

2018-12-06 Thread GitBox
sijie commented on issue #2478: Pulsar Client Interceptor URL: https://github.com/apache/pulsar/issues/2478#issuecomment-444870563 Closed this since interceptors are merged. This is an automated message from the Apache Git Se

[GitHub] sijie commented on issue #2476: PIP-23: Pulsar Interceptors

2018-12-06 Thread GitBox
sijie commented on issue #2476: PIP-23: Pulsar Interceptors URL: https://github.com/apache/pulsar/issues/2476#issuecomment-444870595 Closed this since interceptors are merged. This is an automated message from the Apache Git

[GitHub] sijie closed issue #2478: Pulsar Client Interceptor

2018-12-06 Thread GitBox
sijie closed issue #2478: Pulsar Client Interceptor URL: https://github.com/apache/pulsar/issues/2478 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL a

[GitHub] sijie closed issue #2477: Reader Interceptor

2018-12-06 Thread GitBox
sijie closed issue #2477: Reader Interceptor URL: https://github.com/apache/pulsar/issues/2477 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to

[GitHub] sijie commented on issue #2442: JDBC Connectors

2018-12-06 Thread GitBox
sijie commented on issue #2442: JDBC Connectors URL: https://github.com/apache/pulsar/issues/2442#issuecomment-444870185 yes. both sink and source (via debezium) are available. This is an automated message from the Apache Git

[GitHub] sijie closed issue #2442: JDBC Connectors

2018-12-06 Thread GitBox
sijie closed issue #2442: JDBC Connectors URL: https://github.com/apache/pulsar/issues/2442 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go

[GitHub] sijie commented on issue #2441: Pulsar Flink Connectors

2018-12-06 Thread GitBox
sijie commented on issue #2441: Pulsar Flink Connectors URL: https://github.com/apache/pulsar/issues/2441#issuecomment-444869857 There are bunch of flink connectors available in the main repo. This is an automated message from

[GitHub] sijie closed issue #2441: Pulsar Flink Connectors

2018-12-06 Thread GitBox
sijie closed issue #2441: Pulsar Flink Connectors URL: https://github.com/apache/pulsar/issues/2441 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL abo

[GitHub] sijie commented on issue #3120: Fix calendar link

2018-12-06 Thread GitBox
sijie commented on issue #3120: Fix calendar link URL: https://github.com/apache/pulsar/pull/3120#issuecomment-444861892 retest this please This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] sijie commented on a change in pull request #3126: [Message Routing] Set CustomPartition implicitly when messageRouter is set

2018-12-06 Thread GitBox
sijie commented on a change in pull request #3126: [Message Routing] Set CustomPartition implicitly when messageRouter is set URL: https://github.com/apache/pulsar/pull/3126#discussion_r239441706 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerBuilde

[GitHub] jiazhai commented on issue #3113: [conf] Add annotations for documenting broker configuration settings

2018-12-06 Thread GitBox
jiazhai commented on issue #3113: [conf] Add annotations for documenting broker configuration settings URL: https://github.com/apache/pulsar/pull/3113#issuecomment-444792159 run java8 tests run integration tests This is a