[GitHub] [pulsar] jiazhai opened a new issue #3777: Documentation: link in standalone page failed

2019-03-06 Thread GitBox
jiazhai opened a new issue #3777: Documentation: link in standalone page failed URL: https://github.com/apache/pulsar/issues/3777 http://pulsar.apache.org/docs/en/standalone/

[GitHub] [pulsar] srkukarni merged pull request #3722: Retry creation of assignment topic a few times before giving up

2019-03-06 Thread GitBox
srkukarni merged pull request #3722: Retry creation of assignment topic a few times before giving up URL: https://github.com/apache/pulsar/pull/3722 This is an automated message from the Apache Git Service. To respond to

[GitHub] [pulsar] srkukarni commented on issue #3717: Expose Secrets in Source/SinkContext

2019-03-06 Thread GitBox
srkukarni commented on issue #3717: Expose Secrets in Source/SinkContext URL: https://github.com/apache/pulsar/pull/3717#issuecomment-470417529 run integration tests This is an automated message from the Apache Git Service.

[GitHub] [pulsar] merlimat commented on issue #3671: pulsar-admin topics list public/default fails

2019-03-06 Thread GitBox
merlimat commented on issue #3671: pulsar-admin topics list public/default fails URL: https://github.com/apache/pulsar/issues/3671#issuecomment-470415406 Fix is in #3776 This is an automated message from the Apache Git

[GitHub] [pulsar] merlimat commented on issue #3760: Fix intermittent test: BrokerServiceLookupTest.testModularLoadManager…

2019-03-06 Thread GitBox
merlimat commented on issue #3760: Fix intermittent test: BrokerServiceLookupTest.testModularLoadManager… URL: https://github.com/apache/pulsar/pull/3760#issuecomment-470412358 run java8 tests This is an automated

[GitHub] [pulsar] skyrocknroll commented on issue #3766: Support passing schema definition for JSON and AVRO schemas

2019-03-06 Thread GitBox
skyrocknroll commented on issue #3766: Support passing schema definition for JSON and AVRO schemas URL: https://github.com/apache/pulsar/pull/3766#issuecomment-470411918 run java8 tests This is an automated message from the

[GitHub] [pulsar] skyrocknroll opened a new issue #3671: pulsar-admin topics list public/default fails

2019-03-06 Thread GitBox
skyrocknroll opened a new issue #3671: pulsar-admin topics list public/default fails URL: https://github.com/apache/pulsar/issues/3671 **Describe the bug** pulsar-admin topics list public/default Os Ubuntu 16 04 Pulsar 2.3.0 Failed with following error in log ```

[GitHub] [pulsar] skyrocknroll commented on issue #3671: pulsar-admin topics list public/default fails

2019-03-06 Thread GitBox
skyrocknroll commented on issue #3671: pulsar-admin topics list public/default fails URL: https://github.com/apache/pulsar/issues/3671#issuecomment-470411519 It was a dev cluster. For some reason, we redeployed the whole cluster and the issue went away

[GitHub] [pulsar] jiazhai commented on issue #3677: PIP-30: interface and mutual change authentication

2019-03-06 Thread GitBox
jiazhai commented on issue #3677: PIP-30: interface and mutual change authentication URL: https://github.com/apache/pulsar/pull/3677#issuecomment-470408233 rerun java8 tests This is an automated message from the Apache Git

[GitHub] [pulsar] srkukarni commented on issue #3717: Expose Secrets in Source/SinkContext

2019-03-06 Thread GitBox
srkukarni commented on issue #3717: Expose Secrets in Source/SinkContext URL: https://github.com/apache/pulsar/pull/3717#issuecomment-470404482 run integration tests run java8 tests This is an automated message from the

[GitHub] [pulsar] srkukarni commented on issue #3770: Allow users to update everything in inputspecs except for isregexpattern

2019-03-06 Thread GitBox
srkukarni commented on issue #3770: Allow users to update everything in inputspecs except for isregexpattern URL: https://github.com/apache/pulsar/pull/3770#issuecomment-470404385 run integration tests run java8 tests

[GitHub] [pulsar] MarvinCai commented on issue #3753: Add support for Kafka's ProducerConfig.CONNECTIONS_MAX_IDLE_MS_CONFIG (#1090)

2019-03-06 Thread GitBox
MarvinCai commented on issue #3753: Add support for Kafka's ProducerConfig.CONNECTIONS_MAX_IDLE_MS_CONFIG (#1090) URL: https://github.com/apache/pulsar/pull/3753#issuecomment-470402482 rerun java8 tests This is an automated

[GitHub] [pulsar] jerrypeng commented on issue #3722: Retry creation of assignment topic a few times before giving up

2019-03-06 Thread GitBox
jerrypeng commented on issue #3722: Retry creation of assignment topic a few times before giving up URL: https://github.com/apache/pulsar/pull/3722#issuecomment-470391276 rerun cpp tests rerun integration tests rerun java8 tests

[GitHub] [pulsar] jerrypeng commented on issue #3737: [python client] set protobuf version to be larger than 3.6.0

2019-03-06 Thread GitBox
jerrypeng commented on issue #3737: [python client] set protobuf version to be larger than 3.6.0 URL: https://github.com/apache/pulsar/pull/3737#issuecomment-470391068 run java8 tests This is an automated message

[GitHub] [pulsar] jerrypeng commented on issue #3740: fix document description bugs

2019-03-06 Thread GitBox
jerrypeng commented on issue #3740: fix document description bugs URL: https://github.com/apache/pulsar/pull/3740#issuecomment-470391019 run java8 tests This is an automated message from the Apache Git Service. To

[GitHub] [pulsar] jerrypeng commented on issue #3739: [Issue #3728] Add several instructions for IO Connectors

2019-03-06 Thread GitBox
jerrypeng commented on issue #3739: [Issue #3728] Add several instructions for IO Connectors URL: https://github.com/apache/pulsar/pull/3739#issuecomment-470390925 run java8 tests This is an automated message from

[GitHub] [pulsar] jerrypeng commented on issue #3735: Implementing authentication for Pulsar Functions

2019-03-06 Thread GitBox
jerrypeng commented on issue #3735: Implementing authentication for Pulsar Functions URL: https://github.com/apache/pulsar/pull/3735#issuecomment-470390768 @merlimat @sijie @srkukarni @jiazhai please review. Thanks! This is

[GitHub] [pulsar] jerrypeng commented on issue #3747: Closing FunctionAssignmentTailer should handle ConsumerAlreadyClosedException

2019-03-06 Thread GitBox
jerrypeng commented on issue #3747: Closing FunctionAssignmentTailer should handle ConsumerAlreadyClosedException URL: https://github.com/apache/pulsar/pull/3747#issuecomment-470390548 run java8 tests This is an automated

[GitHub] [pulsar] jerrypeng commented on issue #3776: Use at least 8 threads in Jetty thread pool

2019-03-06 Thread GitBox
jerrypeng commented on issue #3776: Use at least 8 threads in Jetty thread pool URL: https://github.com/apache/pulsar/pull/3776#issuecomment-470390150 rerun java8 tests This is an automated message from the Apache Git

[GitHub] [pulsar] MarvinCai commented on issue #3753: Add support for Kafka's ProducerConfig.CONNECTIONS_MAX_IDLE_MS_CONFIG (#1090)

2019-03-06 Thread GitBox
MarvinCai commented on issue #3753: Add support for Kafka's ProducerConfig.CONNECTIONS_MAX_IDLE_MS_CONFIG (#1090) URL: https://github.com/apache/pulsar/pull/3753#issuecomment-470387565 rerun java8 tests rerun integration tests rerun cpp tests

[GitHub] [pulsar] lxkaka commented on issue #3671: pulsar-admin topics list public/default fails

2019-03-06 Thread GitBox
lxkaka commented on issue #3671: pulsar-admin topics list public/default fails URL: https://github.com/apache/pulsar/issues/3671#issuecomment-470385603 I have the same problem. `pulsar-admin topics list public/default` or `pulsar-admin persistent list public/default` show error

[GitHub] [pulsar] merlimat opened a new pull request #3776: Use at least 8 threads in Jetty thread pool

2019-03-06 Thread GitBox
merlimat opened a new pull request #3776: Use at least 8 threads in Jetty thread pool URL: https://github.com/apache/pulsar/pull/3776 ### Motivation Use at least 8 threads to avoid having Jetty go into threads starving and having the possibility of getting into a deadlock where a

[GitHub] [pulsar] merlimat commented on issue #3760: Fix intermittent test: BrokerServiceLookupTest.testModularLoadManager…

2019-03-06 Thread GitBox
merlimat commented on issue #3760: Fix intermittent test: BrokerServiceLookupTest.testModularLoadManager… URL: https://github.com/apache/pulsar/pull/3760#issuecomment-470378274 run java8 tests This is an automated message

[GitHub] [pulsar] merlimat merged pull request #3761: Updated consumer example to use negative acks

2019-03-06 Thread GitBox
merlimat merged pull request #3761: Updated consumer example to use negative acks URL: https://github.com/apache/pulsar/pull/3761 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [pulsar] merlimat commented on issue #3703: Added support for "negative acks" in Java client

2019-03-06 Thread GitBox
merlimat commented on issue #3703: Added support for "negative acks" in Java client URL: https://github.com/apache/pulsar/pull/3703#issuecomment-470375735 run java8 tests This is an automated message from the Apache Git

[pulsar] branch master updated: Updated consumer example to use negative acks (#3761)

2019-03-06 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 17b531b Updated consumer example to use

[GitHub] [pulsar] david-streamlio opened a new pull request #3775: Pulsar-IO: Added Kinesis Source

2019-03-06 Thread GitBox
david-streamlio opened a new pull request #3775: Pulsar-IO: Added Kinesis Source URL: https://github.com/apache/pulsar/pull/3775 ### Motivation Added an AWS Kinesis Source connector to the existing Kinesis module. ### Modifications - Added an AWS Kinesis Source

[GitHub] [pulsar] MarvinCai commented on a change in pull request #3753: Add support for Kafka's ProducerConfig.CONNECTIONS_MAX_IDLE_MS_CONFIG (#1090)

2019-03-06 Thread GitBox
MarvinCai commented on a change in pull request #3753: Add support for Kafka's ProducerConfig.CONNECTIONS_MAX_IDLE_MS_CONFIG (#1090) URL: https://github.com/apache/pulsar/pull/3753#discussion_r263226100 ## File path:

[GitHub] [pulsar] MarvinCai commented on issue #3753: Add support for Kafka's ProducerConfig.CONNECTIONS_MAX_IDLE_MS_CONFIG (#1090)

2019-03-06 Thread GitBox
MarvinCai commented on issue #3753: Add support for Kafka's ProducerConfig.CONNECTIONS_MAX_IDLE_MS_CONFIG (#1090) URL: https://github.com/apache/pulsar/pull/3753#issuecomment-470370713 rerun java8 tests rerun integration tests rerun cpp tests

[GitHub] [pulsar] wolfstudy commented on issue #3764: Fixed Reader.HasNext() in Go client

2019-03-06 Thread GitBox
wolfstudy commented on issue #3764: Fixed Reader.HasNext() in Go client URL: https://github.com/apache/pulsar/pull/3764#issuecomment-470360644 LGTM This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] merlimat commented on issue #3535: Deduplication causes a lot of Full GCs

2019-03-06 Thread GitBox
merlimat commented on issue #3535: Deduplication causes a lot of Full GCs URL: https://github.com/apache/pulsar/issues/3535#issuecomment-470360296 Updated #3612 with correct fix This is an automated message from the Apache

[GitHub] [pulsar] sijie commented on issue #3761: Updated consumer example to use negative acks

2019-03-06 Thread GitBox
sijie commented on issue #3761: Updated consumer example to use negative acks URL: https://github.com/apache/pulsar/pull/3761#issuecomment-470359470 run integration tests This is an automated message from the Apache Git

[GitHub] [pulsar] wolfstudy commented on a change in pull request #3759: Fixes for Go client unit test

2019-03-06 Thread GitBox
wolfstudy commented on a change in pull request #3759: Fixes for Go client unit test URL: https://github.com/apache/pulsar/pull/3759#discussion_r263216289 ## File path: pulsar-client-go/pulsar/consumer_test.go ## @@ -98,7 +100,10 @@ func TestConsumer(t *testing.T) {

[GitHub] [pulsar] wolfstudy commented on a change in pull request #3759: Fixes for Go client unit test

2019-03-06 Thread GitBox
wolfstudy commented on a change in pull request #3759: Fixes for Go client unit test URL: https://github.com/apache/pulsar/pull/3759#discussion_r263216289 ## File path: pulsar-client-go/pulsar/consumer_test.go ## @@ -98,7 +100,10 @@ func TestConsumer(t *testing.T) {

[GitHub] [pulsar] rdhabalia removed a comment on issue #3760: Fix intermittent test: BrokerServiceLookupTest.testModularLoadManager…

2019-03-06 Thread GitBox
rdhabalia removed a comment on issue #3760: Fix intermittent test: BrokerServiceLookupTest.testModularLoadManager… URL: https://github.com/apache/pulsar/pull/3760#issuecomment-470356454 rerun java8 tests rerun java8 tests

[GitHub] [pulsar] rdhabalia commented on issue #3760: Fix intermittent test: BrokerServiceLookupTest.testModularLoadManager…

2019-03-06 Thread GitBox
rdhabalia commented on issue #3760: Fix intermittent test: BrokerServiceLookupTest.testModularLoadManager… URL: https://github.com/apache/pulsar/pull/3760#issuecomment-470356454 rerun java8 tests rerun java8 tests This is

[GitHub] [pulsar] wolfstudy commented on issue #3759: Fixes for Go client unit test

2019-03-06 Thread GitBox
wolfstudy commented on issue #3759: Fixes for Go client unit test URL: https://github.com/apache/pulsar/pull/3759#issuecomment-470356154 LGTM This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] merlimat commented on issue #3612: Set the dedup cursor as "inactive" after recovery

2019-03-06 Thread GitBox
merlimat commented on issue #3612: Set the dedup cursor as "inactive" after recovery URL: https://github.com/apache/pulsar/pull/3612#issuecomment-470354878 @hrsakai @massakam Did more experimentation and fixed it by making sure the dedup cursor is never considered "active" in order to

[GitHub] [pulsar] rdhabalia removed a comment on issue #3760: Fix intermittent test: BrokerServiceLookupTest.testModularLoadManager…

2019-03-06 Thread GitBox
rdhabalia removed a comment on issue #3760: Fix intermittent test: BrokerServiceLookupTest.testModularLoadManager… URL: https://github.com/apache/pulsar/pull/3760#issuecomment-470334799 rerun java8 tests This is an automated

[GitHub] [pulsar] wolfstudy opened a new issue #3774: [go client] add go related tests and checks in jenkins

2019-03-06 Thread GitBox
wolfstudy opened a new issue #3774: [go client] add go related tests and checks in jenkins URL: https://github.com/apache/pulsar/issues/3774 **Is your feature request related to a problem? Please describe.** At present, Jenkins does not check the unit tests and code specifications

[GitHub] [pulsar] jiazhai commented on issue #3677: PIP-30: interface and mutual change authentication

2019-03-06 Thread GitBox
jiazhai commented on issue #3677: PIP-30: interface and mutual change authentication URL: https://github.com/apache/pulsar/pull/3677#issuecomment-470347984 rerun java8 tests This is an automated message from the Apache Git

[GitHub] [pulsar] aahmed-se commented on issue #3772: Force before and after methods to always run

2019-03-06 Thread GitBox
aahmed-se commented on issue #3772: Force before and after methods to always run URL: https://github.com/apache/pulsar/pull/3772#issuecomment-470345592 @rdhabalia it's one part of the problem , if one test fails teardown doesn't run so it won't solve the issue but it will the right logs.

[GitHub] [pulsar] lovelle commented on issue #3748: [cpp client] Bugfix prevent dup consumer for same topic subscription

2019-03-06 Thread GitBox
lovelle commented on issue #3748: [cpp client] Bugfix prevent dup consumer for same topic subscription URL: https://github.com/apache/pulsar/pull/3748#issuecomment-470340551 run java8 tests This is an automated message from

[GitHub] [pulsar] lovelle commented on issue #3746: [java client] Bugfix prevent dup consumers for same topic subscription

2019-03-06 Thread GitBox
lovelle commented on issue #3746: [java client] Bugfix prevent dup consumers for same topic subscription URL: https://github.com/apache/pulsar/pull/3746#issuecomment-470340371 run java8 tests This is an automated message

[GitHub] [pulsar] rdhabalia commented on issue #3760: Fix intermittent test: BrokerServiceLookupTest.testModularLoadManager…

2019-03-06 Thread GitBox
rdhabalia commented on issue #3760: Fix intermittent test: BrokerServiceLookupTest.testModularLoadManager… URL: https://github.com/apache/pulsar/pull/3760#issuecomment-470334799 rerun java8 tests This is an automated message

[GitHub] [pulsar] rdhabalia commented on issue #3772: Force before and after methods to always run

2019-03-06 Thread GitBox
rdhabalia commented on issue #3772: Force before and after methods to always run URL: https://github.com/apache/pulsar/pull/3772#issuecomment-470333240 how does it help if function-worker actually has the deadlock issue? This

[GitHub] [pulsar] aahmed-se commented on issue #3772: Force before and after methods to always run

2019-03-06 Thread GitBox
aahmed-se commented on issue #3772: Force before and after methods to always run URL: https://github.com/apache/pulsar/pull/3772#issuecomment-470329785 run java8 tests This is an automated message from the Apache Git Service.

[GitHub] [pulsar] codelipenghui commented on issue #3766: Support passing schema definition for JSON and AVRO schemas

2019-03-06 Thread GitBox
codelipenghui commented on issue #3766: Support passing schema definition for JSON and AVRO schemas URL: https://github.com/apache/pulsar/pull/3766#issuecomment-470329631 run java8 tests This is an automated message from the

[GitHub] [pulsar] rdhabalia commented on issue #3760: Fix intermittent test: BrokerServiceLookupTest.testModularLoadManager…

2019-03-06 Thread GitBox
rdhabalia commented on issue #3760: Fix intermittent test: BrokerServiceLookupTest.testModularLoadManager… URL: https://github.com/apache/pulsar/pull/3760#issuecomment-470328994 rerun integration tests This is an automated

[GitHub] [pulsar] srkukarni commented on issue #3770: Allow users to update everything in inputspecs except for isregexpattern

2019-03-06 Thread GitBox
srkukarni commented on issue #3770: Allow users to update everything in inputspecs except for isregexpattern URL: https://github.com/apache/pulsar/pull/3770#issuecomment-470326835 updating input topic has the associated overhead of cleaning up subscriptions and such.

[GitHub] [pulsar] merlimat commented on issue #3535: Deduplication causes a lot of Full GCs

2019-03-06 Thread GitBox
merlimat commented on issue #3535: Deduplication causes a lot of Full GCs URL: https://github.com/apache/pulsar/issues/3535#issuecomment-470325628 As @hrsakai pointed out, the fix was ineffective because applied on a code path that's not being used. The problem is that that while

[GitHub] [pulsar] jiazhai opened a new issue #3773: Update documentation for topic partitions auto update

2019-03-06 Thread GitBox
jiazhai opened a new issue #3773: Update documentation for topic partitions auto update URL: https://github.com/apache/pulsar/issues/3773 Update documentation for topic partitions auto update This is an automated message

[pulsar] branch master updated: On shutdown, kill the function instance thread after interrupt attempt (#3749)

2019-03-06 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 69faeaf On shutdown, kill the function

[GitHub] [pulsar] merlimat merged pull request #3749: On shutdown, kill the function instance thread after interrupt attempt

2019-03-06 Thread GitBox
merlimat merged pull request #3749: On shutdown, kill the function instance thread after interrupt attempt URL: https://github.com/apache/pulsar/pull/3749 This is an automated message from the Apache Git Service. To respond

[GitHub] [pulsar] lovelle commented on issue #3746: [java client] Bugfix prevent dup consumers for same topic subscription

2019-03-06 Thread GitBox
lovelle commented on issue #3746: [java client] Bugfix prevent dup consumers for same topic subscription URL: https://github.com/apache/pulsar/pull/3746#issuecomment-470306023 run java8 tests run integration tests This is

[GitHub] [pulsar] lovelle removed a comment on issue #3748: [cpp client] Bugfix prevent dup consumer for same topic subscription

2019-03-06 Thread GitBox
lovelle removed a comment on issue #3748: [cpp client] Bugfix prevent dup consumer for same topic subscription URL: https://github.com/apache/pulsar/pull/3748#issuecomment-469436084 run java8 tests This is an automated

[GitHub] [pulsar] lovelle removed a comment on issue #3746: [java client] Bugfix prevent dup consumers for same topic subscription

2019-03-06 Thread GitBox
lovelle removed a comment on issue #3746: [java client] Bugfix prevent dup consumers for same topic subscription URL: https://github.com/apache/pulsar/pull/3746#issuecomment-470261127 run integration tests This is an

[GitHub] [pulsar] grantwwu edited a comment on issue #3715: Pulsar functions worker fails to initialize

2019-03-06 Thread GitBox
grantwwu edited a comment on issue #3715: Pulsar functions worker fails to initialize URL: https://github.com/apache/pulsar/issues/3715#issuecomment-470291412 In broker logs. Running in a 3 node cluster. Unfortunately I'm not sure we can reproduce this anymore - it was breaking

[GitHub] [pulsar] grantwwu commented on issue #3715: Pulsar functions worker fails to initialize

2019-03-06 Thread GitBox
grantwwu commented on issue #3715: Pulsar functions worker fails to initialize URL: https://github.com/apache/pulsar/issues/3715#issuecomment-470291412 In broker logs. Running in a 3 node cluster. Unfortunately I'm not sure we can reproduce this anymore - it was breaking clusters

[GitHub] [pulsar] jerrypeng commented on issue #3770: Allow users to update everything in inputspecs except for isregexpattern

2019-03-06 Thread GitBox
jerrypeng commented on issue #3770: Allow users to update everything in inputspecs except for isregexpattern URL: https://github.com/apache/pulsar/pull/3770#issuecomment-470287776 @srkukarni but then why don't we allow users to update the actual input topic? Since serde and schema are

[GitHub] [pulsar] srkukarni commented on issue #3717: Expose Secrets in Source/SinkContext

2019-03-06 Thread GitBox
srkukarni commented on issue #3717: Expose Secrets in Source/SinkContext URL: https://github.com/apache/pulsar/pull/3717#issuecomment-470284433 run java8 tests This is an automated message from the Apache Git Service. To

[GitHub] [pulsar] jerrypeng commented on issue #3715: Pulsar functions worker fails to initialize

2019-03-06 Thread GitBox
jerrypeng commented on issue #3715: Pulsar functions worker fails to initialize URL: https://github.com/apache/pulsar/issues/3715#issuecomment-470276983 @grantwwu how often have you seen this happen? Did you find the exceptions you listed above in function logs or worker/broker logs? How

[GitHub] [pulsar] lovelle commented on issue #3746: [java client] Bugfix prevent dup consumers for same topic subscription

2019-03-06 Thread GitBox
lovelle commented on issue #3746: [java client] Bugfix prevent dup consumers for same topic subscription URL: https://github.com/apache/pulsar/pull/3746#issuecomment-470273529 @sijie @jiazhai Great! :+1: thanks you both for the feedback. So when checks are success this pr will be

[GitHub] [pulsar] aahmed-se opened a new pull request #3772: Force before and after methods to always run

2019-03-06 Thread GitBox
aahmed-se opened a new pull request #3772: Force before and after methods to always run URL: https://github.com/apache/pulsar/pull/3772 This should improve test stability This is an automated message from the Apache Git

[GitHub] [pulsar] srkukarni commented on issue #3717: Expose Secrets in Source/SinkContext

2019-03-06 Thread GitBox
srkukarni commented on issue #3717: Expose Secrets in Source/SinkContext URL: https://github.com/apache/pulsar/pull/3717#issuecomment-470271049 run integration tests This is an automated message from the Apache Git Service.

[GitHub] [pulsar] merlimat commented on issue #3760: Fix intermittent test: BrokerServiceLookupTest.testModularLoadManager…

2019-03-06 Thread GitBox
merlimat commented on issue #3760: Fix intermittent test: BrokerServiceLookupTest.testModularLoadManager… URL: https://github.com/apache/pulsar/pull/3760#issuecomment-470269568 run java8 tests run integration tests This

[GitHub] [pulsar] srkukarni commented on issue #3770: Allow users to update everything in inputspecs except for isregexpattern

2019-03-06 Thread GitBox
srkukarni commented on issue #3770: Allow users to update everything in inputspecs except for isregexpattern URL: https://github.com/apache/pulsar/pull/3770#issuecomment-470262744 @jerrypeng I don't see a reason not to? Afterall one can experiment with different libraries of serialization

[GitHub] [pulsar] srkukarni commented on a change in pull request #3770: Allow users to update everything in inputspecs except for isregexpattern

2019-03-06 Thread GitBox
srkukarni commented on a change in pull request #3770: Allow users to update everything in inputspecs except for isregexpattern URL: https://github.com/apache/pulsar/pull/3770#discussion_r263119829 ## File path:

[GitHub] [pulsar] merlimat commented on a change in pull request #3764: Fixed Reader.HasNext() in Go client

2019-03-06 Thread GitBox
merlimat commented on a change in pull request #3764: Fixed Reader.HasNext() in Go client URL: https://github.com/apache/pulsar/pull/3764#discussion_r263119822 ## File path: pulsar-client-go/pulsar/reader_test.go ## @@ -218,3 +219,49 @@ func TestReaderCompaction(t

[GitHub] [pulsar] srkukarni commented on a change in pull request #3770: Allow users to update everything in inputspecs except for isregexpattern

2019-03-06 Thread GitBox
srkukarni commented on a change in pull request #3770: Allow users to update everything in inputspecs except for isregexpattern URL: https://github.com/apache/pulsar/pull/3770#discussion_r263119861 ## File path:

[GitHub] [pulsar] lovelle commented on issue #3746: [java client] Bugfix prevent dup consumers for same topic subscription

2019-03-06 Thread GitBox
lovelle commented on issue #3746: [java client] Bugfix prevent dup consumers for same topic subscription URL: https://github.com/apache/pulsar/pull/3746#issuecomment-470261127 run integration tests This is an automated

[GitHub] [pulsar] jerrypeng commented on issue #3749: On shutdown, kill the function instance thread after interrupt attempt

2019-03-06 Thread GitBox
jerrypeng commented on issue #3749: On shutdown, kill the function instance thread after interrupt attempt URL: https://github.com/apache/pulsar/pull/3749#issuecomment-470257979 run java8 tests This is an automated

[GitHub] [pulsar] jerrypeng commented on issue #3770: Allow users to update everything in inputspecs except for isregexpattern

2019-03-06 Thread GitBox
jerrypeng commented on issue #3770: Allow users to update everything in inputspecs except for isregexpattern URL: https://github.com/apache/pulsar/pull/3770#issuecomment-470257404 @srkukarni a general question: We should definitely allow users to update receiverQueueSize config in

[GitHub] [pulsar] jerrypeng commented on a change in pull request #3770: Allow users to update everything in inputspecs except for isregexpattern

2019-03-06 Thread GitBox
jerrypeng commented on a change in pull request #3770: Allow users to update everything in inputspecs except for isregexpattern URL: https://github.com/apache/pulsar/pull/3770#discussion_r263113441 ## File path:

[GitHub] [pulsar] jerrypeng commented on a change in pull request #3770: Allow users to update everything in inputspecs except for isregexpattern

2019-03-06 Thread GitBox
jerrypeng commented on a change in pull request #3770: Allow users to update everything in inputspecs except for isregexpattern URL: https://github.com/apache/pulsar/pull/3770#discussion_r263112143 ## File path:

[GitHub] [pulsar] merlimat commented on issue #3768: [pulsar-function] intermittent test failure due to deadlock

2019-03-06 Thread GitBox
merlimat commented on issue #3768: [pulsar-function] intermittent test failure due to deadlock URL: https://github.com/apache/pulsar/issues/3768#issuecomment-470254736 I think he's referring to the `PulsarWorkerAssignmentTest` test getting stuck during shutdown. There's already #3749 to

[GitHub] [pulsar] jerrypeng opened a new pull request #3771: fix: function config cleanupSubscription update bug

2019-03-06 Thread GitBox
jerrypeng opened a new pull request #3771: fix: function config cleanupSubscription update bug URL: https://github.com/apache/pulsar/pull/3771 ### Motivation The are currently two bugs involving the config cleanupSubscription and updating a function: 1. when a user updates a

[GitHub] [pulsar] srkukarni commented on issue #3768: [pulsar-function] intermittent test failure due to deadlock

2019-03-06 Thread GitBox
srkukarni commented on issue #3768: [pulsar-function] intermittent test failure due to deadlock URL: https://github.com/apache/pulsar/issues/3768#issuecomment-470253042 @rdhabalia Could you please add more color on what the dead lock is?

[pulsar] branch retry_creation updated (bbfb1cb -> 024831f)

2019-03-06 Thread sanjeevrk
This is an automated email from the ASF dual-hosted git repository. sanjeevrk pushed a change to branch retry_creation in repository https://gitbox.apache.org/repos/asf/pulsar.git. from bbfb1cb Added header new ccfb949 When the loadmanager leader is not available, fall through

[GitHub] [pulsar] merlimat commented on a change in pull request #3750: Negative acks in C++ client

2019-03-06 Thread GitBox
merlimat commented on a change in pull request #3750: Negative acks in C++ client URL: https://github.com/apache/pulsar/pull/3750#discussion_r263103180 ## File path: pulsar-client-cpp/tests/BasicEndToEndTest.cc ## @@ -99,7 +100,7 @@ static void

[GitHub] [pulsar] jai1 commented on issue #3750: Negative acks in C++ client

2019-03-06 Thread GitBox
jai1 commented on issue #3750: Negative acks in C++ client URL: https://github.com/apache/pulsar/pull/3750#issuecomment-470243091 rerun java8 tests This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] jai1 commented on a change in pull request #3750: Negative acks in C++ client

2019-03-06 Thread GitBox
jai1 commented on a change in pull request #3750: Negative acks in C++ client URL: https://github.com/apache/pulsar/pull/3750#discussion_r263097629 ## File path: pulsar-client-cpp/tests/BasicEndToEndTest.cc ## @@ -99,7 +100,7 @@ static void sendCallBackWithDelay(Result r,

[GitHub] [pulsar] srkukarni commented on a change in pull request #3717: Expose Secrets in Source/SinkContext

2019-03-06 Thread GitBox
srkukarni commented on a change in pull request #3717: Expose Secrets in Source/SinkContext URL: https://github.com/apache/pulsar/pull/3717#discussion_r263097424 ## File path: pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/SchedulerManager.java

[GitHub] [pulsar] jai1 commented on issue #3761: Updated consumer example to use negative acks

2019-03-06 Thread GitBox
jai1 commented on issue #3761: Updated consumer example to use negative acks URL: https://github.com/apache/pulsar/pull/3761#issuecomment-470240572 rerun java8 tests This is an automated message from the Apache Git Service.

[GitHub] [pulsar] jai1 commented on a change in pull request #3633: [pulsar-broker] Fix deadlock: add zk-operation timeout for blocking call on zk-cache

2019-03-06 Thread GitBox
jai1 commented on a change in pull request #3633: [pulsar-broker] Fix deadlock: add zk-operation timeout for blocking call on zk-cache URL: https://github.com/apache/pulsar/pull/3633#discussion_r263094693 ## File path:

[GitHub] [pulsar] jai1 commented on a change in pull request #3633: [pulsar-broker] Fix deadlock: add zk-operation timeout for blocking call on zk-cache

2019-03-06 Thread GitBox
jai1 commented on a change in pull request #3633: [pulsar-broker] Fix deadlock: add zk-operation timeout for blocking call on zk-cache URL: https://github.com/apache/pulsar/pull/3633#discussion_r263094012 ## File path: conf/broker.conf ## @@ -61,6 +61,9 @@

[GitHub] [pulsar] jai1 commented on issue #3633: [pulsar-broker] Fix deadlock: add zk-operation timeout for blocking call on zk-cache

2019-03-06 Thread GitBox
jai1 commented on issue #3633: [pulsar-broker] Fix deadlock: add zk-operation timeout for blocking call on zk-cache URL: https://github.com/apache/pulsar/pull/3633#issuecomment-470238478 rerun java8 tests This is an

[GitHub] [pulsar] rdhabalia commented on issue #3760: Fix intermittent test: BrokerServiceLookupTest.testModularLoadManager…

2019-03-06 Thread GitBox
rdhabalia commented on issue #3760: Fix intermittent test: BrokerServiceLookupTest.testModularLoadManager… URL: https://github.com/apache/pulsar/pull/3760#issuecomment-470238447 created issue #3768 This is an automated

[GitHub] [pulsar] rdhabalia opened a new issue #3768: [pulsar-function] intermittent test failure due to deadlock

2019-03-06 Thread GitBox
rdhabalia opened a new issue #3768: [pulsar-function] intermittent test failure due to deadlock URL: https://github.com/apache/pulsar/issues/3768

[GitHub] [pulsar] jai1 commented on a change in pull request #3764: Fixed Reader.HasNext() in Go client

2019-03-06 Thread GitBox
jai1 commented on a change in pull request #3764: Fixed Reader.HasNext() in Go client URL: https://github.com/apache/pulsar/pull/3764#discussion_r263092680 ## File path: pulsar-client-go/pulsar/reader_test.go ## @@ -218,3 +219,49 @@ func TestReaderCompaction(t *testing.T)

[GitHub] [pulsar] rdhabalia commented on issue #3760: Fix intermittent test: BrokerServiceLookupTest.testModularLoadManager…

2019-03-06 Thread GitBox
rdhabalia commented on issue #3760: Fix intermittent test: BrokerServiceLookupTest.testModularLoadManager… URL: https://github.com/apache/pulsar/pull/3760#issuecomment-470237356 I am going to disable

[GitHub] [pulsar] merlimat commented on a change in pull request #3764: Fixed Reader.HasNext() in Go client

2019-03-06 Thread GitBox
merlimat commented on a change in pull request #3764: Fixed Reader.HasNext() in Go client URL: https://github.com/apache/pulsar/pull/3764#discussion_r263083466 ## File path: pulsar-client-cpp/lib/ConsumerImpl.cc ## @@ -1039,8 +1040,7 @@ void

[GitHub] [pulsar] jai1 commented on a change in pull request #3764: Fixed Reader.HasNext() in Go client

2019-03-06 Thread GitBox
jai1 commented on a change in pull request #3764: Fixed Reader.HasNext() in Go client URL: https://github.com/apache/pulsar/pull/3764#discussion_r263080874 ## File path: pulsar-client-cpp/lib/ConsumerImpl.cc ## @@ -1039,8 +1040,7 @@ void

[GitHub] [pulsar] srkukarni commented on issue #3722: Retry creation of assignment topic a few times before giving up

2019-03-06 Thread GitBox
srkukarni commented on issue #3722: Retry creation of assignment topic a few times before giving up URL: https://github.com/apache/pulsar/pull/3722#issuecomment-470213817 run java8 tests This is an automated message from the

[GitHub] [pulsar] merlimat commented on issue #3749: On shutdown, kill the function instance thread after interrupt attempt

2019-03-06 Thread GitBox
merlimat commented on issue #3749: On shutdown, kill the function instance thread after interrupt attempt URL: https://github.com/apache/pulsar/pull/3749#issuecomment-470194548 run java8 tests This is an automated message

[GitHub] [pulsar] merlimat commented on issue #3760: Fix intermittent test: BrokerServiceLookupTest.testModularLoadManager…

2019-03-06 Thread GitBox
merlimat commented on issue #3760: Fix intermittent test: BrokerServiceLookupTest.testModularLoadManager… URL: https://github.com/apache/pulsar/pull/3760#issuecomment-470194520 run java8 tests This is an automated message

[GitHub] [pulsar] merlimat commented on a change in pull request #3752: revise the schema default type not null

2019-03-06 Thread GitBox
merlimat commented on a change in pull request #3752: revise the schema default type not null URL: https://github.com/apache/pulsar/pull/3752#discussion_r263034204 ## File path: pulsar-client-api/src/main/java/org/apache/pulsar/client/api/Schema.java ## @@ -167,49

[GitHub] [pulsar] merlimat commented on a change in pull request #3752: revise the schema default type not null

2019-03-06 Thread GitBox
merlimat commented on a change in pull request #3752: revise the schema default type not null URL: https://github.com/apache/pulsar/pull/3752#discussion_r263034112 ## File path: pulsar-client-api/src/main/java/org/apache/pulsar/client/api/Schema.java ## @@ -167,49

[GitHub] [pulsar] merlimat commented on a change in pull request #3752: revise the schema default type not null

2019-03-06 Thread GitBox
merlimat commented on a change in pull request #3752: revise the schema default type not null URL: https://github.com/apache/pulsar/pull/3752#discussion_r263035591 ## File path: pulsar-client-api/src/main/java/org/apache/pulsar/client/api/Schema.java ## @@ -167,49

[pulsar] branch master updated: Multi version generic schema provider (#3756)

2019-03-06 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new a662757 Multi version generic schema provider

  1   2   >